From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id B9FD2C77B7C for ; Tue, 24 Jun 2025 21:10:21 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 5627E6B00AF; Tue, 24 Jun 2025 17:10:21 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 539DD6B00B1; Tue, 24 Jun 2025 17:10:21 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 476E56B00B3; Tue, 24 Jun 2025 17:10:21 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 371A56B00AF for ; Tue, 24 Jun 2025 17:10:21 -0400 (EDT) Received: from smtpin01.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id C812EC1105 for ; Tue, 24 Jun 2025 21:10:20 +0000 (UTC) X-FDA: 83591537400.01.C893155 Received: from tor.source.kernel.org (tor.source.kernel.org [172.105.4.254]) by imf23.hostedemail.com (Postfix) with ESMTP id 33AF9140007 for ; Tue, 24 Jun 2025 21:10:19 +0000 (UTC) Authentication-Results: imf23.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=korg header.b=IvvS17NH; spf=pass (imf23.hostedemail.com: domain of akpm@linux-foundation.org designates 172.105.4.254 as permitted sender) smtp.mailfrom=akpm@linux-foundation.org; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1750799419; a=rsa-sha256; cv=none; b=US0O5q5iNPB9WUSd8NrLAB+2tVmU9X25fcYNlnjZYefRoCGMcTdSsc8r5nFhhF6aRQEoHA DrP8+vZh4J1W90WLbfGsANwFkvpfiHWU9GX6e16yfa7RQ/t9fp4DlqXXChxrBVfiA6cOOG s6DVpS5rW0XO3J5NeP4rCMmBULWDw+4= ARC-Authentication-Results: i=1; imf23.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=korg header.b=IvvS17NH; spf=pass (imf23.hostedemail.com: domain of akpm@linux-foundation.org designates 172.105.4.254 as permitted sender) smtp.mailfrom=akpm@linux-foundation.org; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1750799419; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=sjL4JlDc0rWwjlohUxicPg9AUCQe+82weP9autapHsQ=; b=knG+Rgtuw7+PKH7fj8gHoHnu3nfmnPK7pvifJ757axPnWfnfANco0Lt3M4eENRYQaChv+y OuQ2D0m+3R/LN+308aErQdiTubm9lbO4eBTwKO4zO9y0U/JmsOoIur1tKMhwQC8mct50QV IU2uTTHu9hZ8W7RZ88ep2XqCPqA69Xw= Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by tor.source.kernel.org (Postfix) with ESMTP id 620A86116E; Tue, 24 Jun 2025 21:10:18 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id ED117C4CEE3; Tue, 24 Jun 2025 21:10:17 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linux-foundation.org; s=korg; t=1750799418; bh=tCpJopxRfveBHKsni2w2YybQAZVK875LEnvbkVzqoxc=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=IvvS17NHVjIghqXKML+vhLIWl9NcDc4tqkFt737VXv95o0dCIcO4+VC3GjQnl8Nhu bN8ErG7hn/JG2gWm80Ubc8R+xx9Tf5WgkkH1/9++jQYfUEBqHpdbbbZ8tPn6SWRe/l lStg/WCe3cttBLZWSiDXm+eVTpD4bBfneErTiivo= Date: Tue, 24 Jun 2025 14:10:17 -0700 From: Andrew Morton To: kernel test robot Cc: Davidlohr Bueso , oe-kbuild-all@lists.linux.dev, Linux Memory Management List Subject: Re: [akpm-mm:mm-new 203/215] memcontrol.c:undefined reference to `user_proactive_reclaim' Message-Id: <20250624141017.fbc3743d3bf83c387f3ec62b@linux-foundation.org> In-Reply-To: <202506250208.ZOcoZLb6-lkp@intel.com> References: <202506250208.ZOcoZLb6-lkp@intel.com> X-Mailer: Sylpheed 3.8.0beta1 (GTK+ 2.24.33; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Stat-Signature: 96kesraogcyuj88y3h98fyaxt91bo9w1 X-Rspamd-Server: rspam05 X-Rspamd-Queue-Id: 33AF9140007 X-Rspam-User: X-HE-Tag: 1750799419-611834 X-HE-Meta: U2FsdGVkX1+3B2r+bWyqgTpqQpTOTh+0RNjJUZxt2A/mOXKQEOgvF3To68lcSJX75k+vDhx4l8PzUVCfFu2M1QjCcRWSW+BdCE8JR8rRdAXO3EyeKD6n5FsirY7xrbZYMWJh1Q7Dv4pd2SDN/di60eWCVhY6ZCi70QKAtQOot73NXGIbp6KLHRSHyVgAS+rgBm9lGbIHRP0g/nZYisLIpmJwwkdL3Vmr1EVp/zRw2H7I8MOf/YAYnNfiKb7tjcnIm5ybcrIW6sbPAgWLyDBUipNOp6xSiwoVxE2vzKX9i2abCC3fkZBIv7+tVXi3FPcBPqUfnp8dBXEBb1XJPpOkVgbG0Em31ml+HSffCOIc1KbAj5f3OPI1WxLqX2jinrswkb4au5kApVA8h5LDIjZdoTbRp1OnAEP5irBdcB7/NYOlK3xpiRogCswDpokVLpavHwcn3TG5G1P0hEuVG6BPpSmfC/CHWPsLqVE+UCR+bKon++bnJ2YJkKgT28/4/4wz3euLVha5ZqpO0Foe1JCMW/LwFENT/XldzvoGGov41HRYHd0kD4EvyAYk1rSV/YxkQN1E/4sP3lPzrjzk84+jkxAU3m6lZYYZUPUzOzSZ+SHcbMjBdelLbu1HO+jcxsQWMABdjDQ26FX6Zi8lHnVmOamfMbyxTgR1fNwd9WGCPYTTwvSxCIOVOumeNWv+aSx7gip3yhyCMz9RTydyxqCxZ3qsW2uTZIGpKRxaAoFQ3K/ArYcnqUsgXV5Pm/1SjVNchW8bi8+GsGMl3FBH+8z+w1LdsCSOOX4b8Z5EHrM+5LATdy6cK/WWvCjsSbDzKA/xthVCxcV0X106R9urm0KwkZRqcTJjEL+63CHJO3bvsbQryXBpzaF+9Clc3nc3k2if1QjGvoU2muH2CQ8hsn8dRXCx4c/ZN4gzZsms0lIMSE2Sxo8n+Cvx24MqklgrX7Nl2FpVDgiFQGr6McEDX4G NVT0v1Mk YUbx2aSEW2UCLwdf+tCrT+jg0xLjOCr5d6yq0xDW9wWnyHQjfVpYdVUyrGjMU29hen2KaBLkmUGeOIH7Zbucd7Kg2b+FXZNE4xyezpJ0fsyT9/x3KUre0ng75RxvNY1XTxRL8U4vtPfHtz0ctMGtazklVj+jM7pISpDx0r/0SZq/ntNcLT3ibf0YpDLWLbyFECPr+ddRAd7Bgz7AWMdnYgyTW49S2PC89jfGmCdJArXCX8yOTvtpr8TCQeH7PdQPqBgrOVK2J3DW2Mgoevm044ODoag+qaxcmiiWx9RMOzra8eAPdAeIlmPPO7plD+d1zeguQ7OPNFG/k2erdgFrXlPZZbImDA2TqO1Zr7gJfI1zld5DuooJnJG/YTuLMlUkZjjDhQ308NyNnrhtGMpLHmVYV6G+eXnV0U8ocRdp8nO/VK96cywj55mEPsw== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Wed, 25 Jun 2025 02:57:13 +0800 kernel test robot wrote: > tree: https://git.kernel.org/pub/scm/linux/kernel/git/akpm/mm.git mm-new > head: d1c90ab3cf156e6dcfb3b74bbb1fc26d99cea303 > commit: 67cc9632fbf2d4095ced88c37130de79914140d6 [203/215] mm/memcg: make memory.reclaim interface generic > config: i386-buildonly-randconfig-003-20250625 (https://download.01.org/0day-ci/archive/20250625/202506250208.ZOcoZLb6-lkp@intel.com/config) > compiler: gcc-12 (Debian 12.2.0-14) 12.2.0 > reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20250625/202506250208.ZOcoZLb6-lkp@intel.com/reproduce) > > If you fix the issue in a separate patch/commit (i.e. not just a new version of > the same patch/commit), kindly add following tags > | Reported-by: kernel test robot > | Closes: https://lore.kernel.org/oe-kbuild-all/202506250208.ZOcoZLb6-lkp@intel.com/ > > All errors (new ones prefixed by >>): > > ld: mm/memcontrol.o: in function `memory_reclaim': > >> memcontrol.c:(.text+0xa06): undefined reference to `user_proactive_reclaim' Thanks, let's try this: --- a/mm/internal.h~mm-memcg-make-memoryreclaim-interface-generic-fix +++ a/mm/internal.h @@ -517,8 +517,16 @@ extern unsigned long highest_memmap_pfn; bool folio_isolate_lru(struct folio *folio); void folio_putback_lru(struct folio *folio); extern void reclaim_throttle(pg_data_t *pgdat, enum vmscan_throttle_state reason); +#ifdef CONFIG_NUMA int user_proactive_reclaim(char *buf, struct mem_cgroup *memcg, pg_data_t *pgdat); +#else +static inline int user_proactive_reclaim(char *buf, + struct mem_cgroup *memcg, pg_data_t *pgdat) +{ + return 0; +} +#endif /* * in mm/rmap.c: _