From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6B609C77B7F for ; Tue, 24 Jun 2025 16:16:56 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id E5EC56B0096; Tue, 24 Jun 2025 12:16:55 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id E0F536B009B; Tue, 24 Jun 2025 12:16:55 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id D4C976B00AC; Tue, 24 Jun 2025 12:16:55 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id C40C26B0096 for ; Tue, 24 Jun 2025 12:16:55 -0400 (EDT) Received: from smtpin03.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 93C5A1D7BAF for ; Tue, 24 Jun 2025 16:16:55 +0000 (UTC) X-FDA: 83590797990.03.3CA187E Received: from nyc.source.kernel.org (nyc.source.kernel.org [147.75.193.91]) by imf10.hostedemail.com (Postfix) with ESMTP id CA92CC000B for ; Tue, 24 Jun 2025 16:16:53 +0000 (UTC) Authentication-Results: imf10.hostedemail.com; dkim=pass header.d=linuxfoundation.org header.s=korg header.b="qW+iT8/r"; spf=pass (imf10.hostedemail.com: domain of gregkh@linuxfoundation.org designates 147.75.193.91 as permitted sender) smtp.mailfrom=gregkh@linuxfoundation.org; dmarc=pass (policy=none) header.from=linuxfoundation.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1750781813; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=IAupuGMWxI3BIublkrMGY5qPHKlqE3R3CwjlxU34SdQ=; b=wG5DJAaeH0jMjP3TQfEfVdH5t05Tu2ymafaTzS+3W7qa1LUSpXrKETxGwAdAiWz6ew56iN yPaKG6uG2ceaIcKNBFDepJjuDv9uVahacLXAYP64DM/Nsp/+Sf/gBGvaEJSVf+4zdTWZRo AJhFgVRZoVoMxAqh6dwRk+VPUGyhYJs= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1750781813; a=rsa-sha256; cv=none; b=HcdN3nmjA6lMIHvAtWRRHoSHIJ+k0mlzJ2HLcjdCi/hzpCBsliim2g5oC1dTPGSD+zx6kZ 2fNddRrwvQRWwxboQfgVLFUGzUSSejbHP9Uovu41+lL4l0j6gUyrwn09HR+f5OXS2Hg1Cb ilRwYyq5Wn0C7Dy5PQLe08gnLtUi2Kw= ARC-Authentication-Results: i=1; imf10.hostedemail.com; dkim=pass header.d=linuxfoundation.org header.s=korg header.b="qW+iT8/r"; spf=pass (imf10.hostedemail.com: domain of gregkh@linuxfoundation.org designates 147.75.193.91 as permitted sender) smtp.mailfrom=gregkh@linuxfoundation.org; dmarc=pass (policy=none) header.from=linuxfoundation.org Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by nyc.source.kernel.org (Postfix) with ESMTP id 3E108A4FBB4; Tue, 24 Jun 2025 16:16:53 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 7092CC4CEE3; Tue, 24 Jun 2025 16:16:52 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1750781812; bh=8gl1rLZNofAk2fof2YGBHaM5ebdXQZzyZfIQBIqfrGI=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=qW+iT8/rsJkuyydGDGHb8KNzu5Fem+I5+k86517u6RHxYUMT3QX+o7hLK8Qaf+v5P Ucpo6f9iuC5p59VlLBER+lJwCjJ+0excGOnQEkIhR4PdLsSdZSLdxvtsIR8ERIGYJk PdyGDvUBZLGO5mE2WaXTxs/YYp+Tz7zl2Mc5LjeM= Date: Tue, 24 Jun 2025 17:16:50 +0100 From: Greg KH To: Jonathan Cameron Cc: Catalin Marinas , james.morse@arm.com, linux-cxl@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-acpi@vger.kernel.org, linux-arch@vger.kernel.org, linux-mm@kvack.org, Will Deacon , Dan Williams , Davidlohr Bueso , Yicong Yang , linuxarm@huawei.com, Yushan Wang , Lorenzo Pieralisi , Mark Rutland , Dave Hansen , Thomas Gleixner , Ingo Molnar , Borislav Petkov , x86@kernel.org, H Peter Anvin , Andy Lutomirski , Peter Zijlstra Subject: Re: [PATCH v2 2/8] generic: Support ARCH_HAS_CPU_CACHE_INVALIDATE_MEMREGION Message-ID: <2025062439-submitter-affection-324b@gregkh> References: <20250624154805.66985-1-Jonathan.Cameron@huawei.com> <20250624154805.66985-3-Jonathan.Cameron@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20250624154805.66985-3-Jonathan.Cameron@huawei.com> X-Rspamd-Queue-Id: CA92CC000B X-Stat-Signature: uyad8zje6qcnjjm151hhemzujmkskxsj X-Rspam-User: X-Rspamd-Server: rspam01 X-HE-Tag: 1750781813-413512 X-HE-Meta: U2FsdGVkX18EWBktNrG27d5JG+5hdP9bSNEyPgVVyY0y8+KMWZztyBDBnOhD7SOIaKPwkE/5BVYPhbuzAkJzz/EXifcG+nEjxXg7+LJNGG5mjZWVOKNtR1Swve6ZzykZ8JgjHAs6lpdFNVhqo4bd6YwmXi7MuChviq/07x1y/t1XqIfzU5qVNubg187bdu5hdMCd/ATyywC+udAizwYO7p31YrT2Kjpjqd7rsSoXcjzBBTh9u+63V1wUbu+xfT5mTI2Q6QqKWCnohe/Nm2C0sp9m9cqbQap+fFPpszy8UHzr5Tk/dvAQyViY+V/5lkZ07zpx+c3YPAEW9T4X0LKs0ujtrmqXPqSeWHl/7SQ+RuV+oTO3EasoU0RZ6KEtrx+HSKADqC8hwbQ7EO49AAwSjckcNE/AL9eM1YXy7U96mVbLSHz+cbShGdF3sT0DjOxhXqOzyOUYKK8x5d6QsnRk+JLL8gyTDqszERtsDROu1m6lPZIG9B8Tcrx9N8ADe2Zn5EIRDgrky6tCAxSPpAFiw6uvNAoLR4ZX7r63vUdwkhS4/ohZwuun0CIWjUQNWFmP4ypShTdltc2QOfNImeIM7g7WT01v2nRgoQpAaU4YbNxFRmr23XB59TzSjeheblDJxr9NyOIs7TKvGXF/HmMyYcGQxBMlfAkS6y7tG5569qQQHdL9V7AH+ob5Smxbv4vjA0slbJvro7i5vGISF0WkvKE+z7+MWeMy0ZWaMISyOefQyfG9BwbGJKvasOtwXsItuvdQXD+ORjNscjShNdr7pgjqmWpBOD1B8HIA/J9Xt7Dk0g+jhRrCahMZO9MHylTFALhplQBEoaal+v2ilvk29k16b++vseVyytav/sLL4TYWiobZSEUQDjNjFJzPO65/kz1Z7lBqM5ngBCvqKphvOvTdR9+myEuZgDTj9VYnNk6mIlI/wiy7zoWQp4LL7sGJW4iNWi9/Y2LMEpZeyzy l4mreJ16 bZEcQqICI2Nex7+oSmAYx1OaYLLEs61Gw4B3dDczJaj/YVEO9YmwtLWG98yRw0ULdCmVg4Olp5SFQeW6g1LKhWOYUs1S+WgyE0rZ5tKvRRJtt9v37trENf9TvxOaBtIUfOhhE3YYofTe0FsJpW75aDc+QM/bMiD1qK3XxK4ScHuEgvnlpltnqDgKBVGOQy9UQJo+AG2nGkE46FcHztUUPV7nw0oY0mi+HLMh1cF8UypY2MHvkDTSQd/ewub3LQqIVJECjszfERhafsC5EdA0+3tvl/2uRx4NWAg62HdyZNZX758hu3JUgVGhteWCD0ubTnbAIdn+4ulNL99xMeQafrn5y5IG3gtZFFBHt4aBW1jCsFxpqdlV5EayeT6I0umG7N6SGBdIs7mOni/O/HD2BDXV7kt/PyWiMgSNPC7HhtRFsnGq2q08d7l/IOc6XsmDKFGNXWvLNH6Iyca22Zeb2RxMwE9yvPnydHo51nmdOtS9h1Cg= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Tue, Jun 24, 2025 at 04:47:58PM +0100, Jonathan Cameron wrote: > From: Yicong Yang > > ARCH_HAS_CPU_CACHE_INVALIDATE_MEMREGION provides the mechanism for > invalidate certain memory regions in a cache-incoherent manner. > Currently is used by NVIDMM adn CXL memory. This is mainly done > by the system component and is implementation define per spec. > Provides a method for the platforms register their own invalidate > method and implement ARCH_HAS_CPU_CACHE_INVALIDATE_MEMREGION. > > Architectures can opt in for this support via > CONFIG_GENERIC_CPU_CACHE_INVALIDATE_MEMREGION. > > Signed-off-by: Yicong Yang > Signed-off-by: Jonathan Cameron > --- > drivers/base/Kconfig | 3 +++ > drivers/base/Makefile | 1 + > drivers/base/cache.c | 46 ++++++++++++++++++++++++++++++++ > include/asm-generic/cacheflush.h | 12 +++++++++ > 4 files changed, 62 insertions(+) > > diff --git a/drivers/base/Kconfig b/drivers/base/Kconfig > index 064eb52ff7e2..cc6df87a0a96 100644 > --- a/drivers/base/Kconfig > +++ b/drivers/base/Kconfig > @@ -181,6 +181,9 @@ config SYS_HYPERVISOR > bool > default n > > +config GENERIC_CPU_CACHE_INVALIDATE_MEMREGION > + bool > + > config GENERIC_CPU_DEVICES > bool > default n > diff --git a/drivers/base/Makefile b/drivers/base/Makefile > index 8074a10183dc..0fbfa4300b98 100644 > --- a/drivers/base/Makefile > +++ b/drivers/base/Makefile > @@ -26,6 +26,7 @@ obj-$(CONFIG_DEV_COREDUMP) += devcoredump.o > obj-$(CONFIG_GENERIC_MSI_IRQ) += platform-msi.o > obj-$(CONFIG_GENERIC_ARCH_TOPOLOGY) += arch_topology.o > obj-$(CONFIG_GENERIC_ARCH_NUMA) += arch_numa.o > +obj-$(CONFIG_GENERIC_CPU_CACHE_INVALIDATE_MEMREGION) += cache.o > obj-$(CONFIG_ACPI) += physical_location.o > > obj-y += test/ > diff --git a/drivers/base/cache.c b/drivers/base/cache.c > new file mode 100644 > index 000000000000..8d351657bbef > --- /dev/null > +++ b/drivers/base/cache.c > @@ -0,0 +1,46 @@ > +// SPDX-License-Identifier: GPL-2.0 > +/* > + * Generic support for CPU Cache Invalidate Memregion > + */ > + > +#include > +#include > +#include > + > + > +static const struct system_cache_flush_method *scfm_data; > +DEFINE_SPINLOCK(scfm_lock); Shouldn't this lock be static? I don't see it being used outside of this file, and it's not exported. thanks, greg k-h