From: Dev Jain <dev.jain@arm.com>
To: akpm@linux-foundation.org, Liam.Howlett@oracle.com
Cc: richard.weiyang@gmail.com, maple-tree@lists.infradead.org,
linux-mm@kvack.org, linux-kernel@vger.kernel.org,
Dev Jain <dev.jain@arm.com>
Subject: [PATCH 1/2] maple tree: Clean up mtree_range_walk()
Date: Thu, 26 Jun 2025 22:49:17 +0530 [thread overview]
Message-ID: <20250626171918.17261-1-dev.jain@arm.com> (raw)
The special casing for offset == 0 is being done because min will stay
mas->min in this case. So refactor the code to use the while loop for
setting the max and getting the corresponding offset, and only set the
min for offset > 0.
Signed-off-by: Dev Jain <dev.jain@arm.com>
---
lib/maple_tree.c | 11 +++--------
1 file changed, 3 insertions(+), 8 deletions(-)
diff --git a/lib/maple_tree.c b/lib/maple_tree.c
index 0e85e92c5375..6c89e6790fb5 100644
--- a/lib/maple_tree.c
+++ b/lib/maple_tree.c
@@ -2770,13 +2770,8 @@ static inline void *mtree_range_walk(struct ma_state *mas)
end = ma_data_end(node, type, pivots, max);
prev_min = min;
prev_max = max;
- if (pivots[0] >= mas->index) {
- offset = 0;
- max = pivots[0];
- goto next;
- }
- offset = 1;
+ offset = 0;
while (offset < end) {
if (pivots[offset] >= mas->index) {
max = pivots[offset];
@@ -2784,9 +2779,9 @@ static inline void *mtree_range_walk(struct ma_state *mas)
}
offset++;
}
+ if (likely(offset))
+ min = pivots[offset - 1] + 1;
- min = pivots[offset - 1] + 1;
-next:
slots = ma_slots(node, type);
next = mt_slot(mas->tree, slots, offset);
if (unlikely(ma_dead_node(node)))
--
2.30.2
next reply other threads:[~2025-06-26 17:19 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-06-26 17:19 Dev Jain [this message]
2025-06-26 17:19 ` [PATCH 2/2] maple tree: Add and fix some comments Dev Jain
2025-06-26 20:04 ` Liam R. Howlett
2025-06-28 11:56 ` Dev Jain
2025-06-29 23:16 ` Wei Yang
2025-07-03 5:54 ` Liam R. Howlett
2025-07-03 6:14 ` Dev Jain
2025-06-26 19:58 ` [PATCH 1/2] maple tree: Clean up mtree_range_walk() Liam R. Howlett
2025-06-28 11:57 ` Dev Jain
2025-07-03 6:00 ` Liam R. Howlett
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250626171918.17261-1-dev.jain@arm.com \
--to=dev.jain@arm.com \
--cc=Liam.Howlett@oracle.com \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=maple-tree@lists.infradead.org \
--cc=richard.weiyang@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).