From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 33C66C77B7F for ; Sat, 28 Jun 2025 11:35:08 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id A90676B009C; Sat, 28 Jun 2025 07:35:07 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id A409B6B009E; Sat, 28 Jun 2025 07:35:07 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 92F816B009F; Sat, 28 Jun 2025 07:35:07 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 74C8D6B009C for ; Sat, 28 Jun 2025 07:35:07 -0400 (EDT) Received: from smtpin01.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id F38091A0571 for ; Sat, 28 Jun 2025 11:35:06 +0000 (UTC) X-FDA: 83604603012.01.CC8FD24 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by imf19.hostedemail.com (Postfix) with ESMTP id C616E1A0006 for ; Sat, 28 Jun 2025 11:35:04 +0000 (UTC) Authentication-Results: imf19.hostedemail.com; dkim=none; spf=pass (imf19.hostedemail.com: domain of dev.jain@arm.com designates 217.140.110.172 as permitted sender) smtp.mailfrom=dev.jain@arm.com; dmarc=pass (policy=none) header.from=arm.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1751110505; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:references; bh=zHlmKddhyoWW5/eAkf5UH+WTTRDD7SRb+dQwhpy8D2E=; b=xZj+qYd9p7vfB1QaiEKnF2T+1Df6Z9xcpP/dY9UOK01VO7weYf3eYAjbIkVr3NySDYDXfA VgTalwVrPxhibFmq7va20hOQMikEnbbR6xy34jpVz1EcJniAkN5o4caxA6mLfl8sW2tQbE OcXs7PlxKS7W0ra3l/2DXL0HmA9+L78= ARC-Authentication-Results: i=1; imf19.hostedemail.com; dkim=none; spf=pass (imf19.hostedemail.com: domain of dev.jain@arm.com designates 217.140.110.172 as permitted sender) smtp.mailfrom=dev.jain@arm.com; dmarc=pass (policy=none) header.from=arm.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1751110505; a=rsa-sha256; cv=none; b=jm5nzE8iIffxSpw0iQaON15uoRPSwWEjqKzL8cvmYV9FbX++vL02sx2R8KOesd9+deZdNP yjK5OtBc3Ng+HherFdRyd7beH5MTYHPfD7OBmws19KuE7ambwFnqUtcPC4YFD7fNXsT8cM T/9ZzwCnTQ3zfJWQBPbZ2VdQP6S7G3U= Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id B49D01BD0; Sat, 28 Jun 2025 04:34:46 -0700 (PDT) Received: from MacBook-Pro.blr.arm.com (MacBook-Pro.blr.arm.com [10.164.18.46]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPA id CC5763F762; Sat, 28 Jun 2025 04:34:55 -0700 (PDT) From: Dev Jain To: akpm@linux-foundation.org Cc: ryan.roberts@arm.com, david@redhat.com, willy@infradead.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, catalin.marinas@arm.com, will@kernel.org, Liam.Howlett@oracle.com, lorenzo.stoakes@oracle.com, vbabka@suse.cz, jannh@google.com, anshuman.khandual@arm.com, peterx@redhat.com, joey.gouly@arm.com, ioworker0@gmail.com, baohua@kernel.org, kevin.brodsky@arm.com, quic_zhenhuah@quicinc.com, christophe.leroy@csgroup.eu, yangyicong@hisilicon.com, linux-arm-kernel@lists.infradead.org, hughd@google.com, yang@os.amperecomputing.com, ziy@nvidia.com, Dev Jain Subject: [PATCH v4 0/4] Optimize mprotect() for large folios Date: Sat, 28 Jun 2025 17:04:31 +0530 Message-Id: <20250628113435.46678-1-dev.jain@arm.com> X-Mailer: git-send-email 2.39.3 (Apple Git-146) MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Rspam-User: X-Rspamd-Server: rspam06 X-Rspamd-Queue-Id: C616E1A0006 X-Stat-Signature: 5jfugxg7hodjfjhonxo4cze8hj786cw1 X-HE-Tag: 1751110504-399115 X-HE-Meta: U2FsdGVkX19HPqq5Rrg1cGIZF9j6Z3Xyn6/fQaZLcNJoSb29mQrO/lQyE1tWxISfOHk+EQplliKGUcvHjCC6P3rV8OW4bCZM0i3kvA7bHTg8t9dwGBl/9K7fCHjcY/P5Xg1gnYxWzYgAhfJxhCSdZhVM9gVOIpt6IHM9kVboBck+CFVwBBTVkeycNwhnpZ2sd117RYckxWvurGsmhUjNWXa+dczz404z+0pMCgFuvuJRTW3TcFp22tQleVLRi2/ZkrEVVMPDu4C9jz/op2798HeVcnpyLfhQtdqVMvIpWCU/qllhyyZbS/os+wc3Ss5mKo43MjknqL/h0Mfue4aY+m4es9WLNXJ4WEQ3VOBvHg/hM5AO1iya8W7rR6BoI/PZCea7m/EJIXpwdLa0Lg3is2Dpsif5xcCgtX4+2xAgEGl98C9I77w3KKolY2Wo82uWbqdPoe95VfjCInbefITpVxczACbCB8UXjjzCdP3slpXXYXxYhp1N4NJqSZUmpb19DPPmOlLbrxxbR6hU6NezBk6ZnMb0+uiUPNXOLIf7/6Ef7KQ25xcgac/bCzDgK0FBSznJi+St2WVQRmH5bBhUdjlDUjUfFkYjDhBKQsVVhPPS/ZI/baXx6/fa6Rf/Obbk8tetwLZVQ4vZLlLCnnbF9px59eKnhOzzIlwNG2wnepjudmqt7u5b6M+e4usruLfykdpUevk3Vw1rPNBt6HX04aAw1w7jjpfPMqdCQVbhhbVfU8e+oBZaCdLsNlZrvKJGgHIfqC3hSWv9zerqRnMO0hRqZuLUZHyxVenjmFZva8iB8JgB6VpXEWd7kXt/zyamuOLfV0J5Pnc3QvvAOUIWRE7Rbj7FxJRzWScBUp+uixIz6CQ+K8XCBaYEFaYHXoacqY4tG7XTqjOE8YXL8H3c1UWvVQP8f4yWaZ8TDALnCLTuCZOLHwO+L1/WMDJ/UTUIYT7cdQzr5ODI9a3hWD5 ZxmXROGD 74NV/yq/Q0LGzmsOdaQ9pYB6oEeXvuRUxrgcyZH6x3rc0fm9tdbeK8o/8RawrvgDb+zMbAp4N/pL3MK9a0KS1b3PGXUyy0ji07MtP X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: This patchset optimizes the mprotect() system call for large folios by PTE-batching. No issues were observed with mm-selftests, build tested on x86_64. We use the following test cases to measure performance, mprotect()'ing the mapped memory to read-only then read-write 40 times: Test case 1: Mapping 1G of memory, touching it to get PMD-THPs, then pte-mapping those THPs Test case 2: Mapping 1G of memory with 64K mTHPs Test case 3: Mapping 1G of memory with 4K pages Average execution time on arm64, Apple M3: Before the patchset: T1: 7.9 seconds T2: 7.9 seconds T3: 4.2 seconds After the patchset: T1: 2.1 seconds T2: 2.2 seconds T3: 4.3 seconds Observing T1/T2 and T3 before the patchset, we also remove the regression introduced by ptep_get() on a contpte block. And, for large folios we get an almost 74% performance improvement, albeit the trade-off being a slight degradation in the small folio case. Here is the test program: #define _GNU_SOURCE #include #include #include #include #include #define SIZE (1024*1024*1024) unsigned long pmdsize = (1UL << 21); unsigned long pagesize = (1UL << 12); static void pte_map_thps(char *mem, size_t size) { size_t offs; int ret = 0; /* PTE-map each THP by temporarily splitting the VMAs. */ for (offs = 0; offs < size; offs += pmdsize) { ret |= madvise(mem + offs, pagesize, MADV_DONTFORK); ret |= madvise(mem + offs, pagesize, MADV_DOFORK); } if (ret) { fprintf(stderr, "ERROR: mprotect() failed\n"); exit(1); } } int main(int argc, char *argv[]) { char *p; int ret = 0; p = mmap((1UL << 30), SIZE, PROT_READ | PROT_WRITE, MAP_PRIVATE | MAP_ANONYMOUS, -1, 0); if (p != (1UL << 30)) { perror("mmap"); return 1; } memset(p, 0, SIZE); if (madvise(p, SIZE, MADV_NOHUGEPAGE)) perror("madvise"); explicit_bzero(p, SIZE); pte_map_thps(p, SIZE); for (int loops = 0; loops < 40; loops++) { if (mprotect(p, SIZE, PROT_READ)) perror("mprotect"), exit(1); if (mprotect(p, SIZE, PROT_READ|PROT_WRITE)) perror("mprotect"), exit(1); explicit_bzero(p, SIZE); } } --- The patchset is rebased onto Saturday's mm-new. v3->v4: - Refactor skipping logic into a new function, edit patch 1 subject to highlight it is only for MM_CP_PROT_NUMA case (David H) - Refactor the optimization logic, add more documentation to the generic batched functions, do not add clear_flush_ptes, squash patch 4 and 5 (Ryan) v2->v3: - Add comments for the new APIs (Ryan, Lorenzo) - Instead of refactoring, use a "skip_batch" label - Move arm64 patches at the end (Ryan) - In can_change_pte_writable(), check AnonExclusive page-by-page (David H) - Resolve implicit declaration; tested build on x86 (Lance Yang) v1->v2: - Rebase onto mm-unstable (6ebffe676fcf: util_macros.h: make the header more resilient) - Abridge the anon-exclusive condition (Lance Yang) Dev Jain (4): mm: Optimize mprotect() for MM_CP_PROT_NUMA by batch-skipping PTEs mm: Add batched versions of ptep_modify_prot_start/commit mm: Optimize mprotect() by PTE-batching arm64: Add batched versions of ptep_modify_prot_start/commit arch/arm64/include/asm/pgtable.h | 10 ++ arch/arm64/mm/mmu.c | 28 +++- include/linux/pgtable.h | 83 +++++++++- mm/mprotect.c | 269 +++++++++++++++++++++++-------- 4 files changed, 315 insertions(+), 75 deletions(-) -- 2.30.2