From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id A8AB5C8302F for ; Mon, 30 Jun 2025 13:01:17 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 9169B6B00B8; Mon, 30 Jun 2025 09:01:01 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 8C7866B00B9; Mon, 30 Jun 2025 09:01:01 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 767A66B00BA; Mon, 30 Jun 2025 09:01:01 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 671AF6B00B8 for ; Mon, 30 Jun 2025 09:01:01 -0400 (EDT) Received: from smtpin04.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id 391971A050D for ; Mon, 30 Jun 2025 13:01:01 +0000 (UTC) X-FDA: 83612077122.04.BC8262A Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf27.hostedemail.com (Postfix) with ESMTP id F29E040014 for ; Mon, 30 Jun 2025 13:00:58 +0000 (UTC) Authentication-Results: imf27.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=JMklJlk2; spf=pass (imf27.hostedemail.com: domain of dhildenb@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=dhildenb@redhat.com; dmarc=pass (policy=quarantine) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1751288459; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=JRChIqxUOgPOieQj0YeNNw03RDlWoIXMOrbpFO40kH0=; b=g2NbuvgbJyhVkI068+5d7iamyuwcwskePHOEwK4WdY5fOlCtgg09cwy06pGzHLUyIDzBKX FS3GIfQfuMcL25IbLRIKjPdGweRz7O4fr+8pF66b8ETfbmp7TfCTJFJRavAFRnPBJR1gMb TFDmsLgslVgGbOGLRLsWIa/p5VAqjuI= ARC-Authentication-Results: i=1; imf27.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=JMklJlk2; spf=pass (imf27.hostedemail.com: domain of dhildenb@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=dhildenb@redhat.com; dmarc=pass (policy=quarantine) header.from=redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1751288459; a=rsa-sha256; cv=none; b=sNwtvhMT/BJca+cEmTBhd2jWYxYROXh4NZdm37cUztY8FO0OlO77eU72N0CdFEgDsKlyNY e6e1aDMR10jUvRib8CQaEEfVRZnRxtZuMe3VmboPWQV3sTfCVAKClpavZWAlpiz7iuagQS wKVsn/wPG5Lc/YePUY9wVDCHuhYJcTk= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1751288458; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=JRChIqxUOgPOieQj0YeNNw03RDlWoIXMOrbpFO40kH0=; b=JMklJlk2hkFhMutUSqzcfVCbklqKvjSEXaXQpkP37tk7MwwXSTs8PUQD9MVqYME7jRI3Pa 5AmXRcT0a9Um8aIeaui/mDgBZSaJp+vthH7Zfc9cVNFmYljvb4tCBhJ5GbbOzYCMN4/SR5 k61GlgMYta5o9VA+CzhxgaWK1PpKqWM= Received: from mail-wm1-f70.google.com (mail-wm1-f70.google.com [209.85.128.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-220-hznoB47FO3qi7tceT7S3vQ-1; Mon, 30 Jun 2025 09:00:56 -0400 X-MC-Unique: hznoB47FO3qi7tceT7S3vQ-1 X-Mimecast-MFC-AGG-ID: hznoB47FO3qi7tceT7S3vQ_1751288455 Received: by mail-wm1-f70.google.com with SMTP id 5b1f17b1804b1-4530c186394so9156555e9.0 for ; Mon, 30 Jun 2025 06:00:55 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1751288455; x=1751893255; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=JRChIqxUOgPOieQj0YeNNw03RDlWoIXMOrbpFO40kH0=; b=mUlTVOwy1dgmrvYoZ9UZ2rG1H+xQOQJNefHqee4PLX2/lltcuM9zrm8yEs/Q4G105C 8qD9H5FpmDeavqwsbe7LJhPNCAU4Y/5F6/X7Dz5Uc5oG4aXHKhqGgz133hs5oVpZr2CA R0ziBTvTZfEZEAxAOvJlPaLcSKvtDyKVe0raebyLR1HNWt3IKkUYJdOWRdb7V0py6OWP BfmRoHKsBKHQx3NT6e/Whf989PXHALrOMqeMCDs0IFY/jzbsi3vi/1TyGQ9g5hF8CBV0 /lLDLGED0B4bEvHnqJwMdOhVSxHAXxAT8nv4hjsqpLo7TX/wcnGb8w8C9ND1FTtR2Vel d/CA== X-Gm-Message-State: AOJu0YyKlwvUEv84MNFoF+XAyghg+1HjyZUGmp6X5b61IIgKWvrp6ypo sqwtu1/CpSgLUXtgFpGxR6vCgh4IXgmDwyFWjuE6yqxaMEGPBQCFMkpp3v45U+3zeJdw1tEKcVZ btweVYXzu0ntnRfv9phqVvGZXy6Zs1SaJsWrtXxywp0Tpne1SttbF X-Gm-Gg: ASbGncsgYruNHzhlgGT33THyYCf/q6zoMfPBV08V7NlmL50mJgqeCAGHrecjzhVfN8c jEBKVh3Xp3EsfHwB2SbwB3BE7Ysd25DgsSDNLn2S+JmL22Ko2MwLawg+cqsVD8tqvleafZaH4ZG GXAEvaxKKAEJEcbs3IqlclNrECsdxUDk0TdGNiJdHWHq8YQeKFU1vMjbKhM7YL7HhhefnwlLu+v tOTr/rU9O+D5kffvh88/3MV+zBsb3EBOwx47IfTtj7SrgLYdQR2NrGa1nxPXHawOX9A431t9JdJ 641E4L5447No5iupkNmC/WcabPZShoCTzxaXgoalKFCqBPimNVZUNeSFxa5mYDIorvc121Eocui zd/uQazE= X-Received: by 2002:a05:600c:3b8e:b0:43c:f513:9591 with SMTP id 5b1f17b1804b1-453913c5a63mr120798095e9.14.1751288453963; Mon, 30 Jun 2025 06:00:53 -0700 (PDT) X-Google-Smtp-Source: AGHT+IHZHtsc7XNjhOjxkvKCZ2uHLxZSkMRI4G1PqHHBjrp6rzXGUbjSQmg1iO1pCKPy78A7k9Rgqw== X-Received: by 2002:a05:600c:3b8e:b0:43c:f513:9591 with SMTP id 5b1f17b1804b1-453913c5a63mr120797265e9.14.1751288453316; Mon, 30 Jun 2025 06:00:53 -0700 (PDT) Received: from localhost (p200300d82f40b30053f7d260aff47256.dip0.t-ipconnect.de. [2003:d8:2f40:b300:53f7:d260:aff4:7256]) by smtp.gmail.com with UTF8SMTPSA id ffacd0b85a97d-3a892e59ab5sm10144896f8f.82.2025.06.30.06.00.51 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 30 Jun 2025 06:00:52 -0700 (PDT) From: David Hildenbrand To: linux-kernel@vger.kernel.org Cc: linux-mm@kvack.org, linux-doc@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, virtualization@lists.linux.dev, linux-fsdevel@vger.kernel.org, David Hildenbrand , Andrew Morton , Jonathan Corbet , Madhavan Srinivasan , Michael Ellerman , Nicholas Piggin , Christophe Leroy , Jerrin Shaji George , Arnd Bergmann , Greg Kroah-Hartman , "Michael S. Tsirkin" , Jason Wang , Xuan Zhuo , =?UTF-8?q?Eugenio=20P=C3=A9rez?= , Alexander Viro , Christian Brauner , Jan Kara , Zi Yan , Matthew Brost , Joshua Hahn , Rakie Kim , Byungchul Park , Gregory Price , Ying Huang , Alistair Popple , Lorenzo Stoakes , "Liam R. Howlett" , Vlastimil Babka , Mike Rapoport , Suren Baghdasaryan , Michal Hocko , "Matthew Wilcox (Oracle)" , Minchan Kim , Sergey Senozhatsky , Brendan Jackman , Johannes Weiner , Jason Gunthorpe , John Hubbard , Peter Xu , Xu Xin , Chengming Zhou , Miaohe Lin , Naoya Horiguchi , Oscar Salvador , Rik van Riel , Harry Yoo , Qi Zheng , Shakeel Butt Subject: [PATCH v1 14/29] mm/migrate: remove __ClearPageMovable() Date: Mon, 30 Jun 2025 14:59:55 +0200 Message-ID: <20250630130011.330477-15-david@redhat.com> X-Mailer: git-send-email 2.49.0 In-Reply-To: <20250630130011.330477-1-david@redhat.com> References: <20250630130011.330477-1-david@redhat.com> MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: gLPItOJ485wKy6w0na0aUXXZIksm0Yaj3ts32Op-iTM_1751288455 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: 8bit content-type: text/plain; charset="US-ASCII"; x-default=true X-Rspam-User: X-Rspamd-Server: rspam06 X-Rspamd-Queue-Id: F29E040014 X-Stat-Signature: ap993zyh3nonhjsjwp1n5jpxpu5htb8e X-HE-Tag: 1751288458-10417 X-HE-Meta: U2FsdGVkX19PiHfnjkse+trDiofdBJkhYua8aFxXbXSAq0UaPnylN9gfhpmrpuSUd4bTBsTVjbwIKnrd7o84UpysuKbtKjdNUQtU+ymbsVUanFnOyzj0gG4ZLwN8XVOdtvOEzzvFNUIZrpJAbcZ/i0ogcihZw09QJNq29dmgdKsqZyCIwypXInJpLvgSmTecHex1fOyIKArAKFfGK9S/a2cHmSCAktRN9o5gSeKLZa3vRPNWZuVZquOX2Qt9iULjRQhH4zIbhTCr3g54vnQVbjTMr+vaoYSQaLFdTug673j7ciFURfwJNyy39UgKlAjlDN7uxpE5rdkNkwWhkmSdYIGlDAWh7WOpVf4Pc2yaAKZQeCC8jD5nk/RmsNkA5M+z/xZzHPCcbBkwSELae/Uo2AICK2TW5+dIZZwdGJN/ErCS49Ud29MJ0HFrCu4+0fUVu+2rJH5KAapt0did/ICuMUP7VsFDfc3ysmbBu8JJ4e7k5A6kw3H1brYkGfc4OLgTTP6aoRSP9pH56VGBuL4YWKaOUhvjdYFwQwkkYjr5y+Fb5G383Y6TVqrzdOnJwg2meQJmFsI095H/npxvDC22Ddei9LuZRT0MnPkJGK0WouuusteHrp+gSYFYl6o9TjamXel1p3w2TubO0PaXJQpk5zJ2MzVkirIuT5PjEK5f9+wZZDChBOp02UvTFHUclR8SdSevea28rq1NOZv1aCkxps3yFxWTmVL8BK/OBIWi5ok5S+dbWVlS3cOmNpnXSDTY1AMgyUQjvxThvd7HU9QXi9OMRqGTrb3C0nr6iQzE/67UFOem/VH5cM3R2Yo9KeRYaQobchnnqP+KE0jx1F/tiLHHcCCamG3fC9N8ZylbeiQ+GfDEnkophrYhogGxCnkUvVz6ISkwoaXhoNfGjosFNZ01mUhITgfjQraiaffNRhROUsMcrwlz+9feIFRVwz8xj40i857jFMmENXJNnvn +Rkhs4Lr q8FFKdnztoBbVoYRw/GaY4YJ9rgjjhVFv/MgG1nhSQ39kFUVdFuP3xweWSCYJ53llo9xEAQkykJWJip+uY92kBNq7/QKDKtlDmLCpVLQyfrDlsaKXuVw8B5Qxu072bZtpGR3bMOIKmJtEkHpJUBdnzAuTBrPD9arLpsmZ+MUkPmx4x1nvduX/aeTAGZNU/MH8uL6tEbrA/xi/YiRtPo1BMTgaPvRXnpkOrBQWrmTCuMEML6Wg+bMzhvCk7tKSNg9JTGdhAP+I38EFPWRQP8N6mYm26758W/ap76jkKW5vDtcpy1N9ynChtQMnvFojxA/Kp55X3DIIKfua4WKXnN+oRAs4wsZxYsBQjyGl3u8i+dsH9OY1M80IbAqJAlWRyuqpNLQrq2VH8cxMUsjV9khLZfLeFH8PLKxR2VKxVc68MBdu+8YVer1PfK4+6ngI1J0dTE97veMWY7iUUvCKdxIv4oW8mktyFMvb35IH+OVbyUroEjG+Uz9P1hf4R8r9uqnWdYnYm01hoVRktqXT3BFBmAhhFHEStVr0GO90VfJoX9fbgvHzd7qE47T2mlx1aGTvX8fAEUb7PVsLqXJ67OzmLqpuh/sVs5YP37w0Lm/Xzzz43REj9HdWn2fUNZhyOR+NIaJPqVlZ0DmQA1VjEPAUWkyCRL4jR7iyDete58c1Qv8pkdQ/X7vB5CYoTQ== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: Unused, let's remove it. The Chinese docs in Documentation/translations/zh_CN/mm/page_migration.rst still mention it, but that whole docs is destined to get outdated and updated by somebody that actually speaks that language. Reviewed-by: Zi Yan Signed-off-by: David Hildenbrand --- include/linux/migrate.h | 8 ++------ mm/compaction.c | 11 ----------- 2 files changed, 2 insertions(+), 17 deletions(-) diff --git a/include/linux/migrate.h b/include/linux/migrate.h index c99a00d4ca27d..6eeda8eb1e0d8 100644 --- a/include/linux/migrate.h +++ b/include/linux/migrate.h @@ -35,8 +35,8 @@ struct migration_target_control; * @src page. The driver should copy the contents of the * @src page to the @dst page and set up the fields of @dst page. * Both pages are locked. - * If page migration is successful, the driver should call - * __ClearPageMovable(@src) and return MIGRATEPAGE_SUCCESS. + * If page migration is successful, the driver should + * return MIGRATEPAGE_SUCCESS. * If the driver cannot migrate the page at the moment, it can return * -EAGAIN. The VM interprets this as a temporary migration failure and * will retry it later. Any other error value is a permanent migration @@ -106,16 +106,12 @@ static inline int migrate_huge_page_move_mapping(struct address_space *mapping, #ifdef CONFIG_COMPACTION bool PageMovable(struct page *page); void __SetPageMovable(struct page *page, const struct movable_operations *ops); -void __ClearPageMovable(struct page *page); #else static inline bool PageMovable(struct page *page) { return false; } static inline void __SetPageMovable(struct page *page, const struct movable_operations *ops) { } -static inline void __ClearPageMovable(struct page *page) -{ -} #endif static inline diff --git a/mm/compaction.c b/mm/compaction.c index 17455c5a4be05..889ec696ba96a 100644 --- a/mm/compaction.c +++ b/mm/compaction.c @@ -137,17 +137,6 @@ void __SetPageMovable(struct page *page, const struct movable_operations *mops) } EXPORT_SYMBOL(__SetPageMovable); -void __ClearPageMovable(struct page *page) -{ - VM_BUG_ON_PAGE(!PageMovable(page), page); - /* - * This page still has the type of a movable page, but it's - * actually not movable any more. - */ - page->mapping = (void *)PAGE_MAPPING_MOVABLE; -} -EXPORT_SYMBOL(__ClearPageMovable); - /* Do not skip compaction more than 64 times */ #define COMPACT_MAX_DEFER_SHIFT 6 -- 2.49.0