From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 48D81C8302F for ; Mon, 30 Jun 2025 13:00:26 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id E1E526B00A6; Mon, 30 Jun 2025 09:00:25 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id DF6346B00A9; Mon, 30 Jun 2025 09:00:25 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id D0BED6B00AA; Mon, 30 Jun 2025 09:00:25 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id C40E66B00A6 for ; Mon, 30 Jun 2025 09:00:25 -0400 (EDT) Received: from smtpin13.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 806CB105CBC for ; Mon, 30 Jun 2025 13:00:25 +0000 (UTC) X-FDA: 83612075610.13.126B4A4 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf08.hostedemail.com (Postfix) with ESMTP id 4FD3C160016 for ; Mon, 30 Jun 2025 13:00:23 +0000 (UTC) Authentication-Results: imf08.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=dLhe8hoM; spf=pass (imf08.hostedemail.com: domain of dhildenb@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=dhildenb@redhat.com; dmarc=pass (policy=quarantine) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1751288423; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=iLYHGg19bG0clXk7rQPjR4hvYWmeZvg7QKQ5c0snrQE=; b=gznj81KCej5EwPx78hH0IJffzlc6UvQxaByfdsTjAwv/LmbjzWqvaqXYnImHxstDm7H6ce i4VbEVpknqgAN140MAvstIY0X7ugzfdA/yU10aBm5ewz5V7mXUeVns/I33zcsfExBruiOn Yi4bA0BVKGH/FJK+FgFoImEiKjb9/tU= ARC-Authentication-Results: i=1; imf08.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=dLhe8hoM; spf=pass (imf08.hostedemail.com: domain of dhildenb@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=dhildenb@redhat.com; dmarc=pass (policy=quarantine) header.from=redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1751288423; a=rsa-sha256; cv=none; b=O4dAglx7bZzT8qXw/FQF/NcOEHhEYc5L5di84FK+09QOjwjdK6KNzWcLtg5Yx2LJDCt7uc sq90XufTcpION/OaMw4M+bxUwO1imEwoofE2zHJHq7NeqCq+egPF4MyhUhSid1JASGXJcm 18CRE47IlFr4r8YBUxTMmuGtstdNGwk= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1751288422; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=iLYHGg19bG0clXk7rQPjR4hvYWmeZvg7QKQ5c0snrQE=; b=dLhe8hoM4R2naQTI+tl05dbihx0WLetxGloe9e0/LadX6vuthRIBEYxOpq/17gx38S+IH5 3Mie5bcI23FWF/zivfIBcrvyyPH+mKAL6zjP6oMYYXj/SFjjwHT1GD0UUGIlkbTB/9CbFn VUPmYo8kyWw1DaloQjb0n6PGBpFB8Ow= Received: from mail-wm1-f70.google.com (mail-wm1-f70.google.com [209.85.128.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-635-Jvs5PkhmNcCj-8tCtQEdIw-1; Mon, 30 Jun 2025 09:00:20 -0400 X-MC-Unique: Jvs5PkhmNcCj-8tCtQEdIw-1 X-Mimecast-MFC-AGG-ID: Jvs5PkhmNcCj-8tCtQEdIw_1751288418 Received: by mail-wm1-f70.google.com with SMTP id 5b1f17b1804b1-4532514dee8so28312915e9.0 for ; Mon, 30 Jun 2025 06:00:18 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1751288418; x=1751893218; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=iLYHGg19bG0clXk7rQPjR4hvYWmeZvg7QKQ5c0snrQE=; b=iBa1/ueTtATjvbYda0pwTF5sWP1THEkqIhIYeg0PPC3UMUGXaYweLMGAOsHW+oUf2C 18VYHcS5BbqqTMkD57f/U/x0n/XnLK2kfVcV4ORtl8R6oymKATPvOvDKdWC0c+ZZomRL lk58JBZo0WfTiac6/fVqesuaL61lRXAGBEITIJW0GhnJVrOgiNnIOTvK9BjMFqbBITRR OueR7JQQzeuMBCPU9wOVYaxwYcHsB4Ygm+lq40e5thm2Mtxuox9edh7XeHh2dd9I7jJz buOa23VXwS6R4HRxR1uDluV2kJVgd78aE77XVfOCG0BrvtZaSElFioD7+jlcByhgpJlm QHtA== X-Gm-Message-State: AOJu0Yx2yWI7KrNkvN5flF/YljB9NfnhUjcXF3U6O1N8K4exAB44CGsa QmxOq52X699nTA2dW6P5JFb6tvjo55ugnO4jYngRuw7lqcB/26c4mtOgEmsb+RLOL3YqeamOze7 3ugs1H6uh9rSk4DDypLGl0Fko/ytugKDZiAfYp3rS1Vdfe2eNea0x X-Gm-Gg: ASbGncsuEZ/ppzCjSWTAp6q/thMtuXhl7PATSWOKTXstE/EiONU9g5kxImsZy3W4FaS illOvFJZh7+1Zzp6zvFC3YouQBuAPMcCcPX/1qS57FVdxTr1WfiyNFiNHyhXLEpWexUUQ4L4s9D yHdgLTIpqTebi8Jb14qVGKxNCD81LotDjYTVADnye/+NHu5m8eLZv24nLpUvnNxOuW7lqI5p1K2 yJxdUzFSH/FBcI+0gnbrnXaYGQegRqpQN+OMTKHH7pP0rYhJIG6Ptbnv3+Dw4FkZBFTL/qf/ZWH 1CTE5F3L4Vp2nswrZTuz7AJcPvKILlPfQ9baHSQNERSAw8/BW2BB76+m7FQLHgvR5xMRfhZ+tY3 EACnNaE8= X-Received: by 2002:a05:600c:35c9:b0:453:608:a18b with SMTP id 5b1f17b1804b1-453947d8ff2mr103853205e9.9.1751288417713; Mon, 30 Jun 2025 06:00:17 -0700 (PDT) X-Google-Smtp-Source: AGHT+IGb/NAxjgNou29rgmmNKmV3zZO0Mb6cYoPiX5R9Zf8/khrmrYWUc/XyFqJpcvry+rGAxO8smA== X-Received: by 2002:a05:600c:35c9:b0:453:608:a18b with SMTP id 5b1f17b1804b1-453947d8ff2mr103852575e9.9.1751288417169; Mon, 30 Jun 2025 06:00:17 -0700 (PDT) Received: from localhost (p200300d82f40b30053f7d260aff47256.dip0.t-ipconnect.de. [2003:d8:2f40:b300:53f7:d260:aff4:7256]) by smtp.gmail.com with UTF8SMTPSA id ffacd0b85a97d-3a892e59659sm10376420f8f.77.2025.06.30.06.00.15 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 30 Jun 2025 06:00:16 -0700 (PDT) From: David Hildenbrand To: linux-kernel@vger.kernel.org Cc: linux-mm@kvack.org, linux-doc@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, virtualization@lists.linux.dev, linux-fsdevel@vger.kernel.org, David Hildenbrand , Andrew Morton , Jonathan Corbet , Madhavan Srinivasan , Michael Ellerman , Nicholas Piggin , Christophe Leroy , Jerrin Shaji George , Arnd Bergmann , Greg Kroah-Hartman , "Michael S. Tsirkin" , Jason Wang , Xuan Zhuo , =?UTF-8?q?Eugenio=20P=C3=A9rez?= , Alexander Viro , Christian Brauner , Jan Kara , Zi Yan , Matthew Brost , Joshua Hahn , Rakie Kim , Byungchul Park , Gregory Price , Ying Huang , Alistair Popple , Lorenzo Stoakes , "Liam R. Howlett" , Vlastimil Babka , Mike Rapoport , Suren Baghdasaryan , Michal Hocko , "Matthew Wilcox (Oracle)" , Minchan Kim , Sergey Senozhatsky , Brendan Jackman , Johannes Weiner , Jason Gunthorpe , John Hubbard , Peter Xu , Xu Xin , Chengming Zhou , Miaohe Lin , Naoya Horiguchi , Oscar Salvador , Rik van Riel , Harry Yoo , Qi Zheng , Shakeel Butt Subject: [PATCH v1 01/29] mm/balloon_compaction: we cannot have isolated pages in the balloon list Date: Mon, 30 Jun 2025 14:59:42 +0200 Message-ID: <20250630130011.330477-2-david@redhat.com> X-Mailer: git-send-email 2.49.0 In-Reply-To: <20250630130011.330477-1-david@redhat.com> References: <20250630130011.330477-1-david@redhat.com> MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: rC4DLz_p5ocIdR5oT5I3oo63uL2ZB_sD3_dPTc5KzAg_1751288418 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: 8bit content-type: text/plain; charset="US-ASCII"; x-default=true X-Rspam-User: X-Rspamd-Server: rspam05 X-Rspamd-Queue-Id: 4FD3C160016 X-Stat-Signature: jjuh7row3ui9zzyhii4x9chngrwgy8e3 X-HE-Tag: 1751288423-913813 X-HE-Meta: U2FsdGVkX19ns8Vg4MuPK9qPKRXybf3i3C+SFmSgRwmwTxgq3TpVqAWbWzMNNb+K/UCth6EXm3hfoYH0PWH+Q2rUPmSRnCzhjNHbRl3z/4wvIkt4EEPB2Fxs2Vs1V/WA/U50Ag+/jTbWq4dVhQj86USq/XWQi+J48ZLIZkIO4oXgCmoui1f57PEMsY/cbOBTMPy3snjkrqOuwKJmKu0INhvhhF0VV9JYVCN25e507z/JvmIpsLp2ll8gZOvnTi3GrsXSL7vFi3u21mhNm5IJXhZCG4/nv0KePXAPQmRZym28GTgV/XxV5ILZhGsVJdfllhaD7cp9/fSBMN0XAnmH4uOOB5BurNsIrfxnYIazqwKsNe+X5TnRAkeSnGJM6dLLuD0ResX+lQfc/uX4Lm4151TXcT6JT7tx4UbhlDOBVJidUqa0bzEoPlRXHtobycr1CSkaLClhAYsiDwhvrGcrbaeWVkyzPHye20hen1FQ6T5dYBj62yC6Bk/ub5OVGJBr7xITlDD8OmAmMKGoxz0uqwSlcmysa/a5Lpt5es5BK2DdbENf466AcmxPD2Jc/wl+tvD8BoqNlk1UpKEGEVypthgVaIUjX72LxY1K+hVV9FPWC4xDLEy7ZY5nGGRxNFuNijiZU7X2v7n34O6TSRar9vYB2pS22j4eDyVVodj6wj9WVUEYkeDpbuJ4IdbTD+hlbIaHc+PmRNR9JiU29hX+E60+Q/MCJbTlFjZOJZ5c3R/vp+xWlaQTsUX7WwC0Xv8QQ/Bk2vqQ1m6000SDoURl9m9P/GhyEzbqKPeohqZ27ewYmxUvyEFKKdnYjk8HdYR8Wh27LYuOYXTCACrpmItx4OZN2pVO+52tsnVf3AVDtiaqym13+3rlBql/t4jKO3T8Vvf0t3EnhKd0m1dhXn0SHPC8EoNzlnj0psw9Uhih1m5LLoLaEAS99LSXfPXrMDVjnTYW46jXBMyj9D5acND izDWPoQ1 WZFCWjOlBso1FxqQDjGrVppalDUNNBxuBlHthZ/i7rHxoccQ5HTfrr0AanJg0NqxpZsC5mrOtBf2WJdxpQzUlNy8Xol57DdSgmOX8N3SgZPdHnlg71wmKrAupgsAZEX1GjHXfX65bbjGMymXZz5mp0RmbhWd9hknoRIvQhZGJP3LkYKt3+oN/N5jJ1BWuBinZA57lHKct2WjAFpOcOF50+7ko3LdJmsrkggyX2ip+ukdmGRgNXZiR9iQHQhwsMjzzdowowX3L1seXUfiLWyiF+yYboFJdpp7+lOsbKD9LS9R5EfZcwy3hQH6eRkFWHMcQO5RW6iykNsuMJYeKnvNQhdBtGcdToFEHCvYcrUtxDb6kb5xaJqYU+wTh+YFxqoJQgA5yWxx4330rxXkhLBBi0LoPdpC2TJLDQZvZTS/SqTUVft03SLllK+ZEevJm9rorxfUFHwya4FMeFEdCV5iHUo3mQ0379KmiRQj+vFMXz83CuEUFsbMT3TZE19yPAioLjANWLfC1+Ykhr3vmgw2r/7FOTmDsWwuC5qrOhxgSEG7Lr9zfLiIATdFVJzpkAjo2xEXAAmb8opjRlfiVJpAt54hMs62noulUZrszSCElzE/Bv6F0FojHBR3S2Dc0pf03vv9y99gD+VvfrC9gBVItU8K98jmUuhkZk8HomsRi2UCs+Rs2xrcneC5dVw== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: The core will set PG_isolated only after mops->isolate_page() was called. In case of the balloon, that is where we will remove it from the balloon list. So we cannot have isolated pages in the balloon list. Let's drop this unnecessary check. Acked-by: Zi Yan Signed-off-by: David Hildenbrand --- mm/balloon_compaction.c | 6 ------ 1 file changed, 6 deletions(-) diff --git a/mm/balloon_compaction.c b/mm/balloon_compaction.c index d3e00731e2628..fcb60233aa35d 100644 --- a/mm/balloon_compaction.c +++ b/mm/balloon_compaction.c @@ -94,12 +94,6 @@ size_t balloon_page_list_dequeue(struct balloon_dev_info *b_dev_info, if (!trylock_page(page)) continue; - if (IS_ENABLED(CONFIG_BALLOON_COMPACTION) && - PageIsolated(page)) { - /* raced with isolation */ - unlock_page(page); - continue; - } balloon_page_delete(page); __count_vm_event(BALLOON_DEFLATE); list_add(&page->lru, pages); -- 2.49.0