From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 55BFBC83030 for ; Mon, 30 Jun 2025 13:02:04 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 3E6FB6B007B; Mon, 30 Jun 2025 09:01:37 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 3C0176B00C6; Mon, 30 Jun 2025 09:01:37 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 260686B00C7; Mon, 30 Jun 2025 09:01:37 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 162716B007B for ; Mon, 30 Jun 2025 09:01:37 -0400 (EDT) Received: from smtpin15.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id CD9161D743D for ; Mon, 30 Jun 2025 13:01:36 +0000 (UTC) X-FDA: 83612078592.15.9771770 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf25.hostedemail.com (Postfix) with ESMTP id 72893A001E for ; Mon, 30 Jun 2025 13:01:34 +0000 (UTC) Authentication-Results: imf25.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=DGWTaa65; dmarc=pass (policy=quarantine) header.from=redhat.com; spf=pass (imf25.hostedemail.com: domain of dhildenb@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=dhildenb@redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1751288494; a=rsa-sha256; cv=none; b=z+AKc2Y57uI4+QD6KO1pJ1pBeWXvS9jEcITn4YYVwjOO7F4J0n58aHlz+xeeTDGLIcUit0 t5bm1A4o9h1MaX7FJd53UfbjqfEMcMfI8yM9br6iS3PtwCcPxlU2EMuBn3EnhdCndvlJaH +ilqY5NXLaL/oJNVRw4I2hpv93PsxP4= ARC-Authentication-Results: i=1; imf25.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=DGWTaa65; dmarc=pass (policy=quarantine) header.from=redhat.com; spf=pass (imf25.hostedemail.com: domain of dhildenb@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=dhildenb@redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1751288494; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=sNIKdrm33pmadL5+MWfVmqXzrIDEGwSSahCLerJeLDg=; b=tv2qXk9R+kvXT0pP+KfYtUqyafYXBIT14M5SBdMrkpMiH4mHFEuZbOlGFVbuQ3403Rl4FN poablnuyixQQe+iBm7NHywRyEFT+bCi/3qZ8VBiFnOxYdCToGqdoDHsV3ASJ8tGd50bPqB IKHil/PW7YRMgm/Qtts7GxBs2KZE3WQ= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1751288493; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=sNIKdrm33pmadL5+MWfVmqXzrIDEGwSSahCLerJeLDg=; b=DGWTaa65Mtabvx7558N4oPxxU/vrZcUSgMfs/ysSuZjkV6V3mGNm/IdTzhurpq5DrEHIGw ia1CQKDEolEIqBV0Xy7B5qwmyLvnT+Ag8BpkniJZaPblCEX8LusBjYrTsVZKaxpUJT+Q3J /24h2XctGUq7hbjIyb5vaFTKUEEmwFA= Received: from mail-wm1-f71.google.com (mail-wm1-f71.google.com [209.85.128.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-553-bt2ClfIoNYCgnBXPm_WmJg-1; Mon, 30 Jun 2025 09:01:32 -0400 X-MC-Unique: bt2ClfIoNYCgnBXPm_WmJg-1 X-Mimecast-MFC-AGG-ID: bt2ClfIoNYCgnBXPm_WmJg_1751288491 Received: by mail-wm1-f71.google.com with SMTP id 5b1f17b1804b1-450d6768d4dso13586415e9.2 for ; Mon, 30 Jun 2025 06:01:32 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1751288491; x=1751893291; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=sNIKdrm33pmadL5+MWfVmqXzrIDEGwSSahCLerJeLDg=; b=J1Dw8jgJeA3kEWlVwGET4XiMYcSWfLJOh0IhG2sri8DUUwe/rOexwP0GsOMw5csSau VOaTMt166iVZ30q+M8Nx/66SlmTwCBGgtodTaxgmQ+qnNcHtHlQ80ryZ0Zye0afFvWud YVwu/zY0jYYjDoYz/BCbj5yK+LjzKs3FqQzPIXZT6UxHlX61lachkHar7Rle4pnuaZRY l60QBKY9xtGife8xxwx/zON5DSKXyEmiLHbPyIm8eeQDxEqxkDnXj828kHGWQ4RdyYWF 24lCNsxPISyc4g54Q1LHnHukVOFTjB0nKWky2oTWkaEjQ0gpBzmE0Bkh7Smsj2bLjAly c8dg== X-Gm-Message-State: AOJu0YxPxr/hWkcpMQHGlCUFiWzVvPIttQZQRf3WjoHWN8Rs1HCkDInq 5FtQ17/+EtM+TFZQJU2K8oZGNBkaXCVMDelEQ+kb151T76ulEDijF7rzF6QUU7Yl6Ax/qcOZQv/ bdQrDIyBnbhe9dqCB59WOvUTfx2jmu60wbWbuInL79zKOlAPkkzFp X-Gm-Gg: ASbGncsfze+xDi2Hz8BrRGlK+x7mgFOYwmD+ho4bh5QEBmcPUFL3GqlsJQ6ibOAZf7P 6+dt+zUjq/lzvmkd7v964SIo5Y9rjlQFNeXTSx9CbozHUBL2qPdYauDPVEJ/jfiXS2WzaSkywzG 91Mpm15AdFNWO9JiDrb8AJ7nNkfFIWZDEGeaQ2GFBdgdRnPU6bM1piyKARNoWhiPL7jF3RWtSwe C5nWTDqezuMc68ZOzuCPmh7Igh5cPJrpk6deR54mmCWvSEsGu4ZEqHQ+5AUTNUIZiu78ebJpIE/ BqoBWubK7IbnMlFtjTOah8wxGrB2/mbISAqSv+Ll6GK+kHFBlx8dlSRy+Tbiy91m1onKY+X2UwM 8E4DQce0= X-Received: by 2002:a05:600c:4fd1:b0:453:6f1:bdba with SMTP id 5b1f17b1804b1-4538ee60a60mr107461305e9.20.1751288490710; Mon, 30 Jun 2025 06:01:30 -0700 (PDT) X-Google-Smtp-Source: AGHT+IHvKPbKK01jDGKdO7HMFpJHGVfeP34xEfryqVjaTqeCy8FfNy/5uAgcgaE7N6g1euFItwJ1Ng== X-Received: by 2002:a05:600c:4fd1:b0:453:6f1:bdba with SMTP id 5b1f17b1804b1-4538ee60a60mr107459575e9.20.1751288488983; Mon, 30 Jun 2025 06:01:28 -0700 (PDT) Received: from localhost (p200300d82f40b30053f7d260aff47256.dip0.t-ipconnect.de. [2003:d8:2f40:b300:53f7:d260:aff4:7256]) by smtp.gmail.com with UTF8SMTPSA id 5b1f17b1804b1-453823ad01csm166146565e9.22.2025.06.30.06.01.26 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 30 Jun 2025 06:01:28 -0700 (PDT) From: David Hildenbrand To: linux-kernel@vger.kernel.org Cc: linux-mm@kvack.org, linux-doc@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, virtualization@lists.linux.dev, linux-fsdevel@vger.kernel.org, David Hildenbrand , Andrew Morton , Jonathan Corbet , Madhavan Srinivasan , Michael Ellerman , Nicholas Piggin , Christophe Leroy , Jerrin Shaji George , Arnd Bergmann , Greg Kroah-Hartman , "Michael S. Tsirkin" , Jason Wang , Xuan Zhuo , =?UTF-8?q?Eugenio=20P=C3=A9rez?= , Alexander Viro , Christian Brauner , Jan Kara , Zi Yan , Matthew Brost , Joshua Hahn , Rakie Kim , Byungchul Park , Gregory Price , Ying Huang , Alistair Popple , Lorenzo Stoakes , "Liam R. Howlett" , Vlastimil Babka , Mike Rapoport , Suren Baghdasaryan , Michal Hocko , "Matthew Wilcox (Oracle)" , Minchan Kim , Sergey Senozhatsky , Brendan Jackman , Johannes Weiner , Jason Gunthorpe , John Hubbard , Peter Xu , Xu Xin , Chengming Zhou , Miaohe Lin , Naoya Horiguchi , Oscar Salvador , Rik van Riel , Harry Yoo , Qi Zheng , Shakeel Butt Subject: [PATCH v1 25/29] mm: simplify folio_expected_ref_count() Date: Mon, 30 Jun 2025 15:00:06 +0200 Message-ID: <20250630130011.330477-26-david@redhat.com> X-Mailer: git-send-email 2.49.0 In-Reply-To: <20250630130011.330477-1-david@redhat.com> References: <20250630130011.330477-1-david@redhat.com> MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: R1Dztzf9KznCXeFvJLZakqoMK4AS2AlexDL35fcOYRA_1751288491 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: 8bit content-type: text/plain; charset="US-ASCII"; x-default=true X-Stat-Signature: 573x8n7qgomgny9irb6536mo1zknyyqh X-Rspamd-Server: rspam01 X-Rspamd-Queue-Id: 72893A001E X-Rspam-User: X-HE-Tag: 1751288494-181374 X-HE-Meta: U2FsdGVkX1/2by6ENNGvH4L+j80J33ybtElIspPqLCfSHuAZUGMLKRC8fWc7mwfWwt95Q82rhYduUO0eOnOFOVcqzUUDW16/1FF8oZZrb9fl9aJTmFw18WxYuqrUuFTgqogxHsGbAlnhn6W8EV6ocoY/7PiRCmiN5TSMQxm3JmED1BlDmA5OoIfnaDq5o6aqhlDibZqVtOTm90dxEbuxHTH1z3OYOefSQmaxCt/N6UyOYR25o0nGnCWL3c1UpBMKvWZ4ndfpg6nipvCHAZg3JkWiFrh5mBXlayR/qphO/QhyupkfYXqUBXkyORFOBPCcg+nUdKqi47MbLD+d8XOnWiUwTZixcjZJdYt+vfJGVoFDfJNmF5IT9KvYUY8B2ij1UPEmbef6tgRzMPppNwUHohtZ635uowx+aSqjhBcX2IgiIj7Dl1UKX10mlPe+UfjDdeCCpACtX3FaDmZVH731B85KLnAcem6p4luOv7slctHGicAl192o6Tph8ZHrda9RXY4WNLlPcql8gL1QTrUQ1GFj6H8sIP0bECE5LztF35Ywa77ahKGJYWY45FupWi9kxl2lr9UU0Aceyistx/0mn2s5GlF/zVCjeKpzbxENQXJhKsLn9Sjf4ZZuETVzf31B5avnOWtyW6W9r+L2/LPX7Ut7jXKc47vsgtfcdphak8akccsIhIMDafpdOcdri2VUHotT5Gihl4bsiW+FFpSBKJpN6fsjSLT1/P+N4eRZZQhbrBXf0DSN0NSRJj+8fnjNECQOsxZJtPscx1cRNIrP+cbKr3d99zRdFLSTtURTF7XOtu2j38y1B0LtZv7tzJw3PVzyKyxoVL/YDVtg9ao7yKJBSLGtfNSig1GP9DWm1syMyhalfT77UFWx7S+p3TLTCWkEl+WfsVhFN8lyWTfc+xKvZalZYgKXtcicK1e4c4sXDN30gxaZ0ugmqrS29ITXYddbw5Mn0aQWJuORvOP Yfz5de+a z0nc/Krp6+/r7qkvkYZPjTsqU1V8/HiYERMm6QBJOFiov+qBQmbXMhjodgUliW2ls0vLfEC/dKqspyMaPxI/QsM2fPogYjhqIQWqWuw42ibKDDN6h5QfyZ7yodRy2UPtBEMPKMHbqh1puutsxtBcUnlmpQn45PY/zIEaGH3iPgEP1xfzy0qVhdNI52jZ62fcqnBWddtNv6SoXx394Jwrt7iYpE9iC4KDqovthJR65iZY2ex86cZYU1fv3AECXban0QpY4I/WNbnA3O6kgvLAJ6xfBZ2VzccyhW1IV+R3IRXKmRuC/B6/0OdKoTUHVlUYYasgmVubWcmFKr5dUGplAarthinEBwjgGsQshz+iEOJMSaGK/tlDzii2tc303vlRXeFSRYK3vjkMke4rwzbKsHqMQ+QCASHYc7sg3bhjWscmU9gO/gj2P21W01dliET4yWnSBkf+EGw7h/B5gCWry0domurxYHF0/zS8OLtfyUWeGUDywAPQFs72V0oB/PnGtuyyeH/Ub8zNA/fdOe/O6eEWGQojH/a8ppTcnWavAFJMuN8DZT2+jAwf5BuQ4OXTqmsz46hW91LSdmpegi3wTcaQUwoPB8excUJu7zrz8BdYoMicWqwhCfDM8eT0fp9A+yPlfcqbCDnJiVGECyVhyOxSIFcJ7/dWezEJGWorJuDGjf+w3lFJqsaRztQ== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: Now that PAGE_MAPPING_MOVABLE is gone, we can simplify and rely on the folio_test_anon() test only. ... but staring at the users, this function should never even have been called on movable_ops pages. E.g., * __buffer_migrate_folio() does not make sense for them * folio_migrate_mapping() does not make sense for them * migrate_huge_page_move_mapping() does not make sense for them * __migrate_folio() does not make sense for them * ... and khugepaged should never stumble over them Let's simply refuse typed pages (which includes slab) except hugetlb, and WARN. Reviewed-by: Zi Yan Signed-off-by: David Hildenbrand --- include/linux/mm.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/include/linux/mm.h b/include/linux/mm.h index 6a5447bd43fd8..f6ef4c4eb536b 100644 --- a/include/linux/mm.h +++ b/include/linux/mm.h @@ -2176,13 +2176,13 @@ static inline int folio_expected_ref_count(const struct folio *folio) const int order = folio_order(folio); int ref_count = 0; - if (WARN_ON_ONCE(folio_test_slab(folio))) + if (WARN_ON_ONCE(page_has_type(&folio->page) && !folio_test_hugetlb(folio))) return 0; if (folio_test_anon(folio)) { /* One reference per page from the swapcache. */ ref_count += folio_test_swapcache(folio) << order; - } else if (!((unsigned long)folio->mapping & PAGE_MAPPING_FLAGS)) { + } else { /* One reference per page from the pagecache. */ ref_count += !!folio->mapping << order; /* One reference from PG_private. */ -- 2.49.0