From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id ECB83C83030 for ; Mon, 30 Jun 2025 13:02:12 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 2D6066B00C8; Mon, 30 Jun 2025 09:01:50 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 2AE3D6B00CA; Mon, 30 Jun 2025 09:01:50 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 1C4DA6B00CB; Mon, 30 Jun 2025 09:01:50 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 0908B6B00C8 for ; Mon, 30 Jun 2025 09:01:50 -0400 (EDT) Received: from smtpin22.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id C2AB71604F8 for ; Mon, 30 Jun 2025 13:01:49 +0000 (UTC) X-FDA: 83612079138.22.DC7C735 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf12.hostedemail.com (Postfix) with ESMTP id 7FEA54002C for ; Mon, 30 Jun 2025 13:01:47 +0000 (UTC) Authentication-Results: imf12.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b="BI/V/2BH"; spf=pass (imf12.hostedemail.com: domain of dhildenb@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=dhildenb@redhat.com; dmarc=pass (policy=quarantine) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1751288507; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=cBlqU3v31THD5gXpB9nn15wD9nofG3PBMtxlPOPDIeI=; b=yCEJ8gZbVgb3tQpTT3BChWvjllB5DBNol0bJpouHc+PVDEV+uOOgbB6+giSw4rIiCqpfOl uXGCeiOEg1e5lbbukGU8WTajiSusdb+WtAApccyQzV8TEi4aTeH3T2LcZXoRpOWzrbTEdj HRVlL/9KltV/xuP7EZMLikdjasNfnMc= ARC-Authentication-Results: i=1; imf12.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b="BI/V/2BH"; spf=pass (imf12.hostedemail.com: domain of dhildenb@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=dhildenb@redhat.com; dmarc=pass (policy=quarantine) header.from=redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1751288507; a=rsa-sha256; cv=none; b=r1lehuIQIxyEaT2Mr2kGXVccIRFc+hirdGdN1Pcoj7hysZcDIxIbbnqvJQUYFz5xD5Xhqv UQV+qGrLqQ4/DIlq3aWXpzd7hzdPTCY02uaGde3nvGZh2yJwiHMVdCGLbJ2zex7ANnNPwe Aw79Ma3llbcPVpn6N/HrBSgc00BbohQ= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1751288506; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=cBlqU3v31THD5gXpB9nn15wD9nofG3PBMtxlPOPDIeI=; b=BI/V/2BHr4wuS7mT8BgRkrh/x4dCYVkiTG8ShP6vilIV4gJjse9aKV64LXNkJvApGeF13Y Y+QKgp0WBKN8SPVGet21y9KVboqcHba52deNgp0r4v4D+6QBVzKD+BqlHQANYDzeBMoOMe j+7ef//OISWYpQjsUQdhbLOwQEE30OA= Received: from mail-wr1-f70.google.com (mail-wr1-f70.google.com [209.85.221.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-519-xPMbFZbzPFi90UbWNk-AVQ-1; Mon, 30 Jun 2025 09:01:43 -0400 X-MC-Unique: xPMbFZbzPFi90UbWNk-AVQ-1 X-Mimecast-MFC-AGG-ID: xPMbFZbzPFi90UbWNk-AVQ_1751288502 Received: by mail-wr1-f70.google.com with SMTP id ffacd0b85a97d-3a5281ba3a4so1975981f8f.0 for ; Mon, 30 Jun 2025 06:01:43 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1751288502; x=1751893302; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=cBlqU3v31THD5gXpB9nn15wD9nofG3PBMtxlPOPDIeI=; b=McSOhHnuphGIXgdQT78neqgxlxpVcSysl0Q9Oz+A4FPK3IeBOCFfBgcPbqn3pPyytS BzsMQBhgMf6YWgUkB7/sXliqxbYqKBIv7OBX/1UyIwA+Rgt0m41TDwpKNXm0sAANkC4m d7R9JknQuJ73ChcoD1sRk/3Yu2DhnZtd1w7I7NuBqSZumLoO1gWnwsntRcPeT1zTfUzu UWqgY5DX/prVgWAvkbbheQSJt8JKThwWGA27SbUX9gDYsxk2DYR0mZgcNKnvX7M87UYX oNSeBN73iyfdKNPVP9xjiH7IyO7Qun16qyPuvP62AyNmSZhplQahNxRXEalR44LrIbSR PaCQ== X-Gm-Message-State: AOJu0Yw3cd968zce9Fgm69ISHWz2GoMCJx7I/U8brdRwKj81jejGnV8U lhDVfEhGiiQOQFih4+qXJMJIp4KBLPN1dvfSCcegofPtmhWEpPXZDaYPSNy5JLMa8XlTRga7eVF Bxl/mQ1Gz/+w3JRTFJljk49+cEqPiU3TKpHaRviZPPMjdhxz9fTkp X-Gm-Gg: ASbGncuXru+7AD1eAUZU3JdYA5ofvKZj18i2YHkWk0HRP4nBAeGXAxVD8c23Om1l8kc Ha2bG9GMcuu9j2wOkk3d6EDv9sH8PF4Z+axc45zEUNOKXE/znmyjIOfwyruQw0JeMFmAeUjfXJ6 f5LXpGBWajSH4br6CIRzZMYRop3JOQbS6TFL6m8Sy3wl/V5LGRPusx3t9vjQjodRRIcUC2u2S6o WDmQb9pfG3WIZJWlBujh9nXXCTOwU2BVDvSr5G8hxgYujNExL5CyANcO2d1GsS4nvnQs/kSaaPJ i+Z1usXRuo1qiMeUoYPrLmGkPmcD218eYNqLo8iwca1pmMPFhx409gIp6eJCYJ9NcSlh5XWVI9X EqqJg6Ho= X-Received: by 2002:adf:9c85:0:b0:3a4:f90c:31e3 with SMTP id ffacd0b85a97d-3a8ffcca245mr9545920f8f.31.1751288501881; Mon, 30 Jun 2025 06:01:41 -0700 (PDT) X-Google-Smtp-Source: AGHT+IEmBHmttdmK2eq+WBU1B9I2DDaPMLfI/76nbXYnXDHgExr/7iQPmKv6fPJxJBiz140zN+RyvQ== X-Received: by 2002:adf:9c85:0:b0:3a4:f90c:31e3 with SMTP id ffacd0b85a97d-3a8ffcca245mr9545827f8f.31.1751288501169; Mon, 30 Jun 2025 06:01:41 -0700 (PDT) Received: from localhost (p200300d82f40b30053f7d260aff47256.dip0.t-ipconnect.de. [2003:d8:2f40:b300:53f7:d260:aff4:7256]) by smtp.gmail.com with UTF8SMTPSA id ffacd0b85a97d-3a892e5f943sm10337130f8f.101.2025.06.30.06.01.39 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 30 Jun 2025 06:01:40 -0700 (PDT) From: David Hildenbrand To: linux-kernel@vger.kernel.org Cc: linux-mm@kvack.org, linux-doc@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, virtualization@lists.linux.dev, linux-fsdevel@vger.kernel.org, David Hildenbrand , Andrew Morton , Jonathan Corbet , Madhavan Srinivasan , Michael Ellerman , Nicholas Piggin , Christophe Leroy , Jerrin Shaji George , Arnd Bergmann , Greg Kroah-Hartman , "Michael S. Tsirkin" , Jason Wang , Xuan Zhuo , =?UTF-8?q?Eugenio=20P=C3=A9rez?= , Alexander Viro , Christian Brauner , Jan Kara , Zi Yan , Matthew Brost , Joshua Hahn , Rakie Kim , Byungchul Park , Gregory Price , Ying Huang , Alistair Popple , Lorenzo Stoakes , "Liam R. Howlett" , Vlastimil Babka , Mike Rapoport , Suren Baghdasaryan , Michal Hocko , "Matthew Wilcox (Oracle)" , Minchan Kim , Sergey Senozhatsky , Brendan Jackman , Johannes Weiner , Jason Gunthorpe , John Hubbard , Peter Xu , Xu Xin , Chengming Zhou , Miaohe Lin , Naoya Horiguchi , Oscar Salvador , Rik van Riel , Harry Yoo , Qi Zheng , Shakeel Butt Subject: [PATCH v1 29/29] mm/balloon_compaction: provide single balloon_page_insert() and balloon_mapping_gfp_mask() Date: Mon, 30 Jun 2025 15:00:10 +0200 Message-ID: <20250630130011.330477-30-david@redhat.com> X-Mailer: git-send-email 2.49.0 In-Reply-To: <20250630130011.330477-1-david@redhat.com> References: <20250630130011.330477-1-david@redhat.com> MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: 1B8X67SBf1uEsfnYSX5jStKtQbxUVmyKeEFIcnS_fZk_1751288502 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: 8bit content-type: text/plain; charset="US-ASCII"; x-default=true X-Rspam-User: X-Rspamd-Server: rspam06 X-Rspamd-Queue-Id: 7FEA54002C X-Stat-Signature: u79duscg4wyi7s37f7xpauy59zgkbppp X-HE-Tag: 1751288507-533263 X-HE-Meta: U2FsdGVkX19X/1CekWYraFaQD066YlJU04i/jd8aZ+k/vRWGg8Aj6yTQkx6G/n/n6QdZlD2WbtSnlrjgizg/VWnbNSbxcd+yB6dHpQxvh9T4/GoMuXT3IbJawyMVvdq1yhxBYHhIDZmST4QMDyiaZ7k19VKUfnDWOWG+3etuDU0CZqBZ2SWaRsCM+HsB2XgQ8DHS3UQnLG3uShyeFYNkcObkZ92e1jFvHsCyEmRvtlBa0Ia2CLZ/VfizZ+fzRFuebHp8KOupvalSoMceaa+2jzUoy+sBXRUf+HPBQRgk66ms5wChnU9WCkTFSKhBS+sdD+oMxtWdjVm5e1mz7cYxLnUBUUl4JEVC9uzhf69l2B56+BM5lSBTCtSpt99CFntxeJd4dHGpMf28F6o45yURXXkY5OKLCyZ5UqLhlpuaaf8twlKHk2c2Ezioi0oxEzAnIwAC2T+aEMWHTTK8rngwo4hGH5jewIob84P2MJHNh60z/lP5ig7dN9/U9doDDpbif591vCnHPqaJQ2RKpCDbO3aSGbqx4RGatHQoJKVnuSFmCAutAx1pHKc0qmPWiFK4TEovdD4D/z6Tdl/AcaUqC85CSJbXKMPvgR5YcC4G6aMr6T/u+s1Eb6VscA/+cW7aaQREOmr33UCsRfxbKlfal3a71S66/a5Y5hzMvbM0dR5OhaYgFhMLwGFxApHACDt09sTEMzpkgRnBOOtqRyZNbnwF8xK9X1d/XJxxroHB+R3ps1sX90qZF3q6lntBmBnJGyyhHBHX3XyhsDEJZeOdd86N4Ekin+ipf/lnQMmr+WJ3nPrvpWKyiHzv1VdA04gtMnbhGNZtVjMvyVcQnpUai45GrO9cbMS91yqBjl87dv8YzwwVd9WolVe3uqVlRrlzDrnX21NW532Rbf+i/gqLe2a62qsqPB+rDZ03ibG7Gr336wxGgNrJrVU0gzwT5byv4jEcHV2bjHyxnP0MM5U 9STLOZ1X WCj7WGPzRRMkSbEigh35917/gtrqTard/mRgSNy/xk21aSHAjhgdJFfuHOvsA61PjUUYVKylFMUg25TBOWH0nzLoFJLWB1thOQJ3UOmCCFYT8+ewVQoSDLoe7yKIhsoB36IKcKoDjv7ryGLwjzAohI3y7iftC9SRn6So5J1ENDSIlvVncjh4O3vyNg0TWyPjxBhHzsdNWulkbcOPVYHddhv9Jvb/N6K6kOQCgdUCWcnR32DjL895vVYg3Yv5pjGCYcgQKBup9F76NcH/hNRC+42hoX4b+uPzOvqaZCxmHh7N2zpSOIKw0gA5l7XSclaoVNYzA0dgY2CU9+SM/tXh3Bijkufwrp0flIMKPEJ1FbwFcq7pIsj0uBwC22en5klCbLe7IlGOOEzqYPceK89HMcsCowdi9m40lDWCOywYCRyz791I+BiUYcSFPppM2NzAM3+qnFLAe1ApP/OF3nfh8udlAlcRlMSn9k/ZWvmwbBrlnQVOPl9B8C+WZKd048KVIZWqXbd/eJ+wYoU7K4TmQwrx1pU31VHICLN+j+I2NeuC8VB348NXZWENLs2I6rpCWKg8C4X+sppHROX1Mbf8WFXAvvHfVPmUDRrZ3yjdPhNGcF6Bl6j6C7PD+pTd6/T0ZftJ6G/iSBtbw5/zEsxxyEeJPbyzAdUijzz+6 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: Let's just special-case based on IS_ENABLED(CONFIG_BALLOON_COMPACTION like we did for balloon_page_finalize(). Signed-off-by: David Hildenbrand --- include/linux/balloon_compaction.h | 42 +++++++++++------------------- 1 file changed, 15 insertions(+), 27 deletions(-) diff --git a/include/linux/balloon_compaction.h b/include/linux/balloon_compaction.h index 2fecfead91d26..7cfe48769239e 100644 --- a/include/linux/balloon_compaction.h +++ b/include/linux/balloon_compaction.h @@ -77,6 +77,15 @@ static inline void balloon_devinfo_init(struct balloon_dev_info *balloon) #ifdef CONFIG_BALLOON_COMPACTION extern const struct movable_operations balloon_mops; +/* + * balloon_page_device - get the b_dev_info descriptor for the balloon device + * that enqueues the given page. + */ +static inline struct balloon_dev_info *balloon_page_device(struct page *page) +{ + return (struct balloon_dev_info *)page_private(page); +} +#endif /* CONFIG_BALLOON_COMPACTION */ /* * balloon_page_insert - insert a page into the balloon's page list and make @@ -91,41 +100,20 @@ static inline void balloon_page_insert(struct balloon_dev_info *balloon, struct page *page) { __SetPageOffline(page); - SetPageMovableOps(page); - set_page_private(page, (unsigned long)balloon); - list_add(&page->lru, &balloon->pages); -} - -/* - * balloon_page_device - get the b_dev_info descriptor for the balloon device - * that enqueues the given page. - */ -static inline struct balloon_dev_info *balloon_page_device(struct page *page) -{ - return (struct balloon_dev_info *)page_private(page); -} - -static inline gfp_t balloon_mapping_gfp_mask(void) -{ - return GFP_HIGHUSER_MOVABLE; -} - -#else /* !CONFIG_BALLOON_COMPACTION */ - -static inline void balloon_page_insert(struct balloon_dev_info *balloon, - struct page *page) -{ - __SetPageOffline(page); + if (IS_ENABLED(CONFIG_BALLOON_COMPACTION)) { + SetPageMovableOps(page); + set_page_private(page, (unsigned long)balloon); + } list_add(&page->lru, &balloon->pages); } static inline gfp_t balloon_mapping_gfp_mask(void) { + if (IS_ENABLED(CONFIG_BALLOON_COMPACTION)) + return GFP_HIGHUSER_MOVABLE; return GFP_HIGHUSER; } -#endif /* CONFIG_BALLOON_COMPACTION */ - /* * balloon_page_finalize - prepare a balloon page that was removed from the * balloon list for release to the page allocator -- 2.49.0