From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 98721C7EE30 for ; Tue, 1 Jul 2025 22:40:29 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 1E6C06B009F; Tue, 1 Jul 2025 18:40:29 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 1970A6B00AF; Tue, 1 Jul 2025 18:40:29 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 086BD6B00B7; Tue, 1 Jul 2025 18:40:29 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id E840D6B009F for ; Tue, 1 Jul 2025 18:40:28 -0400 (EDT) Received: from smtpin18.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id 83F4B1A01BA for ; Tue, 1 Jul 2025 22:40:28 +0000 (UTC) X-FDA: 83617166136.18.E0E4777 Received: from mail-yb1-f178.google.com (mail-yb1-f178.google.com [209.85.219.178]) by imf09.hostedemail.com (Postfix) with ESMTP id A3983140007 for ; Tue, 1 Jul 2025 22:40:26 +0000 (UTC) Authentication-Results: imf09.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=hJofmhSX; spf=pass (imf09.hostedemail.com: domain of bijan311@gmail.com designates 209.85.219.178 as permitted sender) smtp.mailfrom=bijan311@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1751409626; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=8ppPEYZhg4B0ycuUdBcvBC5LZYOf/2HD/LRvna5W+34=; b=o74iAh+TTSYpQ5FWPSZKdzjIH7gaanApVZExCICI9Ks9uuUjFirsqMN2aaMx4EJ13hox+V o63IM7eTJlVgiRYq9td3k/soxY8/R3WKp1jSDqyof4bzn8qE0PC+yKajLNTEEyEF67GA4T ZIdsb3jUlvy24Ue1u7bZ4B3j0X+Mx9g= ARC-Authentication-Results: i=1; imf09.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=hJofmhSX; spf=pass (imf09.hostedemail.com: domain of bijan311@gmail.com designates 209.85.219.178 as permitted sender) smtp.mailfrom=bijan311@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1751409626; a=rsa-sha256; cv=none; b=WuVMo+wnkcND+hnujXjiu9X2CTPKa8sdC2P3peQM4T9Bl1n9gEGhBh+JuD5eu9aJJ16qJU Ov+z5/5s6kING+qib+KF3AHPhiAliaaljJTs2/tznIvQtMZVjdKvvIOmmSackd5AKtYHcP V1xS1or906d7lmv1pr6iBVybJtiKBxs= Received: by mail-yb1-f178.google.com with SMTP id 3f1490d57ef6-e87c86845d9so2284215276.1 for ; Tue, 01 Jul 2025 15:40:26 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1751409626; x=1752014426; darn=kvack.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=8ppPEYZhg4B0ycuUdBcvBC5LZYOf/2HD/LRvna5W+34=; b=hJofmhSXKqOFl+mifXbnx3R3Vc6NpRJI1V+iwuyWd4h9Hko8KPD239p4hO56HWAE27 uGyGIINdHixcTAPsF8klM9DhNlZWCElkWjX5LLyRo6AIqyNvedSrLp14RiYzCLW3Kmct t8yKxlgMj6zNX66SEEPmysB6X4m5ALul46jhdu0P7wCC9bCCnsby2KLwOaznwC6DQNv1 spqWAzJmH6tGvdAAjRe6k73msETZuLRW58CI+CHygbiVbHouIc/Jjfs4u1YeikaAXGkp eynnDBnKpJlzeuBsdJvgbFQfP/sp1R4btnUYfB5olSShGa4V0QdOi94hMWYq4sfGhgPX 4TuA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1751409626; x=1752014426; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=8ppPEYZhg4B0ycuUdBcvBC5LZYOf/2HD/LRvna5W+34=; b=ttexnSdiaVXU/7Xu4LGuU7FbD6VTvdhzTcGk9KNqq7kVvV8IzttcqEv878A9Keb3Ch 3SsPbUWFSsnjzP9/ASu3cTghEUGyY03HQQR2Lve43t2AGzeGy3rt26sY8Pg1RL0hOrn8 nNARC+a8WMNx8CEXuyUDtX3HmNHoCm3ueZdXSDR7qDvvne+3oCHv61t7cM4y8Xw4KmV1 kuOTnda0E4zp/mboRKpZZ9GLsn8A/W2mYzOw0HuSsVZb5E/r7YCylrptmBb6fE2sujVv B565aj0fguYfFUQ+30IhFd0eu5BjxvN/Prl6wPJlVDNEIWwlHsc+k1fFXdlk8L4JSU9E To0g== X-Forwarded-Encrypted: i=1; AJvYcCVC5sx6SQSopsZ/IbwpuxnT3hiJrSby6wwjk9u5raQQy8ggGqpNUsU8waEXgqmHGUodWifKrdbraQ==@kvack.org X-Gm-Message-State: AOJu0YzDyX5/jTE99OV6O7vKqr1I5WWKm4cm5j129IXswu4nAfLLcB2C hfyTZ97bzvwpwDvOVcov0xXv4oBIW/ikOEY8NQOsxWmV86oyUeXQ5Ohd X-Gm-Gg: ASbGncs4LenVRkhX+IOc/kxN0VF2ClvZMVdTpro3V7RVrTk1kGk/XMRaiSmyl5Bgt6C mNJiYUbPhJ7nqNieWgaAJtxo/rxYsMka2wzYlxSMDBIbayTkzK0SXrbG5FLy/Jfk+E+x3qRcLXB 9GfpZUOBxD4I4aDCVVk9QnBKyDiBB530udr15q05NUaZ21FcVzfZDtqPqEdskLTbMTtqYZ2sWNp 0wpWO3160rJdrMboWfJI37hJWaoWwZGJN6zysY0PvXUsi1Y+BTMpJ1zZc5m9Ivm09YtJDcv+dS/ PCW0KR/wZOJMM6r9D7RA+wFn22qkzqGKXA6O/MVbjgCkjwDQioNNyo5iprseypk+3grRXpZYrc2 JTQziqeM= X-Google-Smtp-Source: AGHT+IEfSExKlYBLEF5iYY85elbMldfM05dmX2YVT1MmFhly9PsAe+w+JK2QOyqbX2jckL9O0qwTbg== X-Received: by 2002:a05:6902:f85:b0:e81:28d6:ed5 with SMTP id 3f1490d57ef6-e897e1a1c3fmr915143276.8.1751409625609; Tue, 01 Jul 2025 15:40:25 -0700 (PDT) Received: from bijan-laptop.attlocal.net ([2600:1700:680e:c000:bdbc:6e11:c9be:13a3]) by smtp.gmail.com with ESMTPSA id 3f1490d57ef6-e87a6bf2290sm3249392276.53.2025.07.01.15.40.22 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 01 Jul 2025 15:40:25 -0700 (PDT) From: Bijan Tabatabai To: bijan311@gmail.com, SeongJae Park Cc: Andrew Morton , Bijan Tabatabai , damon@lists.linux.dev, kernel-team@meta.com, linux-kernel@vger.kernel.org, linux-mm@kvack.org Subject: Re: [RFC PATCH 0/4] mm/damon: add DAMOS_MIGRATE_{HOT,COLD} destination nodes and weights Date: Tue, 1 Jul 2025 17:39:37 -0500 Message-ID: <20250701224014.9008-1-bijan311@gmail.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20250621173131.23917-1-sj@kernel.org> References: <20250621173131.23917-1-sj@kernel.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Rspamd-Server: rspam02 X-Rspamd-Queue-Id: A3983140007 X-Stat-Signature: guyuq3s5i4sgdjqg66boyauzmg6hs6ku X-Rspam-User: X-HE-Tag: 1751409626-651151 X-HE-Meta: U2FsdGVkX19ot6PPPviIAwaOVoNV7nTBhYXOheYJCeC+hEGIytFcJkULfLziijavX0hVL3hCr4ft7jk4ieu5/mStuaqIeVh/GncgObz3vrEwt9Q9JiTpM4qYIenLzgRJ5g0Qu1WAVics6i5hBQM4Es6tMw9bcZ4+MNqJb56BWPmHRD9rqtNVVd/WhHsN0u4fgmzngr1iuz6RLbqmCojfwEj25K2VzH+fhJ/mCdOhSreHdl8gPZ6ga5it/xGQOoifTSYWdvFqaErtfx3MrGb6l+ByGf9FpekC9eGF1kwZXHolE+m11QaQB8KT9Aj4dU2jFXH8zy7XQbD19UIpdv3Dsbj/vZuLcCEgalVyXqX9A6kdlO1mVyvSxnkl3+8kBaiao++w50PFGWaU/fPP+2mQGeV1nB7Cl2B0fIqzpA8ZMFhd5wtQQKkTeQ6UwBmwN8OVBdz4kXEhT1Bx3fYdNBp1OK5TcgX6gLgyobKeNqX6q2FjVLBOmHLVkwTq2nUiiCa6NpvsBVM7oTQiJhtGNDlTRPSJRzYrkwTugOXXNziaQSse7EPCCtT+J9SMJ7YftBwwiD5LAXenNAHiagMPuIFm9zPEM6aqKOfcGW04lgf7rXDt9qtp7x6m8uqlJYM+E+NQy4jb3iUc/qCJBHTIhbKetabMc2oojl4E294nq0OSHXKkTFxp8n/5r3yDCd3DLzRxm7rJS8aqUfhB3zzmefRHylTxcNu7UGXqt2TjreUbzxPMih1VI1Js3aCOgg/DXiRi0nQF55YFOpeyh1BZ+5OKo4vJa2yEvMHL6HO0UoPesQwsyGdquzA2Sq0JtK3yfLbzdYQYCzgp5JYeJZFszdkXKCGhHr0BXu20JshrLtsM0gXteDQ7Vu2WEHHRKCvPDNMmXvI/ga6z0nbB/A2+7O6EDwQHBd9C80IZZQjvIn8/kO6ozFTyUv82KDKJZu0Uuh+zLVeeggHOcsO1fZ3qJFK Qb4oBX/c rM2VAyfInjvkLou+0nXb3SC1p43QIbTeQawcmbgNwqRJlc5jz8EZrUwjW9qNI2l0ixFi80jY0hpMzfTkIxvg+zZlFFZPaWLCM1wMVVNTJIKsCu+FOMTkM4XTDPiivR2cyxe7PI/ZTJYHZHwaCYsRZp4ur4hrRWmephrTqj1eosnbcFm8zDZm40QJ3YnmN25B25VTHaZsLDAcXb3WAV03/GEc9qtLgtSMvYLahJhoXEAWvu/B882ShxqzBRWST219eec6lyIl3afaYEdBllFaMPs8604eNIrl4CIeNFV/aMh0IGZxYYWc03jbDCHh/jjtCKDw/kw5WgZA6X4Bj4BVSvQR777gaQ6+SwVH+3/9BjWVxEFmim7ueWT09bcvvf1itgGdw4KgCZvS+uBRdflYjyVbqPM1avVwq8eAJ X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Sat, 21 Jun 2025 10:31:27 -0700 SeongJae Park wrote: > DAMOS_MIGRATE_{HOT,COLD} action can migrate pages to only single node. > It could be useful to allow it migrates pages to multiple nodes with > different weights. A work for dynamic interleaving[1] is in progress. > We also discussed this could be useful for memory tiering, e.g., when we > want to move pages to multiple noes of same tier. > > Extend the API and ABI interface for specifying the multiple destination > nodes and their weights. > > Note that this RFC is a prototype of the interface change for Bijan's > interleaving work[1]. Hence this patch series is only implementing the > interface part, not the real implementation of the migration behavior. > > [1] https://lore.kernel.org/20250620180458.5041-1-bijan311@gmail.com > [2] https://lore.kernel.org/20240408175228.91414-1-sj@kernel.org > > SeongJae Park (4): > mm/damon: add struct damos_migrate_dest > mm/damon/core: add damos->migrate_dest field > mm/damon/sysfs-schemes: implement DAMOS action destinations directory > mm/damon/sysfs-schemes: set damos->migrate_dest > > include/linux/damon.h | 29 ++++- > mm/damon/core.c | 4 + > mm/damon/sysfs-schemes.c | 253 ++++++++++++++++++++++++++++++++++++++- > 3 files changed, 282 insertions(+), 4 deletions(-) > > > base-commit: 78745efafbb93197e476717385616ed57ea2df22 > -- > 2.39.5 Hi SeongJae, Thanks for putting this patch together. Sorry for taking a while to respond to it. I am finishing up V3 of the interleave patchset using these patches. It has mostly worked great, but I noticed that damos->migrate_dest was not being updated in damos_commit(), so new weights would not be applied. This meant that you could not update the interleave weights by committing the damon state. I also saw that damos->target_nid was also not being updated here. I will will have a patch fixing this with the V3 of the interleave patchset that I will hopefully send out tomorrow. Thanks, Bijan