From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5F1FCC77B7C for ; Wed, 2 Jul 2025 21:03:30 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id D6A708D000A; Wed, 2 Jul 2025 17:03:29 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id D1BD48D0001; Wed, 2 Jul 2025 17:03:29 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id C31438D000A; Wed, 2 Jul 2025 17:03:29 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id B17C48D0001 for ; Wed, 2 Jul 2025 17:03:29 -0400 (EDT) Received: from smtpin05.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 50A16106BFE for ; Wed, 2 Jul 2025 21:03:29 +0000 (UTC) X-FDA: 83620550538.05.2D476B3 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf07.hostedemail.com (Postfix) with ESMTP id 8849640007 for ; Wed, 2 Jul 2025 21:03:27 +0000 (UTC) Authentication-Results: imf07.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b="oX0I/rpg"; spf=pass (imf07.hostedemail.com: domain of sj@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=sj@kernel.org; dmarc=pass (policy=quarantine) header.from=kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1751490207; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=dkqr11cIGn08NIH+0Pwy+7SnuwyR3+SfsTAav3UzekE=; b=gX3+mpSuW5xnvX9xL+JJMmOk159+A/6eoFIpV2vF5hkI/3PMMFas0/UxZZy/TJx92/KjdN YIlEZtJ/Z2f8qIjUajaTXBczMk/TNZ/FA9vjwn9AYgosHl1q0K2T6xfM/nI/+d12b306fp HvRHAtklJ0+o16jhzrqrp9VWufmBVI4= ARC-Authentication-Results: i=1; imf07.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b="oX0I/rpg"; spf=pass (imf07.hostedemail.com: domain of sj@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=sj@kernel.org; dmarc=pass (policy=quarantine) header.from=kernel.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1751490207; a=rsa-sha256; cv=none; b=zEyVJ8UKoGTa3BF71bgWseeiKBY3df0fqC1N2kZeWI2sypZXJCqrOIFxWtz8yp7Vk7vzdG MQWlcmBdskpra7Ex1q7NZ1oCrnudRIi7XybJUTah6SgABdErKaVXzeQ5DF+b9pZNhhXv2t 3p/es3C5iiKahlO1Uw2Ohzhv4+prPRI= Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id 895CB5C474F; Wed, 2 Jul 2025 21:03:26 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 0F411C4CEEE; Wed, 2 Jul 2025 21:03:26 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1751490206; bh=naRdjLcPdsggu6n8OxVx2EKzl9/toXIJWmrz5C5JylM=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=oX0I/rpgpOl+PVs1XtygJG+2K1aU2HQ8q4wtjjy4udHSeOjpmVYT24HzdG8aGF5MV U3/qGl9K+kfAfMvCsHPbzlkocFUNXKB5Qj3H6T68UZadTHn7dUYsv7U/eHfa+GNIML vF/N3EgqYEWzemLZDGS+Lt5YRqVjezKSckH2UBbmMzSmOPWjsU0Td0TBWJJWD5KNCG qaZFavuctiBNZd5sB6niME2Z9Bd5ypP0ihIXyz7GIiK2mmcc2wptqoVumug4TOk8j1 J12Ad7CKXnwo3rLaUwB42yK89Ul1UdWwsS4UiEXAYipprdS4TZFkvVP9r3W85nJ9uL 7iTRKTu+bsmBQ== From: SeongJae Park To: Bijan Tabatabai Cc: SeongJae Park , damon@lists.linux.dev, linux-mm@kvack.org, linux-kernel@vger.kernel.org, linux-doc@vger.kernel.org, akpm@linux-foundation.org, corbet@lwn.net, joshua.hahnjy@gmail.com, bijantabatab@micron.com, venkataravis@micron.com, emirakhur@micron.com, ajayjoshi@micron.com, vtavarespetr@micron.com Subject: Re: [RFC PATCH v3 07/13] mm/damon/core: Commit damos->target_nid/migrate_dests Date: Wed, 2 Jul 2025 14:03:23 -0700 Message-Id: <20250702210323.55199-1-sj@kernel.org> X-Mailer: git-send-email 2.39.5 In-Reply-To: <20250702201337.5780-8-bijan311@gmail.com> References: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Rspamd-Server: rspam02 X-Rspamd-Queue-Id: 8849640007 X-Stat-Signature: fp1ytk3xpmy5597ryixtsyrqcbbm8zt8 X-Rspam-User: X-HE-Tag: 1751490207-64586 X-HE-Meta: U2FsdGVkX1/V5kMGkcmOTRqFMjYzQyY60EmNCKIGnazzl1ow/lzPecFfL1kdQHmr9mF7aXFkOby1tZe6htZ1PGk4Azs6RLSbO5l2U4tt1ubDcVVXXbLBAC8TmvgkY98ZtKA414XU9TXyUF53zfoENgqpNFKoTNsDx9wjTszoH2Sbu7v7kvXMMnoPYAeRhI9/9+/9hG3vmhXawZbhXE0DCTNm5aXthf7rVHWI4FtBMGAHVTFLJ4j+vUnfCgzYV/DTBs5QB8XR1vm+HPdG0ufCBJnbMUQ/kwtCfNq2xqJvZJk05yYXYZGqxMAfVAXolVRGzF/y510YEke3WiQrkpYRXHnDtybqSArm7+icre6JmFl+AWehkzKthGh5+GaOx9YT2SQRay8zEuEBo3JBRdBkAizdX6EB6YsvWX1M9d5DwUjeVNt3DnP9h1EFYARqWjvERSy6vskOsYUnGgUctfhKG4b4StCqGo9zbeutOo1vt8SZtwy7Bj8uBjzNukPMZ3pn9c67Vnn0axOgJZT45/Ah3zuv0i9QhmZBHvg6xRqchXryRfoPlZ69HSnu/Wx+F0dmTyvhSSNmWfprsMeRphZSn/K4shRbwK/9V968yqx2YdjAutBCSdkjB92RrDPx1RqwOdQhh9gMgxLUbmPjuqplY0dLQNMg58+DOr3U7aFfZS72U3tDOCX9e8Yr9eJht9Gdg2x578dYYv0S4fzKgU/DnErNBSHqfg8BlU0DGkNYtaszQrlxaxVConF2yN2aKeHhm2e4btpyDYcNcfIRyWuqtPZvaAMotcDJFLw0SVXqcB2lQhXgGlvDqeySnxfWFesVvH9IADroDkUbbrXv7yynv/cXQ/x/G0ojnfTkvimAsh2qKnTvW8BkFi+7QbQavc1aFdqvR/JkWHT7nvkoV4Cd3VUtSzDfR4A7URgAyr66E94Z9E8m5F5fM3WKB0E2YQt2r2a5vRu2MmRVxiTFZYu HX1YjN5T b4hLZ2t4oXGjhq3dtM+uJhoiIpx1zXdbn//h7yK1R1JaWw1eca/GDVdjJBovzuLtu8ouEBSt3q95tNRG8Gk9TVj3ckPx9SrjNVuqxwJMEnpikKC57TSawRxOA3lt082Q3Qz+m/uhD6MsG0BZlk19SMbkcOqlXreSPksSzWatBK8i0Bb4csw7Hg4UjMDk5CmuamC22m7qsyK7ItOSnaTzdIpaqPNWlTH8IHm0Nc41wttdpLanhA0cbgHExwfLiU/pY7OEv9ICD/Xf4yrObSD+rV22DUkjWS6wKmEEZb25zawcQ2X3kT7rCswYIpRMOyG4ARmMNY6K0B2d9Czsqh/sQp/0pI5NSlDjnLbzCHv2Wo03o48ZrP/txMrPFXMiVarbzKSyfIAhd5kJRyiRtdv61BVeYnj1zs4PsPh2n2p5tkgHAlE9fhrLA95M4SXF8T0KivP4/1WZZlxY/pwRBiWiDXztRqQ== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Wed, 2 Jul 2025 15:13:30 -0500 Bijan Tabatabai wrote: > From: Bijan Tabatabai > > When committing new scheme parameters from the sysfs, copy the > target_nid and migrate_dests of the source schemes into the destination > schemes. Fixing the missed update of target_nid deserves Fixes: and Cc: stable@ in my opinion. Could you please split and post the part as another patch? For the Fixes, I think 83dc7bbaecae ("mm/damon/sysfs: use damon_commit_ctx()") should be appripriate. > > Signed-off-by: Bijan Tabatabai Assuming my above request is accepted, Reviewed-by: SeongJae Park > --- > mm/damon/core.c | 40 ++++++++++++++++++++++++++++++++++++++++ > 1 file changed, 40 insertions(+) > > diff --git a/mm/damon/core.c b/mm/damon/core.c > index a4c3cfe531df..0565aae8d1fa 100644 > --- a/mm/damon/core.c > +++ b/mm/damon/core.c > @@ -943,6 +943,41 @@ static void damos_set_filters_default_reject(struct damos *s) > damos_filters_default_reject(&s->ops_filters); > } > > +static int damos_commit_dests(struct damos *dst, struct damos *src) > +{ > + struct damos_migrate_dests *dst_dests, *src_dests; > + > + dst_dests = &dst->migrate_dests; > + src_dests = &src->migrate_dests; > + > + if (dst_dests->nr_dests != src_dests->nr_dests) { > + kfree(dst_dests->node_id_arr); > + kfree(dst_dests->weight_arr); > + > + dst_dests->node_id_arr = kmalloc_array(src_dests->nr_dests, > + sizeof(*dst_dests->node_id_arr), GFP_KERNEL); > + if (!dst_dests->node_id_arr) { > + dst_dests->weight_arr = NULL; > + return -ENOMEM; > + } > + > + dst_dests->weight_arr = kmalloc_array(src_dests->nr_dests, > + sizeof(*dst_dests->weight_arr), GFP_KERNEL); > + if (!dst_dests->weight_arr) { > + /* ->node_id_arr will be freed by scheme destruction */ > + return -ENOMEM; > + } > + } > + > + dst_dests->nr_dests = src_dests->nr_dests; > + for (int i = 0; i < src_dests->nr_dests; i++) { > + dst_dests->node_id_arr[i] = src_dests->node_id_arr[i]; > + dst_dests->weight_arr[i] = src_dests->weight_arr[i]; > + } > + > + return 0; > +} > + > static int damos_commit_filters(struct damos *dst, struct damos *src) > { > int err; > @@ -983,6 +1018,11 @@ static int damos_commit(struct damos *dst, struct damos *src) > > dst->wmarks = src->wmarks; > > + dst->target_nid = src->target_nid; > + err = damos_commit_dests(dst, src); > + if (err) > + return err; > + As mentioned above, let's split and post this part as another individual patch. > err = damos_commit_filters(dst, src); > return err; > } > -- > 2.43.5 Thanks, SJ