From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id F2D8BC83F03 for ; Thu, 3 Jul 2025 14:07:49 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 18A6C6B019B; Thu, 3 Jul 2025 10:07:47 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 116EE6B019D; Thu, 3 Jul 2025 10:07:47 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id EF67E6B019E; Thu, 3 Jul 2025 10:07:46 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id E0B466B019B for ; Thu, 3 Jul 2025 10:07:46 -0400 (EDT) Received: from smtpin29.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id B2521B734D for ; Thu, 3 Jul 2025 14:07:46 +0000 (UTC) X-FDA: 83623131732.29.2FCE1F5 Received: from tor.source.kernel.org (tor.source.kernel.org [172.105.4.254]) by imf24.hostedemail.com (Postfix) with ESMTP id 20275180003 for ; Thu, 3 Jul 2025 14:07:44 +0000 (UTC) Authentication-Results: imf24.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=lUeZonbi; spf=pass (imf24.hostedemail.com: domain of frederic@kernel.org designates 172.105.4.254 as permitted sender) smtp.mailfrom=frederic@kernel.org; dmarc=pass (policy=quarantine) header.from=kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1751551665; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=nc3BQeQxPFwdC/9heAIn0UriatZkxeRvTGAHfUT87Pw=; b=u//1R0Vs/s5Xe6wixvKi+K5mxLko3aWXFt2ytG0u1n4lwHhvxvd/clkLIj9xv1Tm5SL3L4 oQruczURNDmP6q8ODNA0slbDWy0swNfCRX3PfG8M6FQzqjCjVJEYjrkUbBUKc7Lti2ldhO 4mZSrIesV/313Z3fUHVtS+3E8FOVdxc= ARC-Authentication-Results: i=1; imf24.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=lUeZonbi; spf=pass (imf24.hostedemail.com: domain of frederic@kernel.org designates 172.105.4.254 as permitted sender) smtp.mailfrom=frederic@kernel.org; dmarc=pass (policy=quarantine) header.from=kernel.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1751551665; a=rsa-sha256; cv=none; b=H7DTbbEiQneq53fnl1chqWYfGT5joGB2EJyzGtEXKhNoXVvwRdP3I3ujnFSdB1COUj2M4D jWIUUi0HLWY35odNj4dwsS9wq5SXiqoiAXHlHGrzLB5gRwvAboHSRtx5YcFkHoLncHt80W CdunQwgO1SagdIH4lXI3iwxWQJrU5Pk= Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by tor.source.kernel.org (Postfix) with ESMTP id A027C61142; Thu, 3 Jul 2025 14:07:44 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 1426EC4CEE3; Thu, 3 Jul 2025 14:07:41 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1751551664; bh=6YLBMO4OX7UQZr8sjL+8YFZIQDKbhjUdn2GAhwLdBXI=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=lUeZonbi0i97RiWpdXIlsePYQZPLgKc87nTUzdVxZmFG34JdoqRcAHk8uZXyoNdQC CfM8FFA+iHXdlqB8aTC449Vv7DJ6HgZ+SBpHsvhoPl26dPx1djC92/7X14hkzQpCy1 oDAEEU2vVruA2KXAnglmv3rFulkloSYie2ZXWn8fbViy7mabmajRu3uSkTwlYVR7Vu tfJwbWeE0avB3n0sRXkGU0hl24FTdJeQpxUk9llXySq24QTgt1JUyWKNY4nQqRTOxR AwbdRlBXsp8ykprfNoT3smm3C/yab5+/H2+N85fz4/HSU0bXOkjI+mX0E0Svi5NQMT EOhTnmujdu8DQ== From: Frederic Weisbecker To: LKML Cc: Frederic Weisbecker , Andrew Morton , Ingo Molnar , Marcelo Tosatti , Michal Hocko , Oleg Nesterov , Peter Zijlstra , Thomas Gleixner , Valentin Schneider , Vlastimil Babka , linux-mm@kvack.org Subject: [PATCH 4/6] tick/nohz: Move nohz_full related fields out of hot task struct's places Date: Thu, 3 Jul 2025 16:07:15 +0200 Message-ID: <20250703140717.25703-5-frederic@kernel.org> X-Mailer: git-send-email 2.48.1 In-Reply-To: <20250703140717.25703-1-frederic@kernel.org> References: <20250703140717.25703-1-frederic@kernel.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Rspam-User: X-Rspamd-Server: rspam06 X-Rspamd-Queue-Id: 20275180003 X-Stat-Signature: ga5gpihhqgntmtdruwsir9n3pbkd59up X-HE-Tag: 1751551664-667809 X-HE-Meta: U2FsdGVkX1+kPc45IKuYw6QBWZbkBW5ug0talki+aPAlhdOzZn2ODFFTZuV0FnO0/EVNr57tecW5iClTnxPP3nInI92xvREOP2BKn1axUdjOhnaV13MmCge2cPhvFFIxO5LN3wq7jF22qKCpiOaqLegfRPUPRjJs9cMpLF+pLf05kVgaXqk6VWGrS6Cbl47+OxmRM+UtQm9e/2OFAar79a04OMrW68mWljiRz8dpIBb32Q9RhjcUA5tEggUj+Csj76/GcP4Q7eGHp6Ysox3LJhOxOW+7wg1pS+SsK+D1syqkIaCnFog6iv749VCeZs9bHOrd3OByD1x/GyuTW9+f9Jug2a3m5oZp6IVM93SfaEeyLUEZZK9dQxxiVuNcEwI/LyrY3PbTxfyxjTtDFwtI+QPRPyBTSp1YZX8vn+/7DRPwQ9zdzE2Z9WF+KR14ZM00upA6xLcxOfZB9nkr8uLyW4vMau1T1XxJy50ng2NT65qqXE+xqM12avGSB3mC7Swxa4KyoOdbLI+RTOGprvHnnCp/XqxpX0IzOElzHf4QOp+9+DLW9NPlY/X2of9i+w5zwwnJHwcn/ZCapAQCXSqdGBPR2ooFY+soJbRZ1j1ynTV5VbvBmn+0RbWj3KDQvqE0/9qewvmFxpn7e22gp1GKXX0DMUq23eRGJnhqkj20HrH7nXBDnQKNwKV24VIBQzqbGPSa8J8pVd+KZSybh4p3bBiGeJa9GKCL372Q241MN14J0dFSH/C9EPCSJ4pJ1ldqAyTg4Z+rnHO5gZh0miNXZ2l3Bg/UW0NSQsSDFUNL22Mi/xWVm/TIZs5Z/y9Sn3G7MnjcdZSMi/OGBJpdm0kRSXc5ogJjoofPAGc3T2/FgW97c7qT5LdAL75t5aaBN5b1TISjrExLgXR2ReFt1nV7zK2fdKLKzYsZ3eDJWx9FFPB9HjFDkGy73WCEswHP7ZPDvULYyYk8o+l4vRJxH0m JuL5Myq7 BW3/yCXLzE4RuEi8F0DWpaZQYvASHHGdces3SqdLLZj/ihwjroar+kSkffba0R5p/DxryTxnX423Du4xui4mq6wl/OKq8mReWAKTlJcVlq8tq3t7Chn11rVx0DpWIGtA7X9C6IS1mHyASjJ/wyzRUgAkD2037Gr+B+RVWV2SCV/XP8RdNGtVIgSDmUHJJ2Ai2gt3weLlDLHNb5Udts5R40dOjeyxCc9bGG0r7qhGj+xyotRwaJV4V+FbEicrFuh8Qogdqeq2/q/iVkM+hTivVncINZ0WscCFTj5uBd77xl9/8VksAMB2NhMQFdTC0VG+Afhr8 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: nohz_full is a feature that only fits into rare and very corner cases. Yet distros enable it by default and therefore the related fields are always reserved in the task struct. Those task fields are stored in the middle of cacheline hot places such as cputime accounting and context switch counting, which doesn't make any sense for a feature that is disabled most of the time. Move the nohz_full storage to colder places. Signed-off-by: Frederic Weisbecker --- include/linux/sched.h | 14 ++++++++------ 1 file changed, 8 insertions(+), 6 deletions(-) diff --git a/include/linux/sched.h b/include/linux/sched.h index 4f78a64beb52..117aa20b8fb6 100644 --- a/include/linux/sched.h +++ b/include/linux/sched.h @@ -1114,13 +1114,7 @@ struct task_struct { #endif u64 gtime; struct prev_cputime prev_cputime; -#ifdef CONFIG_VIRT_CPU_ACCOUNTING_GEN - struct vtime vtime; -#endif -#ifdef CONFIG_NO_HZ_FULL - atomic_t tick_dep_mask; -#endif /* Context switch counts: */ unsigned long nvcsw; unsigned long nivcsw; @@ -1446,6 +1440,14 @@ struct task_struct { struct task_delay_info *delays; #endif +#ifdef CONFIG_VIRT_CPU_ACCOUNTING_GEN + struct vtime vtime; +#endif + +#ifdef CONFIG_NO_HZ_FULL + atomic_t tick_dep_mask; +#endif + #ifdef CONFIG_FAULT_INJECTION int make_it_fail; unsigned int fail_nth; -- 2.48.1