From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id E89B2C77B7C for ; Thu, 3 Jul 2025 16:52:43 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 6DFE96B0201; Thu, 3 Jul 2025 12:52:43 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 6B7006B0202; Thu, 3 Jul 2025 12:52:43 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 5F4786B0204; Thu, 3 Jul 2025 12:52:43 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 4F9426B0201 for ; Thu, 3 Jul 2025 12:52:43 -0400 (EDT) Received: from smtpin30.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id CC3A1B8663 for ; Thu, 3 Jul 2025 16:52:42 +0000 (UTC) X-FDA: 83623547364.30.7B2D3AF Received: from sea.source.kernel.org (sea.source.kernel.org [172.234.252.31]) by imf08.hostedemail.com (Postfix) with ESMTP id 205BA160004 for ; Thu, 3 Jul 2025 16:52:40 +0000 (UTC) Authentication-Results: imf08.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=Sbjkl3By; spf=pass (imf08.hostedemail.com: domain of sj@kernel.org designates 172.234.252.31 as permitted sender) smtp.mailfrom=sj@kernel.org; dmarc=pass (policy=quarantine) header.from=kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1751561561; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=4J+TtNlIs9oJ2fZo0vkyJSfsPuHAXQPOo5CM1UxdXPE=; b=W+zjbO+gis8ouKzceRgIQpF1tITg4h+gyNqwd4NLK6PhoMKwVudOvr8ftooedjc1dbOwUC ZUzePP6mcfLmctkY/5o3zGlzZb2WBj873uTPLgpGYPNZgdVzYfieiLNEfXpRpvRBRLDlwE oLIMMKt3BMhC60aHTotzDE3dKnYqHTg= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1751561561; a=rsa-sha256; cv=none; b=rx3I3vPcNjo3wRv20m2QXNc0n7I5/7KlbUGBbNtdYgcV8L693qJ+pfnF/PDNvLBLxxQ9WS amFBMRZYiLPA8o5EBdwmD2ICEwTcX9I6HGPVBuQgJQm2z5lTfmxc+ihf20TSJcmbDJHZ+B ylmNy67ejhhqen1QGHN+FWcvL8PKR5o= ARC-Authentication-Results: i=1; imf08.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=Sbjkl3By; spf=pass (imf08.hostedemail.com: domain of sj@kernel.org designates 172.234.252.31 as permitted sender) smtp.mailfrom=sj@kernel.org; dmarc=pass (policy=quarantine) header.from=kernel.org Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by sea.source.kernel.org (Postfix) with ESMTP id C489C4608A; Thu, 3 Jul 2025 16:52:39 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 7DD95C4CEE3; Thu, 3 Jul 2025 16:52:39 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1751561559; bh=FXncib9IFgDGC6K+cesVYMgwW7vQ5WoISOE2fNWV3IY=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=Sbjkl3ByTogVRPsjQQTSV0b3uGmpTx9m3ntm9CmonxC6waeVZ5pTSvBUvbIXzmfVX YOQVuSqCrkPGSZb+uV4wDDUQ/1NZxGW4buP5zLyy9CY8ovX7QfgVbs9ud+XRK4bIxH KADW1gDQjW7syUY6MXnnLyMwLA5M0MRYOwcMVOxp7pbs+X69f57Y0fWLwZTgsscMra RL8eraCK0bKLPjZwm1TRHyOfNNfMv+trhhX7Kl6Gow7AC52HsdCJGFQzVSUOwSKdzw uA//VZ2g/vSUdbQZGYVOl2pG+vXhNGTnGhfkDjxie/5jU/UGQCY45Oxs4QCUrxjD27 +qkraSVIRv4ag== From: SeongJae Park To: Yunjeong Mun Cc: SeongJae Park , akpm@linux-foundation.org, damon@lists.linux.dev, linux-mm@kvack.org, linux-kernel@vger.kernel.org, kernel_team@skhynix.com, honggyu.kim@sk.com Subject: Re: [RFC PATCH v2] samples/damon: support automatic node address detection Date: Thu, 3 Jul 2025 09:52:37 -0700 Message-Id: <20250703165237.43771-1-sj@kernel.org> X-Mailer: git-send-email 2.39.5 In-Reply-To: <20250703074423.1771-1-yunjeong.mun@sk.com> References: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Rspamd-Server: rspam03 X-Rspamd-Queue-Id: 205BA160004 X-Stat-Signature: c5h1sr5c5gqq763atttfkzf46uwsk8kk X-Rspam-User: X-HE-Tag: 1751561560-939183 X-HE-Meta: U2FsdGVkX187WtaZaoNZPE13Dvhvfk4KYzRijS2PCV3ndXgJKZrhH+EX/Dti5782sIMHsqpuU53uUHipOCOi27oAyfgv3N0UKF+GdLhQZ3FPzUITbm4FJyLhXj7fMfMEaTmHn06l+sSAYXx98J7AzhMHSxQR+qzTYidXc/+JmZ3vtx+0nm3aiwfvCUzQNp0vYOA5yXX+wYb8ckZWSWVw/bUW48jDvA4dLdxLRw/7Q5pUe4N2tCuArUgeEQUWSaZnrgYWbVe8NNxkNV6Ib3f3XvgK0ry2IY851ZAAN7Wa+sDOaJKRZCYtO+zajoxtGuOEJH7xX8I3AdkAnaqYgeu4KeBCduayzz0nFYc365/4ilQOhQWiqtqYu1ZCSO2Pj8dl+q1tZd7U3Vef4+6cgcWbKF8hNVEHf5kDwLTlL3xrklDoYysFsTHGlewlDxYU2y+BANateB8V3G6xlDpIOSEAS1o4fvUSCY0pFeaXy5P2xMcm7OCjoJZdLqSTLqFWc6fAOwWAlhFnsho6jLgR21JMeAqQP9mU1H7oAlFjHS6tAoQSyeXW7GCQ07HOqjGddStaWCGKdKl+x8NrcjyYsCAoJv4+Wrtj82MUO088bR/Q1BE3IU6Jdf3hYsvUBqF+N6LHRpP8gWdb8PL2hwR5uhsogXvEFW0AeeFKaluEYp4/22z6hq9JcEs9nU4jVnQ2SR90WfUN0pCi3ePj3zEVUu37nrHk+ptMN22SGLULHo35qyoG9lZ92chneZqCx2cdZc7e+wexGSV8Q6OZk1ds3WA/XFoE59XF6+wWt9FzyVKma/xptV8PUWwq3pNFPJnhvyAIBCFUXghjuvqosDrMW8H0+1q2OBcskd1L+C0jMGsCkdN+dMdhH5NiHFRA3QEjhe+XNu8Eyuolcy65LVlID3cXs20trfn9TxzZIhSTNLooyTaaa/SrUqlefDEScuDV2FZG1RaO+3od556l/ceCaPo h3qxk6JR gw4K1ahhQaeE0vWVM2al00Lq2121NuQxeLdQtGkvG+DpmB3ajCIs1TW52zyvknKQL+u6wXP3dlWfkfgIQiAge1etG+vm91+ZkDLoNDQYSkEoLb9vc/oK9y+3swxHCTuVX+YA89+jck3HKW4ocgp7qz5Zx8x0rKS8dDgjvqlqJbNw4OtWu/hUWNTZbfcdsoBzKdvqdl04zsAnwOLlbnKq8BR3oMH86MORIWgSQmq3Ih+Qt6iEVtklf2rioiA4MrROC4WA0Tu1nuwd1UA8RtcUUISLDvl/LNnBuiZAV1fS5Jz3pnK6ngTuUcRUomA== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: Hello Yunjeong, On Thu, 3 Jul 2025 16:44:22 +0900 Yunjeong Mun wrote: > This patch adds a new knob `detect_node_addresses`, which determines > whether the physical address range is set manually using the existing > knobs or automatically by the mtier module. When `detect_node_addresses` > set to 'Y', mtier automatically converts node0 and node1 to their > physical addresses. If set to 'N', it uses the existing > 'node#_start_addr' and 'node#_end_addr' to define regions as before. Thank you for this patch! > > Suggested-by: Honggyu Kim > Signed-off-by: Yunjeong Mun Reviewed-by: SeongJae Park > --- >From next time, please consider adding a summary of what changes have made from the previous version here, like suggested[1] on the documentation. > samples/damon/mtier.c | 42 +++++++++++++++++++++++++++++++++++++++--- > 1 file changed, 39 insertions(+), 3 deletions(-) > > diff --git a/samples/damon/mtier.c b/samples/damon/mtier.c > index f3220d6e6739..3570ebe10fab 100644 > --- a/samples/damon/mtier.c > +++ b/samples/damon/mtier.c > @@ -42,8 +42,34 @@ static bool enable __read_mostly; > module_param_cb(enable, &enable_param_ops, &enable, 0600); > MODULE_PARM_DESC(enable, "Enable of disable DAMON_SAMPLE_MTIER"); > > +static bool detect_node_addresses __read_mostly; > +module_param(detect_node_addresses, bool, 0600); > + > static struct damon_ctx *ctxs[2]; > > +struct region_range { > + phys_addr_t start; > + phys_addr_t end; > +}; > + > +static int nid_to_phys(int target_node, struct region_range *range) > +{ > + > + if (!node_online(target_node)) { > + pr_err("NUMA node %d is not online\n", target_node); > + return -EINVAL; > + } > + > + /* TODO: Do we need to support more accurate region range? */ I understand you are saying we might need to remove address ranges in the node that DAMON will anyway unable to check accesses, e.g., reserved memory. Since those are uusally only a small portion and this is a sample code, I think we don't really need to do that, so I think you can drop this TODO comment from your next version, if you are gonna make it. > + unsigned long start_pfn = node_start_pfn(target_node); > + unsigned long end_pfn = node_end_pfn(target_node); > + > + range->start = PFN_PHYS(start_pfn); > + range->end = PFN_PHYS(end_pfn); > + > + return 0; > +} [...] [1] https://docs.kernel.org/process/submitting-patches.html#commentary Thanks, SJ