From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 59470C83030 for ; Fri, 4 Jul 2025 06:07:53 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 6944E6B8007; Fri, 4 Jul 2025 02:07:46 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 61DFA6B00FF; Fri, 4 Jul 2025 02:07:46 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 496C76B8007; Fri, 4 Jul 2025 02:07:46 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 345AA6B00FC for ; Fri, 4 Jul 2025 02:07:46 -0400 (EDT) Received: from smtpin21.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id F1DA8109C54 for ; Fri, 4 Jul 2025 06:07:45 +0000 (UTC) X-FDA: 83625550890.21.8DF4564 Received: from mail-pj1-f74.google.com (mail-pj1-f74.google.com [209.85.216.74]) by imf21.hostedemail.com (Postfix) with ESMTP id 29E871C000D for ; Fri, 4 Jul 2025 06:07:43 +0000 (UTC) Authentication-Results: imf21.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=1jkuVz5x; spf=pass (imf21.hostedemail.com: domain of 3r29naAYKCHYmolYhVaiiafY.Wigfchor-ggepUWe.ila@flex--surenb.bounces.google.com designates 209.85.216.74 as permitted sender) smtp.mailfrom=3r29naAYKCHYmolYhVaiiafY.Wigfchor-ggepUWe.ila@flex--surenb.bounces.google.com; dmarc=pass (policy=reject) header.from=google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1751609264; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=h5UIhHsA2QH3v7duxv2jqX5tfGSl+3WijZnkCT/PyKo=; b=Q+9NRHQ61yjGubzE4QWgqZ2rO5LgxTjndQTS5KmuEmmnVe3M8R0HIS6xT1HICLeLJOsgeB jKmkm46Dy6IqPOaeScVK+4BmLp9Xj8xrFOG4OCfDtKIJu8eDg96OThjOxqQcNq3s0vQyo3 xH9ONzPldKjLxLoWcykFfzMpeJjYHLo= ARC-Authentication-Results: i=1; imf21.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=1jkuVz5x; spf=pass (imf21.hostedemail.com: domain of 3r29naAYKCHYmolYhVaiiafY.Wigfchor-ggepUWe.ila@flex--surenb.bounces.google.com designates 209.85.216.74 as permitted sender) smtp.mailfrom=3r29naAYKCHYmolYhVaiiafY.Wigfchor-ggepUWe.ila@flex--surenb.bounces.google.com; dmarc=pass (policy=reject) header.from=google.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1751609264; a=rsa-sha256; cv=none; b=o5Al5+SJMaq+WpR5H9+QW2A9smDD20YKt1LNuotGPa798Z/bV/6Y3UQBNc8/hawKIcyfh1 kV6+xqvwOjwOe+g9YLdw5Ae8WXAtTWdWqHyfouF4TNYzw7FI63lQefiUWAojAzkgEWe76h 3EwEH7GrhS3GVsIryCC0JjJOBImFHbU= Received: by mail-pj1-f74.google.com with SMTP id 98e67ed59e1d1-3138c50d2a0so977262a91.2 for ; Thu, 03 Jul 2025 23:07:43 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1751609263; x=1752214063; darn=kvack.org; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:from:to:cc:subject:date:message-id:reply-to; bh=h5UIhHsA2QH3v7duxv2jqX5tfGSl+3WijZnkCT/PyKo=; b=1jkuVz5xvItXHL12x4cFU/HJa108TLx0c4NmGfqaxOCDPhTneVPiEwt3SgX2+Ds4xM wlEcwiAKrfJFtvQGG/bPaEbnXB685fUrJhyq8TpbEbt5FyA/oqEQMjeVHtJseSF7trR2 slcGqeYKF0qKxzpa6GEjO1w+SGkkJvDOOX1sWh0qK7Xb5U/TBzFCEoB8PTrmKkZtzqO6 qCgkqGUeV2CI+EMi4TW6ueaGTgp6kVYFmAEfynL+hkmm8eb4f97I2bVMU+P7buqrqKN/ Du5KVZtW1DqvefI4ZqzXsGD38bph2R6GRbmQjCVd0kK/XIvy/AvwwmiOKTejApfOwwwJ 44zg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1751609263; x=1752214063; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=h5UIhHsA2QH3v7duxv2jqX5tfGSl+3WijZnkCT/PyKo=; b=DstOycMFRgVX77G+pXK+66kpSxK+00Jme+ba5aSlg2G/iYEw3XwYP7xJTx1gvmtcCV W1xIb/+VYFZgTXi7CueKPHcfTVjWASunqoKwyQqIEw1YUYcKo1r0W6OiTFqc/87deBA8 hKRxgdTfhkMt6qLaxsjpcladXQUFZfLuQABAxP5Uhqbyhm1CXpjLM8I4Dt8pDXHwG7jq nRxDPKz8UUptWT5KvPjgGrfexyQbSCj0KQOwS8/aMnX2MyExawk3TWhPRzOw41856BUL OkvY2EYsLmJWX5nx2773e64kyHe4PzaATchNhwulVuu66PLgN/k6Tsa6BNHJ8JUjRjAh +clg== X-Forwarded-Encrypted: i=1; AJvYcCWThkc/bmESJcNJhnv0Qs22+Exf7HKpT8o1UeSgPIw3jbaaYh/CtB+X9wRZuKy8b/Z7P8wQTFN7fQ==@kvack.org X-Gm-Message-State: AOJu0YzFviGp3mB1NtOj1Cog+c0hxEYb67m1X4+5hZID6vgj9/VGuQp6 QoOc4nff1vc55Bx5x4KtDgz/YraJ5BbAE6I2fC6YiyZUvXBhUdlnavod5llR/Mmm+NILGaDH1wE tekc9dw== X-Google-Smtp-Source: AGHT+IGb1KdAzn5YP1WDTyP0Cp9f49AuhUCkK4JgigY7PefACgEs5tH7aIbj4XAEANijeDnY8cuDukZytlM= X-Received: from pjtd10.prod.google.com ([2002:a17:90b:4a:b0:311:c197:70a4]) (user=surenb job=prod-delivery.src-stubby-dispatcher) by 2002:a17:90b:2702:b0:314:2939:efdc with SMTP id 98e67ed59e1d1-31aac44a392mr2310092a91.13.1751609263074; Thu, 03 Jul 2025 23:07:43 -0700 (PDT) Date: Thu, 3 Jul 2025 23:07:24 -0700 In-Reply-To: <20250704060727.724817-1-surenb@google.com> Mime-Version: 1.0 References: <20250704060727.724817-1-surenb@google.com> X-Mailer: git-send-email 2.50.0.727.gbf7dc18ff4-goog Message-ID: <20250704060727.724817-7-surenb@google.com> Subject: [PATCH v6 6/8] fs/proc/task_mmu: remove conversion of seq_file position to unsigned From: Suren Baghdasaryan To: akpm@linux-foundation.org Cc: Liam.Howlett@oracle.com, lorenzo.stoakes@oracle.com, david@redhat.com, vbabka@suse.cz, peterx@redhat.com, jannh@google.com, hannes@cmpxchg.org, mhocko@kernel.org, paulmck@kernel.org, shuah@kernel.org, adobriyan@gmail.com, brauner@kernel.org, josef@toxicpanda.com, yebin10@huawei.com, linux@weissschuh.net, willy@infradead.org, osalvador@suse.de, andrii@kernel.org, ryan.roberts@arm.com, christophe.leroy@csgroup.eu, tjmercier@google.com, kaleshsingh@google.com, aha310510@gmail.com, linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, linux-kselftest@vger.kernel.org, surenb@google.com Content-Type: text/plain; charset="UTF-8" X-Rspamd-Server: rspam10 X-Rspamd-Queue-Id: 29E871C000D X-Rspam-User: X-Stat-Signature: fs6yhw18dee1r9hbo7cyjnjbwysmqpif X-HE-Tag: 1751609263-481966 X-HE-Meta: U2FsdGVkX1/omI5DRvHN0awxYxbSsQzJvCIVs8SJaW+Of6ErqN3ia8Y+mBkzpxco8IM4Oj8FQx43lV2t0kSyqSNLPjO/ihya2DiVBNNLJcOnCe6cersKo+Y+ywF0XtRU8FyW8EOjB8EtrUK0ErmB7/3aVqEk3NNK50XssNp9wpmE0HJYK+mekLup/eid3go3GvJbbN7xxGnoOUl1jOufeOESsC73cvRb8tD6fDgqsp/wxkDnkYXnD3qVbJTwiD0EnNubD7MTzLoV2QwAjsf8zHBV+5UEAdAyosQsZZTJ4CVSNTeBrjS67eCv5XbPk23r+NU3ANiLNZ2xAne1FpRQjQn7F4wmYotkh/+2TTpbNFF1PKcivBuy22RYE0Q20brtYYbn6aE8HwVY0M0vS8U+MC1QcgBAmxWxFgmIYnEdmNzJtgov7ItmNlbzS5Lu4QXNgtWAKJo+o2xXwVutdxBPo6ioZ8bgYZb7wJq+Xu/xZj5MQJuHF8SEuinQmChFXALBK0PORxseXSNeyfGk0ze4q+FjZafKGu2zSDcyRj5+FCZO3o8Dbuip5qfjWIq9WBkEaJg5JOOdoo4SSCovKszA63b7xiKmOBLLMmqIhV0bdHDAS5OdJK6VbfVnoIMh/rFYMFQp1C+z3Vc4igaMsMoZBoegS6AKUg9AhO8q+VahlXSRZctlYfaWLCWx0FiAqCjca1OtQF29W9ueR1HTuT0k1PpNVt/cGI/54bpQtkSAudvIHQXvZx/8iiOeD2fd3y6I0bxINopXLPMcsDhdrDiG78PLvDu8LIyiV5HwTgBwQtm4tlCL0dfj1++/Ap/Vvf3c9Td4deMKU8jsXUc5p/yZuMxfBO2LwyhOLlGgKFQIuX37VhAAQCpPIaAvqB2ZcP2kxTSHzKBUQd6FC/sh9KZIBk8QCs4YK3oTMNRM4Gu21njT7CarXLW+FVJeWRsARZ5cSJhWZd7klCxEpJ+Qjpy HqaVV81R fYMdKUQaB8F9Mi+3KroVVuRB8xfwoNwpQwHLQXy87t70bpktEO2GDtVAtQfpNrkQDqewbXINz5gVCXWbJuav3pRUrHIvhqk8IW4U7OcDWXdVQDHQldS69jlUTUY+yqLXEL21Hp00gdsgvCoWyWcgsi9/TKj3JBaBZ/gHM7wL5vYZ1p+K/4To6W232DmKAhmJ83zkWcs/wH6xlbz+66gS1a5ylisDVCTNORI1++z3AHqxY39QWihb31EqvgekPpOHPG9ACkhsEtwtCyiKmF+jQTTCJ/NO/BWjZFv80HNpQ4gwciniGBve7xSyeV0l8pTVSOjNgd7tkm493kk0ftElpqLVwsPhTVOBToSJSo7kJrBntK1BdNGr8fyEkv98XblVlaXRdcURdDI31hFbgDUhkVELNy7tn90fA7icxcLpSpIzP/mhGHjFpSOyYApd8OKD1rrv0GfvQc8crTuIiTdf07ujMq/krCPGnUgKALMT6NSELmULThtnqJl+zD2I/dDYRMwRAXuB4hBNy2qNH7CJ3G86Ud+QJcYtyJ37SjjjLUqDGBrkhSCxJWSr+8PEOaypTY/J7vGVa9J6aUxADcgDr6ddCOA0DrxyMhbnL0Oypkk2z3AIfJhHs6Wg+XA== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: Back in 2.6 era, last_addr used to be stored in seq_file->version variable, which was unsigned long. As a result, sentinels to represent gate vma and end of all vmas used unsigned values. In more recent kernels we don't used seq_file->version anymore and therefore conversion from loff_t into unsigned type is not needed. Similarly, sentinel values don't need to be unsigned. Remove type conversion for set_file position and change sentinel values to signed. Signed-off-by: Suren Baghdasaryan --- fs/proc/task_mmu.c | 14 +++++++------- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/fs/proc/task_mmu.c b/fs/proc/task_mmu.c index 751479eb128f..b8bc06d05a72 100644 --- a/fs/proc/task_mmu.c +++ b/fs/proc/task_mmu.c @@ -135,7 +135,7 @@ static struct vm_area_struct *proc_get_vma(struct proc_maps_private *priv, if (vma) { *ppos = vma->vm_start; } else { - *ppos = -2UL; + *ppos = -2; vma = get_gate_vma(priv->mm); } @@ -145,11 +145,11 @@ static struct vm_area_struct *proc_get_vma(struct proc_maps_private *priv, static void *m_start(struct seq_file *m, loff_t *ppos) { struct proc_maps_private *priv = m->private; - unsigned long last_addr = *ppos; + loff_t last_addr = *ppos; struct mm_struct *mm; /* See m_next(). Zero at the start or after lseek. */ - if (last_addr == -1UL) + if (last_addr == -1) return NULL; priv->task = get_proc_task(priv->inode); @@ -170,9 +170,9 @@ static void *m_start(struct seq_file *m, loff_t *ppos) return ERR_PTR(-EINTR); } - vma_iter_init(&priv->iter, mm, last_addr); + vma_iter_init(&priv->iter, mm, (unsigned long)last_addr); hold_task_mempolicy(priv); - if (last_addr == -2UL) + if (last_addr == -2) return get_gate_vma(mm); return proc_get_vma(priv, ppos); @@ -180,8 +180,8 @@ static void *m_start(struct seq_file *m, loff_t *ppos) static void *m_next(struct seq_file *m, void *v, loff_t *ppos) { - if (*ppos == -2UL) { - *ppos = -1UL; + if (*ppos == -2) { + *ppos = -1; return NULL; } return proc_get_vma(m->private, ppos); -- 2.50.0.727.gbf7dc18ff4-goog