From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 96D12C8303D for ; Fri, 4 Jul 2025 10:26:28 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id AC2376B802F; Fri, 4 Jul 2025 06:26:19 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id A4B7E6B800A; Fri, 4 Jul 2025 06:26:19 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 914A26B802F; Fri, 4 Jul 2025 06:26:19 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 7C48B6B800A for ; Fri, 4 Jul 2025 06:26:19 -0400 (EDT) Received: from smtpin03.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 5226410742A for ; Fri, 4 Jul 2025 10:26:19 +0000 (UTC) X-FDA: 83626202478.03.B72398F Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf15.hostedemail.com (Postfix) with ESMTP id 2D7DCA0003 for ; Fri, 4 Jul 2025 10:26:17 +0000 (UTC) Authentication-Results: imf15.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=X5Grg4pL; spf=pass (imf15.hostedemail.com: domain of dhildenb@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=dhildenb@redhat.com; dmarc=pass (policy=quarantine) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1751624777; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=0v9UDDMP4rF7Dl8ADVUR+GZMZCj14eHRzzjvBkF5+v8=; b=mIiUFIIriLQAwJtdtVKbFAuw7TL4KiKo875ZnEQv/U/uR+aFDVGgrMnqGbFhVqkqTOfHzs aMw6M5eUBKfkU9NYgri6ogFGjJjntVo/NFW3WmfJY9zBLZKXDyvSuxRB+Kvn9Pv8jGq3db 8scrF0h8C6kyy5ZY6RfFe9mXOIh0CXM= ARC-Authentication-Results: i=1; imf15.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=X5Grg4pL; spf=pass (imf15.hostedemail.com: domain of dhildenb@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=dhildenb@redhat.com; dmarc=pass (policy=quarantine) header.from=redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1751624777; a=rsa-sha256; cv=none; b=C8A1RCcxrb2o3+fD7zGBZeQwS/k6lQ6OQFXUF3ZqILBBqRnm9rXb9NCIo9wbCwT2a1IvdB UWs+3YbdSfJQuRy2Vk304De6sH/NFUGokaxrXBmTijTCsB9nD4Tiye+33PRFXLYbBoM08i lzOvZBGeggKkmkbQijXxvB9qmP1rHqM= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1751624776; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=0v9UDDMP4rF7Dl8ADVUR+GZMZCj14eHRzzjvBkF5+v8=; b=X5Grg4pLQrz2ZzO3O+8zFaXKgo+leUm2Fr2StYGXjKdBziGkwOLfTn27qVmhuHVOZBgnYz nrKsgiwNRGjh9OBIlYNFUmF1sFf+MdX2p9n9eIFfjP5Fr6IXpHolhmCwNAYzkcSG8JzMRw orXq66Xlq6ukWi05UNafL5A/y2h4pjY= Received: from mail-wr1-f72.google.com (mail-wr1-f72.google.com [209.85.221.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-66-aVMsBZXqPPSBzFCeNg8WwQ-1; Fri, 04 Jul 2025 06:26:10 -0400 X-MC-Unique: aVMsBZXqPPSBzFCeNg8WwQ-1 X-Mimecast-MFC-AGG-ID: aVMsBZXqPPSBzFCeNg8WwQ_1751624769 Received: by mail-wr1-f72.google.com with SMTP id ffacd0b85a97d-3a4f6ba526eso519474f8f.1 for ; Fri, 04 Jul 2025 03:26:10 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1751624769; x=1752229569; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=0v9UDDMP4rF7Dl8ADVUR+GZMZCj14eHRzzjvBkF5+v8=; b=EvP0fI5noqSoplQpXt56aOXZAukpzwgFPcRuHxUIiXGDVMq96DhOGsBoGUOAaJu2SF B/qWNNwNgGgBI7efx4O36eOUu1nleaxUB+C7pyJRJpQoFRT7kcKJmRztrweDJfIrq44j TvVqtwV9WDeqwYYpmW5K8bg4yeoH+JLt+nTvJU6t1zJfqCfSoi85h3J1XxUndACbwKxB VzL6ZCWbKg44xg9Xj8UOU54PdXdskl9vhFZ2cvtpFwl4xiQDw58ltp+H723HCcdBPZ9V A5GFsppJbo5T3GL629lmuSAJEgmeO+sB6cieqNGUVr+okU90mtCRmREoYik5VkBsmPVR Oiqw== X-Gm-Message-State: AOJu0YwNnZduM+yeo1qdiMw2iAPEYUACUiAQHRAsde9fl5xduX46XYjG kZglZTUx306HE3F1JfHJxNE9vb1VAXo/L27JKgHfzV6C3vHaiYUpKppM6txb7E5JRYo5rKBZBjj 1jCUGZzyaF5soKKK9tHGtk3TjHyBqEmfUSfH3CB4R+8csgap0sm9c X-Gm-Gg: ASbGnctaJDJXoB2REAC2LREsL1s0HpJV8BDNhK3UupWAYLXcRSmZMowiKDbOUSYLeY1 fYpAJ/i35ffNcLOr1jJyTq3pNYCJWAQXfomjDRDkScew5OkifhlOdesBaF/TvEjH4upaHIpwsQm 4l+uLfHBCT05Rd27txXqoKhVCtbEoUx5dAtQNDl/6bOeQo/IyPvmsvf57+gSxkHtds1BqMPr4rX PCBYRjkleeYwd+F/kqPSTnL7i4M/U9xa1uKA88PzZ7CCwYnqnGVA4nEcQvNJz83JzsTAWxeiNeu bFBhQYso2XG4kxUk6+cMwIaf5sxYD4lLObzOv4pIgS/mZhpC2vGLCcwuDgQONsRNe0PKSuEvM9R 1qRvCwQ== X-Received: by 2002:a05:6000:1a88:b0:3b4:58ff:ed1 with SMTP id ffacd0b85a97d-3b4966267b8mr1677174f8f.52.1751624769068; Fri, 04 Jul 2025 03:26:09 -0700 (PDT) X-Google-Smtp-Source: AGHT+IFOt865rvlOHIOEECbMk+LvbVs6qEWcN/5MI9jLz/1+4Qw68QFcrUmFxGowYoL4Q/9NBp5iRA== X-Received: by 2002:a05:6000:1a88:b0:3b4:58ff:ed1 with SMTP id ffacd0b85a97d-3b4966267b8mr1677111f8f.52.1751624768501; Fri, 04 Jul 2025 03:26:08 -0700 (PDT) Received: from localhost (p200300d82f2c5500098823f9faa07232.dip0.t-ipconnect.de. [2003:d8:2f2c:5500:988:23f9:faa0:7232]) by smtp.gmail.com with UTF8SMTPSA id ffacd0b85a97d-3b47285c90esm2150789f8f.91.2025.07.04.03.26.06 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 04 Jul 2025 03:26:07 -0700 (PDT) From: David Hildenbrand To: linux-kernel@vger.kernel.org Cc: linux-mm@kvack.org, linux-doc@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, virtualization@lists.linux.dev, linux-fsdevel@vger.kernel.org, David Hildenbrand , Andrew Morton , Jonathan Corbet , Madhavan Srinivasan , Michael Ellerman , Nicholas Piggin , Christophe Leroy , Jerrin Shaji George , Arnd Bergmann , Greg Kroah-Hartman , "Michael S. Tsirkin" , Jason Wang , Xuan Zhuo , =?UTF-8?q?Eugenio=20P=C3=A9rez?= , Alexander Viro , Christian Brauner , Jan Kara , Zi Yan , Matthew Brost , Joshua Hahn , Rakie Kim , Byungchul Park , Gregory Price , Ying Huang , Alistair Popple , Lorenzo Stoakes , "Liam R. Howlett" , Vlastimil Babka , Mike Rapoport , Suren Baghdasaryan , Michal Hocko , "Matthew Wilcox (Oracle)" , Minchan Kim , Sergey Senozhatsky , Brendan Jackman , Johannes Weiner , Jason Gunthorpe , John Hubbard , Peter Xu , Xu Xin , Chengming Zhou , Miaohe Lin , Naoya Horiguchi , Oscar Salvador , Rik van Riel , Harry Yoo , Qi Zheng , Shakeel Butt Subject: [PATCH v2 14/29] mm/migrate: remove __ClearPageMovable() Date: Fri, 4 Jul 2025 12:25:08 +0200 Message-ID: <20250704102524.326966-15-david@redhat.com> X-Mailer: git-send-email 2.49.0 In-Reply-To: <20250704102524.326966-1-david@redhat.com> References: <20250704102524.326966-1-david@redhat.com> MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: Ks9_IaOoif2s1A8sWNM77F5yZDS8AiR7xA_tQp3nADA_1751624769 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: 8bit content-type: text/plain; charset="US-ASCII"; x-default=true X-Stat-Signature: stjzmn4663u6nontjaixygebk1y4amyg X-Rspamd-Queue-Id: 2D7DCA0003 X-Rspam-User: X-Rspamd-Server: rspam07 X-HE-Tag: 1751624777-913782 X-HE-Meta: U2FsdGVkX19OswhiWoSJg8Vt2UAg0N2lTcdeBfAVtiCJvOpgbqaxEry0DDUQ6SrRQe9rXfapTqWH6l92V4MCwXROJJzNMhxe5tjGl0/6x8VKJyHCWeR4J1DWbjLD+4V+/AAOQzpQHer1XCB7dDDwP7r382oF8YOCbnlov4OuFou1DDItr9PnbbL0eTCz0px0D4dr/kwz6Vc72qwPmJ5tIcbQLani7g457cIJx9oI8R7aISibFThELo6cd0SXogya8CtmRrCSJSu1XAbP5yYDl0snOpX1+td+IKQiO91SfJAnigdnbXtV6dR+m0Gse1YXjKXz6oGD6oB/mGrUvDZLCXwtdD4ZgFhyjKqP+Aeb5Rngvx7peG4MIWbKbg6juQwn4tVfxr5+S2nCcti5e5H1MbtI//IRdCxP94kyfm1iYwn/EsEL1a7UgBUYHIkoCNf7OmqG6gQemP4q8USTZGQI2mFJ2TI4qEZoPuIRxuuLO40sBQoH3UFKCe+8kT0yWBfqdpb3wcaZJUZuVYq9T3b9v1OmZe8fievYudV20FifNRzVHdPekofcl0DWF79QnHe2HRRp9VjgL9KvGOBZx7th8hcPRvXHuSyeCDjqTWFAsTJpdG1FR+O/zJCT6e+c73nl/ETnjLLGC7Qr5KKKoJhmYMzkmqZCsSXU9mtqH7vFGSih+W0/YVap1rR14nIh8BCrloMTkG1G3TvxOf1/jDhxrS+Qsq7F+oZtT9H51AAiQ/Rg63+mh818lVggoMklr2Ufr5odcP6a0SSnZ3bsNdlxVmJ6iXk5MXAGHRBPoL1kFQ9GHA3DeJt69DMtQkXgcFyrYGfH13IvwkPKoo+803wDSwj/YbooDvgPuEpqZd7qdZ12tN3415rupSW5F0cc1QvVLme4BFKibLbXn09Ntbgo2D0cijfGiaCY5JpGaH3HZ93ahu4ZgEniPePVft8vIA8IwpHdRanpGO+PVxkAWa1 hwilYWqB lrxuPqRpPba3ZjUhO6Fo0dZHG51mZDNTPlr1BEOgQ60H2DDS4axqGzr5aOiCQmOkSpo6SHJjM1zGS7rVgsdC6Q5XALS/iAn4k7pGHPqbtaE7Nn7frQ6MHHiUt2iDEmwPP6w76xnLxvUZOaUERr4foO/k2NBZ8bSwicL7tp74I8uUK/4mqaxAEdFQODdQx3YIUKvu3/IKfFWzfWmtPRbHSRIkIB5Izun/ScA2Rz8ZY9CwjathzE6NsLEv2zpg/AaDK5m15nE6FQenzMUGvl5fKGuzeHRnalbseGT/J3j6u6ekiT85Sr1RmdovWKsHwXIV79MSB4dVev3mvPGOtNMdi3DlIpnOiOKQ4OPL8gDRHHMYyTCv0Kyda8o7WQ93zLL0rZ9OI8sXIhIC8ZUazefq6TUMdCRDzjGnQivOi4PWaeK9Q1u2YUXgY/ktX8uilxXbpQj+bua92iAqP0/Swo9LsKvqEC2EX9BZ7ozmtTQUqBWCJjpWCsQ1LDKwwhow+iPm2j5UGZ2B7k5DJvv4i2D356+Y4WF1Z93yu/umPN91jdo5sHS49qIKfPeA11ab935olTN0eKRjCA94Q00zwVMRkkN5FOG573zCJIicAjNnmw6fjx+cdu4AG9x2Z/jY4FIw8qjpbzxUEAfwzBMdN8wInQHldtfWGpqEEILhQ2p8nAya49ckgMR+arGSmBEwl3llIuVQVit/2c5m5XXI= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: Unused, let's remove it. The Chinese docs in Documentation/translations/zh_CN/mm/page_migration.rst still mention it, but that whole docs is destined to get outdated and updated by somebody that actually speaks that language. Reviewed-by: Zi Yan Reviewed-by: Harry Yoo Reviewed-by: Lorenzo Stoakes Signed-off-by: David Hildenbrand --- include/linux/migrate.h | 8 ++------ mm/compaction.c | 11 ----------- 2 files changed, 2 insertions(+), 17 deletions(-) diff --git a/include/linux/migrate.h b/include/linux/migrate.h index c99a00d4ca27d..6eeda8eb1e0d8 100644 --- a/include/linux/migrate.h +++ b/include/linux/migrate.h @@ -35,8 +35,8 @@ struct migration_target_control; * @src page. The driver should copy the contents of the * @src page to the @dst page and set up the fields of @dst page. * Both pages are locked. - * If page migration is successful, the driver should call - * __ClearPageMovable(@src) and return MIGRATEPAGE_SUCCESS. + * If page migration is successful, the driver should + * return MIGRATEPAGE_SUCCESS. * If the driver cannot migrate the page at the moment, it can return * -EAGAIN. The VM interprets this as a temporary migration failure and * will retry it later. Any other error value is a permanent migration @@ -106,16 +106,12 @@ static inline int migrate_huge_page_move_mapping(struct address_space *mapping, #ifdef CONFIG_COMPACTION bool PageMovable(struct page *page); void __SetPageMovable(struct page *page, const struct movable_operations *ops); -void __ClearPageMovable(struct page *page); #else static inline bool PageMovable(struct page *page) { return false; } static inline void __SetPageMovable(struct page *page, const struct movable_operations *ops) { } -static inline void __ClearPageMovable(struct page *page) -{ -} #endif static inline diff --git a/mm/compaction.c b/mm/compaction.c index 17455c5a4be05..889ec696ba96a 100644 --- a/mm/compaction.c +++ b/mm/compaction.c @@ -137,17 +137,6 @@ void __SetPageMovable(struct page *page, const struct movable_operations *mops) } EXPORT_SYMBOL(__SetPageMovable); -void __ClearPageMovable(struct page *page) -{ - VM_BUG_ON_PAGE(!PageMovable(page), page); - /* - * This page still has the type of a movable page, but it's - * actually not movable any more. - */ - page->mapping = (void *)PAGE_MAPPING_MOVABLE; -} -EXPORT_SYMBOL(__ClearPageMovable); - /* Do not skip compaction more than 64 times */ #define COMPACT_MAX_DEFER_SHIFT 6 -- 2.49.0