From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 480E3C8303D for ; Fri, 4 Jul 2025 10:25:39 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id B85CB6B801F; Fri, 4 Jul 2025 06:25:38 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id B5C1E6B800A; Fri, 4 Jul 2025 06:25:38 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id A23D56B801F; Fri, 4 Jul 2025 06:25:38 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 8D59D6B800A for ; Fri, 4 Jul 2025 06:25:38 -0400 (EDT) Received: from smtpin09.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id 3E520140271 for ; Fri, 4 Jul 2025 10:25:38 +0000 (UTC) X-FDA: 83626200756.09.F015E56 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf02.hostedemail.com (Postfix) with ESMTP id 0B70D80012 for ; Fri, 4 Jul 2025 10:25:35 +0000 (UTC) Authentication-Results: imf02.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=UloUa5YN; spf=pass (imf02.hostedemail.com: domain of dhildenb@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=dhildenb@redhat.com; dmarc=pass (policy=quarantine) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1751624736; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=cQQqBmPuJGjYXvvpwjiHFMj2XowEg2vBjzCyliDZdkg=; b=SgQrF8h6538Rpl3qlIAo7FmDzWzQ1U9SOmMyHTlidfZuxO1Rl4X5dKYS2dAJjMDNbhw4ed xysgkHGALEPTewahzns7t4mFKrw9pLm7idNDCCQ42RxesmzvWxh0ggYJcyL4K8gn1UrR7W uJIdAVtKeLbIVC5WbROGalltamDmZ20= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1751624736; a=rsa-sha256; cv=none; b=mE3adDRvlSmVtQulihM5/6lOjyD7wmdA/XUUm8lg6Q3QAQO6mKDLBE/8b9rgHww+7/n40W LfdmzO6sf6xqPVT1ukZHCs/fssrb6j6GGosk9N/wGYprHiFA3iy4pevNFuu9EvRPE12rG4 3q7rj369ZxoSD0dnbk8YnM/0fpAqGYw= ARC-Authentication-Results: i=1; imf02.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=UloUa5YN; spf=pass (imf02.hostedemail.com: domain of dhildenb@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=dhildenb@redhat.com; dmarc=pass (policy=quarantine) header.from=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1751624735; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=cQQqBmPuJGjYXvvpwjiHFMj2XowEg2vBjzCyliDZdkg=; b=UloUa5YNw6mxL+cp01MVaT1buAkpKDdXyU+YguhUCsHVpSjPsQyZggMwQI/4tSYKil5lRZ sUO3hQO1vHKFXinS5cxY427CaHppBMSN/i0wpGRFteg0j4VKz1lqv2Owc9tOvRMTPiosnK WH1p7CL05lOdaHeYIapJ4iMzlENvA4w= Received: from mail-wm1-f69.google.com (mail-wm1-f69.google.com [209.85.128.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-692-gxVoVA4rOOG7iWyyMdNmPA-1; Fri, 04 Jul 2025 06:25:32 -0400 X-MC-Unique: gxVoVA4rOOG7iWyyMdNmPA-1 X-Mimecast-MFC-AGG-ID: gxVoVA4rOOG7iWyyMdNmPA_1751624731 Received: by mail-wm1-f69.google.com with SMTP id 5b1f17b1804b1-45311704d22so4284985e9.2 for ; Fri, 04 Jul 2025 03:25:32 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1751624731; x=1752229531; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=cQQqBmPuJGjYXvvpwjiHFMj2XowEg2vBjzCyliDZdkg=; b=ZnJVf6r6JEBk8qFL+n6GGKsNxVRQ/3w5uUbqo9ehrFjZ4ICV5uHYUUBHoLEzHZpEN8 fCuJRUIY85INPhbdfXvzXXbdKb1y7DkiBqC7gS1GOpjmaGUlSuJ9/pIsHGoMRdqr3OH6 b/aFWZRqHcAdP7VkR4x/CVg5WxnflV2VjVTkNTuuULNwzwMUwSbyiYEeFGjQKO1avovk jTClfgklLYfzGKvS3RuQP1Amqt90JO9s0PjAhr3ZJrH2Wn/nkIVwLr7LEYxmQvFpsQaX hANpX8w+9GzD2PdGPSW4Sd7Ac6WFzzPmKLOf2Qpes0N9W2FMh0fsvgn/fk1EmqeSt9gN n9cA== X-Gm-Message-State: AOJu0YxtW0/VNsyXJe3QprdR6LxQ0lXk2hGH4naQIfDnY7wdSdK9j/kU stU3bi+apd2dEMxvwtFLiN54TeDrkUs6hpH33+wqgM7YY3sR10oYZ9CyzSGbgQ/MPWm2rd90wQN Vu+UGE38ZpxujsIptyyjG62kjPkgkqxKZAOAb7aBT0+1WigpKbz+m X-Gm-Gg: ASbGncu2sWbKk7TAL+VGYI4Y582qYnr6TS72wsSSP2sLP9FO/YN5XgnWDB8ne9UMQEl Pprm7+o0RLj5nAldCzCD1ASs8K64RvJEuJi+vJomqNl6gJeWItRXU81xpx20i1CotOhJtyme7RL rcL6THvpnfsO+t80GrVkioy1Lh2+lRjkswfZALqFgWQ0KI8eI1hnc0MqfgNm1vCgWiMuKk3S3h8 mfdIcMOiDhwLsbdXw9yJkgzjCVL3RpCpD++DfDmZWhoKTMH1AGXN94QKj6J9gUq1WccS+RuzH9g wu2f9bSSkYieu3OsiAhWgYUEYx9iR01y9Ua4VLBTjSwIkpiqfHvjXbUr/WELz5bHBJjngKYJi+Y VuIV5tQ== X-Received: by 2002:a05:600c:1c19:b0:43c:f8fc:f697 with SMTP id 5b1f17b1804b1-454b4e74ba9mr16507915e9.9.1751624730979; Fri, 04 Jul 2025 03:25:30 -0700 (PDT) X-Google-Smtp-Source: AGHT+IG2JCKcFSESlucn/AkzEEQU5f9yWEwz5OrnoWVnvSvIPUgrXnOXbfSZDcsxaTgozbAMtqKAdQ== X-Received: by 2002:a05:600c:1c19:b0:43c:f8fc:f697 with SMTP id 5b1f17b1804b1-454b4e74ba9mr16507075e9.9.1751624730349; Fri, 04 Jul 2025 03:25:30 -0700 (PDT) Received: from localhost (p200300d82f2c5500098823f9faa07232.dip0.t-ipconnect.de. [2003:d8:2f2c:5500:988:23f9:faa0:7232]) by smtp.gmail.com with UTF8SMTPSA id 5b1f17b1804b1-454a9989fcesm51185055e9.16.2025.07.04.03.25.28 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 04 Jul 2025 03:25:29 -0700 (PDT) From: David Hildenbrand To: linux-kernel@vger.kernel.org Cc: linux-mm@kvack.org, linux-doc@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, virtualization@lists.linux.dev, linux-fsdevel@vger.kernel.org, David Hildenbrand , Andrew Morton , Jonathan Corbet , Madhavan Srinivasan , Michael Ellerman , Nicholas Piggin , Christophe Leroy , Jerrin Shaji George , Arnd Bergmann , Greg Kroah-Hartman , "Michael S. Tsirkin" , Jason Wang , Xuan Zhuo , =?UTF-8?q?Eugenio=20P=C3=A9rez?= , Alexander Viro , Christian Brauner , Jan Kara , Zi Yan , Matthew Brost , Joshua Hahn , Rakie Kim , Byungchul Park , Gregory Price , Ying Huang , Alistair Popple , Lorenzo Stoakes , "Liam R. Howlett" , Vlastimil Babka , Mike Rapoport , Suren Baghdasaryan , Michal Hocko , "Matthew Wilcox (Oracle)" , Minchan Kim , Sergey Senozhatsky , Brendan Jackman , Johannes Weiner , Jason Gunthorpe , John Hubbard , Peter Xu , Xu Xin , Chengming Zhou , Miaohe Lin , Naoya Horiguchi , Oscar Salvador , Rik van Riel , Harry Yoo , Qi Zheng , Shakeel Butt Subject: [PATCH v2 01/29] mm/balloon_compaction: we cannot have isolated pages in the balloon list Date: Fri, 4 Jul 2025 12:24:55 +0200 Message-ID: <20250704102524.326966-2-david@redhat.com> X-Mailer: git-send-email 2.49.0 In-Reply-To: <20250704102524.326966-1-david@redhat.com> References: <20250704102524.326966-1-david@redhat.com> MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: 0iQkWefGRyQhxRLdYGhtDFU6FXVc8HvTTNzxrkkbi2Y_1751624731 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: 8bit content-type: text/plain; charset="US-ASCII"; x-default=true X-Rspam-User: X-Rspamd-Server: rspam08 X-Rspamd-Queue-Id: 0B70D80012 X-Stat-Signature: j11hwdtw8w58nnyehxfzdq34c35x5fdp X-HE-Tag: 1751624735-150159 X-HE-Meta: U2FsdGVkX19C4SnDmJ1IRRBNWKzxJ0se3SZJOmzcZfdGuUjBK+hkuhnW2DHi9oKq/nIYFecZIakavJQ1MTHgqN5yFPfqkmkynhPEtbVMrXXL+J+5Y0dVfG0cTiE1LoCKg18R89MlkkkQZ4vHwlfHEAHe+M3H+Oi2NRO+xatI9Z3ANyvvGX7oZAN1hgqcF4Hn94oJidwmU9F+WbL7bt+HSD7l7gvUcG8NOMzQXu7VNtpcEUTkttND7BbByfBL7pJgRRcRFtDNn+EUgZ0qiVn1AgGTTrhUpWY34JgomA8giYy33y554kCJcGNPglrxgbRTrd2conYG0d7f+Pz0PCHFGCAOQfOzdNmThInfdwbA/wRy8c61tMstovqShi8ZOpGEmGYHbpgnN5MWoIpGUqeV7wdl0W9PW4L3RaM/ayZ3O2s2eH8AiGo+XVgQrqHXoloi2I/0gQJuDpigaxFWtrWS74NzOkSuDFZ/gfugNrt9y+t8nIQe1HtZmK+2VMwmNfiaysVvqNvVyWzKcRi4Ee+uWK56gguU607uN74y5aUpHJ6wBWSMO8hx2Qcir72/u3xUHiu3y8dd7O5gpv+PHW+BDRN404jKi5MADfjFXdcEm3+F77x3vr1Zw7Xx/Ez2qWGp3fHTMETZ3L4NmIdqPuWucTGE9pisYJNB0yYBlxQd8AqcQAjf8Vtw7Hp4xTaMNIjzh2Chu6hAp2v9/hTYknHB6o4eoquxTXPXwm8vRFOo1mcQsq/wSDhwrnzOQvuPHgw3j412C9cHxYWFLOvWB27JHOsSKk5EqDo6Sa4au+PKpWSnjYj2qy6fxwzGm99FXjmBHpgQd1wT9Tkk6p6DdILA26T2EvpfO84WVWWAOYeldCjUlOY8FldY9S9Nudy23Exqa1Fn9rZFBY+NcXKk4zus0w37Ds9mmm3Im9+sFUQ8CKbRX2iXoyFbtamJZKkQ8Hkvt1vsWXbTpq2zmm9kUb/ wibAW6N0 KpHyCYUt7hy1U0yISzMpjgNMeN29TgCKlC4Prbnv7a9m9aFGxg1Cc440kCJhkNyPpCVlbJUgCzaix1tVUVGHB3+Hd/IGAIL/hFYFAdaIUHe6npLlvkz/NpvdPYwSvA1yvePIHMv9FdgA9QRgpDFCD5+kbGlOrtzepwU9fVhW6lHA9XrrgOer81fBx/ywUOD1FsaHzrSvbko2ECOQ2dhKkutOCibBJYvp/Bfbz0/YIAD5MDlNNiMcCaF6WQkpvj4waqueyIwsAs0Ah8Xd0D4Ugd0on+C91oLlF/CcCESJX57Cf+8SHrAGeQzeSL7W0sbvxr5DpyAkdPr67gdztjIIUfdYzsF5o0oE+kP1o1q6XdBarIiLMOfwyUaM+F0ngIpruO2Ol3xkY3Q2xo6pRnxfZSosXsdCgZiknuuwa93f+7HGla/JQWn48MPfLjwadUCn7lJ2Ll5eEVjzPw3vdfY9jY6RXluOEUgZ+nPK/ghGxFxgv1+0OoTJK48OM8Xmwl5ASxhFfKvR5V4Ndm3RlZBxrEhenXOFaA+KwsSKcljZ9whMrTM2m2B54KSWOZRljfRuvsWc3O44vnWWN/g2SZTGLq6+Nk8MdMDfApv+VVzpHhBimHMSAnZb1wHAoP85rqDprV+A2d5JvlwxwUmfP+gp0+ZeiFKqpG1BRv8q2jPWkdDwIHwdHfVtXIAHWSVnYy8I9hPvWH8x4Uopv8ok= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: The core will set PG_isolated only after mops->isolate_page() was called. In case of the balloon, that is where we will remove it from the balloon list. So we cannot have isolated pages in the balloon list. Let's drop this unnecessary check. Acked-by: Zi Yan Reviewed-by: Lorenzo Stoakes Signed-off-by: David Hildenbrand --- mm/balloon_compaction.c | 6 ------ 1 file changed, 6 deletions(-) diff --git a/mm/balloon_compaction.c b/mm/balloon_compaction.c index d3e00731e2628..fcb60233aa35d 100644 --- a/mm/balloon_compaction.c +++ b/mm/balloon_compaction.c @@ -94,12 +94,6 @@ size_t balloon_page_list_dequeue(struct balloon_dev_info *b_dev_info, if (!trylock_page(page)) continue; - if (IS_ENABLED(CONFIG_BALLOON_COMPACTION) && - PageIsolated(page)) { - /* raced with isolation */ - unlock_page(page); - continue; - } balloon_page_delete(page); __count_vm_event(BALLOON_DEFLATE); list_add(&page->lru, pages); -- 2.49.0