From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id BA629C83F03 for ; Fri, 4 Jul 2025 10:26:56 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 433A56B8039; Fri, 4 Jul 2025 06:26:46 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 3E5386B8035; Fri, 4 Jul 2025 06:26:46 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 284A56B8039; Fri, 4 Jul 2025 06:26:46 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 15DD06B8035 for ; Fri, 4 Jul 2025 06:26:46 -0400 (EDT) Received: from smtpin03.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id BE332107494 for ; Fri, 4 Jul 2025 10:26:45 +0000 (UTC) X-FDA: 83626203570.03.C68F5C6 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf05.hostedemail.com (Postfix) with ESMTP id 96AA4100011 for ; Fri, 4 Jul 2025 10:26:43 +0000 (UTC) Authentication-Results: imf05.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=LHCn2Coc; spf=pass (imf05.hostedemail.com: domain of dhildenb@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=dhildenb@redhat.com; dmarc=pass (policy=quarantine) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1751624803; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=PJaNSOUY9l76maSUsyNVNOCD+/VPGSxzGfUbWAq4maw=; b=ANY+I1m81dOH5oDIk/Ys/WmfaK43vL4FKpBz1tDK83DtQOZQmV0hyTn8vIKoODvUdUs3iq ifGwRqsJYtFSCMDOUze0EHXuz15xHmxBFn5mvDnCRrDgenmLzvPLR0o1GgVMh3ANZiYZo5 doFGYXLs4nLV3KAbkDbDrv0xp2J268A= ARC-Authentication-Results: i=1; imf05.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=LHCn2Coc; spf=pass (imf05.hostedemail.com: domain of dhildenb@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=dhildenb@redhat.com; dmarc=pass (policy=quarantine) header.from=redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1751624803; a=rsa-sha256; cv=none; b=Qx3ElzfLLD0xbhdrWs/x87QO/Prd0ZfnOOxUC76qUv2zRdXJdi5NVmv5QUSbFoU/B3EkvX 722H1Kn+jFHSKbWSXV7CnkGvsUfhTHIukltgTIsg7OVl/T1MNEGCENYrjbJv8sm23+QxIe Du9O8grYL5ELboGNw5hszUKQHL3cgYI= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1751624802; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=PJaNSOUY9l76maSUsyNVNOCD+/VPGSxzGfUbWAq4maw=; b=LHCn2CocfsgCDgoX0gxY99ZZUvbfH3wNCTr2lSwntppmh/jLMrzFAwRIgZumgmvdc24ij/ UxAwx3xrt+Uoafvlo6OR45rwE6kT8DVM26JQ7ARBM4zqEvQ1XsVfJI0Ux2ghkNa/yu1HXZ RvqCSsCJ2Gbohfz1p8eOUD3Ea8kObxQ= Received: from mail-wm1-f71.google.com (mail-wm1-f71.google.com [209.85.128.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-608-UMoEUbJsMPewKqxakIxYDQ-1; Fri, 04 Jul 2025 06:26:41 -0400 X-MC-Unique: UMoEUbJsMPewKqxakIxYDQ-1 X-Mimecast-MFC-AGG-ID: UMoEUbJsMPewKqxakIxYDQ_1751624800 Received: by mail-wm1-f71.google.com with SMTP id 5b1f17b1804b1-451d7de4ae3so4257725e9.2 for ; Fri, 04 Jul 2025 03:26:40 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1751624800; x=1752229600; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=PJaNSOUY9l76maSUsyNVNOCD+/VPGSxzGfUbWAq4maw=; b=s5YNjoHiMb55Pj96ebqIxH7ww02dIMUeS+cItyFAkjgYJa5A9rIt7FKDlISZ6J8rNu 4pWJe9Z6jaQJ44lVe7g07S9fO6X+byvzyEIi8WygXllrTcKYvvJJwhpTL3GlbqLYaEbi f/uRZ2MTjy4xItUU0VWtE3R1F9nsLVUuW+/DluUnlIHEW4XV9StC0iBfKToBQhi/xIzm l6AMOhLtyv+3FoyMXivJjMM1hrNRJ7lkkStUKCVsmRrBOEfUhYYQyuG7RSmR+AyqHRVj YhhsEcPdL5L464MwJh9VcTc6rhql3q3XRiA6tB8c+wesy1TqM/Amx30buvuWBtcelh8c FLFw== X-Gm-Message-State: AOJu0YyRY7s5QUdjM6ahS0xjhrcr6DXsceh1nBbIUk8iqKRrTOtlF6nE BZSvZjGmcq1LaxnICmZbctQlhgM4tkO031X6L/CgaQV3hzb1ecfjYlyKzVn9iLVVqYfv4cz3d6C Xb4K31FQ+G44ruBXENXqK5u0HT01NtWReASt/+WEqkFV0FjlEVf8n X-Gm-Gg: ASbGnctXT7zd9NMqj6PmIO4WmKSJkFcM12Ue0rLKMw/T5LyR/JBKbAxDymThbWKebcl TtAItjkdq4fvH5zZ52MraB0/OS6AI+S/vACqOOh9N6KLxZPmWknkwXTnIG3lUokBsqVJhyq98YE hVJTd9EjhYURR/81fLBsYBnx2Z2mHh4JAUSGCPv4jGakpBZpA7FIWdgPoqYH8h7ZsWXX1yILpcU 5vtbA3/KBdcjuPwYFBQdtm2SWFMsC71gh7OlmDsKZMQoCLk8MB4jpH1XPDqiRe8jrLMoIKbf8lE GVFypmKow8mM1tAQgJ1p0WN3GNpPjPvxUCj2uZlqFJXmCK7QRRqvV0vR9qug+1Sb89UdwTEuQw2 xl5n07A== X-Received: by 2002:a05:6000:24c1:b0:3a1:f564:cd9d with SMTP id ffacd0b85a97d-3b4964dbbcemr1548370f8f.36.1751624799685; Fri, 04 Jul 2025 03:26:39 -0700 (PDT) X-Google-Smtp-Source: AGHT+IG//N9DaWJpqR05PkmLCvqepmh6sjEbIjzOMJ6H89vpgrAi3DitTSNnZ5FWKxlekTJwwx1oMQ== X-Received: by 2002:a05:6000:24c1:b0:3a1:f564:cd9d with SMTP id ffacd0b85a97d-3b4964dbbcemr1548348f8f.36.1751624799228; Fri, 04 Jul 2025 03:26:39 -0700 (PDT) Received: from localhost (p200300d82f2c5500098823f9faa07232.dip0.t-ipconnect.de. [2003:d8:2f2c:5500:988:23f9:faa0:7232]) by smtp.gmail.com with UTF8SMTPSA id 5b1f17b1804b1-454b1628d6csm23008015e9.10.2025.07.04.03.26.37 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 04 Jul 2025 03:26:38 -0700 (PDT) From: David Hildenbrand To: linux-kernel@vger.kernel.org Cc: linux-mm@kvack.org, linux-doc@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, virtualization@lists.linux.dev, linux-fsdevel@vger.kernel.org, David Hildenbrand , Andrew Morton , Jonathan Corbet , Madhavan Srinivasan , Michael Ellerman , Nicholas Piggin , Christophe Leroy , Jerrin Shaji George , Arnd Bergmann , Greg Kroah-Hartman , "Michael S. Tsirkin" , Jason Wang , Xuan Zhuo , =?UTF-8?q?Eugenio=20P=C3=A9rez?= , Alexander Viro , Christian Brauner , Jan Kara , Zi Yan , Matthew Brost , Joshua Hahn , Rakie Kim , Byungchul Park , Gregory Price , Ying Huang , Alistair Popple , Lorenzo Stoakes , "Liam R. Howlett" , Vlastimil Babka , Mike Rapoport , Suren Baghdasaryan , Michal Hocko , "Matthew Wilcox (Oracle)" , Minchan Kim , Sergey Senozhatsky , Brendan Jackman , Johannes Weiner , Jason Gunthorpe , John Hubbard , Peter Xu , Xu Xin , Chengming Zhou , Miaohe Lin , Naoya Horiguchi , Oscar Salvador , Rik van Riel , Harry Yoo , Qi Zheng , Shakeel Butt Subject: [PATCH v2 25/29] mm: simplify folio_expected_ref_count() Date: Fri, 4 Jul 2025 12:25:19 +0200 Message-ID: <20250704102524.326966-26-david@redhat.com> X-Mailer: git-send-email 2.49.0 In-Reply-To: <20250704102524.326966-1-david@redhat.com> References: <20250704102524.326966-1-david@redhat.com> MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: 3VRcCHhlWspDh5wDPr9GRbijf4yTjI1C5xkqY1R5mDI_1751624800 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: 8bit content-type: text/plain; charset="US-ASCII"; x-default=true X-Rspamd-Server: rspam03 X-Rspamd-Queue-Id: 96AA4100011 X-Stat-Signature: buin8hihw31jza3xsebgwzknz7mg9o8s X-Rspam-User: X-HE-Tag: 1751624803-133700 X-HE-Meta: U2FsdGVkX18OgpjCSXOIu6+C9c9X/lRf19zqXj2k4CQUTIwqYZh24GAin1PpmA1NCpj4B8ZGtMI0wtbRRLlHmcHicoLAsa6fsChcnCvq8hHltyDh5xZGVq/SDHF70n8BryhqdCI32rC8a7jNN3WaF6FN36auV+AMNV5ce01Ml5Lf1xuJ87YJKDbqpAVlKZG8knCTq/WVEOQm9Ul524dgyjFVMIcukAvpOODsFZy8re1goHtN+/+3II4AxgMcOdbHk40JnQt/6SeNdMdke00EYb2I9QCnixJsW16EQeGdFT7KZo0y4UwDIq9NT1KNZCovt1hFkE70jGnm6iVz8QOQNmiL9LXDPb9xz6mNHqYAZBd2smTDAk2NlYNLJUsS/j3tc4ISLusQmzWJRCf2F+35afWbJ7j8X/k2nshRhkYjHP2MSozX0v+eWVDvJ96SDcydgYoHHNrfkmti040h6f+TtHRwnnqa/JQmO7PeYLLaAWaNT6VPg56Wf53Jc/8/QNrhgK+ZsBBOPudWRLPlfOC3KsMaYM0jvcRUNw1cJHF49D2kIeYiFCPp5MfSaPEIJFye68NghwCzWF0vdNcmEeWqo7KLCMxiDFGUpjXcpQDA8gLADGwtoEebxg6pLQtbrSakKYb1STGjjbBFpJsVcbwS0SgrehBis0iHv8zYr6dZqQD4hXcAM+eoPCuoyrRwlesa2gDlNDmlq5FXpUaLgPcxLMBGdQXe0kZSZ7Oc7ofmguMbpSHh9ZZ/LlAqx+Rdyi2CuePoBaDQsZsADVo57QkGVdEi4bfseE+Gm94mWoOOv8cwpMTAoqX1mRwWrp+zP2F2Yqhgsug4e5RZuJ2fVlsNgx8kQsitehiT7QIaa1rjUnfL8tzj3z/Q9JnKkz5sXSh4wPC/PCrTS920UW20V0Ce9CWDlGGFNQkEO0Za5GKiFpwCSQiFLs1C0OrvEGIpsbr/zrZdHnhtG+UXan5hQve WG3AKACF DmIJVjCl8pLd2UYVZc73Yrnfw+PeYLkZZrYfewGv6EMFurK6MjDV8sucoFQ5GeneCfNM46X2HgquQ5vvZCgKNqhUNWxD6dtN0NDE4xM0xX5b9F/LSwHHCiiZJP3Wk4tr+/zoJ11VygnEINrE0WO6LBEee55W3zGnc/SpWAK8bZRuCX2VOZVHJimnZUqhBQZUHq0gVpaIGxyKF5fco7LKhR+h+NSGSQ4RhPkZ6Me9lBFsocxMb0miQrILXHay4EoPA5PQtVq68w3HdWd3O6RxptBtGhGHdGkIMNf7YOWq6NOO8ZHPn1FdC4uzs3UbTcs3xeH+d+/I5+aI9FhXGx4ybM9Ls2iauhuw5LvU039kcIgMlD15frv9HgnalTOfIoCKkMOU6SYsmFoozTXgDQ8aCaIv6q7/buSs93MkujMmAW3GD+2UEkogbBD2U+0iKWs9xxC7eQjuNyj3s2fQ27jwP8iv9mBqa80q70iLumXWbjD3QcWNk44m6Dmem/RkYXD7zJY5ODJKvkbzylnzg46a1ur/Sgk1ckLtDnExH0QqAidTMInKJf7WFmsb5V4JMIG4I47FIuio/kicq67lxbnvmYS6BY45dIejDLs/hblgdQuZrP87o38DbXkBDAeQ2if+4RYmg3sOR/1GedHvXDIXdh/VIx0JICJOIbFzNC2Zk4apeS2kjJa40B+xNY+7g6ERNnkW40ec6oGtHbbw= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: Now that PAGE_MAPPING_MOVABLE is gone, we can simplify and rely on the folio_test_anon() test only. ... but staring at the users, this function should never even have been called on movable_ops pages. E.g., * __buffer_migrate_folio() does not make sense for them * folio_migrate_mapping() does not make sense for them * migrate_huge_page_move_mapping() does not make sense for them * __migrate_folio() does not make sense for them * ... and khugepaged should never stumble over them Let's simply refuse typed pages (which includes slab) except hugetlb, and WARN. Reviewed-by: Zi Yan Reviewed-by: Lorenzo Stoakes Reviewed-by: Harry Yoo Signed-off-by: David Hildenbrand --- include/linux/mm.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/include/linux/mm.h b/include/linux/mm.h index ef40f68c1183d..805108d7bbc31 100644 --- a/include/linux/mm.h +++ b/include/linux/mm.h @@ -2167,13 +2167,13 @@ static inline int folio_expected_ref_count(const struct folio *folio) const int order = folio_order(folio); int ref_count = 0; - if (WARN_ON_ONCE(folio_test_slab(folio))) + if (WARN_ON_ONCE(page_has_type(&folio->page) && !folio_test_hugetlb(folio))) return 0; if (folio_test_anon(folio)) { /* One reference per page from the swapcache. */ ref_count += folio_test_swapcache(folio) << order; - } else if (!((unsigned long)folio->mapping & PAGE_MAPPING_FLAGS)) { + } else { /* One reference per page from the pagecache. */ ref_count += !!folio->mapping << order; /* One reference from PG_private. */ -- 2.49.0