From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0EBA4C83F05 for ; Fri, 4 Jul 2025 10:25:44 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 605F06B8021; Fri, 4 Jul 2025 06:25:42 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 5B6926B800A; Fri, 4 Jul 2025 06:25:42 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 481B96B8021; Fri, 4 Jul 2025 06:25:42 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 349B06B800A for ; Fri, 4 Jul 2025 06:25:42 -0400 (EDT) Received: from smtpin28.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id AEBD31038E9 for ; Fri, 4 Jul 2025 10:25:41 +0000 (UTC) X-FDA: 83626200882.28.23000E7 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf07.hostedemail.com (Postfix) with ESMTP id 7DA5440009 for ; Fri, 4 Jul 2025 10:25:39 +0000 (UTC) Authentication-Results: imf07.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=dMW0Z+kH; spf=pass (imf07.hostedemail.com: domain of dhildenb@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=dhildenb@redhat.com; dmarc=pass (policy=quarantine) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1751624739; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=Km36h+57LoMclmINdAl2JdQwpEFbx1KUS9NaV7ZwoS0=; b=kiCsEpmnKRUENXAi2Nj5gn8J/ZVhM64Ao7dbP5LPS48djy3+17He3fu6lqFPbSotSuWgk6 9h1tSJLtKErKqFThtX0v0X6O3KXL8AZSPkmZkFnrjHvl98jPIcdwEKsNWD3QBYI9rYV8CQ TzGZ1s76trai3zUyjvid3Xj8wl0Kj/4= ARC-Authentication-Results: i=1; imf07.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=dMW0Z+kH; spf=pass (imf07.hostedemail.com: domain of dhildenb@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=dhildenb@redhat.com; dmarc=pass (policy=quarantine) header.from=redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1751624739; a=rsa-sha256; cv=none; b=dgzlT394w5OEE7Eovh5UJTn9xnTPSiZS0Q5n1NJXohN8IIR/vjd+lP3o/1zVK1AI6EnZUF DLOqEHl3rl7CzBDbilkWLp4H3QOv1U62/nHT+DNb3B2bk0H3UIxYm4z8Pk+FHR0+LbRSKg 4pZehkbIpgAQ4ZvOc479sy+XtUyqF80= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1751624738; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Km36h+57LoMclmINdAl2JdQwpEFbx1KUS9NaV7ZwoS0=; b=dMW0Z+kHp+W2pmVe0kg4qbMAF7dUTjOa+oju5ZwQ9aGzO4mZE97+hB6SXn+GvniukaXEYU cszO4LG3Oe69ZqnSaK8zVyDNy/Wb8zLCqvFKdPsAEv3+VI8fEQgKxAKuYjDdEN7uFgaWKq hbp6YK9BVfKax/4b/SwtHLqJoFSkZVs= Received: from mail-wm1-f70.google.com (mail-wm1-f70.google.com [209.85.128.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-16-3SDD5_NWMMq4FzYxwXW7Bg-1; Fri, 04 Jul 2025 06:25:37 -0400 X-MC-Unique: 3SDD5_NWMMq4FzYxwXW7Bg-1 X-Mimecast-MFC-AGG-ID: 3SDD5_NWMMq4FzYxwXW7Bg_1751624736 Received: by mail-wm1-f70.google.com with SMTP id 5b1f17b1804b1-4538f375e86so5909065e9.3 for ; Fri, 04 Jul 2025 03:25:37 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1751624736; x=1752229536; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=Km36h+57LoMclmINdAl2JdQwpEFbx1KUS9NaV7ZwoS0=; b=umxBgZvVv/c1YaOhrDemJy3EPX/ZeGvzEgs64Ad2qwJ68lkv734UkUGBP8+KyuzzrD khtTMKZG+GPPEZD9clwM61ZWQL2gx5n89jTISALD8So920JWGOqfYqyI9+NVEm2GH8wc vThKWqdIahCNuLD/S1k60bUTNxHgxfxbwQkCKpxF90PkahaaeS+BB9uO4DIyOsIOatRl Fi7/qhEdRuaGECFbTuHESALNfNyFgv7wZtOwhVfdsLvz34pOxPiuFIJ1ZzUQOwOSO+dl w7bbqZSRjcNsFfG3l37vaxoBig3qk7dBPyJAboXFAxwYOGyyVhCt2nBdh8G2l7KxXg5M pKcQ== X-Gm-Message-State: AOJu0Yw1xgg/GS0juT5zM5q8p9V0jSAJXSkx80IKc6vvvky2WSlaC19W 8BKLwrJWccTzbM9s7wP9FdUccKrJd+1Rdt83pNmDnC/KTojcJCjWY4GmVMp6ocJAWZ1oxqFRl8Y oJ3bfZ1dt9JbBN1CrToMW0xMPsnqvKXROSLuRkgeMds302Hxlp1RH X-Gm-Gg: ASbGncso+rLNHkXPP65jzDj8SPH+gSAnVEW870pMuLHhU4a3nI5TsxbtRnxVckcSpLo UH9UBqIqUtVZAoidVlfSnybU7wYw6KU5Ag4mMqWf0Z3Pw2CWPjFMXkHKvqJsRaEv8blKvc12gwA u5FLcp+qUGopOpJ7rJvraYg+d5KHAh+uvhjK7BJHtwFsrs6qOQTQeD0TIQQ1GWe2z8XyeLF9TQm OjJW8SkJ5+UVaE9/BFPGz5bD419NFs1Avlp86sWJ071okX/JCBpwJ191lZf+yukZsMGOoRLesGh m3RCk5g6OwHqaP7qxJGH7vrRfA6XJwc6olnkHFFWS2nr90i8YHt2kECaZxHu9GW59PIurOJ7iBj 834MsXQ== X-Received: by 2002:a05:600c:348d:b0:453:608:a18b with SMTP id 5b1f17b1804b1-454b3096211mr21110895e9.9.1751624736375; Fri, 04 Jul 2025 03:25:36 -0700 (PDT) X-Google-Smtp-Source: AGHT+IEYWTkwuG63kWN2pUNG4mMJ/rp0CK4ANHmE+tpQrKYs+JLvfC5kMT/JJWZ4Z30efeBW784Wqg== X-Received: by 2002:a05:600c:348d:b0:453:608:a18b with SMTP id 5b1f17b1804b1-454b3096211mr21110415e9.9.1751624735911; Fri, 04 Jul 2025 03:25:35 -0700 (PDT) Received: from localhost (p200300d82f2c5500098823f9faa07232.dip0.t-ipconnect.de. [2003:d8:2f2c:5500:988:23f9:faa0:7232]) by smtp.gmail.com with UTF8SMTPSA id ffacd0b85a97d-3b4708d080csm2111024f8f.23.2025.07.04.03.25.33 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 04 Jul 2025 03:25:35 -0700 (PDT) From: David Hildenbrand To: linux-kernel@vger.kernel.org Cc: linux-mm@kvack.org, linux-doc@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, virtualization@lists.linux.dev, linux-fsdevel@vger.kernel.org, David Hildenbrand , Andrew Morton , Jonathan Corbet , Madhavan Srinivasan , Michael Ellerman , Nicholas Piggin , Christophe Leroy , Jerrin Shaji George , Arnd Bergmann , Greg Kroah-Hartman , "Michael S. Tsirkin" , Jason Wang , Xuan Zhuo , =?UTF-8?q?Eugenio=20P=C3=A9rez?= , Alexander Viro , Christian Brauner , Jan Kara , Zi Yan , Matthew Brost , Joshua Hahn , Rakie Kim , Byungchul Park , Gregory Price , Ying Huang , Alistair Popple , Lorenzo Stoakes , "Liam R. Howlett" , Vlastimil Babka , Mike Rapoport , Suren Baghdasaryan , Michal Hocko , "Matthew Wilcox (Oracle)" , Minchan Kim , Sergey Senozhatsky , Brendan Jackman , Johannes Weiner , Jason Gunthorpe , John Hubbard , Peter Xu , Xu Xin , Chengming Zhou , Miaohe Lin , Naoya Horiguchi , Oscar Salvador , Rik van Riel , Harry Yoo , Qi Zheng , Shakeel Butt Subject: [PATCH v2 03/29] mm/zsmalloc: drop PageIsolated() related VM_BUG_ONs Date: Fri, 4 Jul 2025 12:24:57 +0200 Message-ID: <20250704102524.326966-4-david@redhat.com> X-Mailer: git-send-email 2.49.0 In-Reply-To: <20250704102524.326966-1-david@redhat.com> References: <20250704102524.326966-1-david@redhat.com> MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: yYoG4ecWgR8xKezfPYgm4rhg6R6fl8Dv4NcHaLbY9QE_1751624736 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: 8bit content-type: text/plain; charset="US-ASCII"; x-default=true X-Stat-Signature: 7hfd93mqckopw7i1yhkrdpk9nasiyodp X-Rspamd-Queue-Id: 7DA5440009 X-Rspamd-Server: rspam11 X-Rspam-User: X-HE-Tag: 1751624739-378571 X-HE-Meta: U2FsdGVkX19s36vl7YDPQoYwMEtkjB6rBPHHT6V4iZuL3cCAcY9xCtew69zhyWNdu1CFaBSZEMP779+Zapchu421Kbc2a3nKRcTVU9GVdnX3vLWJaQCR1CvmcgBgVWLBeuG+OZp+N8XnJamGgpv7/vrW8cQhwN+tAkyRWXcszWK1SHNzcxpLMkSH5uHNIr5NRiVT9VaLjGPwbmH3iDBRBnzqfQ+d+YCSYSjp4dsi0PSvKcqLw5H0fGqLaZivBdCfByjAOV3MTkYOiJmswj9cJtv/7kgPCjJD7mvwZoPKhyI/MBQ1f3XeOxGuHzqVX7PyvWfjFdBVMTRh+RywWHN1v7dlxyiI1GddraJUbJtGYpchLHWCwrM/Pob0410LpYffqBw/Ux3bG34Y97ZbDKOi6gY6QdgS/zNa886t/VfSHIAhxv7DPRdUgRWjSzxd4AdW7RBz0PQ+FIMNLmyGYw7cN7Es0YxZX4nSxJseHBlSZBpfgrngDimCweuAv+UlCwk5UU9ARPqxybiAEaik0QqnZ6/hgSyXT3p2RYXB03Gqekjs/G7ZDSW7FrnROjRD0hakb0NuzxViqjbYxtuQamOGmR2t43QI046vBXeVuXRtFehfi0XSykfZRogQ9N7pui5e38cqX74rw+66A6WALX7gEGTj1j8aFoCYpzYep191HKfjQzHhFy/7Damur20vi/gyNe+x9F9C7RYPCqEkhELDmkAZyasHInzcICWvtLETQmAquoYWlRevap/rsTxFeEyNbLDYVgxJsUYxPO/6xdbpIYfMhdwILymIx26m9kHYclJMczs3ad2U7K9gQM2EL4Hjaftl8MHmeObAZz491L0dNNgYUZJQ3Y8ZtZ4tNOwVJ9QUWxJQKq4cZkhqioFLlSM1aXdCPPycCCo4WHBQ25rrQWs9T2ztKIIz+mSw0AD7c6NEQwrJKpbyMf1ddI/eYGKxJziFyw1gm+Hu8lfttER pFX8YeRu 5n9Rnzyu33aS7rDyS5NyamLIunlny1q3Mrm0+Vj2gg4QHHTQOcXjAdm9758CT2PuxHI1Na9XeBMKpcoZz6TCgimh3VqWrosN4Q90IBvcKZFKVNcxVpZ5cE9/LB8P4DvsF4JcKVNny27DRq/FQlgVyjYjpdtKEPCkkv8YBJE6M1ls7wBwcm+9hoDcaTnlX205RpsblRb5Tzxp9RdMvvgwQmprXOAGgx/wEj+wDvlkiNmL2YkDouTp0SsyoXsP80etfbtIvlvuy7imKCwTppAVoFFtLn4s2lIvjOUnJ4s5INWbF2o1Rbiw/Qp4U2CHVdD7g5W3rvKVl9UdyxFVM22g99sy0jEVLzN8Rppz5DOfmF9s9eNxq2e9lX0k0HJL7suSHQersSzG3gOHnmqr90qkmRxKJrngp9YNljiFYw6GGtGBKtkQ61JoT+SnrGk1LYu6oLgNIVJzTS6BT91Jskz/1kpcuhiEKtwXtRFHcJqddqvDmlivKKeLyIinFcyw+UOqPtaj+97bAT4gQua2gTUmn3KN2vL96LZeLoaDIEWgpQa8ZNfvoOToBBINBrGDnmRvL092y1dfKGJJkYwGMktvBE0g9kbXmBPcuj8HZf+wzRyiCXannBG4mNXXFunUzyrzE8F7R7n58T4b29F+6I/bJooJJK18+ex198BNEzOGM0Tc6zDn9G8YDqsFUG3cUZgwqFswe7ojTxTIZEDVu8LDB1qtzXSHq0yaD/444 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: Let's drop these checks; these are conditions the core migration code must make sure will hold either way, no need to double check. Acked-by: Zi Yan Reviewed-by: Sergey Senozhatsky Acked-by: Harry Yoo Reviewed-by: Lorenzo Stoakes Signed-off-by: David Hildenbrand --- mm/zpdesc.h | 5 ----- mm/zsmalloc.c | 5 ----- 2 files changed, 10 deletions(-) diff --git a/mm/zpdesc.h b/mm/zpdesc.h index d3df316e5bb7b..5cb7e3de43952 100644 --- a/mm/zpdesc.h +++ b/mm/zpdesc.h @@ -168,11 +168,6 @@ static inline void __zpdesc_clear_zsmalloc(struct zpdesc *zpdesc) __ClearPageZsmalloc(zpdesc_page(zpdesc)); } -static inline bool zpdesc_is_isolated(struct zpdesc *zpdesc) -{ - return PageIsolated(zpdesc_page(zpdesc)); -} - static inline struct zone *zpdesc_zone(struct zpdesc *zpdesc) { return page_zone(zpdesc_page(zpdesc)); diff --git a/mm/zsmalloc.c b/mm/zsmalloc.c index 999b513c7fdff..7f1431f2be98f 100644 --- a/mm/zsmalloc.c +++ b/mm/zsmalloc.c @@ -1719,8 +1719,6 @@ static bool zs_page_isolate(struct page *page, isolate_mode_t mode) * Page is locked so zspage couldn't be destroyed. For detail, look at * lock_zspage in free_zspage. */ - VM_BUG_ON_PAGE(PageIsolated(page), page); - return true; } @@ -1739,8 +1737,6 @@ static int zs_page_migrate(struct page *newpage, struct page *page, unsigned long old_obj, new_obj; unsigned int obj_idx; - VM_BUG_ON_PAGE(!zpdesc_is_isolated(zpdesc), zpdesc_page(zpdesc)); - /* The page is locked, so this pointer must remain valid */ zspage = get_zspage(zpdesc); pool = zspage->pool; @@ -1811,7 +1807,6 @@ static int zs_page_migrate(struct page *newpage, struct page *page, static void zs_page_putback(struct page *page) { - VM_BUG_ON_PAGE(!PageIsolated(page), page); } static const struct movable_operations zsmalloc_mops = { -- 2.49.0