From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4F394C83F03 for ; Fri, 4 Jul 2025 10:25:54 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 320966B8024; Fri, 4 Jul 2025 06:25:51 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 2D0AE6B800A; Fri, 4 Jul 2025 06:25:51 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 14AC76B8024; Fri, 4 Jul 2025 06:25:51 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id EF1A06B800A for ; Fri, 4 Jul 2025 06:25:50 -0400 (EDT) Received: from smtpin09.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id B14541A0289 for ; Fri, 4 Jul 2025 10:25:50 +0000 (UTC) X-FDA: 83626201260.09.87E3402 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf08.hostedemail.com (Postfix) with ESMTP id 82933160009 for ; Fri, 4 Jul 2025 10:25:48 +0000 (UTC) Authentication-Results: imf08.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=ImGIfB9q; spf=pass (imf08.hostedemail.com: domain of dhildenb@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=dhildenb@redhat.com; dmarc=pass (policy=quarantine) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1751624748; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=ONGts7/hBJv/SI9LHH6S4PEHXTtUzsYSWsi4Xmz5Gpg=; b=TIHh3U9jWYk82SfQUhOT4N2Lf6cyd89CFpAMKDQ0psECKSQfKlL7u2WGi/jb6AkoHZlJZ7 HY6/StH+UOP4gjesgEks16SKmMQ6IcOX/HlFXjsZ4yyGVguZXAAUDLhZ939yR0k+EM6n9p 8YaJBid5jlImUw4hBkrPCXPe3muVrt8= ARC-Authentication-Results: i=1; imf08.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=ImGIfB9q; spf=pass (imf08.hostedemail.com: domain of dhildenb@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=dhildenb@redhat.com; dmarc=pass (policy=quarantine) header.from=redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1751624748; a=rsa-sha256; cv=none; b=CfSWXJ3qUUUnZPoghxoUOIMr4YhI/QWvct079wdUF3d/xjEvBhMhJP9HSRvEX6Em4vtAlr CYed9qyGx4CtaBNUMWNvAlMBGpPFdH92T7DLq3BkFODEiTPyTA0cc8TAaHc28jLEtKGifH bRE9Ca2dvun+c0FaIJ2c7lhmm04WUNk= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1751624747; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=ONGts7/hBJv/SI9LHH6S4PEHXTtUzsYSWsi4Xmz5Gpg=; b=ImGIfB9qQtNHlsYyTKX6eCgUVdEHLg2T7WtH3H1hXH6E1aJXpotT/6WlKTDZpM55uJubu+ YoKVIpG6l/qJgrpxSE7XJ/iyF91u0vp3pxTORN1w7rCcGuU1P1e3f9NjQZmrXV4JGqzwEJ Vl84VLHNv/QI6Zkp6S+ej6Sd5YCzYtc= Received: from mail-wr1-f72.google.com (mail-wr1-f72.google.com [209.85.221.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-460-7wLw2Il5PxC_vt0l1gQ9rg-1; Fri, 04 Jul 2025 06:25:46 -0400 X-MC-Unique: 7wLw2Il5PxC_vt0l1gQ9rg-1 X-Mimecast-MFC-AGG-ID: 7wLw2Il5PxC_vt0l1gQ9rg_1751624745 Received: by mail-wr1-f72.google.com with SMTP id ffacd0b85a97d-3a5780e8137so973156f8f.1 for ; Fri, 04 Jul 2025 03:25:46 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1751624745; x=1752229545; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=ONGts7/hBJv/SI9LHH6S4PEHXTtUzsYSWsi4Xmz5Gpg=; b=az2EzfEkTNQxHv8csFM1KpBQWGo7zFgsUTAzD9tQ9XkCHEV+k5BbM/dDNRiwGieVEC Jox4MNSOW7z0LQRqP8D5kElVeZ52KRQ8IOrJu9Yf3gk4Xjhkgs83U0ppJSmvqzQdfryn 5CXZsqVjLLMTGxEs3Az292kD2dhbA3bPVkkAnnNQ8Afkv6RbNj7mpHWDbkUeKokyrVWN /fd4jke+4zqPOvQPrKzlC6FBc5xU465crcmVaqapNWaOidTwNuolHI23wZqrlbZtGnOm KrOLLncPRkht1NlHBJftv8M+AJirWF7uecBINmFsCvqhL0nbVr7K0BJVsVvKziMFCuyx 7tag== X-Gm-Message-State: AOJu0YxEbW8k6q4CUste4k9PzuNhO6H6O7LxTA1quD9DyTxd7ZJK38RU HlmtwvHiPhdmp2Y5ALhq9n0/xSFl2FZowPIlXhJC7gA+787g2jmO5YnOufaajRP9YCZVIjv6Ffk t5TE+lDus+HQ8BFXNYp778g2L00IJyXcJmTvGiHHZT3YCWNEvayVWAxz8uldy X-Gm-Gg: ASbGncsa6vn93IRtold96AUR2vEdfX8eTaL3UqxPfKbyLSXToSoRwNmLWaQOOTFlF8t Su8iw+yRqTmUnrVmHCwYiY7ZSpArZiAdgY9UCDi96mFpLcSnxIrOvxJXAoJuR/p9EhQS7F7YOhR zTKdSPNb37M2+kLw0JCxurZr+jqwdOB64g4UqMZBd7pKqup2+9dRGrLLb9gQjUED8ZnjPMcxqbW EbzVZbRdTizV7Fc91lP+TBX7sZ7DwSgI7vUmdwPXEOJd0eR97YkD7s9bV24gWHyGuZEFHzuCe47 7Xsae/I9dRFeIaCww1MBe/kDvVSGzEH9UrpAAisu48NxPnjNVm2HRJEK4qB1RK4WPloEkJJYO2P J7ZsPNA== X-Received: by 2002:a5d:5846:0:b0:3a5:7991:fd3 with SMTP id ffacd0b85a97d-3b495b94916mr2217856f8f.11.1751624745018; Fri, 04 Jul 2025 03:25:45 -0700 (PDT) X-Google-Smtp-Source: AGHT+IECnxpY/j05u6/I6xCq4leYolGKDWTZ8k8uJQRmE44kdkts1pPfCbxB96EsSkR3GWRBi0mgpw== X-Received: by 2002:a5d:5846:0:b0:3a5:7991:fd3 with SMTP id ffacd0b85a97d-3b495b94916mr2217787f8f.11.1751624744465; Fri, 04 Jul 2025 03:25:44 -0700 (PDT) Received: from localhost (p200300d82f2c5500098823f9faa07232.dip0.t-ipconnect.de. [2003:d8:2f2c:5500:988:23f9:faa0:7232]) by smtp.gmail.com with UTF8SMTPSA id ffacd0b85a97d-3b47030ba14sm2117357f8f.6.2025.07.04.03.25.42 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 04 Jul 2025 03:25:44 -0700 (PDT) From: David Hildenbrand To: linux-kernel@vger.kernel.org Cc: linux-mm@kvack.org, linux-doc@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, virtualization@lists.linux.dev, linux-fsdevel@vger.kernel.org, David Hildenbrand , Andrew Morton , Jonathan Corbet , Madhavan Srinivasan , Michael Ellerman , Nicholas Piggin , Christophe Leroy , Jerrin Shaji George , Arnd Bergmann , Greg Kroah-Hartman , "Michael S. Tsirkin" , Jason Wang , Xuan Zhuo , =?UTF-8?q?Eugenio=20P=C3=A9rez?= , Alexander Viro , Christian Brauner , Jan Kara , Zi Yan , Matthew Brost , Joshua Hahn , Rakie Kim , Byungchul Park , Gregory Price , Ying Huang , Alistair Popple , Lorenzo Stoakes , "Liam R. Howlett" , Vlastimil Babka , Mike Rapoport , Suren Baghdasaryan , Michal Hocko , "Matthew Wilcox (Oracle)" , Minchan Kim , Sergey Senozhatsky , Brendan Jackman , Johannes Weiner , Jason Gunthorpe , John Hubbard , Peter Xu , Xu Xin , Chengming Zhou , Miaohe Lin , Naoya Horiguchi , Oscar Salvador , Rik van Riel , Harry Yoo , Qi Zheng , Shakeel Butt Subject: [PATCH v2 06/29] mm/zsmalloc: make PageZsmalloc() sticky until the page is freed Date: Fri, 4 Jul 2025 12:25:00 +0200 Message-ID: <20250704102524.326966-7-david@redhat.com> X-Mailer: git-send-email 2.49.0 In-Reply-To: <20250704102524.326966-1-david@redhat.com> References: <20250704102524.326966-1-david@redhat.com> MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: aqGK8EXaxYeoUtUQw-Q1_cZClG6ntPM-QnYRoaF3AyU_1751624745 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: 8bit content-type: text/plain; charset="US-ASCII"; x-default=true X-Rspamd-Server: rspam10 X-Rspamd-Queue-Id: 82933160009 X-Rspam-User: X-Stat-Signature: xmprt18nhwum39h7doxzqq7iytepgpyo X-HE-Tag: 1751624748-601416 X-HE-Meta: U2FsdGVkX1/SyDyXYhdovaGyYZdLUFYtiZVz6VhH/t4ZgNNd5GZTv6plYjw8CBa/EbbuYzPk/Plny13UlMFqY8woq3wz6CAazJnMOyZ0XrAmcfTubqSgnjHJS8O4pawHjSc0eMy2DmggjlxP2kNDJYhVhj1HdV4O3OdKATSHq4DhrTfOQhTaG6/bCagVLxYH107zFMEC+r9nj5fzeUu6pj4ynisaR3Evvg/f2qzVIQGTjAdQAi+XT1EuPKDuTYtaOZCGZK+DQBIHJoBsma+/tPD9t8Lp6F2F5Rh4NyAmFcZY7PlGf1wif53/1xA8pxBWv8aBlTBWxqLn0cz57UgL/WFXfHumGtdH7K9zJE+1nlGH6/6eXU84Tp4ev0HJE9MeRQ7OJn7QnW8xLKZSZSILtTkJ013lE1rPZhXtTEAy7cpZdjK0Z/4/Cy/vRyCYtnpc9W+TGZd79I+IhWurWqFOlmFQvK2pKgzLtR/kCZgW0GZeHZhblkaql1GUhTR9G6rMs634wN0siSq4jXyRg/zany0BCk5z+X6DhuwBk0nEC6hx8sMyZrdnOhuedf2bikDIXBvbAUa5VtKvZ5uLTBl+dcyXDZthNMs5CHxNlmcvzpGPLle84mWiPYXsETJ0GfoknP92d0gBsMcwVlZ7q6CFg7tDbiNDG/1mlaa+I0Nxm8yasCGk07c3q4aXvPb4+0TYYrSZE7OYxcuj6UID7PF0ZM19WaTSfWV/B8vUpHzW9aW/T8e3nF9IwKCSWWS8qLT1QYXjlFsqkX+yK0+DrPHkWsbXebj4esvtK2Ofw9Q1TkSKhICj2AeqCXT1vfIU6T1lD9BzKFyi3+NIQYW2+xNawFSymkzB1ptyqZOfJGCqkoX/ONTb9mtpIsyYbHGG1UVNlGZnkk+Hpa80bKgM78IiRAD8QNgb8WQk+IrzdOWn7cBsWPwg2cGlISH1L/+Ttwg4QW0+CwEhyNKrDdSjpFK rehB+o2H EiTspLbt3DWCG3zdIyo2IupPBSq5a9/BXfkuRUbpxlZd+hT8kSCil3m6ojIVGvpLR1cLXR9uiZa9fNAm7Z6oMyvnjBj0WjXKVmNaqitKvhwLDYHdP03vEgS+jZLkvHegKKFYuaurmeIRvsIrjiViEHQxad6RR5jZyFRFCfcSUpGXvZ0RJ//vVjev/aerHpIz87i+8VlAgUw/4r6kAdSxRCALCRi5HIdojuG+SGdzJgA5pEumgeS9eEQpvZSix5Fe01ed0187URHENzd7RyNEOkd0IfJefxN3RYz1VjsokClMGQaMwQ5efeOiLATwSzDmJsYkU2Bgd8H1SMdAaLc0oZvurEyh+m+ot0p440kqwSUQNaNiW9oARxFfG8kk/11KqL1Vq3bR0c/B6YZ0NQoMa6VlJTIlyrTUydnXPuUMU+z5b7FapN592KIoHuz1rtDpMVsFrVw8SPmlP1jT3ilxACcKGTUGXfyL3/+EHiBFWegQ0Y2AB/RtNyEnBinA8Te4QBxNNoZnkMapf5P2+oAnBRi6TVnJrD/hfzmIavDoYHz4ILzgwgIqcZe6bdszHGQ7peVaNMsbLYNF8fgL7XieTLsZAVxNthRP4CZIiuavfzKAlm9X05PsTvN3nKTTdku5NjoCku7DNzkWXD5iyo4ozfd2FJI55M7HOf+02cA8p2P9cHORgrYJCJxkNbA== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: Let the page freeing code handle clearing the page type. Being able to identify balloon pages until actually freed is a requirement for upcoming movable_ops migration changes. Acked-by: Zi Yan Reviewed-by: Sergey Senozhatsky Acked-by: Harry Yoo Reviewed-by: Lorenzo Stoakes Signed-off-by: David Hildenbrand --- mm/zpdesc.h | 5 ----- mm/zsmalloc.c | 4 ++-- 2 files changed, 2 insertions(+), 7 deletions(-) diff --git a/mm/zpdesc.h b/mm/zpdesc.h index 5cb7e3de43952..5763f36039736 100644 --- a/mm/zpdesc.h +++ b/mm/zpdesc.h @@ -163,11 +163,6 @@ static inline void __zpdesc_set_zsmalloc(struct zpdesc *zpdesc) __SetPageZsmalloc(zpdesc_page(zpdesc)); } -static inline void __zpdesc_clear_zsmalloc(struct zpdesc *zpdesc) -{ - __ClearPageZsmalloc(zpdesc_page(zpdesc)); -} - static inline struct zone *zpdesc_zone(struct zpdesc *zpdesc) { return page_zone(zpdesc_page(zpdesc)); diff --git a/mm/zsmalloc.c b/mm/zsmalloc.c index 7f1431f2be98f..626f09fb27138 100644 --- a/mm/zsmalloc.c +++ b/mm/zsmalloc.c @@ -244,6 +244,7 @@ static inline void free_zpdesc(struct zpdesc *zpdesc) { struct page *page = zpdesc_page(zpdesc); + /* PageZsmalloc is sticky until the page is freed to the buddy. */ __free_page(page); } @@ -880,7 +881,7 @@ static void reset_zpdesc(struct zpdesc *zpdesc) ClearPagePrivate(page); zpdesc->zspage = NULL; zpdesc->next = NULL; - __ClearPageZsmalloc(page); + /* PageZsmalloc is sticky until the page is freed to the buddy. */ } static int trylock_zspage(struct zspage *zspage) @@ -1055,7 +1056,6 @@ static struct zspage *alloc_zspage(struct zs_pool *pool, if (!zpdesc) { while (--i >= 0) { zpdesc_dec_zone_page_state(zpdescs[i]); - __zpdesc_clear_zsmalloc(zpdescs[i]); free_zpdesc(zpdescs[i]); } cache_free_zspage(pool, zspage); -- 2.49.0