From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 246FAC8303D for ; Fri, 4 Jul 2025 15:25:51 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id A8A426B02BC; Fri, 4 Jul 2025 11:25:46 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id A12CC6B8059; Fri, 4 Jul 2025 11:25:46 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 8DB296B02BF; Fri, 4 Jul 2025 11:25:46 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 774CD6B02BC for ; Fri, 4 Jul 2025 11:25:46 -0400 (EDT) Received: from smtpin06.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id 0EA51140132 for ; Fri, 4 Jul 2025 15:25:46 +0000 (UTC) X-FDA: 83626957092.06.72C7343 Received: from mail-lf1-f48.google.com (mail-lf1-f48.google.com [209.85.167.48]) by imf13.hostedemail.com (Postfix) with ESMTP id 2545B20014 for ; Fri, 4 Jul 2025 15:25:43 +0000 (UTC) Authentication-Results: imf13.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=IoWecfsK; spf=pass (imf13.hostedemail.com: domain of urezki@gmail.com designates 209.85.167.48 as permitted sender) smtp.mailfrom=urezki@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1751642744; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=zNvWjNYrNAUtF5MSlixELkfrw/rQdgWdiIqr1YNwBsU=; b=5dyAf2xF+inuNRnCzn7a34PuKdhvP89nOVPwmBJlEK0pWfKEnmvgxPxdgXaDnE8q81wh4q szQmM/bCgbSGPtg7dAqbaKtujujAzQf5hfTbfrm532sBSn6KhqBgd4Mn05WdQJnyzX+t2M Cmu1DJhHTtHpKTNC3GFW4KzpKRwM6ZQ= ARC-Authentication-Results: i=1; imf13.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=IoWecfsK; spf=pass (imf13.hostedemail.com: domain of urezki@gmail.com designates 209.85.167.48 as permitted sender) smtp.mailfrom=urezki@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1751642744; a=rsa-sha256; cv=none; b=IMvJfCeHSenhiuRIPQ8cR7NdMEH3vOHrFkCEGZm96Uf7Skg5pJzPbbiA9+UKaCnaedm/h+ tM9VQzsnzDyhKh0LkJssaMpwIUenjGLJ+3jIBVLZS4q0NOZa/owCUhpo7Ge9PoGar8e8oZ IliCFrsQVUOXUEjJr4sM5n45RLJYzFQ= Received: by mail-lf1-f48.google.com with SMTP id 2adb3069b0e04-553d52cb80dso993268e87.1 for ; Fri, 04 Jul 2025 08:25:43 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1751642742; x=1752247542; darn=kvack.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=zNvWjNYrNAUtF5MSlixELkfrw/rQdgWdiIqr1YNwBsU=; b=IoWecfsKdemgk1J68Edoqpu2F+OorTatYgHiR9AFhio/WIzAIAittCsPx3NmtAycyS AShcpDKXNg2FuD7phFkW5UeY0x/AZ8GykHmvLPdmhKTPzZigtuOaZQRL9xocWaT7hRVK sRuISH04nWJ3LB7ZIoHdkcE68ZPNbDDjz8ttkos59gl7rePKBullaEEfnoJtbEz0n0xu 0vp453Q74ypuGyZ97KQjziKGPs6r9wwpYgCejhNo/gjClwlJ976dtbstcB2WCRFStFdD JH2F70VuWkITr+GhQXYx8DTxROqgbcY3rlpB9w46jCj/0M95sZ1kVXqGACLoDtwPal5w fhxA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1751642742; x=1752247542; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=zNvWjNYrNAUtF5MSlixELkfrw/rQdgWdiIqr1YNwBsU=; b=Kb86Mv7JV7aYn7Io3li4eLBI2M+iCGonoeqgmfDw49khRKYGfyF6qxfhr/oKn5+Ibm vfabNdm+0CSj/dN4guWmnLRidOv3PAAIJvzIivOxFOLu1k8WuT8KgyTBgm6sfDsPDuRC JIGRCS5T7HEzcgjTOG+yg3jALV/p4XgIv1zXW6IeM/tlevrh3tFRP1OtA9IgKdD251Fb EjV4yDiXrpdVfznOG5LRMdT31mYKRfdqjyO0LfFiI4jhVO8NQ+iRZ60t/dWcS5qOSiOe U2/yya2dEx5MD8sLXOFTMIY48RO2tF0Q2oX3jWRhg4RXg8TUI4Um1gkCxkbeEa8fm8+1 1fww== X-Gm-Message-State: AOJu0YwZ72JSABFj8jOA5ZjouPgoDA69l6mItsPwD6KPBPi1jdqdQMnt U8MRn4MB6M5Qt9p+4hMiS39T7GLaDzaJiUcB/wyzeSvXKoQbHkKKE3MaLxopKw== X-Gm-Gg: ASbGncsxgGjtCZmV4J2dIIxOmEgrI5/NM5vpz75GqwPXZw8BDxG6PxCBRbtl7Eqejt1 swk1CXmWHMjv8P1e2fIyBaiK+SxoKyXykyWf66U69VHq7qY4F9v1CfJcWstD2aFRm5BhTiPlQY3 I654rzaiIAu0v66BxZaJB7RPkhm7bITq1MhF8uV1stwPYwk5oeH83GZAsD1S5QV78luGXBp0duE 8P0X20R31f2RDbAboRprtFzsl8ejIHsKNUPrwiFS1G+BJAQGiGXaBpZIzc7Cd9C80EemYrWgrkc m+0mCgOddWjAvfl431TkHxVRsCa23R511oIKu2SS2+vGAmkiADvce+/mSQ== X-Google-Smtp-Source: AGHT+IGE2i8eluV/zaoznxDbYgeSGEvnc5JUvAs8UNdO65hStlbpmoDP2IpLyiwGQKpAahNWwpnd+Q== X-Received: by 2002:a05:6512:790:b0:553:2159:8716 with SMTP id 2adb3069b0e04-5566258d705mr899527e87.26.1751642742258; Fri, 04 Jul 2025 08:25:42 -0700 (PDT) Received: from pc638.lan ([2001:9b1:d5a0:a500:2d8:61ff:fec9:d743]) by smtp.gmail.com with ESMTPSA id 2adb3069b0e04-556383bb113sm281028e87.11.2025.07.04.08.25.41 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 04 Jul 2025 08:25:41 -0700 (PDT) From: "Uladzislau Rezki (Sony)" To: linux-mm@kvack.org, Andrew Morton Cc: Michal Hocko , LKML , Baoquan He , Uladzislau Rezki Subject: [RFC 3/7] mm/vmalloc: Avoid cond_resched() when blocking is not permitted Date: Fri, 4 Jul 2025 17:25:33 +0200 Message-Id: <20250704152537.55724-4-urezki@gmail.com> X-Mailer: git-send-email 2.39.5 In-Reply-To: <20250704152537.55724-1-urezki@gmail.com> References: <20250704152537.55724-1-urezki@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Rspamd-Server: rspam03 X-Rspamd-Queue-Id: 2545B20014 X-Stat-Signature: 9rmbo7on7zsad7rdewrfob6e6n7p7wje X-Rspam-User: X-HE-Tag: 1751642743-652752 X-HE-Meta: U2FsdGVkX1+b84r9K1jfRPRyqQHYZkkyqpns0XvPsAg0/CWV8LnmQ9g1zA1z+pcftJiY3LeA7qlXJPPjf+EXf4VeInxm1GQVUpg2PTRiot2GqdaMO6KLC8kyW8TiwKifh9iiy6uYTvRj9xy31ZVuQ47hYT2tQRpTx3AqmojbV6FZYic5VKEcbl/NHMCXvOwd+yRihDv5FndDDjfWQ67dHsNZaF7kyUeyV6CrsiN+RnWQTYzs9NBOI6+F+nY+xvL63dpHLpcuwyZy1nlhY6C5Nz5luHuTxL7x451OLF+6rcWSKWf/Up2uoEPHWfGdt3PAshSjDxQp1KKLJ/VaUjthytqXwM5IFAMaMF8ei3pvyzSbEa5vVGxrcEFhD0igRe0eM9p4aN6wy/LvTRWIrCZjlDf+FPrFm8/jKExJ9r1/Ccvqjkiv3XpVoN2udx1+kcWvHZXHWO5ZxG6MPw6ixQuslM6H0N4YRXZBJmyDjkmO00viwB/M2ZgWiQvCBxFH9N3WKPY6c2O2SLgx1Rhqp6KvXKVs/Vu/IQuxEVNS3X0D7r+flA6bVaCSguNAOe7RRjWkEeyZCZSOGBWqiQtBQVAF71SuypI2QW0iwqJJB7J7YR+dbVev9zuLw1uosInozBs1fg/G94W34HAM7kDCrWGq8EjTWu8+Q8IpnKoVH+KzKPtCEkPCuThr3oQZ1RrbXPhRtxEOfVnWnZkOk1HvXQUhziezlF+G2UtkcqGWFnroFVFkAfyUvjS9fH14nqskWk6cZqzUybScUYL1HzN8Eeyl2ZFL+Lu0bETkVw3Ox5M7pLcCRx8a6vqbdR8bWLSYiCOcBkwubdX7qG/3rNM0SYea4FCg0QBOz5fM2GAFkgEmmvIPVO1v7q+8C7fbZZUcT65uZDFtTe/dq3kD5Zc0tETwT1q3GcxUolSxZHM7PD2x5SLsV8MRaqMIsLfCpH09OS8nOTBbqxZCQfPAehe8bSI y2YJldkw 0ZekWc3+nB3CQMhcU10zZMDYFX6p56/1SwQFdgQ3w3Hy+wSr/X/JmhwgQU0uysM1TDdhrd/mTFOAfkJNh3Pza9O4Z6uzOs1bRdAd42Z7BDF99tBmBJmymGTA/HBeeIMfbaeTwW87C4HzOCIA80r690CFdeWCaxnIDm0lzWnFJmZCY2XGhPNPipwVP1IW822TW6bF/4qto1hC22dQ7h3yBGD7dkzj4t/iDTphY5fgJl5AMhG24nhEkzIwoO+Yli3ReggV3KhVB83ebCPQ7GJycoI9yFe6jLPLLccduFkjQfliUc3Gy/FCZXUuhlrIWtVHQHtvoBelhamXSKhEZuyHLu3Bvbi2HePKt2B5YoEhPBEvaHtH/3VjwK61ozDA6ZiqJ3aoVgEfy/d91kGSSMX50y5CwZduSraCDmAeLZ5hLdCYCw9tVnqElFv4RIZyevE2TPkJrN+nrFXtpNWjh34i/cyadi7/GtliII1hKq5J5ePi0jhXRlEoI3BUzWA== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: The vm_area_alloc_pages() function uses cond_resched() to yield the CPU during potentially long-running loops. However, yielding should only be done if the given GFP flags allow blocking. This patch avoids calling cond_resched() when the allocation context is non-blocking(GFP_ATOMIC, GFP_NOWAIT). Signed-off-by: Uladzislau Rezki (Sony) --- mm/vmalloc.c | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/mm/vmalloc.c b/mm/vmalloc.c index 8c375b8e269d..25d09f753239 100644 --- a/mm/vmalloc.c +++ b/mm/vmalloc.c @@ -3624,7 +3624,9 @@ vm_area_alloc_pages(gfp_t gfp, int nid, pages + nr_allocated); nr_allocated += nr; - cond_resched(); + + if (gfpflags_allow_blocking(gfp)) + cond_resched(); /* * If zero or pages were obtained partly, @@ -3666,7 +3668,9 @@ vm_area_alloc_pages(gfp_t gfp, int nid, for (i = 0; i < (1U << order); i++) pages[nr_allocated + i] = page + i; - cond_resched(); + if (gfpflags_allow_blocking(gfp)) + cond_resched(); + nr_allocated += 1U << order; } -- 2.39.5