From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8E0D6C83F03 for ; Fri, 4 Jul 2025 22:14:21 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 51EFE6B8076; Fri, 4 Jul 2025 18:14:18 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 4A8C26B8067; Fri, 4 Jul 2025 18:14:18 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 370286B8076; Fri, 4 Jul 2025 18:14:18 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 1D5F96B8067 for ; Fri, 4 Jul 2025 18:14:18 -0400 (EDT) Received: from smtpin05.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id BF3EC1253BF for ; Fri, 4 Jul 2025 22:14:17 +0000 (UTC) X-FDA: 83627986554.05.787CD73 Received: from nyc.source.kernel.org (nyc.source.kernel.org [147.75.193.91]) by imf21.hostedemail.com (Postfix) with ESMTP id 282511C000A for ; Fri, 4 Jul 2025 22:14:16 +0000 (UTC) Authentication-Results: imf21.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=SgAEPQBt; spf=pass (imf21.hostedemail.com: domain of sj@kernel.org designates 147.75.193.91 as permitted sender) smtp.mailfrom=sj@kernel.org; dmarc=pass (policy=quarantine) header.from=kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1751667256; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=kcxGIS+zCSlKr9dyCddu0NOLpVzq7Soyf9yOcjXgw0E=; b=aAOJMOdTAEvR6kmuPdAcGgk1ko46thH3oPnG/S4ncAirjc1au78VshQP7U8Q7bDdPZB90V lEF/5JGneOGapZeq71hnGVIH0JyafyAtSMLPchIQKlthFyDd7Pey+q1ubCrUNBUWzpjCw0 rhM+OyE1wE9ejY88VDWY7QBgrstiyUg= ARC-Authentication-Results: i=1; imf21.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=SgAEPQBt; spf=pass (imf21.hostedemail.com: domain of sj@kernel.org designates 147.75.193.91 as permitted sender) smtp.mailfrom=sj@kernel.org; dmarc=pass (policy=quarantine) header.from=kernel.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1751667256; a=rsa-sha256; cv=none; b=vv+jb/oN9KT35BxL334Wo5Oe1KdxtiuGDoLr+5buBOv1u5Lw49G6Wt1gWoAhByPzhmyx3G hNb++bRKYjF0YH4qmTjvCuCDZTC08okSiCF6vkajgKpPU3S9HugrAVrPVz3yCaE8+pmR+Y OgAdSuHhYTyqReXlhkuan3QTUECmhvc= Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by nyc.source.kernel.org (Postfix) with ESMTP id 66227A53D5E; Fri, 4 Jul 2025 22:14:15 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 0D502C4CEE3; Fri, 4 Jul 2025 22:14:15 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1751667255; bh=i4kVmwYYJvbGjW13oTsr6Z3ar3qE24r2fehpO6C3TQk=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=SgAEPQBtRLpmCaGFxRT8Oo59TvtLlP2zpM0NfePZsyd0x4yCx3ffAzZI9kRC+q1jE VuAxxRQOiV3tgom2qEq6ODaJZeB0jz+vqndDUU3jQ5WwmvDE1Rc2pC5uAJxhOYd94K HI/s5iiw955ielbthQ7MHpS77IVEYtORmaI2indIDSC0bfW/pm1MYYzYwPEqxqhj0R uakb6FmuJ9GBTq7zyCxsU3lG4jZ3VM7ZiU6PiKcfYpezRJb6fUiwE70PykLYXGeLuh qsrMV/XNNveEfSZDy17DFMiqJyBXi9ZlhpkVAH9JKiII0quwI29nJgWNFH4oRaeIR7 F1fwTd267fZ6g== From: SeongJae Park To: Andrew Morton Cc: SeongJae Park , Masami Hiramatsu , Mathieu Desnoyers , Steven Rostedt , damon@lists.linux.dev, kernel-team@meta.com, linux-kernel@vger.kernel.org, linux-mm@kvack.org, linux-trace-kernel@vger.kernel.org Subject: [PATCH 2/2] mm/damon: add trace event for effective size quota Date: Fri, 4 Jul 2025 15:14:08 -0700 Message-Id: <20250704221408.38510-3-sj@kernel.org> X-Mailer: git-send-email 2.39.5 In-Reply-To: <20250704221408.38510-1-sj@kernel.org> References: <20250704221408.38510-1-sj@kernel.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Rspam-User: X-Rspamd-Queue-Id: 282511C000A X-Rspamd-Server: rspam09 X-Stat-Signature: i4imtzmpouundu7tnbqxqtfndwm8nbsf X-HE-Tag: 1751667256-661279 X-HE-Meta: U2FsdGVkX19HrUxbbwo3Z6ui47GA652PngC3nR7MAileE8coE8mJAsRl56W7XDwcNtkC4+ZrwSqdufNtpIEX0j9UJ20ulcEauvX5ex94ViBaOD592/qvfvBm/bKUrMXUUWtp3SYfbUctEJk4XcQiZnSIRBiWl8dhDfSHevEkKfrXEadFL0xPchoLbQbZ1wQWuqAuwDS0uCaWaXJ/FQTzR0zNOSsBVrcRgT6bDtL4NK8FviEOHFLRCcfy34FV5k5F7MVr8yw2peSmkmzy6qpYG5agOU+/4gtbzHqPzsVMFsHrU8LXDrPz80VSWpI2qiTYCKU5+8QVuC1OEn0bOFE2WzVBZlEzDxyITlbGnC/8W/06O7tpjBRHgpsjFrg0JiNipMLI+V3Zvcqza9z3uc3hRRdEwU7C2R3HgUDRVmC+EWQayHnn2dUrZZ0P9eIO6eFFDp2/e/2h69FO4iCrZxY+iEXy82jQc1EI3ANhBu+QwuTY6mAy96WMNezfx8xVderRzZAQikrIHuoCzpWAv5DREyU1nt8MUBtUBlvDY6Vt6+KWmmC4YWkqGyGkr2DryBXuSovvKYKL/hegKflCqN0BG+0TPsf2o8QlQG458Lwi+wvQO0wv6KY/lg1IBbgdZzQ9o3U7MVgyGufM8rluI3E1FtjkX2UuuFHpM65F9Y75304DR+zPiQZEjFmqEA2ZlFp3vJ+ZGdWYQ/lBuVQSXsDy1Fk5+j1oY0l+0Eu1l6mLRcy+B7g7gFuL9jokvIK67blsQU9yU2i2TG1CiuYF3Whpp1/cL0VrPc5hySLHl6Vt8Y3oCX++9/JSZE2TYmjnHIkEoP+HtRe/9q1l6axzkou4NKsvcJYzcaLZZrrP1xre2LYtooE/W4B2QrMadgOTE/5b7mj8LbbIm4Wp73z/hG2wEM5PHkUM+zfRFT+JMTY8w5f+WM/TEF9CpO1y5XPzDYIgRKXI1u5JyN6iSXx6rT6 JTR9tVds qPx9FCyopsBqzKR2gNFx4GVJDa/ZddB3pvk+EJ/z3UVbUInnBA4Xpr4YJOJfx8TYeyyPjPnOYVHHTkROPnYPJE1JzHjlN/lJmq+aa9DQF70yCL3F+QYRYzTHOoma0rQin5s9hKO2xxbKgUfvy57jqgosEYwVb+WbWp4Xecm0JWR2On4HBqnFGj4EOL/t0sWGmrGjWLIgYzkhORlzJy1MptQEwQOW/XpbeiAxaOwBf+f1nSt1zi3u8xEM78LotN1qRmri/VW2MnweuWr0= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: Aim-oriented DAMOS quota auto-tuning is an important and recommended feature for DAMOS users. Add a trace event for the observability of the tuned quota and tuning itself. Signed-off-by: SeongJae Park --- include/trace/events/damon.h | 26 ++++++++++++++++++++++++++ mm/damon/core.c | 20 +++++++++++++++++++- 2 files changed, 45 insertions(+), 1 deletion(-) diff --git a/include/trace/events/damon.h b/include/trace/events/damon.h index 32c611076023..36b2cdf47dce 100644 --- a/include/trace/events/damon.h +++ b/include/trace/events/damon.h @@ -9,6 +9,32 @@ #include #include +TRACE_EVENT_CONDITION(damos_esz, + + TP_PROTO(unsigned int context_idx, unsigned int scheme_idx, + unsigned long esz, bool do_trace), + + TP_ARGS(context_idx, scheme_idx, esz, do_trace), + + TP_CONDITION(do_trace), + + TP_STRUCT__entry( + __field(unsigned int, context_idx) + __field(unsigned int, scheme_idx) + __field(unsigned long, esz) + ), + + TP_fast_assign( + __entry->context_idx = context_idx; + __entry->scheme_idx = scheme_idx; + __entry->esz = esz; + ), + + TP_printk("ctx_idx=%u scheme_idx=%u esz=%lu", + __entry->context_idx, __entry->scheme_idx, + __entry->esz) +); + TRACE_EVENT_CONDITION(damos_before_apply, TP_PROTO(unsigned int context_idx, unsigned int scheme_idx, diff --git a/mm/damon/core.c b/mm/damon/core.c index 57a1ace4d10d..6019b8ec4bba 100644 --- a/mm/damon/core.c +++ b/mm/damon/core.c @@ -2011,12 +2011,26 @@ static void damos_set_effective_quota(struct damos_quota *quota) quota->esz = esz; } +static void damos_trace_esz(struct damon_ctx *c, struct damos *s, + struct damos_quota *quota) +{ + unsigned int cidx = 0, sidx; + struct damos *siter; + + damon_for_each_scheme(siter, c) { + if (siter == s) + break; + sidx++; + } + trace_damos_esz(cidx, sidx, quota->esz, true); +} + static void damos_adjust_quota(struct damon_ctx *c, struct damos *s) { struct damos_quota *quota = &s->quota; struct damon_target *t; struct damon_region *r; - unsigned long cumulated_sz; + unsigned long cumulated_sz, cached_esz; unsigned int score, max_score = 0; if (!quota->ms && !quota->sz && list_empty("a->goals)) @@ -2030,7 +2044,11 @@ static void damos_adjust_quota(struct damon_ctx *c, struct damos *s) quota->total_charged_sz += quota->charged_sz; quota->charged_from = jiffies; quota->charged_sz = 0; + if (trace_damos_esz_enabled()) + cached_esz = quota->esz; damos_set_effective_quota(quota); + if (trace_damos_esz_enabled() && quota->esz != cached_esz) + damos_trace_esz(c, s, quota); } if (!c->ops.get_scheme_score) -- 2.39.5