From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 17987C83030 for ; Sat, 5 Jul 2025 17:50:17 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 074936B8078; Sat, 5 Jul 2025 13:50:11 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id ECABF6B8067; Sat, 5 Jul 2025 13:50:10 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id D68676B8078; Sat, 5 Jul 2025 13:50:10 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id C79C36B8067 for ; Sat, 5 Jul 2025 13:50:10 -0400 (EDT) Received: from smtpin30.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id 4E45AB74E5 for ; Sat, 5 Jul 2025 17:50:10 +0000 (UTC) X-FDA: 83630949780.30.8A38883 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf25.hostedemail.com (Postfix) with ESMTP id 9502BA0002 for ; Sat, 5 Jul 2025 17:50:08 +0000 (UTC) Authentication-Results: imf25.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=f24XUX+m; spf=pass (imf25.hostedemail.com: domain of sj@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=sj@kernel.org; dmarc=pass (policy=quarantine) header.from=kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1751737808; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=PzQFFKa/D1EgxYd5wxgD6Z3t5M2UwfSDdfulkt1aK2g=; b=Hq1qbKT9s4G5lqDHsWOKwKEQFWtBFCJaH96v2+ouxTu0QmHffwelI9vaE4E+n7kbjdCGPl XwmFYZWdP2JxT52dZj+DYzj47kFzXJgxrqgmDP9odtkkItua6kM65Ke+uU4g4I7qrf7zX+ i6liL4TsFz+nJNDk8hDL+TQxh+o7R7U= ARC-Authentication-Results: i=1; imf25.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=f24XUX+m; spf=pass (imf25.hostedemail.com: domain of sj@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=sj@kernel.org; dmarc=pass (policy=quarantine) header.from=kernel.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1751737808; a=rsa-sha256; cv=none; b=tsXH6In4exqLShSmO1irWKg5EnZkKyvUlV3j+5ajOAJlWzWqGzv/PjirMbemgyjXjCIAks NW9usn1fizuZMPEjcSK9MIMk0UAx1MhY3+YIX2ATrg/q6Xm4572qJeY1J5Rw0rFuyGrqNs WGPCudqp04LjqyPlDThEejGSgtyr0Pw= Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id D640D5C162F; Sat, 5 Jul 2025 17:50:07 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 59F21C4CEE7; Sat, 5 Jul 2025 17:50:07 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1751737807; bh=UlQxor/ZrTo1LCopX/vs+QBnkrkfnY6J7q+nqa5X2vM=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=f24XUX+m23bN8Hmsz3jagw7Q/aGUMDMsDJm9/A+gXpG+aiU8IR7acWQGda1f6YRQu O5vPJ47LfdF1QwhCU6STQWLvEdZ6/847dJpoWR/IbnEcBws3eN06uJ95aAfnPp2tsB 6ETkcJyDuQ6g2eI9nX8ptCiG5qdZ/endL9+s2oJNgtKMaA9HnvQQMPxRWKfWkaXeA2 NRXHywTAoygU+Xq3sAJi1rq4eEu1S6zZK2osbK2aYi06wYQ7ZYezpmuhpBxP+RyIMa 7Sd7yrglH/Om3V3KtgLT1on3xpbOpw84+lb23bjFsjJOKE+G/gtVdsUseZEtdRkN2B HVI8QZC/gipEQ== From: SeongJae Park To: Andrew Morton Cc: SeongJae Park , damon@lists.linux.dev, kernel-team@meta.com, linux-kernel@vger.kernel.org, linux-mm@kvack.org Subject: [PATCH 4/6] mm/damon/sysfs: use DAMON core API damon_is_running() Date: Sat, 5 Jul 2025 10:49:58 -0700 Message-Id: <20250705175000.56259-5-sj@kernel.org> X-Mailer: git-send-email 2.39.5 In-Reply-To: <20250705175000.56259-1-sj@kernel.org> References: <20250705175000.56259-1-sj@kernel.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Rspam-User: X-Rspamd-Queue-Id: 9502BA0002 X-Rspamd-Server: rspam09 X-Stat-Signature: 6x67dko6z8jt8bm6qf1b99i4k8qaog1y X-HE-Tag: 1751737808-551217 X-HE-Meta: U2FsdGVkX1/qKegs3XWaSWgBvDBoS29fMGbqAIpxuoUYYn3ZN80SzWdG0cm2DsChnh92LoPx/OT4r8WhsBdXbi6l/vySgG5OYToMJYioKJxioXlG7YsxDxi8X1mv+kImg8skE/uJEFevRRL44NEYYGAHd6oDLUd6xzw5GHkq8K5E2agbEfpYJ76m6PfRn3SQN0X0NmtwVCIRFAuBVUk7h0aXLnUcoPcztqc3sXmXfjS5nZDVLd3T5XQgzJRtgOBN2/P/I+EpJ8GoLxqzhBPOf2VRJtHbbA1RChGpkZU5SU6C9hfUoyI1H9ZR2uMSUBiVmzo3KkPKYvGQyKXrtROPskXXf4mBRuULcLV9xbMN6OEfvAyvD5fU+zgm6PIOAwEyrtYS03grAesn0ksrcbZPq8hUIzgTDUw9jtw91JCNwPnQz+lvjDDGaHiuNDTsPHLxdOOvObs95pt7MjHmQMDZpfioQy46wETcN7ebjlEBmO9LQU293+wGT+j2JS5YdH9Mj0D+sTBfUrk7nJIFCqp2lEPzPIyFoQYxdJ3iBCHeTxu0fG4YEv/F7oNQqVu+YKngoWzc/2r+gGoUAPhA9iQ+P4JA/HU5Rnbc4AW2WkxbTU3/UBwPBHPLndq+LUXWOVkYtnf22zZdnxry6CHejXbpKWajFFy0MM/7zHCKaR0T0PmSsKbSJBnqidFSzfQtWi+SkgDU5o86BD85Cvm1Uc9+eKkX+LULU/ruFZEC1G9qMafe4CPMKYjqUWcjJw4wR5j66UwOK6VeUO8hLNYgMKahWM5UDU+D13ZGfHib7HqQRi+c12gPPMjyrZeS3I7bqmGfu/6nNAoMcvJtL3PTViR7OooYPgXOxUUjYb5BJEqbMQG9jr0zQ217ocuLRN3UxE5w8EyYNjWitchovWzbGqOYS8yl9jloK/8IqZSlXQYFTOet8JLvjgMF3PWpq+Np/98PNP9XKpkXD+0m8MhsrM1 OsW011bo n5itWgvRA3nFGaeqnZ28J1Bp6+NI+kzQPbKG5pgh1rf8UpcH7trJy73R9kIZVVlUP7tIaTCAyf0BGgNqYAxu3V7+/AlU5pIC4xtk8yvpi1232JKTCYhKEpYalFhLS9WGHJGMusV8juMLr/teqW2yoixi4tppuwUbQLT6BnWOw90Z6Ib3zHa4upCvWVKF06UxREpblH68JP1Mf8aV5aU+emWifmXLXzdSS21YvJENZ1fqudV2PaLHiY8tsgx+en3MShFn770hgEujaWJ1IDN8fj8BWSBYbzRyB0uL2LbrdlydAmnUejMi2S6gzsA== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: DAMON core implements a static function to see if a given DAMON context is running. DAMON sysfs interface is implementing the same one on its own. Make the core function non-static and reuse it from the DAMON sysfs interface. Signed-off-by: SeongJae Park --- include/linux/damon.h | 1 + mm/damon/core.c | 8 +++++++- mm/damon/sysfs.c | 14 ++------------ 3 files changed, 10 insertions(+), 13 deletions(-) diff --git a/include/linux/damon.h b/include/linux/damon.h index bb58e36f019e..e1fea3119538 100644 --- a/include/linux/damon.h +++ b/include/linux/damon.h @@ -934,6 +934,7 @@ static inline unsigned int damon_max_nr_accesses(const struct damon_attrs *attrs int damon_start(struct damon_ctx **ctxs, int nr_ctxs, bool exclusive); int damon_stop(struct damon_ctx **ctxs, int nr_ctxs); +bool damon_is_running(struct damon_ctx *ctx); int damon_call(struct damon_ctx *ctx, struct damon_call_control *control); int damos_walk(struct damon_ctx *ctx, struct damos_walk_control *control); diff --git a/mm/damon/core.c b/mm/damon/core.c index dc0ee2dd55d3..5357a18066b0 100644 --- a/mm/damon/core.c +++ b/mm/damon/core.c @@ -1311,7 +1311,13 @@ int damon_stop(struct damon_ctx **ctxs, int nr_ctxs) return err; } -static bool damon_is_running(struct damon_ctx *ctx) +/** + * damon_is_running() - Returns if a given DAMON context is running. + * @ctx: The DAMON context to see if running. + * + * Return: true if @ctx is running, false otherwise. + */ +bool damon_is_running(struct damon_ctx *ctx) { bool running; diff --git a/mm/damon/sysfs.c b/mm/damon/sysfs.c index 1b1476b79cdb..79d65dcc9dd0 100644 --- a/mm/damon/sysfs.c +++ b/mm/damon/sysfs.c @@ -1189,16 +1189,6 @@ static void damon_sysfs_kdamond_rm_dirs(struct damon_sysfs_kdamond *kdamond) kobject_put(&kdamond->contexts->kobj); } -static bool damon_sysfs_ctx_running(struct damon_ctx *ctx) -{ - bool running; - - mutex_lock(&ctx->kdamond_lock); - running = ctx->kdamond != NULL; - mutex_unlock(&ctx->kdamond_lock); - return running; -} - /* * enum damon_sysfs_cmd - Commands for a specific kdamond. */ @@ -1275,7 +1265,7 @@ static ssize_t state_show(struct kobject *kobj, struct kobj_attribute *attr, if (!ctx) running = false; else - running = damon_sysfs_ctx_running(ctx); + running = damon_is_running(ctx); return sysfs_emit(buf, "%s\n", running ? damon_sysfs_cmd_strs[DAMON_SYSFS_CMD_ON] : @@ -1429,7 +1419,7 @@ static inline bool damon_sysfs_kdamond_running( struct damon_sysfs_kdamond *kdamond) { return kdamond->damon_ctx && - damon_sysfs_ctx_running(kdamond->damon_ctx); + damon_is_running(kdamond->damon_ctx); } static int damon_sysfs_apply_inputs(struct damon_ctx *ctx, -- 2.39.5