From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id B1110C83F09 for ; Sun, 6 Jul 2025 19:32:14 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 186A56B03F7; Sun, 6 Jul 2025 15:32:14 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 1375B6B03F8; Sun, 6 Jul 2025 15:32:14 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 04D7D6B03F9; Sun, 6 Jul 2025 15:32:14 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id E75976B03F7 for ; Sun, 6 Jul 2025 15:32:13 -0400 (EDT) Received: from smtpin13.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id 7840E14019C for ; Sun, 6 Jul 2025 19:32:13 +0000 (UTC) X-FDA: 83634835746.13.0134C16 Received: from tor.source.kernel.org (tor.source.kernel.org [172.105.4.254]) by imf02.hostedemail.com (Postfix) with ESMTP id 0282B8000D for ; Sun, 6 Jul 2025 19:32:11 +0000 (UTC) Authentication-Results: imf02.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=Gp6grlXT; spf=pass (imf02.hostedemail.com: domain of sj@kernel.org designates 172.105.4.254 as permitted sender) smtp.mailfrom=sj@kernel.org; dmarc=pass (policy=quarantine) header.from=kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1751830332; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:references:dkim-signature; bh=rU4x3Z1dilKVz/+6I4X2DCbpZQP5lL9Ptn0cVVZcIMc=; b=q9gXRBY1Z2UlpI8/OpyaHUzzr4M3XgH/YAKTA7QU5TyxCNVpqwG6zS7XyDJt0nBafhQmkX tR+XjS36b0Fm0pOvCy6Zz6nlEEC7j5d15xQj8RHGa4kTesAWBdp4BBVNfm7wa58F6qiDUi tlt7X93w7rtR44+dyk8Q5Dj/Vzv3BYo= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1751830332; a=rsa-sha256; cv=none; b=vZ6QpklW5cWQ/amGYutZCiXOR82RCMSgf7JTOqu+0Gg6iNk2/UV67nufFhn+/7Xm8BP5E8 G55lslHQeFuSjxTbQl7/OgG6XkZRKZzz+RWgffMcnyYBi/uf2v3cN9kdm1KNZdQ14pFcbC cHIplx6hOy4Ewxc6sCjf8X07wmRDx5U= ARC-Authentication-Results: i=1; imf02.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=Gp6grlXT; spf=pass (imf02.hostedemail.com: domain of sj@kernel.org designates 172.105.4.254 as permitted sender) smtp.mailfrom=sj@kernel.org; dmarc=pass (policy=quarantine) header.from=kernel.org Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by tor.source.kernel.org (Postfix) with ESMTP id 556B46145A; Sun, 6 Jul 2025 19:32:11 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id DCF99C4CEED; Sun, 6 Jul 2025 19:32:10 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1751830331; bh=WHVKcu3OKn9+z4TbtcrV+rsHC/Q8OOdR8csfZWK5Jhw=; h=From:To:Cc:Subject:Date:From; b=Gp6grlXTBqDCt3Mj1jb8ViP8M9MdeGMP3n6tW9gklD2Q5k5STNWN/DvFraIXCGBli dkl985rEOAEd8YaRSHISFkhh8ndtBsWHhMJUufR+rnD3qPcEb414PcxKjePnarWfs/ vUHUnNtcP/oTmvaBUzEs1RnW0wuWy263eI7FK3E5RbCy+qRRy0dBVYgel5WFxOEgzv hOo0mTzquqX/IDeD6naguBzfK8fwRezJT0GcT2FWmLXLmsXqxtwwIqaaPeEOiltm3A ES1stfFdYYOFtxiBkQ18KAkOqfTmsXXDc823buGRPeX36ptdZS/pjk/o3I3oJ9VA0B K97ABGraJenWg== From: SeongJae Park To: Andrew Morton Cc: SeongJae Park , damon@lists.linux.dev, kernel-team@meta.com, linux-kernel@vger.kernel.org, linux-mm@kvack.org, stable@vger.kernel.org Subject: [PATCH 0/6] mm/damon: fix misc bugs in DAMON modules Date: Sun, 6 Jul 2025 12:32:01 -0700 Message-Id: <20250706193207.39810-1-sj@kernel.org> X-Mailer: git-send-email 2.39.5 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Rspam-User: X-Rspamd-Server: rspam12 X-Rspamd-Queue-Id: 0282B8000D X-Stat-Signature: 8jrfacurbi6c4dn8n51qeujptkepaeo3 X-HE-Tag: 1751830331-553494 X-HE-Meta: U2FsdGVkX1/PM0mdZcf9BIlfQL/q0oS9x3JFz7DSSQ3Z/GxHQjVqWxBsXU0QrIqQo3ClfvtrgQJO4upV834oNQc+wK+tEykBTennpbEaH+Ih3q0uR9QRNRuenIGySFXX+uqZ4A5BXwVPEnCsKmUB4SWlv2c2ZgB0bkkP/oNAk8Pn8qY5MD8QPI61bG75lcfRa3gDRtdHFR1Hq4+WU7VphtWwYNG5dnWnIEJRHW+wpfLQ36JCaoGLcVThFExpsx0FR2iiS543DR4Eq/i53uoXbKYqBnvsQVEGkZ0NtnipdwfyqnTQCr2kaOegjMwWq5mojI2qg9Ry+ymTibS1kV2t6hsLTTMugYekj0Yz6p2R/LLSPumkmNaOb7reccWnxk35tb934+j5uVXyJoNiTglQs6iBK49FOnOfoeftEJodZ4V94v7pbnMubvyOpVIWItu4d11g6r7WfRsGRPdXiK6hOxWlRKGTF8dh1OnpO5sUhWTqUtxGxH4+bSPz26xh3RDNCp04y3KYQL+Pi/7rcstJXutJ58fQyWhUajisOo/CD/wmEphHjP9d2qaUfWbZVqcwyYEXQwtPXknRF7iy+9IhKnbmNbiWURO7P+C8G5Lvh1ayWE5nJbECTUFlHqasgQB9XXbhTlf6yHFqPK66l1USWkubG3AkdUF5/sIzDdma0sfg7Dou78hwxGV3Mba0nJ2y+b9+LbQQR4m4v7imu+bXiUUpH8ZdY6cZ1djf2x5PUjsocm5Gkh4HoXJDko89V3W2vn6VekVwsuUFiSoTwXj1ANFomiavhxlG6fSfCcQzRfmSd/0VIzegtJVgk11uCUJUgVcihiEJbQrECVIwZhA9S/aivc3FPBmQpdYZoXr9/JPRL3xK1zbGNrpJi3Xt7A71Rhr7jykraj4CRo/kNJy7GX14eIDYN/yWmioS01Gb1sNw4rj/XN3annRuq8ikb5MBT1ut4+fuZuSZpOzTTAn dqUqEc56 xCzVxs+MuqfGSil1PDJ2WrwQtkfWLuwXSIvU9hmVQo5cPzJeGGZ+ekw+pgdqJTtcizwjVxBauEG1Iu5QIapsOsA5GZOpNs5++9xM82banyd0BC6XyfiBdb2yIvdH9ewAtv2lxlLq4PqtI0HDFzQccw+67p12nk9mGavhn5OPnZ7UuhE2c+/869wNT4jZRq+7vUAqNRI6Qpc/rj1aq/t3H3/Lvyijov8NM7tJiBt0pHJRyt5sPsxBp3A8+OA== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: >From manual code review, I found below bugs in DAMON modules. DAMON sample modules crash if those are enabled at boot time, via kernel command line. A similar issue was found and fixed on DAMON non-sample modules in the past, but we didn't check that for sample modules. DAMON non-sample modules are not setting 'enabled' parameters accordingly when real enabling is failed. Honggyu found and fixed[1] this type of bugs in DAMON sample modules, and my inspection was motivated by the great work. Kudos to Honggyu. Finally, DAMON_RECLIAM is mistakenly losing scheme internal status due to misuse of damon_commit_ctx(). DAMON_LRU_SORT has a similar misuse, but fortunately it is not causing real status loss. Fix the bugs. Since these are similar patterns of bugs that were found in the past, it would be better to add tests or refactor the code, in future. Note that the fix of the second bug for DAMON_STAT is sent separately[2], since it is a fix for a bug in mm-unstable tree at the moment. Also as mentioned above, DAMON_LRU_SORT also has a misuse of damon_commit_ctx(), but it is not causing a real issue, hence the fix is not included in this series. I will post it later. [1] https://lore.kernel.org/20250702000205.1921-1-honggyu.kim@sk.com [2] https://lore.kernel.org/20250706184750.36588-1-sj@kernel.org SeongJae Park (6): samples/damon/wsse: fix boot time enable handling samples/damon/prcl: fix boot time enable crash samples/damon/mtier: support boot time enable setup mm/damon/reclaim: reset enabled when DAMON start failed mm/damon/lru_sort: reset enabled when DAMON start failed mm/damon/reclaim: use parameter context correctly mm/damon/lru_sort.c | 5 ++++- mm/damon/reclaim.c | 9 ++++++--- samples/damon/mtier.c | 13 +++++++++++++ samples/damon/prcl.c | 13 +++++++++++++ samples/damon/wsse.c | 15 ++++++++++++++- 5 files changed, 50 insertions(+), 5 deletions(-) base-commit: a555ad24c884e9f4ee2f2a0184f5b7b89c8d4a6e -- 2.39.5