From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 214C0C83F03 for ; Sun, 6 Jul 2025 19:32:16 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id AFCC06B03F8; Sun, 6 Jul 2025 15:32:15 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id AAEB56B03F9; Sun, 6 Jul 2025 15:32:15 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 8FFD16B03FA; Sun, 6 Jul 2025 15:32:15 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 83ABF6B03F8 for ; Sun, 6 Jul 2025 15:32:15 -0400 (EDT) Received: from smtpin26.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 3475C160199 for ; Sun, 6 Jul 2025 19:32:15 +0000 (UTC) X-FDA: 83634835830.26.CCD6FEE Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf09.hostedemail.com (Postfix) with ESMTP id 8FEC7140007 for ; Sun, 6 Jul 2025 19:32:13 +0000 (UTC) Authentication-Results: imf09.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=kNms0LMn; spf=pass (imf09.hostedemail.com: domain of sj@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=sj@kernel.org; dmarc=pass (policy=quarantine) header.from=kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1751830333; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=90saHQ7TLpLUU5x6PcReEwWevrF6a5NitjKkvH1InrA=; b=iFPfoGh3HoX63C1bGcMnTLnYTVXL5/RS0qZO+3Qg5lJOq/t4+qitVnz8KHw/RN3LiXJll9 KLr8BcZYGtmDskE2LHPZmUwc6LmI++V8EX4UFA+nSLoXMpXtenfktXI2xzr0eWuxHhvpZh GG5yWIn/PZyJ6bODmQzpigiA/Xvuw88= ARC-Authentication-Results: i=1; imf09.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=kNms0LMn; spf=pass (imf09.hostedemail.com: domain of sj@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=sj@kernel.org; dmarc=pass (policy=quarantine) header.from=kernel.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1751830333; a=rsa-sha256; cv=none; b=v67n91s4/fnMPDKeVquOq8w6OI8+s11o/iWQo6q+h4FyHszajLYmPgs6PLIfotmtYe/dp7 J+E7T9zjpQ/iO3K6CbbDFcOasUuS3xdzDTwJTiJz9N1QSWz0T3x3qBe26SNYUxOnzp5NOS KD/e5PGsM3sbfUugHwDu8GzJOzmMAnE= Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id 824A65C56B8; Sun, 6 Jul 2025 19:32:12 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 0CEF0C4CEEE; Sun, 6 Jul 2025 19:32:12 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1751830332; bh=sJNUfzwZJvQuoC1F66bEVuJ3ctg7lAi4+PjtYCktIEk=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=kNms0LMnuLq5XZ6TxvfkzWtuOenMfZRROw0kJ5+cQl9xWB24W3LzEwyWWmlGR9HtY AMbsxj2gYKPhGgIRcd8xoe+yu8OPTCVxt9YrgG7jeTdJFJtnT9LfxlNRC7ZFzFeYIy WABZK2AKedpb1JSrnCYxEroLPUUf7i2QNUqs/+qpYZOOKlnYZDWmuvyNp9sw7A9reF 31E7p9yReXo4OpbxkMIneMiAvdB25ljXfRRLQN4O/hDtKxk6y95A6PCOCvLXhO+5hh EaIomREwbJifZTOkCbNYZAqMRJGBRCwfXysRHcRs63XNU02Jc9YeQsaw2P/laz4E/v pM1zJ7JBVa+Xg== From: SeongJae Park To: Andrew Morton Cc: SeongJae Park , damon@lists.linux.dev, kernel-team@meta.com, linux-kernel@vger.kernel.org, linux-mm@kvack.org, stable@vger.kernel.org Subject: [PATCH 1/6] samples/damon/wsse: fix boot time enable handling Date: Sun, 6 Jul 2025 12:32:02 -0700 Message-Id: <20250706193207.39810-2-sj@kernel.org> X-Mailer: git-send-email 2.39.5 In-Reply-To: <20250706193207.39810-1-sj@kernel.org> References: <20250706193207.39810-1-sj@kernel.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Rspamd-Server: rspam10 X-Rspamd-Queue-Id: 8FEC7140007 X-Rspam-User: X-Stat-Signature: wokhk6xsuuco9q7k1a99hgic1dfgbejp X-HE-Tag: 1751830333-974598 X-HE-Meta: U2FsdGVkX19uB6/FniKXtlvC1zX6XyKA3HL07o4vaxQsT4TI3zVr6nWVII1LYsOsqLP6Zm67leE4LihFRL673R8VP/xJ28nIHFD/+JoFxTGQvoxiqqnbDXyOSu3kY0w4lgArG/+BJrbwqUkokscKbwNpAVemRiwDxAWpXDwKNV5YnZDnaUf1pfccWSuVUMinWP5p1XIpb34Vx2GWPusCzGoH50C9qFGlfFgsoDs3EQ0GgPltnJAB8SYA4+w+IJI5A49Bv6+Z/C04ovC7k0DzMdaMqX/xrkwHgA4tvqXZr+bRKbfJWOCdSLlkyQBzVa8Bmm2FlB0Shq+ujSgd8xWxiQNbbW4MmTY6yGzHPWi6fLxZnwTm5/sHPY+V0CWfv/K+oanclPc84dAkWZYA1HhUtALOkA3OPCPPlisa77jvyWhhRjKQp1R/L1XvJsbLIctXSgoXgt9gqbZoPcNziTXO7Yosnlt/Zeml7tPVBiLmLYl1trLTBaSrVWk281YDcQolX/L62517MdWahdaHyoE0/1sOaGm5ziN4Sz6ldqFCOF0rljoRcqLQecXL8LVQB8X2clZvZ0fzl9lke7PzXHVIY9hep8LcW/JRTtxK/GFGns0Lre7I5zcEq0/N8b7NrMSZpOGS7Ey+KuP2wavXUnUVJXy4yoqb/9WW51de00cK08XNcy0bi7I5GSssh6z60QYja8bshKpwtQzQBnfmXb6UQeM+lOIsDGDzC4YSmxPASwjee1znYb+oe9OEDVtEU5lK2JZuEiGAp/ONfgq0MYuQUpxGYuG/NntvMTH8xmfq2eaudH1vyNlxZUod9Lcm/NhLgLs4MeBuRov4f3QPVEYMV4foRBt2scZkjJvLnAWeaQ0S1kCrBoGvXRjyL//xUs3bdKWjIRpSCr5M5XrdunNhVaR4qSCaKUqXjcxQIeUeZDnTKnOlEC7hps7P7vqJtOnuhAUgu5cRrJ1sptJmJIC PDMR+J6z pkf1/V3oYG1oVO40i0SvNZBlh7SmZ5KiTO0nubboqT290hHOwT4ecku3MhAamKL+/TBiWrmIIA8mN5B+vP8kNpip1SWbbV4MtvCzFKSF2+dYLy2peZnACMb6AHDKRb6g/23Vgup9lWTxbNcvNQst7KYaQuGcRuDj4sjys7L/ilLGWL3v/fXLBxSil4wP7fo9OOJP35Y86TeR2GTaKsIiBibC7O4cPHF2U4qzyoQmeWGRGpd4= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: If 'enable' parameter of the 'wsse' DAMON sample module is set at boot time via the kernel command line, memory allocation is tried before the slab is initialized. As a result kernel NULL pointer dereference BUG can happen. Fix it by checking the initialization status. Fixes: b757c6cfc696 ("samples/damon/wsse: start and stop DAMON as the user requests") Cc: stable@vger.kernel.org Signed-off-by: SeongJae Park --- samples/damon/wsse.c | 15 ++++++++++++++- 1 file changed, 14 insertions(+), 1 deletion(-) diff --git a/samples/damon/wsse.c b/samples/damon/wsse.c index e20238a249e7..15e2683fe5f3 100644 --- a/samples/damon/wsse.c +++ b/samples/damon/wsse.c @@ -89,6 +89,8 @@ static void damon_sample_wsse_stop(void) put_pid(target_pidp); } +static bool init_called; + static int damon_sample_wsse_enable_store( const char *val, const struct kernel_param *kp) { @@ -103,6 +105,9 @@ static int damon_sample_wsse_enable_store( return 0; if (enable) { + if (!init_called) + return 0; + err = damon_sample_wsse_start(); if (err) enable = false; @@ -114,7 +119,15 @@ static int damon_sample_wsse_enable_store( static int __init damon_sample_wsse_init(void) { - return 0; + int err = 0; + + init_called = true; + if (enable) { + err = damon_sample_wsse_start(); + if (err) + enable = false; + } + return err; } module_init(damon_sample_wsse_init); -- 2.39.5