From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8D8DEC83F09 for ; Sun, 6 Jul 2025 19:32:23 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 495916B03FC; Sun, 6 Jul 2025 15:32:18 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 445296B03FD; Sun, 6 Jul 2025 15:32:18 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 333B16B03FE; Sun, 6 Jul 2025 15:32:18 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 1F55C6B03FC for ; Sun, 6 Jul 2025 15:32:18 -0400 (EDT) Received: from smtpin03.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id C530714019C for ; Sun, 6 Jul 2025 19:32:17 +0000 (UTC) X-FDA: 83634835914.03.5D6E6B0 Received: from tor.source.kernel.org (tor.source.kernel.org [172.105.4.254]) by imf20.hostedemail.com (Postfix) with ESMTP id 4E8C71C000C for ; Sun, 6 Jul 2025 19:32:16 +0000 (UTC) Authentication-Results: imf20.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b="Pp4Dm5E/"; spf=pass (imf20.hostedemail.com: domain of sj@kernel.org designates 172.105.4.254 as permitted sender) smtp.mailfrom=sj@kernel.org; dmarc=pass (policy=quarantine) header.from=kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1751830336; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=/n5FjzxX7tQU3xZyrj1HDjhMtJhOnAChoduBhGoMZQ0=; b=WX5w1XnBmYirOLaa+Xiqxv+okohcRNqFBM3pGfXo9CeiZnN/Al3gbAqidSO9ikzJ+yPX0s /GyeNwEWGaHUXV5VnEta6AaMQhlkUZgz0bG3219G0rPBWB2axNS2mD0h+8cvYMXONjp+sb RUihAhfmvWJFgJkch3cORplEWK1+Bm0= ARC-Authentication-Results: i=1; imf20.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b="Pp4Dm5E/"; spf=pass (imf20.hostedemail.com: domain of sj@kernel.org designates 172.105.4.254 as permitted sender) smtp.mailfrom=sj@kernel.org; dmarc=pass (policy=quarantine) header.from=kernel.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1751830336; a=rsa-sha256; cv=none; b=Qp3vXUFoQEAoXeaQLZq2byXl7NtkUnd+Kxd+Ro2Yqq2VdyQi84EK6ySfP8LXfWyvJdQctE iV2eam9d8LNyXnCJSVK/MAGH+RLpnanua4lX27/AyyFtifYiPzmA3dSEhpAAtUsoCZ8TRC Ot5amhchyIaXXsfY9MQmPX4EG5ODAnc= Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by tor.source.kernel.org (Postfix) with ESMTP id C0A0061465; Sun, 6 Jul 2025 19:32:15 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 30C82C4CEEE; Sun, 6 Jul 2025 19:32:15 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1751830335; bh=iRbDRRBdy920t5w60L/6dOK5zIzjusH9p6xCWRALcoE=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=Pp4Dm5E/nbhA75Wq1v/zugIkgMxTI08nllee9NR2IzqA406U4JCM86QvyqD/RgDiH NTAlxK+UoF9DyvUo+6TJzktytbzYmZZIOVHcTrIXXpDh0zX2uoFXj0X2mQf7IaTclK 8P5qqdBkMJh1qgYphtDK3s8KMLCq39hrAcxHXmthkKumR/2mjCYDD7Fxj/cTi1oXiR jc2Skv/goone3434aiDwZdi19hsdhn8lIn4IcRDmQpYvLdiA+1oGaSUTbNJLzCfZxH q6CzS3d0691f9VzTKI62okfv4qDNNADJZTh8Va+h5I2AihqRmuKVZG0ldf4cNsT8NF fU2g9zh3zIaGA== From: SeongJae Park To: Andrew Morton Cc: SeongJae Park , damon@lists.linux.dev, kernel-team@meta.com, linux-kernel@vger.kernel.org, linux-mm@kvack.org Subject: [PATCH 4/6] mm/damon/reclaim: reset enabled when DAMON start failed Date: Sun, 6 Jul 2025 12:32:05 -0700 Message-Id: <20250706193207.39810-5-sj@kernel.org> X-Mailer: git-send-email 2.39.5 In-Reply-To: <20250706193207.39810-1-sj@kernel.org> References: <20250706193207.39810-1-sj@kernel.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Rspamd-Server: rspam03 X-Rspamd-Queue-Id: 4E8C71C000C X-Stat-Signature: rt5eyrafnfb85gwhafnkro9fwz58pnsa X-Rspam-User: X-HE-Tag: 1751830336-817048 X-HE-Meta: U2FsdGVkX1+ebEZEfTrs5stbrNRkHDg3ai+8GKb4I4m80afOOi8Jpe3PKJZrvHVADGJpwP+Urh2wYvUCkmyNB5Fvvsk5ME4i37o/BhoaXzmbw3f6TPZUYy8lnqfxD5TPq66SrH2pAg8jrQbNrz88Ewior/3XEIGkB5Y99fe8VAVADyTL40/27+1hs+rERe4Jiv/PZcItZDRahbRu8SulFmSAJDIu70PvklWvEyVF4yTw9OgtXwzqCdwWlH952/f3+SNzUvNWE5cMg2bXFI4pBJmvwqGJ4g0uAVEI69BokEHzHl1tuuM/6ogBls/lp4M/7bwF/kAj9VWNbpJBGQnT8VNGRr+HC1dnHufhc643ZLFyXzTpEtxFAWehY6Bg++M7YsDKJ61JyrYrj4MWul8gieY3CiBuLKeqVIpyQJNm453KLAAKFb0BppKmrETJJyK5RXRxCityijWAsIc445IVqRcEsrcK0DJWbCeP/QcYwdBeqkGbAaNy23R35VGvmG/DWHtNjOPuNgL1B3TQIm+dV5C0J6Iy3EoqujTEZA8Rqts2lNSZQK9UDyJVP3eTVjPcqwRVKvBxJwiJusk3EfYz58YXbEAinzZ1bAR+8qx7TGbDTRQput2eEnmQeJnQI1e4UuY3t+IZogAVcbLFuvV6W0qzWf8YplaG3zHB9g1O2lVmgT0Z7Q7JjDKoNSUT/DmOBjujkxY5b/2lb3AA1QEqZdcWI2gxRLhVanktEBYeMgziVcbS08bKvi1/qjQHRW7QJywRHe2WYIHnfk1SI9bxNjBU1yXMWlUMh6Sb7Pkv4AhRS+MyxNofJZFwX/f6oLsQAOL95v7seo97iCvvtFJRsuaensaf/6CnCihzM1w82/nuHUi8DqlP0fcqJinP+vyne4e36V9Z4Zij4z8DdDaU46mB3ZpSHQi4l8oZLCGRAwIf1dW7BTPLVz8uWDsFN5mXUQE0ASKRUouP6lJSBZK Qhk4OPbJ CfFTNOBC7amKM8DczJyyFHxJbVipw0gfRCGP0XY39e4lmR6/k54WiDlPy/1p/9VbK43lmUS6QnHPOXLGh4Y+JMh2J9BUF0RswvaT/Gq/TGf5gYguWYxo6+R5go48CG6Hsh3Rsf6wKDAwansCZXU5v/SlmlXHZAFbzUTNvt766xAm7Fd8Tu5iM/6dadjfym+J3R3PcXb2vytWeaIo5Jy6KKwHoqI5HKSRwxBag X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: When the startup fails, 'enabled' parameter is not reset. As a result, users show the parameter 'Y' while it is not really working. Fix it by resetting 'enabled' to 'false' when the work is failed. Fixes: 04e98764befa ("mm/damon/reclaim: enable and disable synchronously") Signed-off-by: SeongJae Park --- mm/damon/reclaim.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/mm/damon/reclaim.c b/mm/damon/reclaim.c index a675150965e0..c91098d8aa51 100644 --- a/mm/damon/reclaim.c +++ b/mm/damon/reclaim.c @@ -329,7 +329,7 @@ static int __init damon_reclaim_init(void) int err = damon_modules_new_paddr_ctx_target(&ctx, &target); if (err) - return err; + goto out; ctx->callback.after_wmarks_check = damon_reclaim_after_wmarks_check; ctx->callback.after_aggregation = damon_reclaim_after_aggregation; @@ -338,6 +338,9 @@ static int __init damon_reclaim_init(void) if (enabled) err = damon_reclaim_turn(true); +out: + if (err && enabled) + enabled = false; return err; } -- 2.39.5