From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id CD9A4C83F03 for ; Sun, 6 Jul 2025 19:32:28 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 976196B03FF; Sun, 6 Jul 2025 15:32:20 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 927E66B0400; Sun, 6 Jul 2025 15:32:20 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 83EE76B0401; Sun, 6 Jul 2025 15:32:20 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 6C7246B03FF for ; Sun, 6 Jul 2025 15:32:20 -0400 (EDT) Received: from smtpin05.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 39333127C75 for ; Sun, 6 Jul 2025 19:32:20 +0000 (UTC) X-FDA: 83634836040.05.7E3A839 Received: from sea.source.kernel.org (sea.source.kernel.org [172.234.252.31]) by imf01.hostedemail.com (Postfix) with ESMTP id 8726B4000E for ; Sun, 6 Jul 2025 19:32:18 +0000 (UTC) Authentication-Results: imf01.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=XTcsFcHe; spf=pass (imf01.hostedemail.com: domain of sj@kernel.org designates 172.234.252.31 as permitted sender) smtp.mailfrom=sj@kernel.org; dmarc=pass (policy=quarantine) header.from=kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1751830338; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=UzEuUNMxVlHx727ZhLSa0DP6eUgLTiz/JqvreH1gDd4=; b=BaC3euqISpE935Cx5834ZHUhgrvZTO+FqvnSNgWg6muE5DHYbG1rhGPUz3+YqbyzjWF51F jcNMNav6J0EFBpFXrluTecqKM+07vSuWKhU/wM6Isf3t8CmV5x6PYg3SUPMBCz4bf/UYiA ntHjgKxAYJ1MvY9CZ60WikfW2mc1DkI= ARC-Authentication-Results: i=1; imf01.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=XTcsFcHe; spf=pass (imf01.hostedemail.com: domain of sj@kernel.org designates 172.234.252.31 as permitted sender) smtp.mailfrom=sj@kernel.org; dmarc=pass (policy=quarantine) header.from=kernel.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1751830338; a=rsa-sha256; cv=none; b=4fUyQhDHgmajmpzXJFu2DID6ptC0QMUz0X7Kfq3Wn6cVw2pDCiggAqffRK38bnJwQEDmpS 99Fw+kyKXatOoBWHIBYkd8miYfOW1AGiSBO2PemND7JPu11WzCGuRUWA8HpeESY7Yq30/3 my13FSEn3vCPJS8vX1o/bi+KXo+CQ+A= Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by sea.source.kernel.org (Postfix) with ESMTP id A001F45F15; Sun, 6 Jul 2025 19:32:17 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 5E2E3C4CEED; Sun, 6 Jul 2025 19:32:17 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1751830337; bh=WC8o13MdyLXSnn3QYHivVgrcO/OQGT6f7JW9k71JMmU=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=XTcsFcHeGBuTCVMgzEV9IqQPrvIQNoUIc1770mFyAGnibmeRz3G0wR7UntkY9x2Rq nwSSP2k5J6zU14YCzE2GNp0ayirLuKwHy+/4bwPdxlh6gIA8QvnyEnThFJZXERj8JX /V/AzzM0jIsNwj7VKMX8s8AMUpG5+SbhepCeD7yO9vtE4D8QaC/G0p/pmkq0rzeet0 a+9Gi7Dl+dKKBCxQ1THkmtzs7Hn4yI7kMipkJWNXRKF8iEbFJRDkgwlhijWK+xww1v NfOqrtNlvNPRcFcgm2G7QFW9G7FaQt90kms3kictnzG0V1eKkxyrogDDRJJHFoYE1D m6qFX/phjWiQg== From: SeongJae Park To: Andrew Morton Cc: SeongJae Park , damon@lists.linux.dev, kernel-team@meta.com, linux-kernel@vger.kernel.org, linux-mm@kvack.org Subject: [PATCH 6/6] mm/damon/reclaim: use parameter context correctly Date: Sun, 6 Jul 2025 12:32:07 -0700 Message-Id: <20250706193207.39810-7-sj@kernel.org> X-Mailer: git-send-email 2.39.5 In-Reply-To: <20250706193207.39810-1-sj@kernel.org> References: <20250706193207.39810-1-sj@kernel.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Rspamd-Server: rspam03 X-Rspamd-Queue-Id: 8726B4000E X-Stat-Signature: 3m7tk4m49odbx4pnjds43bw8h4ze15cd X-Rspam-User: X-HE-Tag: 1751830338-163146 X-HE-Meta: U2FsdGVkX19eqgjN6Aw3pVm7DmcG1MhlvXaiyYW579bZkRRH3sbXzvin22Uc4ZVjp6nmoVXEvIWkqPKQT3gfsZykuYopYSdyAQWYcr8L6WB2o0cf3wu4nugGRtlixeN6psq/k3YthY72Dglh50PRYoPRRsl06cxfTdU12F+dMCr+G5qMlpFtO5vhMFyEBBMLKcpvusK+PjzRRfmMN0nmJffhqQiiHpsMR0jDCSeuk4qfvRyZ6jdtyWZaU7reWsINkdh4iXt/vwVFmXsiZUBPh9famhefJ27wK+a5twYIH5fsNU5Rrbyf5kGhJ4xefI47p14L2jDtPBgL/zSBCRb+xihLY+I5+xA/ZG7bE3Wuzig9XvNeWq1XDe0FNYXTEZ9IosG8l5Bt2hzlBOtZtxseBul+buIXVQGTfhXGhlIv0n04pP3Jo5zZM36QcgAItGOjO2pjDkBDeO98fgnPn1MdqAO39CjZnvX95CFJHO2Uaa5hGaY1U3OvedK0S9SbXnoAg/ri26LFd7SOASvgW7mKL2guRM8VUJZvIXqm83Ow4KN7FICWtq1VXvS7e+GtekzX3z4Ori1lT4vgBlvqGsr8QZXUI2gKwU9Fn7Pb1LbHzMSt9NeMb0QHWo3dA0b76SOZBEK9NpPnUoJ9XtlJ5+JIhIOiVPO2qGbSUYKZ/vBv9y/E2cmcokUREMreOryr3uhGWpow13WvKpFSx9PfNKy021q0ns/UuEoAnhk6W0Tpmngn8Bi8GOsFw1iAjbp8EcCQufC+igdP6FfbM1OKVnpPCfcl3+nEhDoUpP4bQviXU2l94iDJ1eGOXfcjDSDUnwiqtaJdeuEBOejxWde+7BN9f0Q4Jfc9pNg8gBTlZaEHlK2Qv13zkQe4/tPXMhdRztbyHJqB7Dm4k6OwxyOVbC8oge6cjW4fOJscghk3l+NqqrA2N2e8jPI63PofFvtaFvDndL14EVi0+LvOQ3j8VXC czxfD0jZ 0mF8CltZ0eexfy/MNpI/TfySOPReD+kEslr8z44oEVlN1rfSaPx7cwfbvUQ6T4Dve5oymYsCfEQrMhPJy3yWOpoAFFbUMb4vlqTsTfOUvvHN/OOBzA7MA4ShhLgIqfJYPreTgF4PotM4xnxEGXcRVRXFUhNCtBAiL/yNuEZ5fySPYeIy/7cg0uw4LiVgr1h1jGuqPF55WYc0JpiDavlO4a+HUoxs4b1tChWP46Mt95S4cB4M= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: damon_reclaim_apply_parameters() allocates a new DAMON context, stages user-specified DAMON parameters on it, and commits to running DAMON context at once, using damon_commit_ctx(). The code is mistakenly over-writing the monitoring attributes and the reclaim scheme on the running context. It is not causing a real problem for monitoring attributes, but the scheme overwriting can remove scheme's internal status such as charged quota. Fix the wrong use of the parameter context. Fixes: 11ddcfc257a3 ("mm/damon/reclaim: use damon_commit_ctx()") Signed-off-by: SeongJae Park --- mm/damon/reclaim.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/mm/damon/reclaim.c b/mm/damon/reclaim.c index c91098d8aa51..0fe8996328b8 100644 --- a/mm/damon/reclaim.c +++ b/mm/damon/reclaim.c @@ -194,7 +194,7 @@ static int damon_reclaim_apply_parameters(void) if (err) return err; - err = damon_set_attrs(ctx, &damon_reclaim_mon_attrs); + err = damon_set_attrs(param_ctx, &damon_reclaim_mon_attrs); if (err) goto out; @@ -202,7 +202,7 @@ static int damon_reclaim_apply_parameters(void) scheme = damon_reclaim_new_scheme(); if (!scheme) goto out; - damon_set_schemes(ctx, &scheme, 1); + damon_set_schemes(param_ctx, &scheme, 1); if (quota_mem_pressure_us) { goal = damos_new_quota_goal(DAMOS_QUOTA_SOME_MEM_PSI_US, -- 2.39.5