From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 39840C83F0A for ; Sun, 6 Jul 2025 20:00:38 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id DA46F6B03FB; Sun, 6 Jul 2025 16:00:31 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id D7BA06B03FD; Sun, 6 Jul 2025 16:00:31 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id C90FF6B03FE; Sun, 6 Jul 2025 16:00:31 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id B64A36B03FB for ; Sun, 6 Jul 2025 16:00:31 -0400 (EDT) Received: from smtpin06.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 7CB66127C47 for ; Sun, 6 Jul 2025 20:00:31 +0000 (UTC) X-FDA: 83634907062.06.EDD2EE6 Received: from nyc.source.kernel.org (nyc.source.kernel.org [147.75.193.91]) by imf27.hostedemail.com (Postfix) with ESMTP id 008434000C for ; Sun, 6 Jul 2025 20:00:29 +0000 (UTC) Authentication-Results: imf27.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=UXdaIZkN; spf=pass (imf27.hostedemail.com: domain of sj@kernel.org designates 147.75.193.91 as permitted sender) smtp.mailfrom=sj@kernel.org; dmarc=pass (policy=quarantine) header.from=kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1751832030; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=81MFybJcNb4tS5wPBbG+qeV3Npl+X0cMKaMCsyhqFcw=; b=0L6KcrXYGYuDkjUh747SpH32oMl3nWO5SfXASbxLYTNo2cfxavpZnUYOZehvifH/pvuwo5 VeMmZQ7aDPSDYLjAIQQZ045iJV5UWtpcMfJJVMzQJIvRNSFz+qaUnBE/0DZw45Vqb2k4qJ 9rWZJ81Rk+ok+8jLCoA/mhfQeD41WI0= ARC-Authentication-Results: i=1; imf27.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=UXdaIZkN; spf=pass (imf27.hostedemail.com: domain of sj@kernel.org designates 147.75.193.91 as permitted sender) smtp.mailfrom=sj@kernel.org; dmarc=pass (policy=quarantine) header.from=kernel.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1751832030; a=rsa-sha256; cv=none; b=aRCEqgHLH45zB/NJr5Nn8CoLqYcjZILPIyagKiRfk8ehL4CeDv7ZvK6b1njQj9ln+HGygX mBA9/DGefLpxgE5tT8jOWQXDjE/xKoUtrSJmi3bOqryhXuXujBQWZZYvORhnEX+I6oAfrY NSYzD8UcFpEM8xSIK1j+KKHmxYnBbzQ= Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by nyc.source.kernel.org (Postfix) with ESMTP id 796DCA53E0B; Sun, 6 Jul 2025 20:00:29 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 23B73C4CEF1; Sun, 6 Jul 2025 20:00:29 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1751832029; bh=fAIXtGREPARQvCC1/X313DQcYGh4YYVNrncF7IRNX5A=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=UXdaIZkNlkgZ1r227EoMFkd/phUYdd18Gs4t6OMVdKw9jA/2XC8RQwJT54vFPN+3g pWlz8hbAcTv/weQ62NPfEDEzkE2tcZSP7QazS6zidY8eKdCjpFLDx951laieehu33L mMwPs9QOm4lZqmgOZwYajcCWfnYrHu1lDF7fAJAel86dZySEG+TQhZYhJHuSQnjI4I nh20kKvS6ahdi8AYjYEl2JfqxA/4eR7OFuWFwrZmJY5ciL+rxRAWu2x1BKzizPTcLb GOeLJf3RGLTlKxj9JX5+bgIq9S+7vJl83ILJ2ylz4MEjSESHwEwb18Y3+qZpi1RltU 6UKa6++4gD1+A== From: SeongJae Park To: Cc: SeongJae Park , Andrew Morton , damon@lists.linux.dev, kernel-team@meta.com, linux-kernel@vger.kernel.org, linux-mm@kvack.org Subject: [RFC PATCH 04/14] mm/damon/reclaim: use damon_call() repeat mode instead of damon_callback Date: Sun, 6 Jul 2025 13:00:08 -0700 Message-Id: <20250706200018.42704-5-sj@kernel.org> X-Mailer: git-send-email 2.39.5 In-Reply-To: <20250706200018.42704-1-sj@kernel.org> References: <20250706200018.42704-1-sj@kernel.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Stat-Signature: de5tyodcpycgihte5zzg7su3zjn1j6u3 X-Rspamd-Queue-Id: 008434000C X-Rspam-User: X-Rspamd-Server: rspam07 X-HE-Tag: 1751832029-640252 X-HE-Meta: U2FsdGVkX1/oQBpWeGotMznKkYsaoe2g+qrHX4yHJ2oMcDyAxbarqKiIBEfEU+aXFfOma61nXsbvvAVhAmS9YAUyJRjsFSTzLsfpOzhk246Jmfs4JI0I2OJ/ys5QkeM26gj6KaOfmjpzpAxuoPejO8jtHCuWXlRiGE57n4RbPeJU2JOFEKtKV2qh9ifoCwFEpTO7/aiOHweHMQ/JA0Rt/MMfPrFLy8/PyzCzL9XlGB7LZ0PRBzxvwM6kzdpkbGyM2SixGLQCr4vErpwYaVFFi9pv4i6aXL/MbvOXrEt3RGqDrJlAYHsk0wP9kSh3Tb/svYTzsDlLao2OZmoSqxfgzbtFxEiGp5j6F4SUj7lFZjC6Hst28ondbF3QdQiYBQjrLQNMfuihOsdpHyXd5yhRRrbKSec9FWPEywCEI8w6u+NGxA5XvNqABSprXnFcxg3uZZ96vCVnT8ojIsvX6t/as+TZzHFEFlJlxCr8t9xkysRxUjq1eBV69gvi+GXNURQ8Kpf8G2lzbsNnm63U+XgAEnO37kSciajUHE94YOhGakZV1ZLGBVlaGh5xTGY4L9FU1vqKSig/IK6Nhd5j+ElGjTl0APPFDbbqFLG7jXAjOMuZ1zPOzJDRtoxt/2JUVuQdhBBsuaE9VjVIiZ8hif4cpt8X6gPKl/+k0ZdBEcJCC3VTJorCr3Y7ixw+G7+29jvDLso4f78aa6/sad+PKAvhdUBeiT24h4PeB4lNn/mjyLfYPPl59+TJ6kcCEVg0V+/xMpWvpaVrrg+Pky0g6n0zVCfp3QSCs5v7vdufLX0BSFoXGOYm/SwbIYkdKLnJSYDd662d22/tMTEPeTAdYErfmhQDFdo23kfsa+nDJZyQkVJTQw8g9jpQJEyrC4YsM6X35GK/NxOxXwc6MZwLdaooK2un3KENGKSdxDnXY6U7OGahqNmZN73VC12AVEjmanpW62RQZsynIxblwHnVMSa g/t8alFe 6wn/4CSdDG7LmaBL+Ln5nnF2B0qH1ZzlG5ez7T9gAopYqlSgJz/X+gLlvy86+CaUDWjZLH+HxV4GIdpXJeTiTXoE7XltffFwPya7r8/c9LzE8ZYuOFFToU9C8td6mfVdbMovz8KRZAxE534zgc4TgASc+gxDsnP9c1Rp2IAPVCuKOVh/wXx8xuY+Wa+HemMoTdQicmIcXfkRt9hpA1Ga7sL4gd0MtJQ3kZZlw5r8kcsKZ7zkdO1VehW3w1/Qibg9yVYxB79h0q2Kcu6XGUU32NQupHA== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: DAMON_RECLAIM uses damon_callback for periodically reading and writing DAMON internal data and parameters. Use its alternative, damon_call() repeat mode. Signed-off-by: SeongJae Park --- mm/damon/reclaim.c | 62 +++++++++++++++++++++++----------------------- 1 file changed, 31 insertions(+), 31 deletions(-) diff --git a/mm/damon/reclaim.c b/mm/damon/reclaim.c index 0fe8996328b8..3c71b4596676 100644 --- a/mm/damon/reclaim.c +++ b/mm/damon/reclaim.c @@ -238,6 +238,35 @@ static int damon_reclaim_apply_parameters(void) return err; } +static int damon_reclaim_handle_commit_inputs(void) +{ + int err; + + if (!commit_inputs) + return 0; + + err = damon_reclaim_apply_parameters(); + commit_inputs = false; + return err; +} + +static int damon_reclaim_damon_call_fn(void *arg) +{ + struct damon_ctx *c = arg; + struct damos *s; + + /* update the stats parameter */ + damon_for_each_scheme(s, c) + damon_reclaim_stat = s->stat; + + return damon_reclaim_handle_commit_inputs(); +} + +static struct damon_call_control call_control = { + .fn = damon_reclaim_damon_call_fn, + .repeat = true, +}; + static int damon_reclaim_turn(bool on) { int err; @@ -257,7 +286,7 @@ static int damon_reclaim_turn(bool on) if (err) return err; kdamond_pid = ctx->kdamond->pid; - return 0; + return damon_call(ctx, &call_control); } static int damon_reclaim_enabled_store(const char *val, @@ -296,34 +325,6 @@ module_param_cb(enabled, &enabled_param_ops, &enabled, 0600); MODULE_PARM_DESC(enabled, "Enable or disable DAMON_RECLAIM (default: disabled)"); -static int damon_reclaim_handle_commit_inputs(void) -{ - int err; - - if (!commit_inputs) - return 0; - - err = damon_reclaim_apply_parameters(); - commit_inputs = false; - return err; -} - -static int damon_reclaim_after_aggregation(struct damon_ctx *c) -{ - struct damos *s; - - /* update the stats parameter */ - damon_for_each_scheme(s, c) - damon_reclaim_stat = s->stat; - - return damon_reclaim_handle_commit_inputs(); -} - -static int damon_reclaim_after_wmarks_check(struct damon_ctx *c) -{ - return damon_reclaim_handle_commit_inputs(); -} - static int __init damon_reclaim_init(void) { int err = damon_modules_new_paddr_ctx_target(&ctx, &target); @@ -331,8 +332,7 @@ static int __init damon_reclaim_init(void) if (err) goto out; - ctx->callback.after_wmarks_check = damon_reclaim_after_wmarks_check; - ctx->callback.after_aggregation = damon_reclaim_after_aggregation; + call_control.data = ctx; /* 'enabled' has set before this function, probably via command line */ if (enabled) -- 2.39.5