From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7BAC8C83F0A for ; Sun, 6 Jul 2025 20:00:43 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 2A7B36B03FF; Sun, 6 Jul 2025 16:00:34 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 27F906B0400; Sun, 6 Jul 2025 16:00:34 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 148186B0401; Sun, 6 Jul 2025 16:00:34 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id EE0556B03FF for ; Sun, 6 Jul 2025 16:00:33 -0400 (EDT) Received: from smtpin07.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id B8FC51D7F04 for ; Sun, 6 Jul 2025 20:00:33 +0000 (UTC) X-FDA: 83634907146.07.B4439F2 Received: from nyc.source.kernel.org (nyc.source.kernel.org [147.75.193.91]) by imf25.hostedemail.com (Postfix) with ESMTP id 3718AA000D for ; Sun, 6 Jul 2025 20:00:32 +0000 (UTC) Authentication-Results: imf25.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=Hu3ELqqO; spf=pass (imf25.hostedemail.com: domain of sj@kernel.org designates 147.75.193.91 as permitted sender) smtp.mailfrom=sj@kernel.org; dmarc=pass (policy=quarantine) header.from=kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1751832032; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=kFzhhywzA2Lyz+Kvv9RAmWbvM2wZutIX38R1MMsDsKg=; b=06/frmt5aAtzdwI2PZDhzCGPj1nA8pq/lOcJUc2cMx+S8KxJZyL48YYR12pN1AUrr6FMkK kJUizLgoJTjNigwpSd21sy2dAmxwtLardEFKTyL3JHesgtf16HPgcjnvWToLCuyORlhij4 bhVoS+goOjVEW1U664ZmIe/2ctgsddo= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1751832032; a=rsa-sha256; cv=none; b=lx5iUg5Y6hIcoqRuVcz6n5X70KVO1x037Ii5hxpfpMzdEgZ22SWSfJ4lSjRiz1ofA6V0K4 JvVtJyEiVWTVqgKMGhj69s4hfwHB3zO3AXGKUkYaR2cW4W3i536LGcj5l4xBXtuTX5w9N0 sPHEpWvy+z1QcAMr+JhqgIess+UtZc4= ARC-Authentication-Results: i=1; imf25.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=Hu3ELqqO; spf=pass (imf25.hostedemail.com: domain of sj@kernel.org designates 147.75.193.91 as permitted sender) smtp.mailfrom=sj@kernel.org; dmarc=pass (policy=quarantine) header.from=kernel.org Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by nyc.source.kernel.org (Postfix) with ESMTP id 8D166A53E0B; Sun, 6 Jul 2025 20:00:31 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 3E16CC4CEF4; Sun, 6 Jul 2025 20:00:31 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1751832031; bh=4rlUnM41KWHBb9R2GQY7K2cpSu4qxxjH6BI9hmtiRvY=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=Hu3ELqqOgQHEt+keoQhLPdyX8rut4DuHulVn/8mGyUWEU/HoEV6x7HOW6LB+FYDxV 5mBnMfXjCCSZvmMuV46mqNk836kS5ydl+Gm9Q/V6JwwrqTVZxa22zKsnQaoGo/Wi/W H1uGWeVHQL9LQUONWb8bQoLI3KwTW/qfwaV2RMQ45ZdeTQ2v+CmihTF1JJsAMlyBXx mWz0h35MWeAD7m6knzzPSJWx6J0VvPwy8TR7lH0JBgPwawURzjjeNkl9efYwGnM4aU +aX8gaCSCNOP2RQgVjjXYj53/6Z1U+euVEuQstT3bMIOy1d/fCpkBqMhTw3dNHsC3X lQbxy0NE8l+Qw== From: SeongJae Park To: Cc: SeongJae Park , Andrew Morton , damon@lists.linux.dev, kernel-team@meta.com, linux-kernel@vger.kernel.org, linux-mm@kvack.org Subject: [RFC PATCH 06/14] samples/damon/prcl: use damon_call() repeat mode instead of damon_callback Date: Sun, 6 Jul 2025 13:00:10 -0700 Message-Id: <20250706200018.42704-7-sj@kernel.org> X-Mailer: git-send-email 2.39.5 In-Reply-To: <20250706200018.42704-1-sj@kernel.org> References: <20250706200018.42704-1-sj@kernel.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Rspam-User: X-Rspamd-Server: rspam12 X-Rspamd-Queue-Id: 3718AA000D X-Stat-Signature: 7jhxqj983hqpsyhpxhn8pifc5syunrka X-HE-Tag: 1751832031-607467 X-HE-Meta: U2FsdGVkX1//lm6latsCMKJ+WkNMqU5F/cekc7r7dHjymDJG89KorxgUQFQ4Ga0Qv4XdWlXh95k3D7DLKT75xsXLlgRsn+DCIEyyle/zj/Wtu9zDPd6RykotKrrcCL2CT0bgThLmOG1mQehJ3YRR1qP0QFBDorc9I4zKAVeNmf11tJJt0Ny9A17g9YE5JCvpCyWIYo6/TDkPtrMK5qqUiXSRtb7Dr53+rKAfMR6s2C0m4qiftPzwF5t+we7qVcfk+2xqHpu7CYiAiVwhMa/mQloqKjEtjhh6XINLFAHHOmy7YpxgVGPQ6NGhdAh2MeWCa3/Y7fmfVjCr7xsxhid8NHx/ymPbV387w2uNOOI2nNCV3b/tchI60VOYHnihPYKpQ6fU6rujk3/YqwfppOXpXUd6/6/2xlhdxAgsUcs3gTAgVoe3SHYp9jvD3BsRw3a+7gUppIVKe3aGLy2+hVcGfA9zYvZI0W0WHQVgkzcuBulC/LdKwkh9e4sAfEHmIu1k1PJgsSB36bOoBBHRzFpzR1BGCoaUGJdjnBlaf8wLE0RvTsCXWhG25FHyu5VJk1ODjlTJM6gDW69Gs0+aNt0yk+ckt4HxKF4w6TuEBl7yrCmYJtsTCnn0IlBsyELtVnQmTzfeL6nVGXsh4773E8c76UvGO6lqe0O4dBMH0jTjiL6B0Ui3RcywOpNQkOtFexDw603vcfErd1uF2yVjreYdKzh78oWvIaY1WZxwl46n5CH8OGA5bNlNp+afh0wDxhv8xNvqUM+Oi4h95UtUAXcvWAALGhhsjZfZAruRbpyR2uGOv23LQQHaa57oOlxkBKrTowPQJKoqhbEVHBO2oWGCtOlyOg6fcLf42sgck9gvEBHlL3ClTQX4pnWD4wecPwiPAFQS05okxZduHNoJEVZz3VIDLWGMqPEfdbISjrjVKFL81RzxbX1VcYl5Nr5XBr+gRStGmNMN6uaS7TY5qr+ X3C8AL/p nE+OkyVeq0/eywMSdWBy4GqOl1SjQIteXtQE+SqdzaPC5LiEMovXnhAK/MyeRXPO0N/STdN+hQOzyLx9e7v9FqGwH3GLeOwZ4j4E0ZvhM81FJ1Ck0u134MxfJaBsU6jHywf2V30emVaDgaw37GA57152lKMbTBsdKevMmrfDJQcacKn8c7aDUIjkyJAlRi+YGWEY3hNELbxBTPp/JtWM/rsTExigqFBqFZ3JmYfKwwoe2sz7MemqjQpS7iD4k7McvtMgwm8S0/c28kD1uQY9fP+wgWBJdO+yZ5UeNhxe7G3b8Sb56vqL/0YFlYw== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: prcl uses damon_callback for periodically reading DAMON internal data. Use its alternative, damon_call() repeat mode. Signed-off-by: SeongJae Park --- samples/damon/prcl.c | 18 ++++++++++++++---- 1 file changed, 14 insertions(+), 4 deletions(-) diff --git a/samples/damon/prcl.c b/samples/damon/prcl.c index d70f47924720..d3215699a5f4 100644 --- a/samples/damon/prcl.c +++ b/samples/damon/prcl.c @@ -34,8 +34,9 @@ MODULE_PARM_DESC(enable, "Enable of disable DAMON_SAMPLE_WSSE"); static struct damon_ctx *ctx; static struct pid *target_pidp; -static int damon_sample_prcl_after_aggregate(struct damon_ctx *c) +static int damon_sample_prcl_repeat_call_fn(void *data) { + struct damon_ctx *c = data; struct damon_target *t; damon_for_each_target(t, c) { @@ -51,10 +52,16 @@ static int damon_sample_prcl_after_aggregate(struct damon_ctx *c) return 0; } +static struct damon_call_control repeat_call_control = { + .fn = damon_sample_prcl_repeat_call_fn, + .repeat = true, +}; + static int damon_sample_prcl_start(void) { struct damon_target *target; struct damos *scheme; + int err; pr_info("start\n"); @@ -79,8 +86,6 @@ static int damon_sample_prcl_start(void) } target->pid = target_pidp; - ctx->callback.after_aggregation = damon_sample_prcl_after_aggregate; - scheme = damon_new_scheme( &(struct damos_access_pattern) { .min_sz_region = PAGE_SIZE, @@ -100,7 +105,12 @@ static int damon_sample_prcl_start(void) } damon_set_schemes(ctx, &scheme, 1); - return damon_start(&ctx, 1, true); + err = damon_start(&ctx, 1, true); + if (err) + return err; + + repeat_call_control.data = ctx; + return damon_call(ctx, &repeat_call_control); } static void damon_sample_prcl_stop(void) -- 2.39.5