linux-mm.kvack.org archive mirror
 help / color / mirror / Atom feed
From: "Pankaj Raghav (Samsung)" <kernel@pankajraghav.com>
To: Suren Baghdasaryan <surenb@google.com>,
	Ryan Roberts <ryan.roberts@arm.com>,
	Baolin Wang <baolin.wang@linux.alibaba.com>,
	Borislav Petkov <bp@alien8.de>, Ingo Molnar <mingo@redhat.com>,
	"H . Peter Anvin" <hpa@zytor.com>,
	Vlastimil Babka <vbabka@suse.cz>, Zi Yan <ziy@nvidia.com>,
	Mike Rapoport <rppt@kernel.org>,
	Dave Hansen <dave.hansen@linux.intel.com>,
	Michal Hocko <mhocko@suse.com>,
	David Hildenbrand <david@redhat.com>,
	Lorenzo Stoakes <lorenzo.stoakes@oracle.com>,
	Andrew Morton <akpm@linux-foundation.org>,
	Thomas Gleixner <tglx@linutronix.de>,
	Nico Pache <npache@redhat.com>, Dev Jain <dev.jain@arm.com>,
	"Liam R . Howlett" <Liam.Howlett@oracle.com>,
	Jens Axboe <axboe@kernel.dk>
Cc: linux-kernel@vger.kernel.org, willy@infradead.org,
	linux-mm@kvack.org, x86@kernel.org, linux-block@vger.kernel.org,
	linux-fsdevel@vger.kernel.org,
	"Darrick J . Wong" <djwong@kernel.org>,
	mcgrof@kernel.org, gost.dev@samsung.com, kernel@pankajraghav.com,
	hch@lst.de, Pankaj Raghav <p.raghav@samsung.com>
Subject: [PATCH v2 2/5] huge_memory: add huge_zero_page_shrinker_(init|exit) function
Date: Mon,  7 Jul 2025 16:23:16 +0200	[thread overview]
Message-ID: <20250707142319.319642-3-kernel@pankajraghav.com> (raw)
In-Reply-To: <20250707142319.319642-1-kernel@pankajraghav.com>

From: Pankaj Raghav <p.raghav@samsung.com>

Add huge_zero_page_shrinker_init() and huge_zero_page_shrinker_exit().
As shrinker will not be needed when static PMD zero page is enabled,
these two functions can be a no-op.

This is a preparation patch for static PMD zero page. No functional
changes.

Signed-off-by: Pankaj Raghav <p.raghav@samsung.com>
---
 mm/huge_memory.c | 38 +++++++++++++++++++++++++++-----------
 1 file changed, 27 insertions(+), 11 deletions(-)

diff --git a/mm/huge_memory.c b/mm/huge_memory.c
index d3e66136e41a..101b67ab2eb6 100644
--- a/mm/huge_memory.c
+++ b/mm/huge_memory.c
@@ -289,6 +289,24 @@ static unsigned long shrink_huge_zero_page_scan(struct shrinker *shrink,
 }
 
 static struct shrinker *huge_zero_page_shrinker;
+static int huge_zero_page_shrinker_init(void)
+{
+	huge_zero_page_shrinker = shrinker_alloc(0, "thp-zero");
+	if (!huge_zero_page_shrinker)
+		return -ENOMEM;
+
+	huge_zero_page_shrinker->count_objects = shrink_huge_zero_page_count;
+	huge_zero_page_shrinker->scan_objects = shrink_huge_zero_page_scan;
+	shrinker_register(huge_zero_page_shrinker);
+	return 0;
+}
+
+static void huge_zero_page_shrinker_exit(void)
+{
+	shrinker_free(huge_zero_page_shrinker);
+	return;
+}
+
 
 #ifdef CONFIG_SYSFS
 static ssize_t enabled_show(struct kobject *kobj,
@@ -850,33 +868,31 @@ static inline void hugepage_exit_sysfs(struct kobject *hugepage_kobj)
 
 static int __init thp_shrinker_init(void)
 {
-	huge_zero_page_shrinker = shrinker_alloc(0, "thp-zero");
-	if (!huge_zero_page_shrinker)
-		return -ENOMEM;
+	int ret = 0;
 
 	deferred_split_shrinker = shrinker_alloc(SHRINKER_NUMA_AWARE |
 						 SHRINKER_MEMCG_AWARE |
 						 SHRINKER_NONSLAB,
 						 "thp-deferred_split");
-	if (!deferred_split_shrinker) {
-		shrinker_free(huge_zero_page_shrinker);
+	if (!deferred_split_shrinker)
 		return -ENOMEM;
-	}
-
-	huge_zero_page_shrinker->count_objects = shrink_huge_zero_page_count;
-	huge_zero_page_shrinker->scan_objects = shrink_huge_zero_page_scan;
-	shrinker_register(huge_zero_page_shrinker);
 
 	deferred_split_shrinker->count_objects = deferred_split_count;
 	deferred_split_shrinker->scan_objects = deferred_split_scan;
 	shrinker_register(deferred_split_shrinker);
 
+	ret = huge_zero_page_shrinker_init();
+	if (ret) {
+		shrinker_free(deferred_split_shrinker);
+		return ret;
+	}
+
 	return 0;
 }
 
 static void __init thp_shrinker_exit(void)
 {
-	shrinker_free(huge_zero_page_shrinker);
+	huge_zero_page_shrinker_exit();
 	shrinker_free(deferred_split_shrinker);
 }
 
-- 
2.49.0



  parent reply	other threads:[~2025-07-07 14:23 UTC|newest]

Thread overview: 40+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-07-07 14:23 [PATCH v2 0/5] add static PMD zero page support Pankaj Raghav (Samsung)
2025-07-07 14:23 ` [PATCH v2 1/5] mm: move huge_zero_page declaration from huge_mm.h to mm.h Pankaj Raghav (Samsung)
2025-07-15 14:08   ` Lorenzo Stoakes
2025-07-16  7:47     ` Pankaj Raghav (Samsung)
2025-07-16 15:24       ` David Hildenbrand
2025-07-07 14:23 ` Pankaj Raghav (Samsung) [this message]
2025-07-15 14:18   ` [PATCH v2 2/5] huge_memory: add huge_zero_page_shrinker_(init|exit) function David Hildenbrand
2025-07-16  8:01     ` Pankaj Raghav (Samsung)
2025-07-15 14:29   ` Lorenzo Stoakes
2025-07-16  8:08     ` Pankaj Raghav (Samsung)
2025-07-07 14:23 ` [PATCH v2 3/5] mm: add static PMD zero page Pankaj Raghav (Samsung)
2025-07-15 14:21   ` David Hildenbrand
2025-07-15 14:53     ` David Hildenbrand
2025-07-17 10:34       ` Pankaj Raghav (Samsung)
2025-07-17 11:46         ` David Hildenbrand
2025-07-17 12:07           ` Pankaj Raghav (Samsung)
2025-07-15 15:26   ` Lorenzo Stoakes
2025-07-07 14:23 ` [PATCH v2 4/5] mm: add largest_zero_folio() routine Pankaj Raghav (Samsung)
2025-07-15 14:16   ` David Hildenbrand
2025-07-15 14:46     ` David Hildenbrand
2025-07-15 16:13   ` Lorenzo Stoakes
2025-07-07 14:23 ` [PATCH v2 5/5] block: use largest_zero_folio in __blkdev_issue_zero_pages() Pankaj Raghav (Samsung)
2025-07-15 16:19   ` Lorenzo Stoakes
2025-07-16 13:24     ` Pankaj Raghav (Samsung)
2025-07-07 18:06 ` [PATCH v2 0/5] add static PMD zero page support Zi Yan
2025-07-09  8:03   ` Pankaj Raghav
2025-07-09 15:55     ` Zi Yan
2025-07-15 14:02     ` Lorenzo Stoakes
2025-07-15 14:06       ` David Hildenbrand
2025-07-15 14:12         ` Lorenzo Stoakes
2025-07-15 14:16           ` David Hildenbrand
2025-07-15 15:25             ` Pankaj Raghav (Samsung)
2025-07-15 15:27               ` David Hildenbrand
2025-07-07 22:38 ` Andrew Morton
2025-07-09  9:59   ` Pankaj Raghav
2025-07-15 14:15   ` David Hildenbrand
2025-07-15 13:53 ` Pankaj Raghav
2025-07-15 14:04 ` Lorenzo Stoakes
2025-07-15 15:34 ` Lorenzo Stoakes
2025-07-17 10:43   ` Pankaj Raghav (Samsung)

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250707142319.319642-3-kernel@pankajraghav.com \
    --to=kernel@pankajraghav.com \
    --cc=Liam.Howlett@oracle.com \
    --cc=akpm@linux-foundation.org \
    --cc=axboe@kernel.dk \
    --cc=baolin.wang@linux.alibaba.com \
    --cc=bp@alien8.de \
    --cc=dave.hansen@linux.intel.com \
    --cc=david@redhat.com \
    --cc=dev.jain@arm.com \
    --cc=djwong@kernel.org \
    --cc=gost.dev@samsung.com \
    --cc=hch@lst.de \
    --cc=hpa@zytor.com \
    --cc=linux-block@vger.kernel.org \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=lorenzo.stoakes@oracle.com \
    --cc=mcgrof@kernel.org \
    --cc=mhocko@suse.com \
    --cc=mingo@redhat.com \
    --cc=npache@redhat.com \
    --cc=p.raghav@samsung.com \
    --cc=rppt@kernel.org \
    --cc=ryan.roberts@arm.com \
    --cc=surenb@google.com \
    --cc=tglx@linutronix.de \
    --cc=vbabka@suse.cz \
    --cc=willy@infradead.org \
    --cc=x86@kernel.org \
    --cc=ziy@nvidia.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).