From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 60B0BC71130 for ; Mon, 7 Jul 2025 22:38:50 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id AFFAE8D0005; Mon, 7 Jul 2025 18:38:49 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id AB0AC8D0002; Mon, 7 Jul 2025 18:38:49 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 9C67D8D0005; Mon, 7 Jul 2025 18:38:49 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 8DF2F8D0002 for ; Mon, 7 Jul 2025 18:38:49 -0400 (EDT) Received: from smtpin02.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 3AE641289CE for ; Mon, 7 Jul 2025 22:38:49 +0000 (UTC) X-FDA: 83638934778.02.757BFB2 Received: from sea.source.kernel.org (sea.source.kernel.org [172.234.252.31]) by imf19.hostedemail.com (Postfix) with ESMTP id 79AFB1A0011 for ; Mon, 7 Jul 2025 22:38:47 +0000 (UTC) Authentication-Results: imf19.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=korg header.b=YSAw3x7U; spf=pass (imf19.hostedemail.com: domain of akpm@linux-foundation.org designates 172.234.252.31 as permitted sender) smtp.mailfrom=akpm@linux-foundation.org; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1751927927; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=kwfDenBnk4G0ptWxqE37DmHqihdxH/AimgsIzGyfnf0=; b=yXv7OjHnb9Mxk0A46xNdeXzi/ePdf4P3An5kD8xVw8kvS8Cv5BsL+sySEjq7pnSkd1jCPt kl5Yv28uSLmik35Mp22N0mk7Aur5EA7u7qjuJrEsAGs2esPT/PhPioH4kT7hM0VU7OBQz3 gSpb/58x9VDIA7P0E4HtuvBp4biqM40= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1751927927; a=rsa-sha256; cv=none; b=Dwu95x9mr300c59KS850XK89amH6aBa3Fz6Z00693Ac2MIxuqvSlVXBhZgSYmazhvkcidC 0z/hK4aE/0uevAzCAXMPp/MDPfxNDn52vcthPj5qYVl1P780u9vslKWx0rT3rup2TBIuCo gWNL/asPzaeFVKZiWaEChqhvAULhf4M= ARC-Authentication-Results: i=1; imf19.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=korg header.b=YSAw3x7U; spf=pass (imf19.hostedemail.com: domain of akpm@linux-foundation.org designates 172.234.252.31 as permitted sender) smtp.mailfrom=akpm@linux-foundation.org; dmarc=none Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by sea.source.kernel.org (Postfix) with ESMTP id 0E17D452CE; Mon, 7 Jul 2025 22:38:46 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 0BE78C4CEE3; Mon, 7 Jul 2025 22:38:45 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linux-foundation.org; s=korg; t=1751927925; bh=ZHXT1F7ky+DycoXihHKVXqJluWPUcKdBjSeD3GvA/+A=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=YSAw3x7U+rLv0xQ3x1tri6xBUf3RSx1Lf09XEKM6xTP3BH2qsTDBNFS46u3XnaNg7 F4nv5BPXF743X+05Ox8CW1NTguMNSbS2F7UYzJeoNGhMT2QT2DwZ34fcAWUiQwwVKX RWG3UPR0cQrbhw01mez3XDUz/hs/isiqUlz5mBuA= Date: Mon, 7 Jul 2025 15:38:44 -0700 From: Andrew Morton To: "Pankaj Raghav (Samsung)" Cc: Suren Baghdasaryan , Ryan Roberts , Baolin Wang , Borislav Petkov , Ingo Molnar , "H . Peter Anvin" , Vlastimil Babka , Zi Yan , Mike Rapoport , Dave Hansen , Michal Hocko , David Hildenbrand , Lorenzo Stoakes , Thomas Gleixner , Nico Pache , Dev Jain , "Liam R . Howlett" , Jens Axboe , linux-kernel@vger.kernel.org, willy@infradead.org, linux-mm@kvack.org, x86@kernel.org, linux-block@vger.kernel.org, linux-fsdevel@vger.kernel.org, "Darrick J . Wong" , mcgrof@kernel.org, gost.dev@samsung.com, hch@lst.de, Pankaj Raghav Subject: Re: [PATCH v2 0/5] add static PMD zero page support Message-Id: <20250707153844.d868f7cfe16830cce66f3929@linux-foundation.org> In-Reply-To: <20250707142319.319642-1-kernel@pankajraghav.com> References: <20250707142319.319642-1-kernel@pankajraghav.com> X-Mailer: Sylpheed 3.7.0 (GTK+ 2.24.33; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Rspam-User: X-Rspamd-Server: rspam08 X-Rspamd-Queue-Id: 79AFB1A0011 X-Stat-Signature: f1kmmx97mydzmsw81kg6bk7krx7hrn6x X-HE-Tag: 1751927927-533582 X-HE-Meta: U2FsdGVkX19PmRpMG2j9GRawzbotW+7qppO6A4gG4U5+HD0+YM1pH0JihcOgrXx3ef+UyXtfjod4QrnKpMPVCRi16bhIQq6yfqjHsLu5D+/2znx6lE082rfjeULyj5c9XDs3XzdlGZqDLzC/NhH1Wndjdl2rT432FcIuyhvYkXSBW1QIA9CyC8PkdVySptAtDgxC2xT/r52OxF1kpaMpDsm8rteO/I/etqvFB9HG1m+0zDQAGxk3Z9bqn35rpmaO4jPL6AoTKqePOlqIzm/D42s2i0do9T52booJY6TLky0e3qBaBeHzj5hEup99Z6Fb9KMjxHdM5eexYdy8V/P6kqJW7tgAVjUOlvBmf5SsyMnVvGBG9stWcyieODJGEsNZwQQZBpNAj9eXDBev4z91R8mexLPKPmr9XChwWTC0YCHzI2nXzO/arFRcWr/X8pEY/fPsIfAhNuwomQ7c7YwCulxOg7NKRKfcJmP5+qM4vIHnfyG9Y9Wo5yrS7jxzJv3WTHauKrSVAFEVJEEK8ogruemMuVr7YW/K58rW5tZMFM7GY3L/AD7HrDkHautVmS7oJiAa88yuJDzeiU+zPIK/UP78fuc2q9VsuaQTxG94TJ+29e/eQB64+AeGa7ygm7ukLzi8pVyFxVPSv0RiM/MEKZgjeC4JvcOgS3+Bh/2AaoeFZSpwIoB2eusPXKfQiNFRwmpT3dmXO4xQrqnzqvilTILSUiP9PZJ0k7ItQO7Kw2BPt+pQCubm+wB9SrznqERSOu7ZXk4xuNJkesCUW5+BZbUMsI0NEpZD5iu+xFDF7gGoGQmcLYi42AOjNJp1G84oOxGWITYgF9EPaMg7Gkseo5VT6tmCqsYVlGLSTibZvvNwP7WnA4WZepNqsVLAMLhSO0AiX4VMwm58aKNduM/DHnzBJXwbQLtSt1H0aGAkZBEZW/ycX4BZDNAVgah7dtj8hm+Sx8zVXBHh+IVNb2O f67quDTc NHoY6tfRPreVY87bn1NWHj+K20JK9J1gF0k9XM1osW7/zNlYXnb2KOqDnvaOh9j7SI6PdFw5tXXkWmdLaEnmIrnMyvYzUU/0/R0oeuuGWuegGCD8Icz+u0AOivko1b/3m6JLgUKIa4N5TScHlVfkp5LAUcZHumAMC+Ktr3k0ZK9zF/+o13yTtC6yiwD7rgn7GUVLBOSOpQEEBchghsLu/D3iyOjRsBSI2y3IkTSwwnE+iQpomMvchSuZP8eT3powdheGUYNQN8TItV/HV0LE57169palAQG3+eG0qYnmLAW6e4IEZoH1jYGRFrQ== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Mon, 7 Jul 2025 16:23:14 +0200 "Pankaj Raghav (Samsung)" wrote: > There are many places in the kernel where we need to zeroout larger > chunks but the maximum segment we can zeroout at a time by ZERO_PAGE > is limited by PAGE_SIZE. > > This concern was raised during the review of adding Large Block Size support > to XFS[1][2]. > > This is especially annoying in block devices and filesystems where we > attach multiple ZERO_PAGEs to the bio in different bvecs. With multipage > bvec support in block layer, it is much more efficient to send out > larger zero pages as a part of a single bvec. > > Some examples of places in the kernel where this could be useful: > - blkdev_issue_zero_pages() > - iomap_dio_zero() > - vmalloc.c:zero_iter() > - rxperf_process_call() > - fscrypt_zeroout_range_inline_crypt() > - bch2_checksum_update() > ... > > We already have huge_zero_folio that is allocated on demand, and it will be > deallocated by the shrinker if there are no users of it left. > > At moment, huge_zero_folio infrastructure refcount is tied to the process > lifetime that created it. This might not work for bio layer as the completions > can be async and the process that created the huge_zero_folio might no > longer be alive. Can we change that? Alter the refcounting model so that dropping the final reference at interrupt time works as expected? And if we were to do this, what sort of benefit might it produce? > Add a config option STATIC_PMD_ZERO_PAGE that will always allocate > the huge_zero_folio via memblock, and it will never be freed.