From: SeongJae Park <sj@kernel.org>
To: Honggyu Kim <honggyu.kim@sk.com>
Cc: SeongJae Park <sj@kernel.org>,
damon@lists.linux.dev, Andrew Morton <akpm@linux-foundation.org>,
linux-mm@kvack.org, kernel_team@skhynix.com
Subject: Re: [PATCH mm-new] samples/damon: change enable parameters to enabled
Date: Mon, 7 Jul 2025 09:15:36 -0700 [thread overview]
Message-ID: <20250707161536.85426-1-sj@kernel.org> (raw)
In-Reply-To: <20250707024548.1964-1-honggyu.kim@sk.com>
On Mon, 7 Jul 2025 11:45:47 +0900 Honggyu Kim <honggyu.kim@sk.com> wrote:
> The damon_{lru_sort,reclaim,stat} kernel modules use "enabled"
> parameter knobs as follows.
>
> /sys/module/damon_lru_sort/parameters/enabled
> /sys/module/damon_reclaim/parameters/enabled
> /sys/module/damon_stat/parameters/enabled
>
> However, other sample modules of damon use "enable" parameter knobs so
> it'd be better to rename them from "enable" to "enabled" to keep the
> consistency with other damon modules.
>
> Before:
> /sys/module/damon_sample_wsse/parameters/enable
> /sys/module/damon_sample_prcl/parameters/enable
> /sys/module/damon_sample_mtier/parameters/enable
>
> After:
> /sys/module/damon_sample_wsse/parameters/enabled
> /sys/module/damon_sample_prcl/parameters/enabled
> /sys/module/damon_sample_mtier/parameters/enabled
>
> There is no functional changes in this patch.
Looks good to me. But, I cannot apply this on latest mm-new. Could you please
rebase and repost?
>
> Signed-off-by: Honggyu Kim <honggyu.kim@sk.com>
Reviewed-by: SeongJae Park <sj@kernel.org>
Thanks,
SJ
[...]
next prev parent reply other threads:[~2025-07-07 16:15 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-07-07 2:45 [PATCH mm-new] samples/damon: change enable parameters to enabled Honggyu Kim
2025-07-07 16:15 ` SeongJae Park [this message]
2025-07-08 2:01 ` Andrew Morton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250707161536.85426-1-sj@kernel.org \
--to=sj@kernel.org \
--cc=akpm@linux-foundation.org \
--cc=damon@lists.linux.dev \
--cc=honggyu.kim@sk.com \
--cc=kernel_team@skhynix.com \
--cc=linux-mm@kvack.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).