From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id E715CC8303C for ; Tue, 8 Jul 2025 11:00:15 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 6141A6B0329; Tue, 8 Jul 2025 07:00:15 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 5BE166B032B; Tue, 8 Jul 2025 07:00:15 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 4ACB46B032C; Tue, 8 Jul 2025 07:00:15 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 345B66B0329 for ; Tue, 8 Jul 2025 07:00:15 -0400 (EDT) Received: from smtpin23.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id DE86810B420 for ; Tue, 8 Jul 2025 11:00:14 +0000 (UTC) X-FDA: 83640803148.23.8BD169F Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf09.hostedemail.com (Postfix) with ESMTP id 15CBA140015 for ; Tue, 8 Jul 2025 11:00:12 +0000 (UTC) Authentication-Results: imf09.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=uN8tyuqT; spf=pass (imf09.hostedemail.com: domain of leon@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=leon@kernel.org; dmarc=pass (policy=quarantine) header.from=kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1751972413; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=5KW2QIC6jmGHY1Ben2OZlkSykbNXUJ+rne80QQUMlFA=; b=Mcyr+w30b6SRiFCjg058EayX68B7d26SsqscKnQ3y8ux0AtqavNYaRQ/SihQNTWMQKMr95 uGghJdwxN380Q11jVT7p92/J3JWn7+678PDxEf9FMki6M4AFDENhnggsnEZk37KFMh1xyC mbsEXBYBTPey/Bof+WgJmrVB8WDPVaU= ARC-Authentication-Results: i=1; imf09.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=uN8tyuqT; spf=pass (imf09.hostedemail.com: domain of leon@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=leon@kernel.org; dmarc=pass (policy=quarantine) header.from=kernel.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1751972413; a=rsa-sha256; cv=none; b=w5S1PCj6UYte13UkWOBrSl6z+mr4V+rTW6GKC/rfTYy75yD/3XDU1YYJNIv8LvV/BGx4lV 9O3tXMb1RR+nCiyqZMlgu4u15EjlsZuY7OnglfPO3WxD1oU4nPnUd030v4DvMpAXoVg0EH j7mRJFhew9sM2n+WztF7FRHCrvWE2ME= Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id D46E15C5ADD; Tue, 8 Jul 2025 11:00:11 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 91044C4CEED; Tue, 8 Jul 2025 11:00:10 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1751972411; bh=5KL6rrIwnrg38ZqhQ6AB+QdSfe6gyMAir5Sbq2Mfv3w=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=uN8tyuqTvou8o+R/mOO7Yg6n7PNJtUdZ+ZUyob65HmWP0T0yfwWgfI24HMU0r7HN3 Iv/9p5Qz7yq0z6SfYzlZ8O2jah6vPR/66HY1GS8sn0oA5aCV40mCMlXhKGhFKpd9Gw Yph0pSgvARTjakjLBRtoXJw/nf2FE8wmvZmAoLV7nUPfAwX721yMnt+1OjeZvHyC1T bIwx5u1WR+ImqC7oRVd+WsK/GJVIJvuKAO2RfbXeHnmDDi/HpwuTz/p5FXQ0xPx0Ct 90/w7Kne0qNm0Sy8IV//jt9S9XVQk4W6wzdF4ltAHTLfCKmlrEIN9liVg613NYj5yK 29yiJVGsn+RvQ== Date: Tue, 8 Jul 2025 14:00:07 +0300 From: Leon Romanovsky To: Marek Szyprowski Cc: Christoph Hellwig , Jonathan Corbet , Madhavan Srinivasan , Michael Ellerman , Nicholas Piggin , Christophe Leroy , Robin Murphy , Joerg Roedel , Will Deacon , "Michael S. Tsirkin" , Jason Wang , Xuan Zhuo , Eugenio =?iso-8859-1?Q?P=E9rez?= , Alexander Potapenko , Marco Elver , Dmitry Vyukov , Masami Hiramatsu , Mathieu Desnoyers , =?iso-8859-1?B?Suly9G1l?= Glisse , Andrew Morton , linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, iommu@lists.linux.dev, virtualization@lists.linux.dev, kasan-dev@googlegroups.com, linux-trace-kernel@vger.kernel.org, linux-mm@kvack.org, Jason Gunthorpe Subject: Re: [PATCH 0/8] dma-mapping: migrate to physical address-based API Message-ID: <20250708110007.GF592765@unreal> References: <35df6f2a-0010-41fe-b490-f52693fe4778@samsung.com> <20250627170213.GL17401@unreal> <20250630133839.GA26981@lst.de> <69b177dc-c149-40d3-bbde-3f6bad0efd0e@samsung.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <69b177dc-c149-40d3-bbde-3f6bad0efd0e@samsung.com> X-Rspamd-Queue-Id: 15CBA140015 X-Stat-Signature: 7rwnypjmag84rez13kaxbufjrmee9rk4 X-Rspam-User: X-Rspamd-Server: rspam05 X-HE-Tag: 1751972412-363318 X-HE-Meta: U2FsdGVkX19/LfVkF+G+Ci1gDVurgTd43DSr/hVttyCWVLAMjkA/OCeCzlMB9qOwQ/DqRFlmLthZdm+S/J49cl0OAxHlPElZc3pfIzrJu6PRYlxckvdVXomRfhnY3m8Kv+skhlCgUAdl4wVjIz8wy7l2eA3/hu0Db4yZvEjtlFcVO4pwORHIEhz/hP0kRf87hAZ+SDrpBIymgESpwfq7twGtTzvQkbrQXiKAIzBcTExBuj2WF1AJqvstfvf1Uarp+8TPIqw7SGDjw815DDlxwUpnB59W+JLrk8guc1vJAjYodX2nkbEmrwwsL4HedplNTOZZOxhDrY80i1dZd+vcS+mfQPG2CqzD13Haw32IwX+1mmleV8TIqtnYx5tfLjjSCejCZvrnfVsdmqdk0+vA+jMHxoFO1GANGFvNzTIdKR4yvKjLOzlFcHKZKJSCeh9E0U8Q6PB2g+0x0nNXi0cv4TAnqQSYAQF9ewb/5zLm2qEQhyUGLkXbI4RrxbQcolN5eJC6HVkbqIGTMo+9NG06Y3QaAA+kJfAsnOgO5nl7xpgG0PLIgCpAyr5bbQREj/4nrk46fwcaFh/MsBZitVhuBBuffSFuJtvDopdlccH7lGEUnVgd2M7wf/Dizb2dlTrcNTzgyUwWKTGFvDaz95hIynAfmJBFhzz4RlsOWvn/7gGJp+EHZRIDUIB2xkmivjKRcCUQFuTAscCc/ckGA5wXinvkJxDYBEedTwx1TJ4nEjy6ccoaCYSsD9G+uL+lpO1Wvb0crXyTNsC91U51G0dh3Rp2U8vIodp8Dc0mTd9H7DenEyvGELdVxycmB98i8r+BnKnWyFZYzRtv9M1YMGDNBydaTQWkAbcETHICOovQInZytZTVOZgJwbFQZNCQAEBGqmsRUmuFYW48k0MqpTDS4KDB6Z7BHlfvI+kGJBHNWt3+HeC52PFWRBnRPRF3TYzLB4ofzg86J7UNbMaaPAt O5xb1G79 D/kS4kB/LBnVBJEELO0Vo1c/AAG4sj4whRYRef4IpxmBaOMNhmhBrFYssat8CvX0Lot3Bw3IirjNxk08wIAp0zI/Wb59wJA04BcxhzaANb6BIaHvQDIX7QvukXIyYvoSpqRU4drlwgFyFPiMpOQxqBg6vztIWErnC/Zj00mwW1TFnSJHKfiMw1J/wtM2r+RU+6+b7uDdegmrDysU2t/Qa0peaDy3v86oB4shRB9XPaFih0Irtxm04mgEDotqh2wyQzNCH X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Tue, Jul 08, 2025 at 12:27:09PM +0200, Marek Szyprowski wrote: > On 30.06.2025 15:38, Christoph Hellwig wrote: > > On Fri, Jun 27, 2025 at 08:02:13PM +0300, Leon Romanovsky wrote: > >>> Thanks for this rework! I assume that the next step is to add map_phys > >>> callback also to the dma_map_ops and teach various dma-mapping providers > >>> to use it to avoid more phys-to-page-to-phys conversions. > >> Probably Christoph will say yes, however I personally don't see any > >> benefit in this. Maybe I wrong here, but all existing .map_page() > >> implementation platforms don't support p2p anyway. They won't benefit > >> from this such conversion. > > I think that conversion should eventually happen, and rather sooner than > > later. > > Agreed. > > Applied patches 1-7 to my dma-mapping-next branch. Let me know if one > needs a stable branch with it. Thanks a lot, I don't think that stable branch is needed. Realistically speaking, my VFIO DMA work won't be merged this cycle, We are in -rc5, it is complete rewrite from RFC version and touches pci-p2p code (to remove dependency on struct page) in addition to VFIO, so it will take time. Regarding, last patch (hmm), it will be great if you can take it. We didn't touch anything in hmm.c this cycle and have no plans to send PR. It can safely go through your tree. > > Leon, it would be great if You could also prepare an incremental patch > adding map_phys callback to the dma_maps_ops, so the individual > arch-specific dma-mapping providers can be then converted (or simplified > in many cases) too. Sure, will do. > > Best regards > -- > Marek Szyprowski, PhD > Samsung R&D Institute Poland >