From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 493FCC83F09 for ; Wed, 9 Jul 2025 02:54:18 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id C212D6B0093; Tue, 8 Jul 2025 22:54:17 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id BD0356B0096; Tue, 8 Jul 2025 22:54:17 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id AE6526B009B; Tue, 8 Jul 2025 22:54:17 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 9D8F56B0093 for ; Tue, 8 Jul 2025 22:54:17 -0400 (EDT) Received: from smtpin07.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id 52B791A02C5 for ; Wed, 9 Jul 2025 02:54:17 +0000 (UTC) X-FDA: 83643207354.07.357F24B Received: from sea.source.kernel.org (sea.source.kernel.org [172.234.252.31]) by imf20.hostedemail.com (Postfix) with ESMTP id 6220E1C0012 for ; Wed, 9 Jul 2025 02:54:15 +0000 (UTC) Authentication-Results: imf20.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=korg header.b=JSV1q3SO; dmarc=none; spf=pass (imf20.hostedemail.com: domain of akpm@linux-foundation.org designates 172.234.252.31 as permitted sender) smtp.mailfrom=akpm@linux-foundation.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1752029655; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=DZaH++dQe6BM7FmWDdWyNuJe7KAz/8MEGjTvescB2eg=; b=QI9pQ2gmdJTU9dh6jBjkisoEocjPNAr0B48efqxyyVFt5aGPNjHJhjuNEpLcTq7IKp+Fsw G8+y16Tnq4x4537LItlJFG9TZjlX+9qmtXCk54GAAhEBVV4BoxqrXl6QARXFD4Dods66Zy mLpA+SAE4kxEEvJO12nMA4UqYQXK4HQ= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1752029655; a=rsa-sha256; cv=none; b=1R4+CUczJkXWih5ErgY6yzS2lmCo+PV1jrHnVfHb08crUcGqdfQ7XqwRQVnQt+ImG3I/Qc n/paQVrs0/Wi6XqBlZEy2N4ojm/b6Kv5UYUoNkW7RJaGO3SLiZOWBsWbF3rJZnn+78qV/6 2CykB8TLz3hlF62tsBhl0FryT9eCs9E= ARC-Authentication-Results: i=1; imf20.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=korg header.b=JSV1q3SO; dmarc=none; spf=pass (imf20.hostedemail.com: domain of akpm@linux-foundation.org designates 172.234.252.31 as permitted sender) smtp.mailfrom=akpm@linux-foundation.org Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by sea.source.kernel.org (Postfix) with ESMTP id 27EAB440D1; Wed, 9 Jul 2025 02:54:14 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id AEEFDC4CEF0; Wed, 9 Jul 2025 02:54:13 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linux-foundation.org; s=korg; t=1752029654; bh=ufxoFfgAqXtjt7qZqYoRDR6akfPIzd5kq+OOk/XGK5Y=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=JSV1q3SOvgMO6tkUf8E2sjHfpQCXnrKJHIQYn4lWnr2gWWoy3BnhlG10Do+FVKohg xBsImfMHPjn6lQhXC//6fWNh8GyjkM+IjveX3ndJhpbNHmanLPp6PGlUSq3HE7WiVi D2T0UnkWkE2JqfdVJ8bSaJ6soMoXIbtTWxY4fXsM= Date: Tue, 8 Jul 2025 19:54:13 -0700 From: Andrew Morton To: kernel test robot Cc: Colin Ian King , Phillip Lougher , Chanho Min , , , Linux Memory Management List , Subject: Re: [PATCH] squashfs: Fix incorrect argument to sizeof in kmalloc_array call Message-Id: <20250708195413.e990d63665144c28b0caa672@linux-foundation.org> In-Reply-To: References: <20250708142604.1891156-1-colin.i.king@gmail.com> X-Mailer: Sylpheed 3.8.0beta1 (GTK+ 2.24.33; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: 6220E1C0012 X-Stat-Signature: y45rckxfwx34egbuytpe6fhkhrrtmnqm X-Rspam-User: X-Rspamd-Server: rspam06 X-HE-Tag: 1752029655-941889 X-HE-Meta: U2FsdGVkX1+Er73DuhNAlmTY0QKdLhf5AUnNZEA4jeC6s88i8qxZLvtBHq7amJBPxf2KHUo6RDPSqLgBpCoy6HJCSJ9Y0u6H7AL0t+qdX2zK9tnGOqjJDJCdge6CQkWKj6lchn6YM5ex8hZo1q8GwJBH9Bwz//fkx79hRA6ZUXBerJcFgjhvyzHY7i2+2EZeBxHQFogcvOi3oYEErMtGR37HaYhxWNgjUT5x9xi75FsHEAxsR26mzAaAidYaJqesWPRNbuunBbh0aJdeWv/X97j/5JOqWXMN20gx6eDbvFHr3mkbq7UWtItUjasdMhc+Ld5uIA/OWz+zgTXsKzFhrd3j17PANQcVr80cDuB91/MufH3li7PvvKngZTTJk4pNNh4VccHZc0hZbIRluVztOTHO9lzMPaGDfraSj9ge/GhbUKhog+e26k2L5XRPvECx+8q3gOF3wTlNkwwVMAT06Q2AFscLe+UvgHkN0jXzlGHV3Bg3NyN6qN5UolCYkDE6ecUd/H0CBTMVVtYbYM9vplqGviSskFomCFINXqAOSrt5EnHBsJ1Lbn2xHQ1RUAuQaLrXaxlKOq9f+N6zMl8rbv0cwWNvvFeBmtrbSsjfpqLfaXT5it8vcjZCr1OwJFxQ84geyQ+fJ8GLuyYJHJyOtHZqdE6DDM58NzbC9r5qKvXEqn20+PeHQDXbybXxmsOWUtW/oDWKQ+uEZetpMRcagA2PDh4gKx1UnGTPMslg4TdAkKYzaB42NjjhvQhuGIcpqm1mxZiH7TZ77LW2kAmHjZntLo8Lmr5z0Lc4WRGYWITMskv5zIIE8ddpwmKk73jeND0dRRAmnEWEKCrRbPfSmtx+a0l1rNwLr3xqDdiB7CgGiKougXUbpNp+J9jc7QqcQFdhmRnqL/y4+OeKkI88gjk+TwL8ndI0rmJkQOUXYJs0EkahXQyrUBnbLsf/5VgiRservW36vF/Oj1oiMrz XFE7C+dO HZQxHBGrGSVMdBxKPblUAyoImC0LggBOcUnBhgLr/lIXoAG4ZCJ7MR5zt4xQWiM9a3cHOVpeAwqvBZ8qVkYEhyv+4pBRAOVejGmDW9kpaWjyDDr2L6TWnnS1X+yf8RJ08pOqgic5QEvGiY39JYQs/ipWSGuYTqLxfrkDD+3cX6j9HlhXGZPRaQCMy0ACzFmYMQuMfB9RHwDFiUxM1LGuggJxdgDu6kR5CLDLemvGVknTcPqBT0tFs/Fje/+5uYet6NI9+5nfZrd89U39j9GqWhnkCFKy3hWtNANjmHwANbAicDArbRF6MDYUTthAfO3q5CBcZ7Yyb8EgGFFo3oGNNLIGhSvMJI6vfkm0tgjXbYMa3glCyMvhs4rgFu7WVtMiBOTrzHKvQWFX7A2rmz6XI96rFcfB6jPa48Hc6GZ1X14pGbliVDJp+IFWIKGwAsdx6JrOz+L8eVE6m8jzPVR/jMmo4jBH3YJ+2zs1iMGMfe7E04B6dXlUTPIBjLzB2RET9Locotfrt1L5BP8c= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Wed, 9 Jul 2025 09:05:25 +0800 kernel test robot wrote: > Hi Colin, > > kernel test robot noticed the following build errors: > > [auto build test ERROR on akpm-mm/mm-everything] > [also build test ERROR on next-20250708] > [cannot apply to linus/master v6.16-rc5] > [If your patch is applied to the wrong git tree, kindly drop us a note. > And when submitting patch, we suggest to use '--base' as documented in > https://git-scm.com/docs/git-format-patch#_base_tree_information] > > url: https://github.com/intel-lab-lkp/linux/commits/Colin-Ian-King/squashfs-Fix-incorrect-argument-to-sizeof-in-kmalloc_array-call/20250708-223017 > base: https://git.kernel.org/pub/scm/linux/kernel/git/akpm/mm.git mm-everything > patch link: https://lore.kernel.org/r/20250708142604.1891156-1-colin.i.king%40gmail.com > patch subject: [PATCH] squashfs: Fix incorrect argument to sizeof in kmalloc_array call > :::::: branch date: 10 hours ago > :::::: commit date: 10 hours ago > config: mips-randconfig-r071-20250709 (attached as .config) > compiler: mips64-linux-gcc (GCC) 8.5.0 > reproduce (this is a W=1 build): (attached as reproduce) > > If you fix the issue in a separate patch/commit (i.e. not just a new version of > the same patch/commit), kindly add following tags > | Reported-by: kernel test robot > | Closes: https://lore.kernel.org/oe-kbuild-all/202507090822.QI1bMiUV-lkp@intel.com/ > > All error/warnings (new ones prefixed by >>): > > In file included from include/linux/percpu.h:5, > from include/linux/percpu_counter.h:14, > from include/linux/mm_types.h:21, > from include/linux/mmzone.h:22, > from include/linux/gfp.h:7, > from include/linux/xarray.h:16, > from include/linux/list_lru.h:14, > from include/linux/fs.h:14, > from include/linux/highmem.h:5, > from include/linux/bvec.h:10, > from include/linux/blk_types.h:10, > from include/linux/blkdev.h:9, > from fs/squashfs/block.c:16: > fs/squashfs/block.c: In function 'squashfs_bio_read_cached': > >> fs/squashfs/block.c:92:12: error: 'folio' undeclared (first use in this function) > sizeof(*folio), GFP_KERNEL | __GFP_ZERO); > ^~~~~ I made it struct folio **cache_folios = kmalloc_array(page_count, sizeof(*cache_folios), GFP_KERNEL | __GFP_ZERO);