From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 64826C83F18 for ; Thu, 10 Jul 2025 08:54:24 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 04AA36B00AF; Thu, 10 Jul 2025 04:54:24 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 022416B00B1; Thu, 10 Jul 2025 04:54:23 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id EA14F6B00B2; Thu, 10 Jul 2025 04:54:23 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id D95026B00AF for ; Thu, 10 Jul 2025 04:54:23 -0400 (EDT) Received: from smtpin07.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id A591A140759 for ; Thu, 10 Jul 2025 08:54:23 +0000 (UTC) X-FDA: 83647743606.07.C5B6EDC Received: from mail-pl1-f182.google.com (mail-pl1-f182.google.com [209.85.214.182]) by imf02.hostedemail.com (Postfix) with ESMTP id CCF2D80018 for ; Thu, 10 Jul 2025 08:54:21 +0000 (UTC) Authentication-Results: imf02.hostedemail.com; dkim=pass header.d=bytedance.com header.s=google header.b=BI4jJr7Q; dmarc=pass (policy=quarantine) header.from=bytedance.com; spf=pass (imf02.hostedemail.com: domain of lizhe.67@bytedance.com designates 209.85.214.182 as permitted sender) smtp.mailfrom=lizhe.67@bytedance.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1752137661; a=rsa-sha256; cv=none; b=q8+dNAev6pfDTZ5ce7cYegMbpI+t+ktV+5Tk/tus7cIw62FPfccerLNLKjXR2WZMFzRxsz j+uG1XboVjxaFReqjFIlW5SwyeXmrsg2VBWTVjNAIqX3BFI5+GATyoe08kaQXxqBmXxLKr ce6dMDVGpr4x9iK43aiPRoY9Uoq7xyE= ARC-Authentication-Results: i=1; imf02.hostedemail.com; dkim=pass header.d=bytedance.com header.s=google header.b=BI4jJr7Q; dmarc=pass (policy=quarantine) header.from=bytedance.com; spf=pass (imf02.hostedemail.com: domain of lizhe.67@bytedance.com designates 209.85.214.182 as permitted sender) smtp.mailfrom=lizhe.67@bytedance.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1752137661; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=Nx6tn515BmvVRbPQz9Ke+EyJMh4nGWIC6oD4cxq1tFQ=; b=gMW5rhvWxPw1nvYcvwNHlFSKAckbKaHwSNuXsOJyS9UUVqkJXNXtx7Eid1Ggwo7DyYdQ9n 9jsNHs0+SbNInvZE84heKIjALSnkcnhajvFQZjb/PeTGaCe9TSwSAqTCIQGhwjVovABSMo +r70hJWzlpkMOldrpuYpm5R8fXR5WL8= Received: by mail-pl1-f182.google.com with SMTP id d9443c01a7336-234bfe37cccso7683335ad.0 for ; Thu, 10 Jul 2025 01:54:21 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bytedance.com; s=google; t=1752137660; x=1752742460; darn=kvack.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=Nx6tn515BmvVRbPQz9Ke+EyJMh4nGWIC6oD4cxq1tFQ=; b=BI4jJr7Q50VGRNC0PmnXnzXA4scSjy2T7JTs0wwLVsC6o1KaZGx7WTx729tLRKgHWF rPGIBoKbrBu03bzf/aSmoG+3p+mRSdZV/VJ9M1b3fBp441nvZPxrmiXlsKj2lMMbYMSW MXbmZsEL0RpFPF+tDM0qXr/pCZGDUdzWPSPWTnwexytlB/ghYDIzO5VHgHceuLgc76B6 AHEbWP2lLbhUw+ewCf29H9IRvX8yrxkGMncxL7iFtHUcQxxV/mxmH4IRCcEJdGtunYRZ 4JvUMn96dIYosHHSDDgHlC+xO5/+nIj+aNMh8Z1J5y3Os/OIuZPHmmX/M2OPugxBWnxh gA1Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1752137660; x=1752742460; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=Nx6tn515BmvVRbPQz9Ke+EyJMh4nGWIC6oD4cxq1tFQ=; b=aGJFeLK5CE9H8ifgrnkMmKpVPODVB0BMR0dSDBfOIRIZVENW40WksqqJkWAb6vcRf+ Cp8CjjOU1RXkPoMSy7VWaP7E8ZvORhd/g/U7vBaXZhJg31QzqF/IbDdR4kuttgl5T6NW bOpAMmkRFe2urrC/hk0ZLmKnqAXav53RDxoiPUDkbZYj/q/0rBLEYuzxZ2Ig5no5deL3 IvYZoXqEzet2js9iW8CuH+4HvrMbnNA0COLHuvGXP9BmWLCNIzkK84DyxIfepwY0m+Rq hzPkXLmdSHLCiOk7CSDBujoMlcuwWhKDH6E6ZsojDtvAuMgch2lrPApOWTTGUuFDDtP4 buXA== X-Forwarded-Encrypted: i=1; AJvYcCVe0c9wP/y2XN3As4eLSxJpKL756wh59Epr7XAuKxUPcOphJ/QGGDMrhCPd6c7q4AIupGWIvhCWFQ==@kvack.org X-Gm-Message-State: AOJu0YwP2h5zGPdMMlZAE3DfHfP57xbs8JMRTCGIBRsePhfewDhrQrG/ ycQJP7p0Yns+88MkSE2ewUocEA/zsZQe4hy/EVVggahhfaQOVcBRLH+SHmdVwyFSpR8= X-Gm-Gg: ASbGncvXddD1Ezn1xvDWwPSYf4+7DqXAU07dU6XkzyyXT4BZJmacyxKUsptK6XNU2an VesHukKWPqrabx3oRT2p08lX5WJ9VfpWalmWlrvuR+zXuc6uRrw6SIPAVbHjdZtKh+fr2tzNonY KhG38H6Tp1dWE93EGi27BEX38Ku0/rwb8nmrS6tMRuOgPATGI7VKRUYTRBQ5srv6TggTrGZWD1o krAeWxGa/UBoPH6NBEKKfCj0I0Xb1caH2Mwk0VBhEvpPH6M4Hgd2KG/WQAl+kyy4/nSrlFx3VRF VifYtMgWv7/XICgneUzQj+vkzF0Mbyk3mzHzrWhnwsK04DJihcVfcZKIk3tY8i/WeIHbr/a2YMW A8itZIHCQwXVPsvJyc8DXzmGq X-Google-Smtp-Source: AGHT+IHinmUo1Q8JyIR8mVroxGH87B3iRX98m8gWf3ZeXBpz/jGd0mYLjHRrHOq8wekDWW+AqoXtuQ== X-Received: by 2002:a17:902:db0b:b0:235:225d:3087 with SMTP id d9443c01a7336-23de24d9865mr39979545ad.30.1752137660449; Thu, 10 Jul 2025 01:54:20 -0700 (PDT) Received: from localhost.localdomain ([203.208.189.12]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-31c3e975d41sm1650228a91.13.2025.07.10.01.54.16 (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Thu, 10 Jul 2025 01:54:20 -0700 (PDT) From: lizhe.67@bytedance.com To: alex.williamson@redhat.com, akpm@linux-foundation.org, david@redhat.com, jgg@ziepe.ca, peterx@redhat.com Cc: kvm@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, lizhe.67@bytedance.com Subject: [PATCH v4 3/5] vfio/type1: batch vfio_find_vpfn() in function vfio_unpin_pages_remote() Date: Thu, 10 Jul 2025 16:53:53 +0800 Message-ID: <20250710085355.54208-4-lizhe.67@bytedance.com> X-Mailer: git-send-email 2.45.2 In-Reply-To: <20250710085355.54208-1-lizhe.67@bytedance.com> References: <20250710085355.54208-1-lizhe.67@bytedance.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Rspamd-Server: rspam11 X-Rspam-User: X-Stat-Signature: 6ghdjfs7dis19wdd7fmjgkqmci1paoim X-Rspamd-Queue-Id: CCF2D80018 X-HE-Tag: 1752137661-844172 X-HE-Meta: U2FsdGVkX1+upHThElDamS9dzhkcYUXp1yqz7+S/LfDU/vlZYIHEjv8WSGnthuqDrAkTg3rUbHZPYqv9ewQzrjHIb1O+KVowR+K0e8riHc4DJ4FcCZdZbDWDE4r38pCWTx1YxPehZcvpP2YfsEE/pniSs+zZJ8C8nlla4mQD+zWTw210ST9Kx/fdsXI3mK6aGwR/+MQGxkaiLYNT5hGpwmgFbDoQC4SmnInXvdEN2fLd9c6np36TNbvy/CGg3eg/LbDNQRJy+3WUQobpHagVKIHFqF8z/s0iNrFnW2dmYS1JOKHksiHzmgaxgrJTQrDJ+4gHM5MqWcyW7rBpjbndj8IvfOPW8O5B9FxsjUyxrTwxyNoy1BABoS2Jh9e3vm9oNN3LuQ+XAqNnWTOjA7rDw8DnXrcmVoeribBTk2AKW+hEbAe+HGKi3TnG6Vm3Py6ECNPqmgOWYkDSnJorbunUDzrIK+mdxSwv/GmWmSRygq3kQThvSZNPDVgb+/Hcnpze8gzI90gmaWpEjV0ST8n6fiG8fv1VDOEAyhujRAmADVWCpALY7a75b0Uokuh7fxlQfKazc2lw5qzl7qEmZHeJ5aa/quLNnyzEe+bvPHh3GD17VuegyJrcNZs7pT0nmOoMgYjlLPCWkwjzpgj2MeATwWSjQCB1DKmdR7HbgsqCFR2qJPjFtNrS9UFNGMy1PNp7IoXjjob85z6+8vKZQb9RPqQFu8sv8Z/heNoRFhgU83qu1VxZnUrkhCCdRtQyrBwOcW4j735NqGUptb6iAn07VeQP+UtpLKZPE6VRy+6599C6Sqpsgzwl1dEWDUd84Zhjn+Ov7G/n66tMxhMAeuUMB78w4JNTPV4QqkEzFkz8qbF4sj0DSETI4i94S5IqbSIU5c8Fll3ij84E3chAv6u8+uxHZASYOmaS3wqqT5tfzhjTpuh+d6WKV5OoU2ozq6Bxllvtu8r3bM31MVrlXja H7oqlqm5 ncAnjMaMUniFSzKB5wHibKxHW5yr5ClhNuOexlsZc/xn31IwNExxmBYisxPM87ZAiBgaDcB4kk4HpIhTYqssSm7C7nRygur+yv/3S0Ja0JhkCMR1qhNBFFu4HECXSkKLebWDHCp3jsnY+McWLMqK5Fqp78ktEOX1zSZrszWcNpiyg3V/j8zS5f2BX4zzWxUEuzeaZ8oEGf/5DkXtQOfurk79A1XnnNJNIoFaO9IUO0qVB9qkucWiK7n1OxQ+9uFo42o8qEQd0IhKr7SYpjdIwiBQt6Dyzx36Rze+xFk5A0uN9kceFicTbSs3zwdS5/MVnVDkycq1V0sLGBeC7sBPEm2PlIQw1XkcAOB93 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: From: Li Zhe The function vpfn_pages() can help us determine the number of vpfn nodes on the vpfn rb tree within a specified range. This allows us to avoid searching for each vpfn individually in the function vfio_unpin_pages_remote(). This patch batches the vfio_find_vpfn() calls in function vfio_unpin_pages_remote(). Signed-off-by: Li Zhe --- drivers/vfio/vfio_iommu_type1.c | 10 +++------- 1 file changed, 3 insertions(+), 7 deletions(-) diff --git a/drivers/vfio/vfio_iommu_type1.c b/drivers/vfio/vfio_iommu_type1.c index 6909275e46c2..cade7ac25eea 100644 --- a/drivers/vfio/vfio_iommu_type1.c +++ b/drivers/vfio/vfio_iommu_type1.c @@ -794,16 +794,12 @@ static long vfio_unpin_pages_remote(struct vfio_dma *dma, dma_addr_t iova, unsigned long pfn, unsigned long npage, bool do_accounting) { - long unlocked = 0, locked = 0; + long unlocked = 0, locked = vpfn_pages(dma, iova, npage); long i; - for (i = 0; i < npage; i++, iova += PAGE_SIZE) { - if (put_pfn(pfn++, dma->prot)) { + for (i = 0; i < npage; i++) + if (put_pfn(pfn++, dma->prot)) unlocked++; - if (vfio_find_vpfn(dma, iova)) - locked++; - } - } if (do_accounting) vfio_lock_acct(dma, locked - unlocked, true); -- 2.20.1