From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 43F69C83F17 for ; Fri, 11 Jul 2025 01:17:11 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id D954A6B00A2; Thu, 10 Jul 2025 21:17:10 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id D6C866B00A3; Thu, 10 Jul 2025 21:17:10 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id C82576B00A4; Thu, 10 Jul 2025 21:17:10 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id B1B396B00A2 for ; Thu, 10 Jul 2025 21:17:10 -0400 (EDT) Received: from smtpin04.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id 5DF4780FD2 for ; Fri, 11 Jul 2025 01:17:10 +0000 (UTC) X-FDA: 83650220220.04.24D4E24 Received: from invmail4.hynix.com (exvmail4.skhynix.com [166.125.252.92]) by imf15.hostedemail.com (Postfix) with ESMTP id 3024FA0005 for ; Fri, 11 Jul 2025 01:17:07 +0000 (UTC) Authentication-Results: imf15.hostedemail.com; spf=pass (imf15.hostedemail.com: domain of byungchul@sk.com designates 166.125.252.92 as permitted sender) smtp.mailfrom=byungchul@sk.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1752196628; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=p0xKaRkJeaUH8fWlbozYv5xYiY8QNNUAReShXEa2txs=; b=iblvc8gRHw3wva+gYhFvthLa49l7OlTHFX6g+ACMg0j4fbtDz+T52IMLN6Pz6O+iryDoyn 0ZyGqSHkfFA4kcSCKMPmKaBEeowUxk0WOuh6k1c1Za3kyQS0MLyx1m16T4l/04rP3vF6KQ ksNAmqjE+BrK9ZgcVLI5p+ImkLE9f4E= ARC-Authentication-Results: i=1; imf15.hostedemail.com; dkim=none; spf=pass (imf15.hostedemail.com: domain of byungchul@sk.com designates 166.125.252.92 as permitted sender) smtp.mailfrom=byungchul@sk.com; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1752196628; a=rsa-sha256; cv=none; b=R67KPCe+5DjXoB1fNdKjjEMwLitzQogWo1tLvB0Rbm9KXGKL6LFau43/JEfCwsWgSfDZ4b Y3KhB/l4OCQGii/bTpKntUvSoFf6HqijzgT7sHxj2XE+fc/7LwxFKRjfbg8EyVWP+eEQY0 CyREUMVoRdOIqBUHLU0XM15xDIm/0Jc= X-AuditID: a67dfc5b-681ff7000002311f-8a-687066114969 Date: Fri, 11 Jul 2025 10:17:00 +0900 From: Byungchul Park To: Mina Almasry Cc: willy@infradead.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, kernel_team@skhynix.com, kuba@kernel.org, ilias.apalodimas@linaro.org, harry.yoo@oracle.com, hawk@kernel.org, akpm@linux-foundation.org, davem@davemloft.net, john.fastabend@gmail.com, andrew+netdev@lunn.ch, asml.silence@gmail.com, toke@redhat.com, tariqt@nvidia.com, edumazet@google.com, pabeni@redhat.com, saeedm@nvidia.com, leon@kernel.org, ast@kernel.org, daniel@iogearbox.net, david@redhat.com, lorenzo.stoakes@oracle.com, Liam.Howlett@oracle.com, vbabka@suse.cz, rppt@kernel.org, surenb@google.com, mhocko@suse.com, horms@kernel.org, linux-rdma@vger.kernel.org, bpf@vger.kernel.org, vishal.moola@gmail.com, hannes@cmpxchg.org, ziy@nvidia.com, jackmanb@google.com Subject: Re: [PATCH net-next v9 4/8] netmem: use netmem_desc instead of page to access ->pp in __netmem_get_pp() Message-ID: <20250711011700.GD40145@system.software.com> References: <20250710082807.27402-1-byungchul@sk.com> <20250710082807.27402-5-byungchul@sk.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: User-Agent: Mutt/1.9.4 (2018-02-28) X-Brightmail-Tracker: H4sIAAAAAAAAA02Sa0hTYRzGeXfO3nMcrc7WxVcTpJVlglpp8Sei/PhSBEnQh/pQI09uOadM M5UKq1UkaRe1y9FiUnmZ1WqZN0xsmi6KFMNYeStvKVrRSvMS1TaJ/PbjeZ73ef4fXp5RP5YH 8npjqmgyag0arGAVnxcUh6sPJevWlf7EUGS7h6FiKh1KP9TIochaheDHdBcH35tbMdwunmSg qM3MwoRthoGhln4OKuw7oa9kmIX6c9UM9F90YsgxzzLwdPoLB6dqymTQXpUrh/yZuwxUZ33g 4E1dEYbee3/kMOzIYeGFVM5CX24MtFiWweTLcQTNtmoZTF64iSGvw4JhwNyHoKOpn4XCk7kI bA0uOcxOeToKn/dyMato0/hXhlaWv5PRWqmHoxb7Efq4LIxmuzoYareex9TuvsLR7rf1mDqv z7K0tua7jOac/oLpt6H3LP3a0ImprbKTpa8szdwu1V7FljjRoE8TTZFbDyh03W8muOTfivSz j64xWegtn438eCJEk4IJJ/OPH17p8TErhJDiqzewl7Gwhrhc0z59ibCW3Gm4LM9GCp4RJEw6 6/pZr7FYMJHKfKvMy0oByND7fOwNqYUyRPIKbcycoSIvbgz6HjCe1l+3Ojw67+HlpPQ3PycH k9NPCn1xPyGWfBpo9sWXCitJY1WrzNtJBCdPRpxn2LmrA8izMhd7CamkeRPSvAnp/4Q0b8KC WCtS641piVq9ITpCl2HUp0ccTEq0I89XKjn+a18NcrfvdiCBR5oFypiKJJ1ark1LyUh0IMIz miXKBzuTdWplnDYjUzQl7TcdMYgpDrScZzX+yg2TR+PUQrw2VUwQxWTR9M+V8X6BWSi9O2/z 4KkAa6NqRfBu07r2sYITh/03RDcu2hF0vsC8MLM+7GHX/bU/Y9tW84mlx1ocUbRt+1QsvAtd uc2wcdNlxcxIAn4dYB4ZDRyIHGVwyRiJ5/Nam24Fh4e4H31OLcgOC7k0E5ohBZEVe/Jj1oAU 7f4WGBV10Ghf/DHIFmTQsCk67fowxpSi/QsDSs0fRgMAAA== X-Brightmail-Tracker: H4sIAAAAAAAAA02Sa0hTcRjG+Z9zdnZcTU7L6mBltZBIyTSKXuiCfSj/FWp+iCKoXHlqy9vY VFQoVpMiSctLF48WE69Na7WWN2yWmhciitnMzBszrUTSvKUZ1aZEfvvxPM/7+/QypOymyJNR xcTxmhhFlJyWUJKQHfpNS86olf4tFn/IM5XTUDadCCV9VSLIM1YgmJj5KIbxxmYaCvKnSMh7 k0LBpOknCQNNDjGUmYOht3iQgtorlSQ4rrfQkJYyS8KzmW9iuFRVSkDD3VYRvK1IF0H2zyIS KnV9YmiryaOhp/yPCAbr0yhoFe5T0JseCE2G5TD1ahhBo6mSgKlrd2nIshlo6E/pRWBrcFCQ ezEdgcnaIYLZaacj92WPONAbNwyPkNhy/wOBq4VuMTaY4/GTUh+c2mEjsdl4lcbmsUwx7mqv pXHLnVkKV1eNEzhN/43G3wc6KTxitdO44MsogU0WO3VIdkyyM4KPUiXwms27wyXKrrZJsfq3 JPHy49ukDrUzqciN4dit3KPMbtLFFOvN5d/KoV1Msxu4jo6ZudyD3cgVWjNEqUjCkKxAc/Ya B+UqlrIazpJtJFwsZYEb6MymXSMZW4q4rFwTOV8s4VpzPs0dkE7rr3s2Z844eSVX8puZj9dw +qe5c3M3Noz73N84N1/GrueeVzQTN5C7sMAkLDAJ/03CApMBUUbkoYpJiFaoorb5aSOVSTGq RL/TsdFm5HyW4vO/MqrQRFtQPWIZJF8sDSyLVcpEigRtUnQ94hhS7iF9GKxWyqQRiqRkXhN7 UhMfxWvr0UqGkq+QHjjCh8vYs4o4PpLn1bzmX0swbp46ZN1vs0wVFTd7FYY31rw/eEm/6oEy vmJtzUgAlRmObTo+qO9owI5FJ7zXRV74wYQm+7Ja4lzmO0fdxYzV1hSq3LfnauiWH2Mh6qHt ye4t/FCQYCyUK5sZXcIpbldTdVGBYN/DPyg5nhrmtW9m3d6TXYflpXpv++iLEI/a19N1X+WU VqkI8CE1WsVfxfbcpigDAAA= X-CFilter-Loop: Reflected X-Rspam-User: X-Stat-Signature: rqw7hoy16a88mdbud8kuxe5wa9mrw54h X-Rspamd-Server: rspam12 X-Rspamd-Queue-Id: 3024FA0005 X-HE-Tag: 1752196627-746767 X-HE-Meta: U2FsdGVkX1+zISKHJR3bPkJEme3fTC6ZJ3YMppdSvnmuSWZErgh/9paVfEDoOyCcK3EKiBhqivqOweDAfhpm+9wLgWXoYWmRbSanjYEUm9WZX+3PGTQJ8eMOkxaYPX5zQ/BSidsRNrP2aBdseZsdw3sWIyEjYUZUFOTEJ//3VzjTr3nReoU1l5PVf+dyDAOIOhhjqwEg7XSQH2GZeSGHlcRwIzpbFieYEWALoQrNs+LhFiCfx/cD2qFXcJpVgl+bx29OHXzVAw+AaoJhNoGqn9nGtpDwrMhxtErwc4daPJZUmvbcw+TDcpRvERAG9z4ydu5VTZs0ZRZknzikC5V0oAWEfVvJvorz+2OZPC2YvzEwIp+ysZQn4b1lrHaU9XeAEi1mISTIDckzFqqpUC+vts7i2jWWjH8//sPQfYt3zmwAE4RgL+Xk3GsJtY1REQ9dHizp9I4G9w7/mC6RQEgXsxml5loe2Ag1O19cnshy0CavCUnpwW3VgBJ0oRdkbHxPfibNSdg5HPrxMwX6NggSQGEojjcsRsfNErwCbsgJNRsE0FSFs3zdZnMFJza66o1X19CAGU07KJurVIC/06gajtxBPxc928VIdyiyns6s4GogGxjS2A4VD+8yneNPWk7TZFZF/9zrs+JKgzzNxQYqh8ZY2lIe9lyQ5QVbJmgu4vtxirYp9tBFrwFqEL5Saj0lZEW+K75+XhInYvNqMvTne84WxX4vvvsjhdjfSwmnNmCm9LKPT+N5EqH8zvUWRxsNOHz7G6hH2hvlVh0+AXFK4hCwBn21dX5wTaXd8MmSwCm/+ULQSpOWVtMJdjCj08KUEmybJsHBAU5L9Iz3HCWXtxPhtcmiUmgRZYqQQDMaX8KvcjBOokO1w3h8FtdnrN+e2F/wLJNwzx416uCWcBvxaViwY+RVSN8GIkHnbcg9MyTruWSPkxdBH02E5BMPdMBqCuwJSH9vCBPfl5dmFzk i1+qLIEC bCThd+q50k/EtoVENCYY57Objew5dSu4I7+rMMXfx35S0TUK8L7K9eSHl+g76DZKQYEKUmtwxzrGCSFnsBm/z0faJGSn1gByBM/VZMaYQlhgrwPiHA6Y+LUpZpw== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Thu, Jul 10, 2025 at 11:25:12AM -0700, Mina Almasry wrote: > On Thu, Jul 10, 2025 at 1:28 AM Byungchul Park wrote: > > > > To eliminate the use of the page pool fields in struct page, the page > > pool code should use netmem descriptor and APIs instead. > > > > However, __netmem_get_pp() still accesses ->pp via struct page. So > > change it to use struct netmem_desc instead, since ->pp no longer will > > be available in struct page. > > > > Signed-off-by: Byungchul Park > > --- > > include/net/netmem.h | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/include/net/netmem.h b/include/net/netmem.h > > index 11e9de45efcb..283b4a997fbc 100644 > > --- a/include/net/netmem.h > > +++ b/include/net/netmem.h > > @@ -306,7 +306,7 @@ static inline struct net_iov *__netmem_clear_lsb(netmem_ref netmem) > > */ > > static inline struct page_pool *__netmem_get_pp(netmem_ref netmem) > > { > > - return __netmem_to_page(netmem)->pp; > > + return __netmem_to_nmdesc(netmem)->pp; > > } > > > > __netmem_to_nmdesc should introduced with this patch. Okay. > But also, I wonder why not modify all the callsites of > __netmem_to_page to the new __netmem_to_nmdesc and delete the > __nemem_to_page helper? It'd be better. I will. Thanks. Byungchul > > > -- > Thanks, > Mina