From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7EDB5C83F1D for ; Sat, 12 Jul 2025 21:32:21 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 6CBC66B00E0; Sat, 12 Jul 2025 17:32:13 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 6578D6B00E2; Sat, 12 Jul 2025 17:32:13 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 4CE7D6B00E1; Sat, 12 Jul 2025 17:32:13 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 33D3B6B00DF for ; Sat, 12 Jul 2025 17:32:13 -0400 (EDT) Received: from smtpin02.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id CB530C0292 for ; Sat, 12 Jul 2025 21:32:12 +0000 (UTC) X-FDA: 83656910904.02.0113A33 Received: from mail-pj1-f52.google.com (mail-pj1-f52.google.com [209.85.216.52]) by imf01.hostedemail.com (Postfix) with ESMTP id C7A8340013 for ; Sat, 12 Jul 2025 21:32:10 +0000 (UTC) Authentication-Results: imf01.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=HKBz3b1P; spf=pass (imf01.hostedemail.com: domain of levymitchell0@gmail.com designates 209.85.216.52 as permitted sender) smtp.mailfrom=levymitchell0@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1752355930; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=HtRQST6oRjj0LgYjY2mtVgF/hjywiLbC7jwSxYoLgQA=; b=czkGLeDWq7U4g5Qj1sfL3tIbfVFyTnDYd7JVO8F9DkVjwF/fXrYki0rRJG//jPmydK4igP ry0Ak6rBtRlhRo6XGBLNFAS5fKY4vQPcpx/idLMPocyhM49/dni+H6/wUn2czcQHjGy2QB 5+4Gx5MXkcXrADCboRYjaUPKuQT+bfY= ARC-Authentication-Results: i=1; imf01.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=HKBz3b1P; spf=pass (imf01.hostedemail.com: domain of levymitchell0@gmail.com designates 209.85.216.52 as permitted sender) smtp.mailfrom=levymitchell0@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1752355930; a=rsa-sha256; cv=none; b=iv+Q7EIrv1XnKKphWzFzG0gqN70xe0DheF8JS0YcKloLhYO5vGZkqDZKjlNl05eMpTLbmU 3C7yOcguJguKfI6IJxBmqwgWOqSG963Sun9FimTqPew54/TrrfTHMG51JGs6LJZTGX3Tyt nik09fy//IPf1oPDxMFGAT46qcIUBhY= Received: by mail-pj1-f52.google.com with SMTP id 98e67ed59e1d1-3122368d7c4so2667897a91.1 for ; Sat, 12 Jul 2025 14:32:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1752355930; x=1752960730; darn=kvack.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=HtRQST6oRjj0LgYjY2mtVgF/hjywiLbC7jwSxYoLgQA=; b=HKBz3b1PcownKenN8gnEZrLWs0I75WZJ4wLJN6IRUpzAlVn9Qn5FyANAgrXcWc83Sn jqLmlR1ruEG3YkevoIvt6yQ39EmeutuQDq//lA/NMsS0R0WPuKP63Ats23VIO+T1NtGe tNqs2ZYmpMd9ZsU6rYbt/ubTszGYyJODKBhO0mbBJ8E0xCJMCVgOparqVTGYcykUXrVQ jh/+tDHsmNMrysAd3czHEhbNbpA+HnSVlZsphEqDEjvZe96WaBkNtGWTm+ro7NEUUxHd SLLELpFv4ItvSwbbBS/LEBlRRthzdQpLkl0UGZ5ELzPhcCslrHY6XzFX5aaiktbi9lH4 XYiA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1752355930; x=1752960730; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=HtRQST6oRjj0LgYjY2mtVgF/hjywiLbC7jwSxYoLgQA=; b=HRo8YnqOlXYIyWZVWIRZdO45ku/mFffIbYPGM8rpxAa8Xd7eRztWwkQPatOP0+U0YV kCtigPv92hiQeEz+kWU5vdA/ZKpB2dGNV8ZFYgaMHJ91jZ6RwLRMmJDu/t/Jd5oZ77qQ iiEJFIs/v04oHJi9cJRTguqVfdcJH6W34jbyjEWX5jOaMC1l9Bft3DGt26MCCwDxqYoi 8w57Q7fiBRjIQBc2Hp6qoO89TmBBVxqW86tEcIHB83fQn0AqqzNczvbQJkBVJDyGC9k/ as4SMJUNBtGrPXKYK9YYY6sjetzoNfTXW6Mhhq8UByaxHjqW931N+gN/EEou8pDgieIS y0Uw== X-Forwarded-Encrypted: i=1; AJvYcCWJekUtPOxaiUtPV+nqFsqSVIN1+hYjYXeBWIcc1S2wMQVruCppba+FssfzEDhghHmygy67YSrXgA==@kvack.org X-Gm-Message-State: AOJu0YzzCFU/r/8RI/wQQzu/6YkpaHtYOzSlxawCKsqrh1eaCMfdjQOl 82q1toEgyG8b5LzCbGem+Jg92Y+p47C0LlIma3NcDm9SFo3QbT5fKxE+ X-Gm-Gg: ASbGncsmcCxHe/q3VSEFJXXjRW6+I6uNfZNTNSeMEN/yS0baacAIsjQkJwqh201kDVG /XNHmXQFWO3GJ2zgvvlwtJMc7YSA7mLvMJo/wJvNbj7Dj9ht25ZnR1tN+WB+bXT9w6QaD9xR5N5 Oi6wZqpMlUcWiXNQ/AD1lvmfGDcAIqUN6LnmsRMQ1+h/GxVKzgmM3paFmXObI51TDduDj0+jxdm w5RvOcm0d+yUKBLRcAf9nMl3ovnqFcOeDGDIx5R267oR64Tpcv7meruL9fgR+1c2Lq9jLIHgY7o cpo25D+yAt5DoOCaU9s6sKb9OAzG6syeIRKwcQusrOLoCz1YaWtitZn2iT2ELNvjUAo41pyFx5T 2Q2wAolWGiGPgXn0TW9Wc2gD1bSYV7d28fcMz3mBOSgeaRw== X-Google-Smtp-Source: AGHT+IH4o4Ul3dJAPkL8Zf1bVxHe/F3eh4QfvlGGzhfBDOyFuZ6X4iobwmvAQbZVaFZoUk34LWX8BA== X-Received: by 2002:a17:90b:2f03:b0:312:e90b:419e with SMTP id 98e67ed59e1d1-31c50d7b487mr11598155a91.12.1752355929612; Sat, 12 Jul 2025 14:32:09 -0700 (PDT) Received: from mitchelllevy.localdomain ([174.127.224.194]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-31c3eb65aa2sm8003935a91.40.2025.07.12.14.32.08 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 12 Jul 2025 14:32:09 -0700 (PDT) From: Mitchell Levy Date: Sat, 12 Jul 2025 14:31:16 -0700 Subject: [PATCH v2 5/5] rust: percpu: cache per-CPU pointers in the dynamic case MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Message-Id: <20250712-rust-percpu-v2-5-826f2567521b@gmail.com> References: <20250712-rust-percpu-v2-0-826f2567521b@gmail.com> In-Reply-To: <20250712-rust-percpu-v2-0-826f2567521b@gmail.com> To: Miguel Ojeda , Alex Gaynor , Boqun Feng , Gary Guo , =?utf-8?q?Bj=C3=B6rn_Roy_Baron?= , Andreas Hindborg , Alice Ryhl , Trevor Gross , Andrew Morton , Dennis Zhou , Tejun Heo , Christoph Lameter , Danilo Krummrich , Benno Lossin Cc: linux-kernel@vger.kernel.org, rust-for-linux@vger.kernel.org, linux-mm@kvack.org, Mitchell Levy X-Mailer: b4 0.14.0 X-Developer-Signature: v=1; a=ed25519-sha256; t=1752355923; l=3148; i=levymitchell0@gmail.com; s=20240719; h=from:subject:message-id; bh=e1kjOZMlHir0QAwDPK2Mh6knOwIrBRKVgMEnFQ0sips=; b=SNmvATz+HCHFQwUB26nikspj2mxM7yzHBgPaqP8iLy3oOOIsHr2Ff3x4m6cZ0iwMHZviz/pI0 7ZWaguSukFNCvS4HxAy06fKXvmysfDraT3Dh5NuKZoVezP+qab4M0nC X-Developer-Key: i=levymitchell0@gmail.com; a=ed25519; pk=n6kBmUnb+UNmjVkTnDwrLwTJAEKUfs2e8E+MFPZI93E= X-Rspam-User: X-Rspamd-Queue-Id: C7A8340013 X-Rspamd-Server: rspam06 X-Stat-Signature: 3o8zkqme5r11ino9g948xtrrh5mdp5np X-HE-Tag: 1752355930-15234 X-HE-Meta: U2FsdGVkX18mMpDZkLh0jt9sCNszVMiW4EA1jsGQDIbO5ZozL6hedpnHNAZnHHR403dHlSTM7WHE6YRiQTBW4723pGcNzEIX015sT617Ev9BQs/FzTLWEKEGQWME8z4wriX8omyGkRXgopfB88U8y278swC/wXQlXzEqG4sgvJS8bEYIMW3E4ZTxDbiVHzGTnLiSLQpYTmdd9XzSleb5UsUZbK6tgNgGV9u+Ebofnl+JfduvMOn6engLkjMJQu7GicNgJbFiBrtjhZ1qB/3qBSsY/6k95+oizwVuoUJQdTsxnDI6fqTdvc3376+EF6J8ZHMgHs0q/c/eh0e21Hq8fgG4hFgfUxWSxohB+iTDtQbCZAl1qXjY7InZ4HdGPf3JNAz5e9x7CXWkxyeP1+X5/yMB+ihCSjhMlJyLPl2LtfA2N25f/l7O1syzFXJ1/EJOVmA0kWO1sGsM1HxRirhWf7ihmaO+fubqDklBysnSceQQQXGde49snn5Y3dX+JMUlZwFUd2F4XImfI1sfqz/O9Bd9hU1rIBDRxZM7xJmDIsnnPa7ts38vSiCMaUu5yCEW9e1TO9duAsSSaQPFGoodj1etcHJMbxHpRPjA1YR0ZHMlY5hQUds28aOQyFggkURQJLJIDl0kvPJDyFueIUNyNm2IesoL2Rv//F9LqBMtYbAUkDvOOpumGfgG2KQzM9ddvnBgrinvM3Ko6yxgEbw/4C67X6HpUGbdCgeYdTmyLGTPRR46VXiUZ7Gv4C3EbrElAbH9qPBlY1wtGmXyZXrjFiYG41wtEHFteDvY4/GmjHFmTJEKJRh+G2ASZQfb/8bu+bQkL5eFFgHsgm0XyHLF5aFE9mF/Z3CaavPSbmAHQCvre+SvXpJDzgJOMFDTMd7UmvVYVBSUvxikqzOTfr1tGq7Nti8TPj8zLkP6vC8o67p7ocErxyAbVWv2/ahh8T6ieXERJajMiYihwD/aUpW v1M8+LeS 4DJmgB6q9KrXlpVqDbSADQBOIRcXYxXP5cRTobLYq9MocEKIRiswC/GIFPc8obpr3UZJwXmNIbwiawuCQaYpbnAZkc5HV9aDI9Hcv+Dbcz+oWP8bfx5GzxB6rkiVspp4DsHiZo/pD2nKs6QEb4pjhMZOgYJLNg8o4dN5S6Y+Yjbx8Jdf9pcWLipLESYoeHOfrUw34LaPw0nZg2vaz1KCvbv8nwNlLMxV6j/T4QL9dVGUs2HGEAwWMbTejUWiROzoUrYdPULRgG6Rh67moIhbRO6WMJ0LINDOPbcIQPp0A0vlGseq5UzGMi2DI1z9OvlUjU5V1spWCIkAQ3NoUxKnS0ix8o0fLNIO07huvRzxgHPF2DfC3NYvBO/1q4s2zQoMSXjc+yKxQYf8wZTHf21IxzScPXZ50XeyERf8kBR9CElmKTzs7EJsv6gW8RhBPGEKI5ibu1wMU0OixZX8tRzPXdvbIVGKnx9Zb4XTsmjrTaLLEnL+DXzo3GoXE7w== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: Currently, the creation of a `PerCpuNumeric` requires a memory read via the `Arc` managing the dynamic allocation. While the compiler might be clever enough to consolidate these reads in some cases, the read must happen *somewhere*, which, when we're concerning ourselves with individual instructions, is a very high burden. Instead, cache the `PerCpuPointer` inside the `DynamicPerCpu` structure; then, the `Arc` is used solely to manage the allocation. Signed-off-by: Mitchell Levy --- rust/kernel/percpu.rs | 12 +++++++++--- rust/kernel/percpu/numeric.rs | 2 +- 2 files changed, 10 insertions(+), 4 deletions(-) diff --git a/rust/kernel/percpu.rs b/rust/kernel/percpu.rs index b97d1d07a614..7458fe413f25 100644 --- a/rust/kernel/percpu.rs +++ b/rust/kernel/percpu.rs @@ -26,7 +26,10 @@ /// Holds a dynamically-allocated per-CPU variable. pub struct DynamicPerCpu { + // INVARIANT: `ptr` is managed by `alloc` and the value of `ptr` does not change for the + // lifetime of `self`. alloc: Arc>, + ptr: PerCpuPtr, } /// Holds a statically-allocated per-CPU variable. @@ -204,9 +207,10 @@ impl DynamicPerCpu { pub fn new(flags: Flags) -> Option { let alloc: PerCpuAllocation = PerCpuAllocation::new()?; + let ptr = alloc.0; let arc = Arc::new(alloc, flags).ok()?; - Some(Self { alloc: arc }) + Some(Self { alloc: arc, ptr }) } } @@ -217,8 +221,9 @@ impl DynamicPerCpu { /// * `alloc` - The allocation to use /// * `flags` - The flags used to allocate an `Arc` that keeps track of the `PerCpuAllocation`. pub fn new_from_allocation(alloc: PerCpuAllocation, flags: Flags) -> Option { + let ptr = alloc.0; let arc = Arc::new(alloc, flags).ok()?; - Some(Self { alloc: arc }) + Some(Self { alloc: arc, ptr }) } } @@ -226,7 +231,7 @@ pub fn new_from_allocation(alloc: PerCpuAllocation, flags: Flags) -> Option PerCpu for DynamicPerCpu { unsafe fn ptr(&mut self) -> &PerCpuPtr { - &self.alloc.0 + &self.ptr } } @@ -234,6 +239,7 @@ impl Clone for DynamicPerCpu { fn clone(&self) -> Self { Self { alloc: self.alloc.clone(), + ptr: self.ptr, } } } diff --git a/rust/kernel/percpu/numeric.rs b/rust/kernel/percpu/numeric.rs index e4008f872af1..1b37cc7e5c19 100644 --- a/rust/kernel/percpu/numeric.rs +++ b/rust/kernel/percpu/numeric.rs @@ -62,7 +62,7 @@ impl DynamicPerCpu<$ty> { /// Returns a `PerCpuNumeric` that can be used to manipulate the underlying per-CPU /// variable. pub fn num(&self) -> PerCpuNumeric<'_, $ty> { - PerCpuNumeric { ptr: &self.alloc.0 } + PerCpuNumeric { ptr: &self.ptr } } } impl StaticPerCpu<$ty> { -- 2.34.1