From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id A4D8FC83F1D for ; Sat, 12 Jul 2025 19:50:28 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 5BBA66B00B0; Sat, 12 Jul 2025 15:50:26 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 51F386B00B2; Sat, 12 Jul 2025 15:50:26 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 3E4F46B00B4; Sat, 12 Jul 2025 15:50:26 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 2B86D6B00B0 for ; Sat, 12 Jul 2025 15:50:26 -0400 (EDT) Received: from smtpin16.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id EADBF10D0A1 for ; Sat, 12 Jul 2025 19:50:25 +0000 (UTC) X-FDA: 83656654410.16.298FFCD Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf10.hostedemail.com (Postfix) with ESMTP id 3A0EFC0007 for ; Sat, 12 Jul 2025 19:50:24 +0000 (UTC) Authentication-Results: imf10.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=Q0tX2vnZ; dmarc=pass (policy=quarantine) header.from=kernel.org; spf=pass (imf10.hostedemail.com: domain of sj@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=sj@kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1752349824; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=i+ga3H6QTmkzuata1gdU1JgT8kaYAM46YftKbbmTQps=; b=aCJ6pM/0fxueYodiOyQHAuWrB8vpX8RzG4NQi7cIfDzDzR6TFAMhNcfUDjpWnNq8GtfyZu w4i42Bdg6aGc9eU5qC15GIQyqCvrPAW/0gAgStIpjlxZSzPtLQHWSGClENBZ/pL3YNxLIm Eykavai/YdqbsKyQ4ZxW+Dd83YseMrE= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1752349824; a=rsa-sha256; cv=none; b=RrYoB6WdJjUhfqcO7vzD0mnNwhTvZThWF6EQQdFF4UGTGfkccIgOQuKZGYVI8Eamkz9A/C GtBQDC0l/3zxFUpRgSCOxOhiswCbJgkWYNuPOQCaoM3/omECsLPsZ6JRcEHqTdQwOC0EAy lv9MH8oziMuuoxbyWDuZm2AeMJFTf1s= ARC-Authentication-Results: i=1; imf10.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=Q0tX2vnZ; dmarc=pass (policy=quarantine) header.from=kernel.org; spf=pass (imf10.hostedemail.com: domain of sj@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=sj@kernel.org Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id B08E85C4784; Sat, 12 Jul 2025 19:50:21 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 3772BC4CEEF; Sat, 12 Jul 2025 19:50:21 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1752349821; bh=JQzHUCo6E86SNxkHiwVE3u7TqJ48m1u5XQT+KNsWP+Y=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=Q0tX2vnZvDL78oHqrWl4XfFPryieDDWOCjoRhH6amuntAiXHntNr8T0qLl8KNKmi/ JTE1i/Lp9CTrR7iv4tibfJF/5dyCcTIRWZ2p0BP/AgJzsQmkHwU4FPA5ZoRkR6ZRwp VPYju7t0X3AakzFacunJto2cws3sivEGWD4KXlaVbkpz8OHdEHnuYb1sJb+ILv7Scm HqLKG9rsF92ztUSnC5Ec/0jm6vwSbHjuEUa5f7o0kf/ApI5ARfc9zhZhxWy1g+c1mJ Lkn9/LGNRGzjyCG1FQ7V7NucTYJG35NVq00e43Ge62zFvc4w69UJ2cgt77krVUYjiA Ud0TMwFlW2aXA== From: SeongJae Park To: Andrew Morton Cc: SeongJae Park , damon@lists.linux.dev, kernel-team@meta.com, linux-kernel@vger.kernel.org, linux-mm@kvack.org Subject: [PATCH 01/14] mm/damon: accept parallel damon_call() requests Date: Sat, 12 Jul 2025 12:50:03 -0700 Message-Id: <20250712195016.151108-2-sj@kernel.org> X-Mailer: git-send-email 2.39.5 In-Reply-To: <20250712195016.151108-1-sj@kernel.org> References: <20250712195016.151108-1-sj@kernel.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Rspamd-Queue-Id: 3A0EFC0007 X-Stat-Signature: zhx7u7erscujdj9cpyr9krmsetnksr85 X-Rspam-User: X-Rspamd-Server: rspam11 X-HE-Tag: 1752349824-967528 X-HE-Meta: U2FsdGVkX1/Un0jTlsix+99vEyvjQXJgHnIrVqJkHfhL1cdL3q5l4Dk3K5OwE7aRICR9TU7SS1qE9U1piFaSn1FZPZIT/I7LPkSdUFlM/jo+EfeSYSjMsuGzYmK//ik71eYcwtJUsQF/aWpKW/fTGCdCnG15ZcMvem3tjnTf4AUCQO1Z4Bwrcl/158fj+vGHuKrosTEBQju/sjhfYQs9bCYR5j9uB+FidK0WRVuJeZr/nM2vgYXxr+Y4yjuSnLaUBH+eng1hErz+Y1zniMHUlglI35Zn5+B5bPLQ7IqdT910DBGtJf32g4F4JEEb7ueqm0UTwjZBo2dCZjuX50od990cFLvQN8Zou6hxuO3iEz+ZiCRjX2hYEWYVnD6mW5TyOrEKTIvMzKjsiVcZT5gn6U+rLA0nb31e6qhCTDwBODOGs3mOWyhb5hEWj03oeVQXdJFlSBMkrH8WwcIqKBCGSFwxYmmJ1uNpPM/59ofUKR+WHWiLvgrMiA8hp9FZpBP1DhIk86rB76Prtxx7pqUX3Dx87ivQO9A0rcej9HM6NKXQCm5LYcVJWjL4S6pUDaP5wF44HBhvkGuSd44J2TdSnF9eOAp+XNZRp44xtdCraFAiQltNmvZDQavq5wpEWWxvOsa6BDOMxchL9NgFHhK3TkNCa/05nrqMSBtAp/+V4ZXh++1ToCSKMM/WKXILgs19OTCGenSPpWHC8N4wJ5PVDzIUowZXS9RnF5VdXXBNgcL5w929r5nvFH78btZTRSBdMwCOMY/ZyqUim8IklkkF3YhTAMzU8T9cEiNwk57ltCfjLzuvL0w0xB/6V+3wseUaw9ZKewNcHM6IjsEWiFWa750QTUhaa2R8bfTWcqJHarqRNwoWU/iLJxDJ386L0cFZlL3PTfb4lb0OEBLix1qRzC/WWn9CIOz00NRvuN/qOBhhrEXVJACrPPe9M9sfMxPUaO8Bm3imkjc+x4jMbQP HPj8nBSk e1Iwul5hvFD8TOWLqL+uii6e7CjKeJ49gueRd12eOQwi1YDrS9fY/RgOr2dQBmBqiDNstgsgk55Cn2B2bNESB4aSN1SR3eaT1SdfZ2cgOXTasC81pzPNGaXV5ylQBmDisgozIiIwFltRpPd80vie/FuVqXfguf8w86AJcCuvcdMybn+haSE7U6fp4/s40TsKsmIJLFIMSVftcj5UmG3QRWGCmEGxAUbBdP+qgCerk29kmeoqZ83X2wsXBug== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: Calling damon_call() while it is serving for another parallel thread immediately fails with -EBUSY. The caller should call it again, later. Each caller implementing such retry logic would be redundant. Accept parallel damon_call() requests and do the wait instead of the caller. Signed-off-by: SeongJae Park --- include/linux/damon.h | 7 +++++-- mm/damon/core.c | 49 ++++++++++++++++++++++--------------------- 2 files changed, 30 insertions(+), 26 deletions(-) diff --git a/include/linux/damon.h b/include/linux/damon.h index 1f425d830bb9..562c7876ba88 100644 --- a/include/linux/damon.h +++ b/include/linux/damon.h @@ -673,6 +673,8 @@ struct damon_call_control { struct completion completion; /* informs if the kdamond canceled @fn infocation */ bool canceled; + /* List head for siblings. */ + struct list_head list; }; /** @@ -798,8 +800,9 @@ struct damon_ctx { /* for scheme quotas prioritization */ unsigned long *regions_score_histogram; - struct damon_call_control *call_control; - struct mutex call_control_lock; + /* lists of &struct damon_call_control */ + struct list_head call_controls; + struct mutex call_controls_lock; struct damos_walk_control *walk_control; struct mutex walk_control_lock; diff --git a/mm/damon/core.c b/mm/damon/core.c index 2714a7a023db..b0a0b98f6889 100644 --- a/mm/damon/core.c +++ b/mm/damon/core.c @@ -533,7 +533,8 @@ struct damon_ctx *damon_new_ctx(void) ctx->next_ops_update_sis = 0; mutex_init(&ctx->kdamond_lock); - mutex_init(&ctx->call_control_lock); + INIT_LIST_HEAD(&ctx->call_controls); + mutex_init(&ctx->call_controls_lock); mutex_init(&ctx->walk_control_lock); ctx->attrs.min_nr_regions = 10; @@ -1393,14 +1394,11 @@ int damon_call(struct damon_ctx *ctx, struct damon_call_control *control) { init_completion(&control->completion); control->canceled = false; + INIT_LIST_HEAD(&control->list); - mutex_lock(&ctx->call_control_lock); - if (ctx->call_control) { - mutex_unlock(&ctx->call_control_lock); - return -EBUSY; - } - ctx->call_control = control; - mutex_unlock(&ctx->call_control_lock); + mutex_lock(&ctx->call_controls_lock); + list_add_tail(&ctx->call_controls, &control->list); + mutex_unlock(&ctx->call_controls_lock); if (!damon_is_running(ctx)) return -EINVAL; wait_for_completion(&control->completion); @@ -2419,11 +2417,11 @@ static void kdamond_usleep(unsigned long usecs) } /* - * kdamond_call() - handle damon_call_control. + * kdamond_call() - handle damon_call_control objects. * @ctx: The &struct damon_ctx of the kdamond. * @cancel: Whether to cancel the invocation of the function. * - * If there is a &struct damon_call_control request that registered via + * If there are &struct damon_call_control requests that registered via * &damon_call() on @ctx, do or cancel the invocation of the function depending * on @cancel. @cancel is set when the kdamond is already out of the main loop * and therefore will be terminated. @@ -2433,21 +2431,24 @@ static void kdamond_call(struct damon_ctx *ctx, bool cancel) struct damon_call_control *control; int ret = 0; - mutex_lock(&ctx->call_control_lock); - control = ctx->call_control; - mutex_unlock(&ctx->call_control_lock); - if (!control) - return; - if (cancel) { - control->canceled = true; - } else { - ret = control->fn(control->data); - control->return_code = ret; + while (true) { + mutex_lock(&ctx->call_controls_lock); + control = list_first_entry_or_null(&ctx->call_controls, + struct damon_call_control, list); + mutex_unlock(&ctx->call_controls_lock); + if (!control) + return; + if (cancel) { + control->canceled = true; + } else { + ret = control->fn(control->data); + control->return_code = ret; + } + mutex_lock(&ctx->call_controls_lock); + list_del(&control->list); + mutex_unlock(&ctx->call_controls_lock); + complete(&control->completion); } - complete(&control->completion); - mutex_lock(&ctx->call_control_lock); - ctx->call_control = NULL; - mutex_unlock(&ctx->call_control_lock); } /* Returns negative error code if it's not activated but should return */ -- 2.39.5