From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id C176BC83F1D for ; Sat, 12 Jul 2025 19:50:31 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id B12C76B00B2; Sat, 12 Jul 2025 15:50:26 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id A74A56B00B4; Sat, 12 Jul 2025 15:50:26 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 9633A6B00B6; Sat, 12 Jul 2025 15:50:26 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 775A46B00B4 for ; Sat, 12 Jul 2025 15:50:26 -0400 (EDT) Received: from smtpin15.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id EFCF757990 for ; Sat, 12 Jul 2025 19:50:25 +0000 (UTC) X-FDA: 83656654410.15.B3A0D13 Received: from nyc.source.kernel.org (nyc.source.kernel.org [147.75.193.91]) by imf04.hostedemail.com (Postfix) with ESMTP id 6B36E4000A for ; Sat, 12 Jul 2025 19:50:24 +0000 (UTC) Authentication-Results: imf04.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=dZhCx5mB; dmarc=pass (policy=quarantine) header.from=kernel.org; spf=pass (imf04.hostedemail.com: domain of sj@kernel.org designates 147.75.193.91 as permitted sender) smtp.mailfrom=sj@kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1752349824; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=CFkduCscuzqS2cVp7iuMW+eyLg/1OXMXZG7sEaCKTug=; b=RW8Lz+z8EexFdBDzvAPU75AOFaIoKXHma+crBOgvNel+7IvLGHSWOR96oGx/xk9uvcUgh9 HmlH6VF32ycQlVab8vy1m41NEOEceRDGN4OVNhQeQ2usyanuyldDvWOTn2tgKszxfSdwiO dPoEMias8Wn3nj/RQ05nPH4yy+GmGkk= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1752349824; a=rsa-sha256; cv=none; b=Czsy9LhnmuUrN3C0tHdffeFM1GSdcujLmeg+6e7ofKDpkhNoqaJ+oFDiKy4/WzoGBqi/ab Q4GmlqSSJor8DF9LGjatAZNNJKg2/M+I7tbNSoT2fu8FDfrhIy52J1UyPqpk4yHWh41Df7 a7+ykZK0qrOKNhMxM5/94yYw0Lh6DQU= ARC-Authentication-Results: i=1; imf04.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=dZhCx5mB; dmarc=pass (policy=quarantine) header.from=kernel.org; spf=pass (imf04.hostedemail.com: domain of sj@kernel.org designates 147.75.193.91 as permitted sender) smtp.mailfrom=sj@kernel.org Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by nyc.source.kernel.org (Postfix) with ESMTP id B109DA54F31; Sat, 12 Jul 2025 19:50:23 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 5A2D4C4CEF5; Sat, 12 Jul 2025 19:50:23 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1752349823; bh=zg5wCAX53+Zaz9D4ii0pAZ1fdfy4NlBPdESVNdjo6HE=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=dZhCx5mBp1+DmVO9gPRsFOjjrVDd0+M7Ain/KZjwWiIFaBhl1BKhE8j6sB2AtTXxR PexvP3cWaiJTTCJjphxyMs9xoWE/ppkV8kFIGVPzXhxA4u3yc+WcORyNFtvCdlDuEo /bN3XYWiqcOscvlPbfVvtAXJPwfeK10ZeSlFaaY7rNxoZaS5q8RXDvR9WUG1+zlCiK ku925kWoJlzXlxbA/lp10XKYE+knsMG1nEjJQZhTqe3wNPWv3MooACCzisIpaN5zIY Cf6PUwW1mQRP4ixjBYA8P+xCd7toRYAU+L0Xly+rcSmwZIE/rw+znYZANQmk2J96e0 Td15cpGo/q+RQ== From: SeongJae Park To: Andrew Morton Cc: SeongJae Park , damon@lists.linux.dev, kernel-team@meta.com, linux-kernel@vger.kernel.org, linux-mm@kvack.org Subject: [PATCH 03/14] mm/damon/stat: use damon_call() repeat mode instead of damon_callback Date: Sat, 12 Jul 2025 12:50:05 -0700 Message-Id: <20250712195016.151108-4-sj@kernel.org> X-Mailer: git-send-email 2.39.5 In-Reply-To: <20250712195016.151108-1-sj@kernel.org> References: <20250712195016.151108-1-sj@kernel.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Rspamd-Queue-Id: 6B36E4000A X-Stat-Signature: fi6w1huj7zcemgxk88duapbkh53aonx1 X-Rspam-User: X-Rspamd-Server: rspam11 X-HE-Tag: 1752349824-992870 X-HE-Meta: U2FsdGVkX18cfi2Ixnozh7gpWuMagRoP7PugipiUhOn0VO/nMzz+MvkGAxHHTxGRvpX4ZGpq/q0fVNXdF2cQUzEhf2wa9DD20gJUB9fqO83WjidUfMnTnDx6Wn3CWDIVOvaTRJdsXC81yQVGLdbFssoZ2WOZIiudEoys7WeW4NTEM5c0Akw/dH6QPoqJb4elKz/9vebryW7KyTxjIu/XFSB6oHgA0IRJI3rfhVtb6g2M0Z4BEnqu92IiLm75jHhbb6Z6gBtrEwWHhIMwUSXJTHzuZmOgNRarYZYXUdC825c53ErZehlvORFC+XP6I2Gbq/zL+Of8dyrMCws9PisqX3OS1S5oB3haOn568009LjbHs28Gu6fB/Nq8YZWxgtdV5y9kwM2aKVdxG+V6+690/yPyODI9iMrT2AVbT0SuGUirGKaKn3gGEpnftXE8Qzw0LtXzlEC8JMZmSfwZnGknWr3sMcZkYZBW6POwKIbCBMxoczjzNQ+dNHIS8YBN0SrGUFYHQNIjRgqkTh/y4HlPK3AQ/+RsJSeuyip4duFtujpcKjhNjkYmYYLjbq7nhGG2yCBr9ciHFDGxtXRRei7ZqFXO/JQnzorYtyASLtxSmSaIf26os5JIhuvRJD/Zrmf8Lmh0MLUvRW0yn6RiWbzgmRlTT55Sxse0xYEIWjagcAY6+tKdLaP7xVD5TgfbAptYFN30NbhVAfXT3Ls5rrsXWiZkDYcK+Rrys9dsVkJNa/ZXGcvnMeGOSbXlrH6JaUNh9GsnEsrNmFFADjPd9AiJkPleQDuk6lG/IV3jCNtfHn/UP8CFDMQO6mpslHKp5D9c+TPk+nn7X+IdsWk1GPuK2e6wx3pokwL4ysQwu/Xwm8+kk2KUzeXYDsQW3ZhYQ2/0FBrAR9xPWhiXbJTGyaZRYMiZZCAlVYEHxvcj2Av7ho5lajmYeRK4/2oiQCM3vH9psGQWHrguJPY7uQpJ+lD A4q6VQBD q/YXsmli/9hsK8714YN6j3crv5F8jq7a8PfiWQ7yudDJn2yUlzsnOHRICnukBMnAB7Qlrf+5AYuwM87UgvJblvj4PZxHX4fj3y2/gBPEPuquYgUP6vaGx2aB6s4N6Njbhydh2MoXAd0AH7MUxBO//xcChLRpkln8ZJIbjIVGLdYLQfLg4htso6D+Yg5Vp1G3v7aGKK4vH53SOVAtWldAqe8obYTrWUcp6+62rLC/Xg5ndZvbDqBp+/qIoD+SdTdFbyYXgVKTevnSfu4CrJymLTdBYqA== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: DAMON_STAT uses damon_callback for periodically reading DAMON internal data. Use its alternative, damon_call() repeat mode. Signed-off-by: SeongJae Park --- mm/damon/stat.c | 17 ++++++++++++++--- 1 file changed, 14 insertions(+), 3 deletions(-) diff --git a/mm/damon/stat.c b/mm/damon/stat.c index b75af871627e..87bcd8866d4b 100644 --- a/mm/damon/stat.c +++ b/mm/damon/stat.c @@ -122,8 +122,9 @@ static void damon_stat_set_idletime_percentiles(struct damon_ctx *c) kfree(sorted_regions); } -static int damon_stat_after_aggregation(struct damon_ctx *c) +static int damon_stat_damon_call_fn(void *data) { + struct damon_ctx *c = data; static unsigned long last_refresh_jiffies; /* avoid unnecessarily frequent stat update */ @@ -182,19 +183,29 @@ static struct damon_ctx *damon_stat_build_ctx(void) damon_add_target(ctx, target); if (damon_set_region_biggest_system_ram_default(target, &start, &end)) goto free_out; - ctx->callback.after_aggregation = damon_stat_after_aggregation; return ctx; free_out: damon_destroy_ctx(ctx); return NULL; } +static struct damon_call_control call_control = { + .fn = damon_stat_damon_call_fn, + .repeat = true, +}; + static int damon_stat_start(void) { + int err; + damon_stat_context = damon_stat_build_ctx(); if (!damon_stat_context) return -ENOMEM; - return damon_start(&damon_stat_context, 1, true); + err = damon_start(&damon_stat_context, 1, true); + if (err) + return err; + call_control.data = damon_stat_context; + return damon_call(damon_stat_context, &call_control); } static void damon_stat_stop(void) -- 2.39.5