From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 210AEC83F1D for ; Mon, 14 Jul 2025 02:44:45 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 71DF46B0096; Sun, 13 Jul 2025 22:44:45 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 6CE9A6B0098; Sun, 13 Jul 2025 22:44:45 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 5BD436B0099; Sun, 13 Jul 2025 22:44:45 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 476D56B0096 for ; Sun, 13 Jul 2025 22:44:45 -0400 (EDT) Received: from smtpin30.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id DBED51404BA for ; Mon, 14 Jul 2025 02:44:44 +0000 (UTC) X-FDA: 83661327288.30.10864B7 Received: from mail-pl1-f175.google.com (mail-pl1-f175.google.com [209.85.214.175]) by imf07.hostedemail.com (Postfix) with ESMTP id 3E16740007 for ; Mon, 14 Jul 2025 02:44:42 +0000 (UTC) Authentication-Results: imf07.hostedemail.com; dkim=pass header.d=bytedance.com header.s=google header.b=gyjureaE; dmarc=pass (policy=quarantine) header.from=bytedance.com; spf=pass (imf07.hostedemail.com: domain of lizhe.67@bytedance.com designates 209.85.214.175 as permitted sender) smtp.mailfrom=lizhe.67@bytedance.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1752461083; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=GGnDLyzoK1hk6QcZEHX4yplSrEzwZbOUE/lD+OVxxOo=; b=PYa8GDK1nWmRqAP5Ag8wRd0IYfdiyGBT43CreDLVXdywPxgMGsx+lg3xCv0070BlDxgLoY V0VMhcUGyzp7B0yAVR9XZBo5va5p9fZADa9YfiHEFPcjxP7dJ6dy72igv8sdIyfltDir4F OG+vNf6gNCy2Uub8xrFAVLXf9viUaag= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1752461083; a=rsa-sha256; cv=none; b=s+9tdiBBwuVWCbnUDoC+U2PVMzB70sbzKyODPEYHRQCfQ+sMDyxgdhW1uKh6cRk3Coy5Kt 5E333Sb6VFvrFKTeRLW1dttz33oQVSms2nHCNbp2IdpF1jq/K8ioafs/i0Nz3JIhEhSywd QHLxFH47OcEi+whZm6y4jhOI2TaQiKo= ARC-Authentication-Results: i=1; imf07.hostedemail.com; dkim=pass header.d=bytedance.com header.s=google header.b=gyjureaE; dmarc=pass (policy=quarantine) header.from=bytedance.com; spf=pass (imf07.hostedemail.com: domain of lizhe.67@bytedance.com designates 209.85.214.175 as permitted sender) smtp.mailfrom=lizhe.67@bytedance.com Received: by mail-pl1-f175.google.com with SMTP id d9443c01a7336-23602481460so35325615ad.0 for ; Sun, 13 Jul 2025 19:44:41 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bytedance.com; s=google; t=1752461081; x=1753065881; darn=kvack.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=GGnDLyzoK1hk6QcZEHX4yplSrEzwZbOUE/lD+OVxxOo=; b=gyjureaE5OyIkzE5Nn1YMR5lR5WC5GBSd9lbOufQRpIrAJV5hzTT8PsfS6ObrUk2Xj BvgZfsrQwbDoKu6/NVBAbwvQTKSt07uNPr4qKDztsEQSoU4PuwvfxO8/kg1p/Qva2m5w UPex6rmHSnZCFE3+cAba90MdThJ35haXJJ3No2MOBo5vb+2FAcVesA92Spzv8d6EHffV Z84hFOfDpTlJkGeRpNTdtCxPrP1HJ22DkxeKNoLyRm2u9BDZy8LoNRZIU6ai3r7WLoHt w9ZPjO/8w9rCrXqkw6yaqpGP4T8GaamRSKICyFvmDlDd8g7rHGFo/jKejKjQOWqS0Yrz 9enA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1752461081; x=1753065881; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=GGnDLyzoK1hk6QcZEHX4yplSrEzwZbOUE/lD+OVxxOo=; b=V1Ltjli+3qROTu8AX5qbLUcd96eRV9LTv6UDe40egtkKxBTX1JG91IkrgGLeHIQ7k5 6vHub/gN0+qCAtFOy8BykG6wRR5nFssvGTEElH3Cj8kCoWJnNyNL+PEqJsvQAEJHPiyQ 4smRsvLlIM4OdwoIbDdqdSPDxC+I1L3hE0I7tCKaY2Es5gLmV/GTLnWTFNZAVsunIoDr SVBlMyu5ECFY2N+fNfuHjGM/pCWEyoS24qQc77tPXIT16RcSRrKU2Noeiob3IV+LQeMA 4q+w5AEUnY8oIKNI03fmsWw5viZmg3lMSm4FxDWmPDGvYRU+1J5wvzBvbgAOdIpLLgrN QP2g== X-Forwarded-Encrypted: i=1; AJvYcCVjvcWpgHdnI/01RcjEuyctGW/O9DeJ1fdIrNoFcw52WEHBDRVI82ki0nrZSJzd6UCCszNGQCgf6g==@kvack.org X-Gm-Message-State: AOJu0Yynx5bpkoB/X9VtkkG63Vpt7WMzBl59ElYvEYJ+xVs87aDf4037 17hp9Fd0UfVi4e/nDikz+rjBnrOT8h83mtccjJJAZIXAwrNv6Cs6UtcJdtoFgd1YyZ0= X-Gm-Gg: ASbGncsKTO+qguSsZrSDU5YUaxbg1Y8hI8eVxChPgCBL+WqG2Njp9U2c3/GbnDi+n02 EuLlhjJh9HD9CUF8Fv6I77JskTuGP+vWegTicF0ADhAM+8Ir9HST73l5NQ2yslJKLOMZ/guJK0s 1N0cYqbSOccK72/HCM8hvkNRAZkQljqIlNsvllyoAB57G2z+0kLbqpDWZTYPu8ejjE44hiagdgr LVGoOkJP/TOkGTdVscISD1P2f/HwaBTsPe0XHi5F+PhBBPXnjudcbeytGo3q2EMp24C3OKKNu5d CfaOGTR8/HgKoDj+UXJKXHK4P61zZebYLU8kMnGKYH02PCtS5fTTr3UMqtvpnEcb6sMOvlQDhgK 2tVxFxw18devtLqU7DB1MnACHzkQLMbbkMnD9KOCe9jzb6VdDzA== X-Google-Smtp-Source: AGHT+IG2a3ZcNn/X49Q30mvFsGR46F/NachCN13vl0w9s5ICMWR61xTnTwucl1IEoa++sqdOjScs+w== X-Received: by 2002:a17:902:f70d:b0:234:a139:1206 with SMTP id d9443c01a7336-23df093ca68mr146385185ad.40.1752461080974; Sun, 13 Jul 2025 19:44:40 -0700 (PDT) Received: from localhost.localdomain ([203.208.189.11]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-23de4323daesm82683445ad.139.2025.07.13.19.44.37 (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Sun, 13 Jul 2025 19:44:40 -0700 (PDT) From: lizhe.67@bytedance.com To: alex.williamson@redhat.com Cc: akpm@linux-foundation.org, david@redhat.com, jgg@ziepe.ca, kvm@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, lizhe.67@bytedance.com, peterx@redhat.com Subject: Re: [PATCH v4 2/5] vfio/type1: optimize vfio_pin_pages_remote() Date: Mon, 14 Jul 2025 10:44:33 +0800 Message-ID: <20250714024433.14441-1-lizhe.67@bytedance.com> X-Mailer: git-send-email 2.45.2 In-Reply-To: <20250711153523.42d68ec0.alex.williamson@redhat.com> References: <20250711153523.42d68ec0.alex.williamson@redhat.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Rspamd-Queue-Id: 3E16740007 X-Stat-Signature: q5ig9udzojxsejqz6xti7feaz1kw6cb8 X-Rspam-User: X-Rspamd-Server: rspam11 X-HE-Tag: 1752461082-967144 X-HE-Meta: U2FsdGVkX1/JTi+pqMxSzWWevliJQH18oi+fp4eZyCxL57wOUQtGnYw/L2EIox240oI+mmfk8BGeMQ3GdDlv0M2suayoL8IJ+zwj2X26pWGZqRmXawUCoN34EjTR9egXseP0B9pl2Bfv4VhjKGHtJ4dJhuXhgqTzglTuILC+S5Eo0eEskofqgPO4hI9I3Se5M6yrrc8vBXJJNH2YnVDlI0NbvhKShBI6AeiFt7KnC1BhGB2qUNW5TBIilt3QmOG8Rvij1Sa2fBuKeAIiJk4Af5xWN/ezcSsB/YQzD0ThuxExue8sY8gTk0JoTx1m8eSSewMCAJBHnUr4rp2Dav26EEwrnAY8ixEpNEDdSWNmh3F4ZwASSpea4qItQQpatsLvVqQS+/Dw+uLKD3sQKOErJttHZqywz2ZgsTNfe1hsACegFXJyTacDI8mHLang/RkMqi7+SuBBDY1NjkGccisYlb0IfTpMHWDomLCLGSGkkfOcGgyKE29KXswp/iTk5yGPC6ejm/ROXI6tomGD4rqYleV2JOdabGlYmLyeEAXJyHpKiB3xD5jGkur1BDLrfur91jD7fpoI2tWLj17TBTPjJ8GY+pe4GwzrwOM5CZJDqAe+L+TJZnqafVUSfgq64VaDQLsFogQOdffq/KgKL+d1NYI3ddwaM/ACT+EX5t2DeUpT+4qumBQu761/YJ4rb165cpzDFNYa6eUAXDfW4zKEzzXp+GzAJhb5+wd1S+VUVZ/6uiE4xGsQgjePhl4v1PbBoYVaepKjCNAZUQxiUIQopJwQzsKW4pxeSvV/YBS842lQAgaPa1FaGI61TTBvrYTzvmC2POgnQiNNf6vF6BRJQjM1IKwmIE3vAOXGbUAMlNIyQ+dPJpisdVo/NNaSLo+x270vDdo+bTsRYJWVYJx4TjnGedGYDFj/JfsMwav5q/YxHyPkAb89csaA891ekCGvihpVZcc2LFU5PKxLo0O Z7qOF7BV aIaK8uJOCts5O6Kq6uCiUqMd0XR/zsNxL/1hwrr+bSVGUTFr3R9+X2aLVpVpl9TkW4XlVFQphoBI4XrXJoUByNJFYhpFfxhztvGd+6JJ3RFCtXXm5KEn6WAe8Yeo950hbM7795u7Plu42m1OsEbG5OBVvgLm0TDRD+rQDicBeg/enxOL0Yt5Hps3kOV6gXJJfzyvY2L0e2PXulJ4vIa3plEwTi51tlDbNzkl5LxitYodeEDsm7yYxCwORYFs1DE2kvaZVvbmFCkzoXkB6ypjbmGMLFgxRTZNtOMyTm6aqHCYlYqvRrQxs9b7f4/JP4sJQntACt/z8783dcKBb+Z+laszGJ6gWbet5F67DvQjpOdWIfuO1EDIsotJTBA== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Fri, 11 Jul 2025 15:35:23 -0600, alex.williamson@redhat.com wrote: > > + if (acct_pages) { > > if (!dma->lock_cap && > > - mm->locked_vm + lock_acct + 1 > limit) { > > + mm->locked_vm + lock_acct + acct_pages > limit) { > > Don't resend, I'll fix on commit, but there's still a gratuitous > difference in leading white space from the original. Otherwise the > series looks good to me The leading-white-space indentation was adjusted in accordance with David's suggestion[1]. It seems to me that either approach is acceptable. Thank you for your review. Thanks, Zhe [1]: https://lore.kernel.org/all/9d74e93d-5a5f-4ffa-91fa-eb2061080f94@redhat.com/