From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 36405C83F17 for ; Mon, 14 Jul 2025 05:24:10 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id B2E5C6B00A6; Mon, 14 Jul 2025 01:24:09 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id ADE756B00A7; Mon, 14 Jul 2025 01:24:09 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 9CD836B00A8; Mon, 14 Jul 2025 01:24:09 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 8ACA46B00A6 for ; Mon, 14 Jul 2025 01:24:09 -0400 (EDT) Received: from smtpin06.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id 58D9EB9E71 for ; Mon, 14 Jul 2025 05:24:09 +0000 (UTC) X-FDA: 83661729018.06.36340DC Received: from us-smtp-delivery-44.mimecast.com (us-smtp-delivery-44.mimecast.com [205.139.111.44]) by imf26.hostedemail.com (Postfix) with ESMTP id 74C58140008 for ; Mon, 14 Jul 2025 05:24:07 +0000 (UTC) Authentication-Results: imf26.hostedemail.com; dkim=none; spf=softfail (imf26.hostedemail.com: 205.139.111.44 is neither permitted nor denied by domain of airlied@gmail.com) smtp.mailfrom=airlied@gmail.com; dmarc=fail reason="No valid SPF, No valid DKIM" header.from=gmail.com (policy=none) ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1752470647; a=rsa-sha256; cv=none; b=SM69LqSCabthRRozP0wCCsJuDArDD2fyH0Qw6Vk7+msUTuxm6d08doWWqXlHddHQW/MlSq F3I0Pgcm7ZeCRHnDbBMKlpPq0V5MHRJxWQSeTX+wBNfIL3gVVuOTIR4hEMquCK6wz4GQCO zUaTnIbxupwHszVQJPAURSxaj9oXLX8= ARC-Authentication-Results: i=1; imf26.hostedemail.com; dkim=none; spf=softfail (imf26.hostedemail.com: 205.139.111.44 is neither permitted nor denied by domain of airlied@gmail.com) smtp.mailfrom=airlied@gmail.com; dmarc=fail reason="No valid SPF, No valid DKIM" header.from=gmail.com (policy=none) ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1752470647; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=oQhJ+Sq7zfubxHCDGJzy/hNtuwPaLBG/Z0pwsJnf9/4=; b=4fnKkHCd2Snw6tRkzyyczqCRwJoNkczYUgxFCeyweI/mzHbrO6T7KeqQ2fKwAzfkhZaAd8 dMfVtF2IFdhPBruE3cJECNLmhaE0R1cQiMfFJmgG9Az7xf6OakgE0lLENdHA/AmthhS75k FJlTJeZ1SLYwBNOeoALl8++MGYEnw+Q= Received: from mx-prod-mc-05.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-684-c-Cndiw8PnSsPX-9VpwHLw-1; Mon, 14 Jul 2025 01:24:03 -0400 X-MC-Unique: c-Cndiw8PnSsPX-9VpwHLw-1 X-Mimecast-MFC-AGG-ID: c-Cndiw8PnSsPX-9VpwHLw_1752470642 Received: from mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.17]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-05.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 00CF51956096; Mon, 14 Jul 2025 05:24:02 +0000 (UTC) Received: from dreadlord.redhat.com (unknown [10.67.32.31]) by mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id B09F61977000; Mon, 14 Jul 2025 05:23:57 +0000 (UTC) From: Dave Airlie To: dri-devel@lists.freedesktop.org, linux-mm@kvack.org, Johannes Weiner , Christian Koenig Cc: Dave Chinner , Kairui Song , Dave Airlie Subject: [PATCH 11/18] ttm/pool: initialise the shrinker earlier Date: Mon, 14 Jul 2025 15:18:26 +1000 Message-ID: <20250714052243.1149732-12-airlied@gmail.com> In-Reply-To: <20250714052243.1149732-1-airlied@gmail.com> References: <20250714052243.1149732-1-airlied@gmail.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.0 on 10.30.177.17 X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: 4uytVIC8zWrBko7r004xhN5lcvH4iPoww-HIhQ_T6aY_1752470642 X-Mimecast-Originator: gmail.com Content-Transfer-Encoding: quoted-printable content-type: text/plain; charset=WINDOWS-1252; x-default=true X-Rspamd-Server: rspam12 X-Rspamd-Queue-Id: 74C58140008 X-Stat-Signature: t8rg1xsfgmcudtx4azjtcehn1fu138s7 X-Rspam-User: X-HE-Tag: 1752470647-137255 X-HE-Meta: U2FsdGVkX1+4ztM9/YH2MhuHfpzEjexpeoh/bCJ2sLYsLxpD56q9SHJH93YRDL5ruwQAoNRCzQmZ6i88WlGcfuTXgrlcKLsCYMXGdecUQ53e4wXs2Znikyc1lliAI+xUm5I8CjpkNAEDkPvKolheFovXGapz1VsP7K6waGjDnyIN62LA4sdylZhD+3+TZGfOI+x/kAGn+RGoYfyIETI7ZUQBE3mpEC3jVQJ6NuifDyP7AzSp3AzCV2XVJ+RhB3AJQ+Rl4iJYEaawRcTx8SvgZzouuG3WFnCRtu8oxEf28sxiBAw6E3hoq/4PRz7pAvpucwzLXKXEXx9hLLt7LqK9E4nfUWDtMeEsJvAPKppK3YPFNBCGgPvWErqYHnq6DgOf8+At3VMICJj4xLKQEVpdShtyIoOcjEWp9vYq/LIckYF+JmIO2QBHOeGs8rp2ZYfDTGtyQmjO3Xk+aTTgARKQj/GTa/mwrRCGAeCLfLR+3AwLMx9/oirXrlVt1zAqMHgyQdnxWCjATtjLzvyqjVu1GX3IIYHKv0nsreh2SXY7MZn5UKkTEm9Yv1IkK1gc4g59Rc80RcH+QOwRBdb+NS1Dh2ztUfWT2QqHNK9XqWeO58hXGbJG9INy7m/5LbUISijLSvBD6YDz/oFszDJhmrrs/g8Q4E+ba0xW1Qr5we0E+0bxwo1/rFdak2JOSPZMHyRrAxqiRUeg+5T0o0XEfBuA5EOmQ+xvulW++lnZM/Rw8e6Mly5T15MWfD8fHlmNGlY1NvD3vspyYLMz7TeladRbvWpz49oQlY6ebnLEZwZdonrMWIOrVAa7ucQ3w8DpN3u2swqVh4K7rL38eVT3C8RaV6WSJwKIPqMufMo7mJkX7WjNRyn22BSF1ykRq+5M74/XfvpTclj5qgmjbEGPo/7s9TgTBf2mDBC7Oiwu8wySNO3NwQ5gttT5uDzuNfuE29RltL5z1KZq/xQfljsgyo9 1AM00eTS 9th2WDFffqW8aanfY2c/QyiNiorCbMEdPBo/yrhLK3+AZD+DimUQX9Gmk8OCFS1wPTekzMMxXbIfESweZi13GiErdQEblU4WH9IkCW6WgEl9tczOUyLNi+x1AfFpPN4iFgzItV7QjbYw8ZvjnTcMG25yva4gISu1qtsPwFnUtWGmytuRA2rJqwjKRLoNcA6MnR9/OKzvAB7o99EIUwVqEmCVuCUe6R7AWdEFw1OMDJXJUlsXkM7SJ6YuSXwlj/ktrKK6+9+PGf3XwdQzR3KM7mprQvkA4vRxj6rDzx46O/ADGP+5v/EoulzzSePHIe0t+CAmn1N46acFdQO4tQgCs7lSBMmdfzPWajfUIerhMAnmo/Ej9GVnnPLUAvXERQ8vM39aOc+jAmoBAsUx0tqcIQtuTfg8EhJ8yvoIiEeSseIBQbts= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: From: Dave Airlie Later memcg enablement needs the shrinker initialised before the list lru, Just move it for now. Signed-off-by: Dave Airlie --- drivers/gpu/drm/ttm/ttm_pool.c | 22 +++++++++++----------- 1 file changed, 11 insertions(+), 11 deletions(-) diff --git a/drivers/gpu/drm/ttm/ttm_pool.c b/drivers/gpu/drm/ttm/ttm_pool.= c index 63eb81b18987..a4f4e27c6a1f 100644 --- a/drivers/gpu/drm/ttm/ttm_pool.c +++ b/drivers/gpu/drm/ttm/ttm_pool.c @@ -1382,6 +1382,17 @@ int ttm_pool_mgr_init(unsigned long num_pages) =09spin_lock_init(&shrinker_lock); =09INIT_LIST_HEAD(&shrinker_list); =20 +=09mm_shrinker =3D shrinker_alloc(SHRINKER_NUMA_AWARE, "drm-ttm_pool"); +=09if (!mm_shrinker) +=09=09return -ENOMEM; + +=09mm_shrinker->count_objects =3D ttm_pool_shrinker_count; +=09mm_shrinker->scan_objects =3D ttm_pool_shrinker_scan; +=09mm_shrinker->batch =3D TTM_SHRINKER_BATCH; +=09mm_shrinker->seeks =3D 1; + +=09shrinker_register(mm_shrinker); + =09for (i =3D 0; i < NR_PAGE_ORDERS; ++i) { =09=09ttm_pool_type_init(&global_write_combined[i], NULL, =09=09=09=09 ttm_write_combined, i); @@ -1404,17 +1415,6 @@ int ttm_pool_mgr_init(unsigned long num_pages) #endif #endif =20 -=09mm_shrinker =3D shrinker_alloc(SHRINKER_NUMA_AWARE, "drm-ttm_pool"); -=09if (!mm_shrinker) -=09=09return -ENOMEM; - -=09mm_shrinker->count_objects =3D ttm_pool_shrinker_count; -=09mm_shrinker->scan_objects =3D ttm_pool_shrinker_scan; -=09mm_shrinker->batch =3D TTM_SHRINKER_BATCH; -=09mm_shrinker->seeks =3D 1; - -=09shrinker_register(mm_shrinker); - =09return 0; } =20 --=20 2.49.0