From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 91700C83F1A for ; Mon, 14 Jul 2025 20:37:54 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 905736B00AA; Mon, 14 Jul 2025 16:37:52 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 8B6306B00AB; Mon, 14 Jul 2025 16:37:52 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 7A41C6B00AC; Mon, 14 Jul 2025 16:37:52 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 5E1E46B00AB for ; Mon, 14 Jul 2025 16:37:52 -0400 (EDT) Received: from smtpin14.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id E7ED45797F for ; Mon, 14 Jul 2025 20:37:51 +0000 (UTC) X-FDA: 83664031542.14.4A4599E Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf16.hostedemail.com (Postfix) with ESMTP id 29FD3180003 for ; Mon, 14 Jul 2025 20:37:49 +0000 (UTC) Authentication-Results: imf16.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=LcCgOqkK; spf=pass (imf16.hostedemail.com: domain of bfoster@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=bfoster@redhat.com; dmarc=pass (policy=quarantine) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1752525470; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=XLdZRvcQL8LOEfVl5rHLuZ7anpsrEIqyRbvnEXKnMtw=; b=03PyIIRPZfKZUJzNKlLglXh+0b6jhZE6rBQ/dQx9IscqZUdggY8+t2vM+9XxyZ5qW9d59j OwD4QusOQigKhTB1McN4g3f8B8hoUwenABxiXtEF9CPLKQ0qegNFkaDw5dphB79hD5glt0 +gJu7QT1MqPUELGFSrn3mSKlS1cOo1g= ARC-Authentication-Results: i=1; imf16.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=LcCgOqkK; spf=pass (imf16.hostedemail.com: domain of bfoster@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=bfoster@redhat.com; dmarc=pass (policy=quarantine) header.from=redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1752525470; a=rsa-sha256; cv=none; b=dvbTH0o8XSgqjB+xCgqiHgZTmZmSp2PNV3kOqsxAZJvh5PB5OLqY9q5zV6U4F5L+2nPvUU FZJ5ciztk4RRqajRE60v0k9hq1JQhsDDGJpVhCZjXeAMyanxJLBrNhpGdWFVmDFO6+iG35 rWPTots2nX/Mi1bqehTn5OYjCxHzgbY= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1752525469; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=XLdZRvcQL8LOEfVl5rHLuZ7anpsrEIqyRbvnEXKnMtw=; b=LcCgOqkKs1POvGUZEayehjRfHG9PAoenKsNHqq4kRjXHUwUHP/C1KngV0HM+8mSYhlW3tp 8/Cz71UtXo4eLhzrco8KRG/idcaac9x/XZxVT0FvJiwI5XVsrS/lfzI6U01WPdtTjKtG6S DS49Ae4YlVxc460HHCVj6z/TDkXKpbU= Received: from mx-prod-mc-06.mail-002.prod.us-west-2.aws.redhat.com (ec2-35-165-154-97.us-west-2.compute.amazonaws.com [35.165.154.97]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-586-j6dcRWlsONyj34yYaO-DtA-1; Mon, 14 Jul 2025 16:37:45 -0400 X-MC-Unique: j6dcRWlsONyj34yYaO-DtA-1 X-Mimecast-MFC-AGG-ID: j6dcRWlsONyj34yYaO-DtA_1752525464 Received: from mx-prod-int-04.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-04.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.40]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-06.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 4EDBD180120C; Mon, 14 Jul 2025 20:37:44 +0000 (UTC) Received: from bfoster.redhat.com (unknown [10.22.64.43]) by mx-prod-int-04.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id 2333C19560A3; Mon, 14 Jul 2025 20:37:41 +0000 (UTC) From: Brian Foster To: linux-fsdevel@vger.kernel.org Cc: linux-xfs@vger.kernel.org, linux-mm@kvack.org, hch@infradead.org, djwong@kernel.org, willy@infradead.org Subject: [PATCH v3 1/7] filemap: add helper to look up dirty folios in a range Date: Mon, 14 Jul 2025 16:41:16 -0400 Message-ID: <20250714204122.349582-2-bfoster@redhat.com> In-Reply-To: <20250714204122.349582-1-bfoster@redhat.com> References: <20250714204122.349582-1-bfoster@redhat.com> MIME-Version: 1.0 Content-Type: text/plain Content-Transfer-Encoding: 8bit X-Scanned-By: MIMEDefang 3.0 on 10.30.177.40 X-Rspam-User: X-Rspamd-Server: rspam02 X-Rspamd-Queue-Id: 29FD3180003 X-Stat-Signature: skhm4prrtrzzg5troqbp15ke8sygh6kg X-HE-Tag: 1752525469-180463 X-HE-Meta: U2FsdGVkX1+krO3cA9ipPDhdJi5LPPRQb0yY41dhwfqWdMvC7/SP0pw6/7lQt3NJLImtnMplDWym0l3fuzsTDmH1GOjzvVcTUm2DaraDuLTvfLHNSb6jcY0M+ACcJw+DBLAWIQO6EncZ1WPNShyBObEZ2DsuT8eJ42er7vcn616dpdj3aGVHXyzyGORDIka4ucEG6yhubZdSmhYYiA72fMDWaDCkqy3W+cngRdQDp0Ni1dQDd1TzIcZTcA3sI56OC61qJaMygRuELps0uSm4BgDFZJwtbIANFJNytY8tirldgX+9OwAbN18IxYQPGnextw59MXIWWsDwyvN64IOPZXtM6h0Zo9BDKXOvbYZxjrZ/EMG6kwVEneyhggiSPzzfdtw+booB2nLEF2dxdWkMKYPP0epoxP9uy7WsU6pFskW1AtxfRNluQKaDC1NNa3c48778WxF2K7vnqQaCU4hR9P/es8cZaZzdvmhDX/2SWb+IauR2JKzUUrhcJRz5BKt0HMWAuqnxOdypBOkdDi9/jvr5nhNtni98xPia6UqOPHk88o0dG/wNFg0qomvfUq8b59plOuL6oi3iSjtGEAe8tQitUON9QTNMFB5lF/DG9ZHcerlHqHyiCbZY3RvjtOh43svDkgKfxsc0DEw574NyC+Mcaqbe5KTMWVCPe5DYX5NY4bnARzRQeWCiaT4ay28h0SyLq5uyPCIoFe4sWQTcAyTv1M7eYVigOESfaLlSdJNWolBGKs+xm1F0WLPCb2EH6etbaGoLyrUtQ4VWPKokCXuMDA1qDdD4Y3Lg9LVtD/3PEjYlifLqtLApuZXFHRRwImo4Y7DH0AZ8JF0NbrqCgfhX0Ha+tKyNYdq+41ji+d9Rl6X5EjpPEQosAafXhwmsIrANm3GxHqx7TtJrudpmSzHssPrNdjb+gMJhtM+j5W8j+K0+sVFPcOl2xxhHlAd1Va4VtPLtcCu78jqKoQS 4IKvHYis WYp12fSgSlSYALsI7lnAxloa35Apn1UZaM6iU1KMSIPF4JzKa+bqLomPWqJWvMlYjQw0lcgPzim+DBp5SN73UtJ/qTMYKwj0yU14Vo5T+yj2ZxQkeEvsQTx23yqFVKY1lNIZzj+BEVWmispPBrwrB0UOHP+TlnJr/RrVQ6rL3FqdGkNi9fE5S2uQ1frRjtDWtu2cQR0AfKEzYtgWSkd+yeah2q3LJnVz1s98sax4OQBgPDS1oP1lhCX0yIBX48O59XfERT9NSvC2qLtBBJrBq5E0LIRWX6qTQn0KkRCutW/dHb6CRghKYJD+PorvHIweb9PEdObE8OmPG+E8= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: Add a new filemap_get_folios_dirty() helper to look up existing dirty folios in a range and add them to a folio_batch. This is to support optimization of certain iomap operations that only care about dirty folios in a target range. For example, zero range only zeroes the subset of dirty pages over unwritten mappings, seek hole/data may use similar logic in the future, etc. Note that the helper is intended for use under internal fs locks. Therefore it trylocks folios in order to filter out clean folios. This loosely follows the logic from filemap_range_has_writeback(). Signed-off-by: Brian Foster Reviewed-by: Christoph Hellwig --- include/linux/pagemap.h | 2 ++ mm/filemap.c | 58 +++++++++++++++++++++++++++++++++++++++++ 2 files changed, 60 insertions(+) diff --git a/include/linux/pagemap.h b/include/linux/pagemap.h index e63fbfbd5b0f..fb83ddf26621 100644 --- a/include/linux/pagemap.h +++ b/include/linux/pagemap.h @@ -941,6 +941,8 @@ unsigned filemap_get_folios_contig(struct address_space *mapping, pgoff_t *start, pgoff_t end, struct folio_batch *fbatch); unsigned filemap_get_folios_tag(struct address_space *mapping, pgoff_t *start, pgoff_t end, xa_mark_t tag, struct folio_batch *fbatch); +unsigned filemap_get_folios_dirty(struct address_space *mapping, + pgoff_t *start, pgoff_t end, struct folio_batch *fbatch); /* * Returns locked page at given index in given cache, creating it if needed. diff --git a/mm/filemap.c b/mm/filemap.c index bada249b9fb7..2171b7f689b0 100644 --- a/mm/filemap.c +++ b/mm/filemap.c @@ -2334,6 +2334,64 @@ unsigned filemap_get_folios_tag(struct address_space *mapping, pgoff_t *start, } EXPORT_SYMBOL(filemap_get_folios_tag); +/** + * filemap_get_folios_dirty - Get a batch of dirty folios + * @mapping: The address_space to search + * @start: The starting folio index + * @end: The final folio index (inclusive) + * @fbatch: The batch to fill + * + * filemap_get_folios_dirty() works exactly like filemap_get_folios(), except + * the returned folios are presumed to be dirty or undergoing writeback. Dirty + * state is presumed because we don't block on folio lock nor want to miss + * folios. Callers that need to can recheck state upon locking the folio. + * + * This may not return all dirty folios if the batch gets filled up. + * + * Return: The number of folios found. + * Also update @start to be positioned for traversal of the next folio. + */ +unsigned filemap_get_folios_dirty(struct address_space *mapping, pgoff_t *start, + pgoff_t end, struct folio_batch *fbatch) +{ + XA_STATE(xas, &mapping->i_pages, *start); + struct folio *folio; + + rcu_read_lock(); + while ((folio = find_get_entry(&xas, end, XA_PRESENT)) != NULL) { + if (xa_is_value(folio)) + continue; + if (folio_trylock(folio)) { + bool clean = !folio_test_dirty(folio) && + !folio_test_writeback(folio); + folio_unlock(folio); + if (clean) { + folio_put(folio); + continue; + } + } + if (!folio_batch_add(fbatch, folio)) { + unsigned long nr = folio_nr_pages(folio); + *start = folio->index + nr; + goto out; + } + } + /* + * We come here when there is no folio beyond @end. We take care to not + * overflow the index @start as it confuses some of the callers. This + * breaks the iteration when there is a folio at index -1 but that is + * already broke anyway. + */ + if (end == (pgoff_t)-1) + *start = (pgoff_t)-1; + else + *start = end + 1; +out: + rcu_read_unlock(); + + return folio_batch_count(fbatch); +} + /* * CD/DVDs are error prone. When a medium error occurs, the driver may fail * a _large_ part of the i/o request. Imagine the worst scenario: -- 2.50.0