From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id AF29BC83F1B for ; Mon, 14 Jul 2025 20:37:52 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 4E7016B009F; Mon, 14 Jul 2025 16:37:52 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 449176B00AA; Mon, 14 Jul 2025 16:37:52 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 29BB16B00AB; Mon, 14 Jul 2025 16:37:52 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 1B9136B009F for ; Mon, 14 Jul 2025 16:37:52 -0400 (EDT) Received: from smtpin15.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id D97761602EE for ; Mon, 14 Jul 2025 20:37:51 +0000 (UTC) X-FDA: 83664031542.15.5BB520D Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf21.hostedemail.com (Postfix) with ESMTP id 510E41C0003 for ; Mon, 14 Jul 2025 20:37:50 +0000 (UTC) Authentication-Results: imf21.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=EiwUA3Gv; spf=pass (imf21.hostedemail.com: domain of bfoster@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=bfoster@redhat.com; dmarc=pass (policy=quarantine) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1752525470; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=G2oilnYSWpKLUb4WBjfIpxHb6dcWw7CrnL7tLxGTlgo=; b=kL24GP4g4Fq1D24WDOFVPkFb+rflJrobWxn5aJOJLYhv2Bdown9piz9kxaPCefD/ADlQSJ Bp6Tr9UQNp8Ni/Fbs52dWyAUyCTaGDdL8TBxjzQ53qd72R/2Of/jw8D3T1mk445yaoZhqw zz99Htw9+oMLvYu9FKaZU1S0dSEQl1c= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1752525470; a=rsa-sha256; cv=none; b=XkoKwKoAL3M/Xyl8tJA0rYrxi5Na49YpkZgQCrLk7m2fl/le26jFldO53zIIUDW2Fs2Owj cLKoelLtKAvnPW0CE/5iEhD9qTMvGMBRIIIwsvruom7iG+xV72+yb1Epn3QO7Ez5xlDi+H JL5ilIXOhMcv5prWcaM3Hk3bvXyXrSY= ARC-Authentication-Results: i=1; imf21.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=EiwUA3Gv; spf=pass (imf21.hostedemail.com: domain of bfoster@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=bfoster@redhat.com; dmarc=pass (policy=quarantine) header.from=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1752525469; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=G2oilnYSWpKLUb4WBjfIpxHb6dcWw7CrnL7tLxGTlgo=; b=EiwUA3GvlWd/uRMPYPrUye5QA6YJfISjmydikqwqDvdlQA/hR60Jsfylqif3CaU08JqiQE obDI/iKNTHCTcJYx/QXoui34q1rskH0LnV2a0ELtOcSG/OQ9OSsDsIGO8ngfJ04DxJH4Nt SW4rf51sWpp45TIYr05WJMENcLRFAaI= Received: from mx-prod-mc-08.mail-002.prod.us-west-2.aws.redhat.com (ec2-35-165-154-97.us-west-2.compute.amazonaws.com [35.165.154.97]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-317-VhtFJ8xJN8OJXh7wlBBIgA-1; Mon, 14 Jul 2025 16:37:47 -0400 X-MC-Unique: VhtFJ8xJN8OJXh7wlBBIgA-1 X-Mimecast-MFC-AGG-ID: VhtFJ8xJN8OJXh7wlBBIgA_1752525465 Received: from mx-prod-int-04.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-04.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.40]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-08.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id BE4FC1800366; Mon, 14 Jul 2025 20:37:45 +0000 (UTC) Received: from bfoster.redhat.com (unknown [10.22.64.43]) by mx-prod-int-04.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id 9171D19560B2; Mon, 14 Jul 2025 20:37:44 +0000 (UTC) From: Brian Foster To: linux-fsdevel@vger.kernel.org Cc: linux-xfs@vger.kernel.org, linux-mm@kvack.org, hch@infradead.org, djwong@kernel.org, willy@infradead.org Subject: [PATCH v3 2/7] iomap: remove pos+len BUG_ON() to after folio lookup Date: Mon, 14 Jul 2025 16:41:17 -0400 Message-ID: <20250714204122.349582-3-bfoster@redhat.com> In-Reply-To: <20250714204122.349582-1-bfoster@redhat.com> References: <20250714204122.349582-1-bfoster@redhat.com> MIME-Version: 1.0 Content-Type: text/plain Content-Transfer-Encoding: 8bit X-Scanned-By: MIMEDefang 3.0 on 10.30.177.40 X-Rspamd-Queue-Id: 510E41C0003 X-Stat-Signature: jzti5zecd7cudyr95p4y81mws7dtj4dw X-Rspam-User: X-Rspamd-Server: rspam07 X-HE-Tag: 1752525470-521371 X-HE-Meta: U2FsdGVkX19IYgoPKfNCVlGxohCT3ACDdCt3veczKciKnWd2vtoypNNFSFMZ8RZtzm14zeD85ItFdXYKWPRs2i4GHctRK8C7i0F6iAewt6K4LJt5/hDlavLax4U7OYaPkr8/2UHtoJ6WjvVUeYEvzJzRNfXjoCvq7ZPhr61ABRA7uS/YPd4auS77gN5QGjYR/1mNogmLWY1huqRBoF8LSgS5vN3VKLI7g3tYFtW4ckSV6onQqKYcYyF3Z7HToGQ9S9MxA4nh7mdGpetFVXbWAQxI5r5Dx+BP9QhAJlHxIzzkazbGOSQQBrrYFGFECEhrj+y0nDmo70/c53MAJsdCqnO2tv+zRL4jUPLq7OKEk3/NNqMdGyCIalT3SwxRYCjn05gOHpnZp0gRTg2uDnvYKnpY5Hn3IYTqq2Waw6oQvpNlCSMynAM7Q6Ua1XWtijIDZ1sxNEAtwCzGMkGpOkuBURpSdiAGv+YccnMJwNsPtLbnWYQ9XwlvQCX/EV080r5B/bYanCoavlHM8I/G3GCOKDD4M8/lKIr3KFl60vWr9bt1mWwd9k/5IAwSqTvo5CT0OlMw/cPa9FPFGKRES1JWMvKKPCNcdtC2xBGx2XJKwBNKMVcWa6H9QF+if8h/AgwIl8XCogcam6lzfp9wPUcqix+Zb3aguLO4YwNV91hCO2gPI9CaB3bM4h6xEqra2BN1O+Fh5dQr+jJKlCYsQ66HucXJgCexDJOgdjD9Xfhdc8MdvybB+XyAp4a+MnE4hKH2IEuJn7PSW8VGI0uqnDZGeLIzrAMo5lKbAV4DkceA/GmuqlhnDwyGhb+MaRB0GwmkvvfY4FhCehw6Lsw3VikyBdMj3Y6wOYI8gzoME75fY4pXT9o0G5U3MorpslC8l+XQUsZV8E/oiIHtOLpudJaanQa/D58Z3G8Z+p2XfgHDSjBhKqfVvYFKfZMstiWbPRzhRHf3oMkwttCUwJnrgCm VhbfAlBX 8Q2dAcaXrJqUqlF8cGfDFK7mTlL09TR6pIGJjn3EaHB4O8soia0hkMAfpOc+QMGJRo5JpIkCg9kqPR9J0fnLQLWScfCC2T3QrdZg92o7Phi3ySzI= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: The bug checks at the top of iomap_write_begin() assume the pos/len reflect exactly the next range to process. This may no longer be the case once the get folio path is able to process a folio batch from the filesystem. On top of that, len is already trimmed to within the iomap/srcmap by iomap_length(), so these checks aren't terribly useful. Remove the unnecessary BUG_ON() checks. Signed-off-by: Brian Foster Reviewed-by: Christoph Hellwig --- fs/iomap/buffered-io.c | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/fs/iomap/buffered-io.c b/fs/iomap/buffered-io.c index 3729391a18f3..38da2fa6e6b0 100644 --- a/fs/iomap/buffered-io.c +++ b/fs/iomap/buffered-io.c @@ -805,15 +805,12 @@ static int iomap_write_begin(struct iomap_iter *iter, struct folio **foliop, { const struct iomap_folio_ops *folio_ops = iter->iomap.folio_ops; const struct iomap *srcmap = iomap_iter_srcmap(iter); - loff_t pos = iter->pos; + loff_t pos; u64 len = min_t(u64, SIZE_MAX, iomap_length(iter)); struct folio *folio; int status = 0; len = min_not_zero(len, *plen); - BUG_ON(pos + len > iter->iomap.offset + iter->iomap.length); - if (srcmap != &iter->iomap) - BUG_ON(pos + len > srcmap->offset + srcmap->length); if (fatal_signal_pending(current)) return -EINTR; -- 2.50.0