From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id B20A3C83F1A for ; Tue, 15 Jul 2025 02:08:31 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 3D1EE6B007B; Mon, 14 Jul 2025 22:08:31 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 3A9E76B0088; Mon, 14 Jul 2025 22:08:31 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 2E6C26B0089; Mon, 14 Jul 2025 22:08:31 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 1FA5A6B007B for ; Mon, 14 Jul 2025 22:08:31 -0400 (EDT) Received: from smtpin16.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id 951A85876C for ; Tue, 15 Jul 2025 02:08:30 +0000 (UTC) X-FDA: 83664864780.16.357F4F7 Received: from invmail4.hynix.com (exvmail4.skhynix.com [166.125.252.92]) by imf05.hostedemail.com (Postfix) with ESMTP id 2542B100002 for ; Tue, 15 Jul 2025 02:08:27 +0000 (UTC) Authentication-Results: imf05.hostedemail.com; spf=pass (imf05.hostedemail.com: domain of byungchul@sk.com designates 166.125.252.92 as permitted sender) smtp.mailfrom=byungchul@sk.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1752545308; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=oOjxvWUGWmshLI+icgWUVAZjl6UNtTv0kd0LRvDaDIc=; b=DLIVrzsoMvCvZj12yfNa56W69PloWDyVSze5EMnU59SqKEuj0o15n7UNFwut+DcObeKQmx lz9sUFug325QuVaYdpjfojcBOChR8rcsntVpWD6TVqj2zsTEoDrb12WJgp/35kGhAfo59f C+lFoern/Vv2HwRTuxfaSrXVCnUhQFY= ARC-Authentication-Results: i=1; imf05.hostedemail.com; dkim=none; spf=pass (imf05.hostedemail.com: domain of byungchul@sk.com designates 166.125.252.92 as permitted sender) smtp.mailfrom=byungchul@sk.com; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1752545308; a=rsa-sha256; cv=none; b=2wclv+mStuXXxEUaEEr912PD+lmvUSfA1NviigjCzZZfEx6OWygkl6oQ5E7EK0BQP6O49Y mlaZO53XMeFDbptdXJV8qlpH5ig5lvL7GW8BtPnVmC0eQ5dyw/9RxlApRQmJWza6V9c1Ne gJK+XZkAspqERl8MzsxULz3sARczPAE= X-AuditID: a67dfc5b-669ff7000002311f-49-6875b8184208 Date: Tue, 15 Jul 2025 11:08:19 +0900 From: Byungchul Park To: Jakub Kicinski Cc: Harry Yoo , Vlastimil Babka , willy@infradead.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, kernel_team@skhynix.com, almasrymina@google.com, ilias.apalodimas@linaro.org, hawk@kernel.org, akpm@linux-foundation.org, davem@davemloft.net, john.fastabend@gmail.com, andrew+netdev@lunn.ch, asml.silence@gmail.com, toke@redhat.com, tariqt@nvidia.com, edumazet@google.com, pabeni@redhat.com, saeedm@nvidia.com, leon@kernel.org, ast@kernel.org, daniel@iogearbox.net, david@redhat.com, lorenzo.stoakes@oracle.com, Liam.Howlett@oracle.com, rppt@kernel.org, surenb@google.com, mhocko@suse.com, horms@kernel.org, linux-rdma@vger.kernel.org, bpf@vger.kernel.org, vishal.moola@gmail.com, hannes@cmpxchg.org, ziy@nvidia.com, jackmanb@google.com Subject: Re: [PATCH net-next v7 1/7] netmem: introduce struct netmem_desc mirroring struct page Message-ID: <20250715020819.GA80407@system.software.com> References: <20250625043350.7939-2-byungchul@sk.com> <20250626174904.4a6125c9@kernel.org> <20250627035405.GA4276@system.software.com> <20250627173730.15b25a8c@kernel.org> <20250701164508.0738f00f@kernel.org> <92073822-ab60-40ca-9ff5-a41119c0ad3d@suse.cz> <20250714184743.4acd7ead@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20250714184743.4acd7ead@kernel.org> User-Agent: Mutt/1.9.4 (2018-02-28) X-Brightmail-Tracker: H4sIAAAAAAAAA02Sa0hTYRjHeXfOzjlbjo7L6m0GwVIK7aJh9ARRfjA4oYISRFmyRju00byw uaVB4NQKJS2yi86Fs/DSMkbL5gq12pbZjUSpVlkrb3S31GxmWU6L/Pbj//yfH8+HhyGklUIZ o8nM4XWZSq2cEpPiTyE1K2UugzpmwrkCLPZGCi4GcqH+tUsIFpsTwej4CxpGvHcoOF8zRoDl UREJ3+w/CBho76XhoiMZ/HWDJLQcaSag91gHBaVFEwS0jn+mocDVIIBOZ5kQTv6oJaA5/zUN 3dctFLxq/C2EQXcpCXfNF0jwl8VDu3UBjN3/iMBrbxbA2NGzFJR3WSnoK/Ij6PL0klBlKkNg b/MJYSIw5ai6/YqOj+A8H4cIrunCMwF3zfyS5qwOA3elIYor8XURnMNWTHGO4RM01/OkheI6 KiZI7pprRMCVFn6muK8Dz0luqO0xxdmbHpPcA6uXTglNE29Q8VqNkdet3rhbrB5olWXfonP7 3pjIfJRPlSARg9k47P1uI//xt+aW6ZxkI7H/11NBkCl2Gfb5xokgh7ERuOhK5XSfYG9QOHA6 LcjzWCVu6R2d7ktYwAV+HypBYkbKFhJ44OoHemYQiu9W9v9djsK+yXdTC8wUh+P6SSYYi9hY bPfUTlfms0vxTecdQdCD2UsMPuevoGcOXYRvNfjI44g1z9KaZ2nN/7VWRNiQVJNpzFBqtHGr 1HmZmtxVe7IyHGjqYeoO/tzpQsOdW92IZZA8RALvc9RSodKoz8twI8wQ8jDJ+5c6tVSiUuYd 4HVZCp1By+vdKJwh5Qsla8b2q6TsXmUOv4/ns3ndv6mAEcnyUc62/v3tKiZQfqYybL2xp7o/ vRMtPl290HS8LzR9dcYW12BBbRg/h48xJMkSv6Qwc3lR9VuLQJbapyhf5+pmo+/t3bG2Z3lX UsWphF2exMuO6lrmsOJ6ZLJJ7ztEPiRuv4lWLDeWEQnDouiOw5s2fl+zpDgSGVK3P9zMymQ9 CjmpVytjowidXvkHKz1dRSwDAAA= X-Brightmail-Tracker: H4sIAAAAAAAAA02Sa0hTYRjHec95d87ZaHJaVi+uTyu7CFlR0QNdlIQ6REVEFFmkhzy14bVN RSVpXiAStSuRa8a6eoXVvE1Rq2mmhGSWtm6bLmdXtNTEWxdnRX378f//f8+nh6NVkziA08Ul Svo4MUbDKLBi5/qs5cSepF3Ze3IpmK3lDJSNpUBRj10G5tJqBCPjr1gYbn7IwPWrozSYH2dj +GadoMHb4mGhzLYD3Lf6MdSfrKHBc7qVgbzsSRoaxgdYyLQXU9BU2CaDjup8GVyYuElDjbGH had1ZgZc5T9l0O/Iw9BmKsHgzg+FFss8GH30GUGztYaC0dxCBs53Whh4m+1G0NnkwXA5Ix+B tdEpg8mx6RuXH7jY0ECh6fMgLVSWvKCEWtMbVrDYkoSK4iAhx9lJC7bSU4xgGzrHCq+76xmh 9dIkFmrtw5SQlzXACF+9L7Ew2NjFCNfff6EEa2UX3qUKV2yIkmJ0yZJ+xaZIhdbbEJBwn015 25uBjcjI5CA5R/g15FtN/QxjPpC4vz+nfMzwS4jTOU772J9fRLIrCrCPaf4uQ8Yuhvt4Di+S es/IzF7JA8l0O1EOUnAqPosm3qpP7O9iNmkr6PsjBxHnjw/TAjfNalL0g/PFcn4VsTbdnJnM 5ReSe9UPqTNIafrPNv1nm/7ZFkSXIn9dXHKsqItZG2yI1qbG6VKCD8fH2tD0S9xKnzprRyNP tzoQzyHNLCV8TNSqZGKyITXWgQhHa/yVH9/otSpllJiaJunjI/RJMZLBgdQc1sxXbtsnRar4 o2KiFC1JCZL+b0tx8gAjOhZSbY7AXE/K9tw0bnH7nt6wDfJL6avz916lHR7K9bKgaP/tZys6 1O/GNgbLmSfqsICWLQMdVXXX/DYv2uhKTntSXnnB3hbvV0kniEcOLdg9wbuMC8jBiTvr5k9l tSv3DrErzSf6wov8y5bZLOndN8ynjh9rP1By+ob6Ch71aw7RYINWXBVE6w3iL74R2YYOAwAA X-CFilter-Loop: Reflected X-Stat-Signature: b86erd6woaeasa7f8xdb9tebnqdkwisf X-Rspamd-Server: rspam01 X-Rspamd-Queue-Id: 2542B100002 X-Rspam-User: X-HE-Tag: 1752545307-637503 X-HE-Meta: U2FsdGVkX1+Ssyz2YpH2G06H2K91nTAuRq9z2Y7LMZcNxYxFrsNqI1hdSBsRCOCxHR8T2lZswlHnuc00zMeDLeF4IZE9cUyAN07PnRkPiOWDCEfChQAWeS323oWJTFOGjL9DbkT6B0dk6HVo90U9MiE9NNRHuVcJVpDKA7X0xR2dqyqSYxAxVVjFa7CXAuSm2lQAc45iwixoghH/6OqctQnTKwXaBTZVirjIDS7SvZvm7jyAWFbyLjLIckHVxUMJ5Tnha6z+ITw/ojZYEWxYrnK2gyz+1jG3jD9yJbW8t5Q6NC+lIp5mZh953huwJkCd7x6ffJCCrKJPz/LfyHgE5KvvzAnavW3MjZjKT5jqL98tpIIiyqnvhiEAe/wYxScaCDX9sMJcFTE/q3HHnJ/oJoK9qxlKTspQj6xJwrlvfC2CrXkyVsPbpY0mozH9OOz8Ayq4EJFvXjqFidCvF5F9V1BWEapPbIlYMN55daWjAtQoOeMgRxDOYB3Ne/F3qMD0awkKMucDRRu+Qdp0ySvSR9Ctgc6Fu1/d9UM83/H8LEaT4rSLsrPOElWH0fK8CQKPWagoCwx3/4MuM4FpVz1xkw7wTyO4yjf3Z+P2piF/+fWqte9C4kSx3iMyt3lKCDi4mA+cgBMxuDq+Q5/vG0i6p/DmsWucA5sHqZeU1MnfBF8hoP27eU6QmXn9MkvyeVS96EDPvKDICo1S/VVkwO6VBB6G64NlVFDiiACXfY/Hr2Ivzoye9sqxwdmU8CUnsJ7JTkc4qyKsYWTXSsqXjbdORN+fcfb03SAAvztFs06BkdCFdsK9pBjKdqYVsNSFtDNJBmpt4xBefs9TrP7jDVit/YYNsOyvbS1ONXypsvoS0nCyIAz7Q9luXo90+pEMrWEOLpBawZ2LZ8jhq8yu3u7Twd2bb8OQGzFF739PHuY8np6s6Noi6bZ87itbv47+qJ+yhFYW38QXtqKTqD/tqMa fS2sYERv /axNyQwRr58bYesgkgNBrQP1hkfRcAkZ7Chah+eQ20iF4ll6rISOuyLZnmoGsRg+PiqcGiuoa2UyPlslFt1NWzxMzpJeWccjmE1+Qkzz/8LndDLq0TNLSqBjUhQ== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Mon, Jul 14, 2025 at 06:47:43PM -0700, Jakub Kicinski wrote: > > On Mon, 14 Jul 2025 22:58:31 +0900 Harry Yoo wrote: > > > > Could you please share your thoughts on why it's hard to judge them and > > > > what's missing from the series, such as in the comments, changelog, or > > > > the cover letter? > > My main concern (as shared on earlier revisions) is the type hierarchy > exposed to the drivers. Converting things back and forth or blindly > downcasting to netmem and upcasting back to the CPU-readable type is > no good. I understand your concern. I removed a lot of converting things but left essencial things, that is inevitable to remove accessing the pp fields through struct page. Is it still not okay with v10 [1]? There are some points under disscussion with Mina but I'm curious about how you think about the direction changed. [1] https://lore.kernel.org/all/20250714120047.35901-1-byungchul@sk.com/ Byungchul