From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 04041C83F1D for ; Tue, 15 Jul 2025 09:35:02 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id BF8CB6B00B2; Tue, 15 Jul 2025 05:34:39 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id BA90B6B00B3; Tue, 15 Jul 2025 05:34:39 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id A4AE16B00B4; Tue, 15 Jul 2025 05:34:39 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 8FF856B00B2 for ; Tue, 15 Jul 2025 05:34:39 -0400 (EDT) Received: from smtpin06.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 5C3BA12D717 for ; Tue, 15 Jul 2025 09:34:39 +0000 (UTC) X-FDA: 83665989078.06.A8DBA20 Received: from mail-ed1-f73.google.com (mail-ed1-f73.google.com [209.85.208.73]) by imf26.hostedemail.com (Postfix) with ESMTP id 79DF6140003 for ; Tue, 15 Jul 2025 09:34:37 +0000 (UTC) Authentication-Results: imf26.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=wgmDh+CJ; spf=pass (imf26.hostedemail.com: domain of 3rCB2aAUKCBEArssrx55x2v.t532z4BE-331Crt1.58x@flex--tabba.bounces.google.com designates 209.85.208.73 as permitted sender) smtp.mailfrom=3rCB2aAUKCBEArssrx55x2v.t532z4BE-331Crt1.58x@flex--tabba.bounces.google.com; dmarc=pass (policy=reject) header.from=google.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1752572077; a=rsa-sha256; cv=none; b=bGqqXCmBngb2EDjkvHqZu3Ogn/Quee12QV4mLY/CxmhTWbVFhpeSWlMNa/A1FSYdrhGniL fv9C+bEcFAS68Ffa+9dl6qcIuXJse7U4rqGUbBjs37Z/cWvVN+JmH8fdJ6V9NUQVjVTNNt F5thWDeEv3RpMh7go2cD4/rluc5AfJ0= ARC-Authentication-Results: i=1; imf26.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=wgmDh+CJ; spf=pass (imf26.hostedemail.com: domain of 3rCB2aAUKCBEArssrx55x2v.t532z4BE-331Crt1.58x@flex--tabba.bounces.google.com designates 209.85.208.73 as permitted sender) smtp.mailfrom=3rCB2aAUKCBEArssrx55x2v.t532z4BE-331Crt1.58x@flex--tabba.bounces.google.com; dmarc=pass (policy=reject) header.from=google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1752572077; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=AOxTG6i7FEjwgO78cp+SZydc4yJ2EnAl5OEX1LUXtxU=; b=59E4kP8XcXvSfa6+E35XSVUnLuoUDovkB18sZKwHtQ19Bg50Arx6eSk4IHta4C8nX3+9RB DrcJgYMyHPYWwpM+nZX+DVLWE21TZA7CzNVKUq4mwbkt5RpqWF5dV44aqNaOzx32Hv83Kd YrZ43s0jaA9FMv6Vgqotw7zytl+jXdo= Received: by mail-ed1-f73.google.com with SMTP id 4fb4d7f45d1cf-6083f613f0eso5322264a12.1 for ; Tue, 15 Jul 2025 02:34:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1752572076; x=1753176876; darn=kvack.org; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:from:to:cc:subject:date:message-id:reply-to; bh=AOxTG6i7FEjwgO78cp+SZydc4yJ2EnAl5OEX1LUXtxU=; b=wgmDh+CJTvrtb8PBCxi9z2m1Ngpt2oMmWHrdBE39GU5A/XDIItnXzy9NE2+UTuiHdV vxLXlDVrMrRwJgt4Fc/FkNB2pT1x5yrK1myE8ha6ITBOcFjtJzmkYkd0nrJ6gcSfh0r1 FPCFvOGjHE2YJvgohuItTt5ubI7jlSjOsuMuLxs9rmiI+jMEi8mFQ/fja8Nl9eNhQVr+ UJamiXJ774P52HDSs3PblNu19L3Zv2jND0Pl1ZZ7X0FAbXVF8OJUSyiSOUomsiB4UXlg NRBQ67mFqGhtcbKsZlgkC8LY5fJugeVIOdajLI5vOp8g3xfCKOvxjYOHXzHVEeGlhKFi 8INA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1752572076; x=1753176876; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=AOxTG6i7FEjwgO78cp+SZydc4yJ2EnAl5OEX1LUXtxU=; b=QpIrQb+KRwi9fSv4jhy9P5Yz4bWCRu595Mqa25poYkwYBt6EtlJqYv1v/GU4ueHSI1 EFdqz2/vcqcfiUiN4oHXnb9Bw2PCKa3OLH66+J/9MNJu8t14UTs+hdKlRsN+s66BRoHt JQvcUlBnPdZekXdyn7oXkoJU5rQcCAIOKoPqIWLxW513FbBD8Vd1jUcz2LgshrtXsyrt egx3FBb2tlM2fAsyvwSe8/xpCBzrc9AbKm6LVIVOScL+xkJwy3ybY+7IwmXufec/qJmJ 7hZtp1GPkPEKkZY93OvQN4NVFmLk8szbGf7vdRgZriLHWKJvHI/Tm3SHkmclWKwgNoRi aj8w== X-Forwarded-Encrypted: i=1; AJvYcCUJ17smKV9bm9O2WIgnFNMctjDPRA1tmkauoN7gvjWNfjh6/sgffqzjrsDfqrbEeiiL4hC2VgGCDg==@kvack.org X-Gm-Message-State: AOJu0YyGdK6iEybgCB5apPJAtfX748yflPUB53RhxOiy9NzFSKZ1vWyO JM/+fKiQujjDBJxz86y8+urIEjCg8E76QscHAsMirVudevQNFGzCPZjpuv+0ljX/HD5QQDyor2p X+A== X-Google-Smtp-Source: AGHT+IGI610lCZHGfon3SNZZY/SVw9WaoOiFuKCCBX2T0KCJ+afRtNdmxFp5hhQEFR82WUfFrBduY0Ajzg== X-Received: from edt19.prod.google.com ([2002:a05:6402:4553:b0:609:36ed:3901]) (user=tabba job=prod-delivery.src-stubby-dispatcher) by 2002:a05:6402:378d:b0:5fb:c126:12c9 with SMTP id 4fb4d7f45d1cf-611e84c2334mr13524470a12.25.1752572076080; Tue, 15 Jul 2025 02:34:36 -0700 (PDT) Date: Tue, 15 Jul 2025 10:33:49 +0100 In-Reply-To: <20250715093350.2584932-1-tabba@google.com> Mime-Version: 1.0 References: <20250715093350.2584932-1-tabba@google.com> X-Mailer: git-send-email 2.50.0.727.gbf7dc18ff4-goog Message-ID: <20250715093350.2584932-21-tabba@google.com> Subject: [PATCH v14 20/21] KVM: selftests: Do not use hardcoded page sizes in guest_memfd test From: Fuad Tabba To: kvm@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-mm@kvack.org, kvmarm@lists.linux.dev Cc: pbonzini@redhat.com, chenhuacai@kernel.org, mpe@ellerman.id.au, anup@brainfault.org, paul.walmsley@sifive.com, palmer@dabbelt.com, aou@eecs.berkeley.edu, seanjc@google.com, viro@zeniv.linux.org.uk, brauner@kernel.org, willy@infradead.org, akpm@linux-foundation.org, xiaoyao.li@intel.com, yilun.xu@intel.com, chao.p.peng@linux.intel.com, jarkko@kernel.org, amoorthy@google.com, dmatlack@google.com, isaku.yamahata@intel.com, mic@digikod.net, vbabka@suse.cz, vannapurve@google.com, ackerleytng@google.com, mail@maciej.szmigiero.name, david@redhat.com, michael.roth@amd.com, wei.w.wang@intel.com, liam.merwick@oracle.com, isaku.yamahata@gmail.com, kirill.shutemov@linux.intel.com, suzuki.poulose@arm.com, steven.price@arm.com, quic_eberman@quicinc.com, quic_mnalajal@quicinc.com, quic_tsoni@quicinc.com, quic_svaddagi@quicinc.com, quic_cvanscha@quicinc.com, quic_pderrin@quicinc.com, quic_pheragu@quicinc.com, catalin.marinas@arm.com, james.morse@arm.com, yuzenghui@huawei.com, oliver.upton@linux.dev, maz@kernel.org, will@kernel.org, qperret@google.com, keirf@google.com, roypat@amazon.co.uk, shuah@kernel.org, hch@infradead.org, jgg@nvidia.com, rientjes@google.com, jhubbard@nvidia.com, fvdl@google.com, hughd@google.com, jthoughton@google.com, peterx@redhat.com, pankaj.gupta@amd.com, ira.weiny@intel.com, tabba@google.com Content-Type: text/plain; charset="UTF-8" X-Rspam-User: X-Rspamd-Server: rspam05 X-Rspamd-Queue-Id: 79DF6140003 X-Stat-Signature: aykgc33d9dqs1qh43deo6wad41i76dtp X-HE-Tag: 1752572077-484591 X-HE-Meta: U2FsdGVkX187G4B0BHCEWqCsOI1jdy14Mdiu8KNDOvVTWS34rY9c343G4LoO+dfQ8UxEY4ncZvX/MX6ZMjZIkj9P0OhIxkq9bJ4Banw7BohRRbab6o45Kpkdyv7TeOQHW+IFaYrOHoh/IFdVjpRk20QJSYa+4GZSuWYnsYAf41Zhq+PEyWqSx+a5Bq4LL0kVzBkZ0Ekjtl80KjpY3tPqr6PP8vP/VrNjqhsT+gfNLX2Uccx312hZcub84YzlJ4gHd1cDHktoX9JHnStWbhNOMHdicOP9IEEiU0ZSLdX6omr7wi0ES+OJlA7KYmLO3WWcg046kNHpibFD+k2+qJitiR3YKEu7ZL2M+FGPmC3kFVSaEw/xnmX4maUdNKEny1fj+QUmXrBQZdFKtdMlLCzlP0gqX+CXq/sTLWmrPSR8yeReFhD94E/Z2zgH4USHPqGtHU6YdvG2gD6bcvMP3xpp3a66H1k5p06cEISGy5GEaA8ujBLh9XBiWMkfKZnzdwY4c7xf1tLEhW85gHhCJ85RS8TFiAL4cNQU4vMn0afziLeiCxSj6mkYT03Jpbyj+x1Xtzw93tMtFvdDGdrQNeTswuXpa1Nzs+xH22JkXt2IchHbDn9Kx+upPUrqQrdL/3XFd0TvXwQVuqI2WrXcXgHg1cfjQ/fL3PanYCgivoboUL3+mrijkv9eZgJbknCjJuObJC54fsBdq1zfn/omTAoCMPQW1C7TE6ynyoXv5uY3tiR/8OccW7B5h1/kfFqCbXmYRMw3DKIGDwM21DMLlIsnRT+Qi028o2wRRQLnRG9fwtWF6kXeom1YC94VHtr/SU4p+0hiEgYv+Iupzmm20AP4oeZPE1Rhzz17f8eiWe7V9OgDqJPD7G0XrEYY3ApqXtQuuijdYnkMeFr7mDvpA69221YJ7ogQd66c+2mjREptbSkfKQub1xdAbWTLyMQEOise2iCMdbB6Wyx1IOX0kDc NzpmM4ZG 8udO/zdfvkPlFhMQP/WBiWV5prP4V6CAd38icLnSqkvnDnc3uNOYa6sru0kybCIj17+YbsrR+CdwV3nloSsLsd7rhatsFDx+yKwkhzpXAiB2xgrhaA0AVB1KfcScxOc4i09LxWlxD7BEzwScrQoqsmi4iiGkq4r6x+ghCyQlj8ls8bEyqOuryM3rqd6LcgKXYZnB5njt10QH3ehw2Lz2nuvtesKWDY+6zvcB2+nhE9FWMfhALgdu5ghPFFMYy3oOjCF4RiWl1ebvWhS7WZnTKXQRL6kU1e2tY8swfcBdtMZaLp34ymudyMB5fU9z/FeENLs+uuBI15YrklT3Nqr+RK7AMOOkBnhCZciWKVpLN2fRc9vkkZsTDgYNu4cLbdzVH0UMD3Yy2/ycfpN/9gePeQqWCiJRFGwdYdP6qJiim61P40IFV3+7C5MG/vH867XhWNfD+2zyqqf2heVckUmCnjBofiCByY4QDPnJ4CIiFGEYCg4Ga/PgZKVoUyljCr++kSMkIav9cg3nt2aSalRJ2TZ8x/YxA2zN0utsp1sADO9eNrVprV8iy5zZPwo+0QrspmQ5JpNXT4ejoSiWF3ntOtxNdna+XV+idZ+wxyA9m+QowxVZN10dIUUsk5cUzA1y6Ar6F5/07LFuHKDr4xdSYyVCq0gKTGTak2kt3JoiBc8c0jc+bxVD9hhAFmBwpfBAJcQCw X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: Update the guest_memfd_test selftest to use getpagesize() instead of hardcoded 4KB page size values. Using hardcoded page sizes can cause test failures on architectures or systems configured with larger page sizes, such as arm64 with 64KB pages. By dynamically querying the system's page size, the test becomes more portable and robust across different environments. Additionally, build the guest_memfd_test selftest for arm64. Reviewed-by: David Hildenbrand Reviewed-by: Shivank Garg Suggested-by: Gavin Shan Reviewed-by: Gavin Shan Signed-off-by: Fuad Tabba --- tools/testing/selftests/kvm/Makefile.kvm | 1 + tools/testing/selftests/kvm/guest_memfd_test.c | 11 ++++++----- 2 files changed, 7 insertions(+), 5 deletions(-) diff --git a/tools/testing/selftests/kvm/Makefile.kvm b/tools/testing/selftests/kvm/Makefile.kvm index 38b95998e1e6..e11ed9e59ab5 100644 --- a/tools/testing/selftests/kvm/Makefile.kvm +++ b/tools/testing/selftests/kvm/Makefile.kvm @@ -172,6 +172,7 @@ TEST_GEN_PROGS_arm64 += arch_timer TEST_GEN_PROGS_arm64 += coalesced_io_test TEST_GEN_PROGS_arm64 += dirty_log_perf_test TEST_GEN_PROGS_arm64 += get-reg-list +TEST_GEN_PROGS_arm64 += guest_memfd_test TEST_GEN_PROGS_arm64 += memslot_modification_stress_test TEST_GEN_PROGS_arm64 += memslot_perf_test TEST_GEN_PROGS_arm64 += mmu_stress_test diff --git a/tools/testing/selftests/kvm/guest_memfd_test.c b/tools/testing/selftests/kvm/guest_memfd_test.c index ce687f8d248f..341ba616cf55 100644 --- a/tools/testing/selftests/kvm/guest_memfd_test.c +++ b/tools/testing/selftests/kvm/guest_memfd_test.c @@ -146,24 +146,25 @@ static void test_create_guest_memfd_multiple(struct kvm_vm *vm) { int fd1, fd2, ret; struct stat st1, st2; + size_t page_size = getpagesize(); - fd1 = __vm_create_guest_memfd(vm, 4096, 0); + fd1 = __vm_create_guest_memfd(vm, page_size, 0); TEST_ASSERT(fd1 != -1, "memfd creation should succeed"); ret = fstat(fd1, &st1); TEST_ASSERT(ret != -1, "memfd fstat should succeed"); - TEST_ASSERT(st1.st_size == 4096, "memfd st_size should match requested size"); + TEST_ASSERT(st1.st_size == page_size, "memfd st_size should match requested size"); - fd2 = __vm_create_guest_memfd(vm, 8192, 0); + fd2 = __vm_create_guest_memfd(vm, page_size * 2, 0); TEST_ASSERT(fd2 != -1, "memfd creation should succeed"); ret = fstat(fd2, &st2); TEST_ASSERT(ret != -1, "memfd fstat should succeed"); - TEST_ASSERT(st2.st_size == 8192, "second memfd st_size should match requested size"); + TEST_ASSERT(st2.st_size == page_size * 2, "second memfd st_size should match requested size"); ret = fstat(fd1, &st1); TEST_ASSERT(ret != -1, "memfd fstat should succeed"); - TEST_ASSERT(st1.st_size == 4096, "first memfd st_size should still match requested size"); + TEST_ASSERT(st1.st_size == page_size, "first memfd st_size should still match requested size"); TEST_ASSERT(st1.st_ino != st2.st_ino, "different memfd should have different inode numbers"); close(fd2); -- 2.50.0.727.gbf7dc18ff4-goog