linux-mm.kvack.org archive mirror
 help / color / mirror / Atom feed
* [PATCH mm-unstable 0/2] mm/damon: kernel-doc comments fixup for damon_callback removal
@ 2025-07-15 18:52 SeongJae Park
  2025-07-15 18:52 ` [PATCH mm-unstable 1/2] mm/damon: add kernel-doc comment for damon_operations->cleanup_target SeongJae Park
  2025-07-15 18:52 ` [PATCH mm-unstable 2/2] mm/damon: remove damon_ctx->callback kernel-doc comment SeongJae Park
  0 siblings, 2 replies; 3+ messages in thread
From: SeongJae Park @ 2025-07-15 18:52 UTC (permalink / raw)
  To: Andrew Morton; +Cc: SeongJae Park, damon, kernel-team, linux-kernel, linux-mm

Patch series "mm/damon: remove damon_callback"[1] causes two kernel-doc
comments build warnings[2].  Fix those.

[1] https://lore.kernel.org/20250712195016.151108-1-sj@kernel.org
[2] https://lore.kernel.rog/20250715185549.264260b8@canb.auug.org.au

SeongJae Park (2):
  mm/damon: add kernel-doc comment for damon_operations->cleanup_target
  mm/damon: remove damon_ctx->callback kernel-doc comment

 include/linux/damon.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)


base-commit: c6255edeab2199ffde2dafae3c9df042ef4c9ef3
-- 
2.39.5


^ permalink raw reply	[flat|nested] 3+ messages in thread

* [PATCH mm-unstable 1/2] mm/damon: add kernel-doc comment for damon_operations->cleanup_target
  2025-07-15 18:52 [PATCH mm-unstable 0/2] mm/damon: kernel-doc comments fixup for damon_callback removal SeongJae Park
@ 2025-07-15 18:52 ` SeongJae Park
  2025-07-15 18:52 ` [PATCH mm-unstable 2/2] mm/damon: remove damon_ctx->callback kernel-doc comment SeongJae Park
  1 sibling, 0 replies; 3+ messages in thread
From: SeongJae Park @ 2025-07-15 18:52 UTC (permalink / raw)
  To: Andrew Morton
  Cc: SeongJae Park, damon, kernel-team, linux-kernel, linux-mm,
	Stephen Rothwell

Commit 769bd386e490 ("mm/damon/core: add cleanup_target() ops callback")
on mm-unstable added cleanup_target field to damon_operations, but
forgot adding the kernel-doc description.  This causes a build warning.
Fix it by adding the description.

Fixes: 769bd386e490 ("mm/damon/core: add cleanup_target() ops callback") # mm-unstable
Reported-by: Stephen Rothwell <sfr@canb.auug.org.au>
Closes: https://lore.kernel.org/20250715185549.264260b8@canb.auug.org.au
Signed-off-by: SeongJae Park <sj@kernel.org>
---
 include/linux/damon.h | 1 +
 1 file changed, 1 insertion(+)

diff --git a/include/linux/damon.h b/include/linux/damon.h
index 34fc5407f98e..efabc3ba52ee 100644
--- a/include/linux/damon.h
+++ b/include/linux/damon.h
@@ -576,6 +576,7 @@ enum damon_ops_id {
  * @get_scheme_score:		Get the score of a region for a scheme.
  * @apply_scheme:		Apply a DAMON-based operation scheme.
  * @target_valid:		Determine if the target is valid.
+ * @cleanup_target:		Clean up each target before deallocation.
  * @cleanup:			Clean up the context.
  *
  * DAMON can be extended for various address spaces and usages.  For this,
-- 
2.39.5


^ permalink raw reply related	[flat|nested] 3+ messages in thread

* [PATCH mm-unstable 2/2] mm/damon: remove damon_ctx->callback kernel-doc comment
  2025-07-15 18:52 [PATCH mm-unstable 0/2] mm/damon: kernel-doc comments fixup for damon_callback removal SeongJae Park
  2025-07-15 18:52 ` [PATCH mm-unstable 1/2] mm/damon: add kernel-doc comment for damon_operations->cleanup_target SeongJae Park
@ 2025-07-15 18:52 ` SeongJae Park
  1 sibling, 0 replies; 3+ messages in thread
From: SeongJae Park @ 2025-07-15 18:52 UTC (permalink / raw)
  To: Andrew Morton
  Cc: SeongJae Park, damon, kernel-team, linux-kernel, linux-mm,
	Stephen Rothwell

Commit 769bd386e490 ("mm/damon/core: add cleanup_target() ops callback")
on mm-unstable tree removed callback field of damon_ctx, but not erased
the kernel-doc comment for the field.  This results in build warning.
Fix it by removing the obsolete comment.

Fixes: 769bd386e490 ("mm/damon/core: add cleanup_target() ops callback")
Reported-by: Stephen Rothwell <sfr@canb.auug.org.au>
Fixes: 769bd386e490 ("mm/damon/core: add cleanup_target() ops callback") # mm-unstable
Signed-off-by: SeongJae Park <sj@kernel.org>
---
 include/linux/damon.h | 1 -
 1 file changed, 1 deletion(-)

diff --git a/include/linux/damon.h b/include/linux/damon.h
index efabc3ba52ee..f13664c62ddd 100644
--- a/include/linux/damon.h
+++ b/include/linux/damon.h
@@ -746,7 +746,6 @@ struct damon_attrs {
  * Accesses to other fields must be protected by themselves.
  *
  * @ops:	Set of monitoring operations for given use cases.
- * @callback:	Set of callbacks for monitoring events notifications.
  *
  * @adaptive_targets:	Head of monitoring targets (&damon_target) list.
  * @schemes:		Head of schemes (&damos) list.
-- 
2.39.5


^ permalink raw reply related	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2025-07-15 18:52 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-07-15 18:52 [PATCH mm-unstable 0/2] mm/damon: kernel-doc comments fixup for damon_callback removal SeongJae Park
2025-07-15 18:52 ` [PATCH mm-unstable 1/2] mm/damon: add kernel-doc comment for damon_operations->cleanup_target SeongJae Park
2025-07-15 18:52 ` [PATCH mm-unstable 2/2] mm/damon: remove damon_ctx->callback kernel-doc comment SeongJae Park

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).