From: "Thomas Weißschuh" <thomas.weissschuh@linutronix.de>
To: Al Viro <viro@zeniv.linux.org.uk>, Luis Chamberlain <mcgrof@kernel.org>
Cc: Kees Cook <kees@kernel.org>,
Christian Brauner <brauner@kernel.org>, Jan Kara <jack@suse.cz>,
linux-mm@kvack.org, linux-fsdevel@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v4 06/15] fs,fork,exit: export symbols necessary for KUnit UAPI support
Date: Wed, 16 Jul 2025 07:30:46 +0200 [thread overview]
Message-ID: <20250716072228-2dc39361-80b4-4603-8c20-4670a41e06ec@linutronix.de> (raw)
In-Reply-To: <20250714073704-ad146959-da12-4451-be01-819aba61c917@linutronix.de>
On Mon, Jul 14, 2025 at 07:52:28AM +0200, Thomas Weißschuh wrote:
> On Fri, Jul 11, 2025 at 04:44:23PM +0100, Al Viro wrote:
(...)
> > On Fri, Jul 11, 2025 at 12:35:59PM +0200, Thomas Weißschuh wrote:
> > > could you take a look at these new symbol exports?
> >
> > > > +EXPORT_SYMBOL_GPL_FOR_MODULES(put_filesystem, "kunit-uapi");
> >
> > What's that one for???
>
> What are you referring to?
Reading this again you probably asked why put_filesystem() is exported.
As I see it, that should be called after being done with the return value of
get_fs_type(). Not that it does anything for the always built-in ramfs.
The alternatives I see are a commented-out variant with an explanation or
making put_filesystem() into an inline function.
Thomas
next prev parent reply other threads:[~2025-07-16 5:30 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-06-26 6:10 [PATCH v4 00/15] kunit: Introduce UAPI testing framework Thomas Weißschuh
2025-06-26 6:10 ` [PATCH v4 06/15] fs,fork,exit: export symbols necessary for KUnit UAPI support Thomas Weißschuh
2025-07-11 10:35 ` Thomas Weißschuh
2025-07-11 15:44 ` Al Viro
2025-07-14 5:52 ` Thomas Weißschuh
2025-07-14 8:12 ` Christian Brauner
2025-07-16 5:30 ` Thomas Weißschuh [this message]
2025-07-16 6:21 ` Christoph Hellwig
2025-07-16 8:39 ` Thomas Weißschuh
2025-07-16 11:11 ` Christoph Hellwig
2025-07-16 11:33 ` Thomas Weißschuh
2025-07-16 11:36 ` Christoph Hellwig
2025-07-16 12:47 ` Thomas Weißschuh
2025-07-16 12:57 ` Christoph Hellwig
2025-06-26 6:10 ` [PATCH v4 12/15] kunit: Introduce UAPI testing framework Thomas Weißschuh
2025-06-26 18:11 ` Benjamin Berg
2025-06-27 4:20 ` Thomas Weißschuh
2025-06-27 6:58 ` Benjamin Berg
2025-06-27 8:27 ` Thomas Weißschuh
2025-07-07 18:18 ` [PATCH v4 00/15] " Jonathan Corbet
2025-07-08 5:51 ` Thomas Weißschuh
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250716072228-2dc39361-80b4-4603-8c20-4670a41e06ec@linutronix.de \
--to=thomas.weissschuh@linutronix.de \
--cc=brauner@kernel.org \
--cc=jack@suse.cz \
--cc=kees@kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mcgrof@kernel.org \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).