From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id C9676C83F1B for ; Wed, 16 Jul 2025 08:27:54 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 11DD16B00A5; Wed, 16 Jul 2025 04:27:54 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 0F6116B00A7; Wed, 16 Jul 2025 04:27:54 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id EFF856B00A8; Wed, 16 Jul 2025 04:27:53 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id DFF746B00A5 for ; Wed, 16 Jul 2025 04:27:53 -0400 (EDT) Received: from smtpin03.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id A80801D9567 for ; Wed, 16 Jul 2025 08:27:53 +0000 (UTC) X-FDA: 83669449626.03.EEA8B52 Received: from mail-ej1-f47.google.com (mail-ej1-f47.google.com [209.85.218.47]) by imf24.hostedemail.com (Postfix) with ESMTP id D553F180006 for ; Wed, 16 Jul 2025 08:27:51 +0000 (UTC) Authentication-Results: imf24.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=df9Qf+vb; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf24.hostedemail.com: domain of richard.weiyang@gmail.com designates 209.85.218.47 as permitted sender) smtp.mailfrom=richard.weiyang@gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1752654471; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:content-type: content-transfer-encoding:in-reply-to:in-reply-to: references:references:dkim-signature; bh=bEfc0veNlXcEt85xeZi9Qnz+9539GlgJUQMopNQd468=; b=4qtlvFhJ9dFzB5Xa5eTrqGuWUzZ1EBz9VGhMU4GbSgSbQSfZvromuH31K6/ZitT7xQWrcJ FeN/KjeWoShCaDjedsJax8Z/HtrjlBA7p+4pY6OCz6nkPDCY/VPrxAPVC3hU4DMruiWHMy K1MNZ6tSQ4I08bQLh5cfM8/o/j/9uU0= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1752654471; a=rsa-sha256; cv=none; b=nhT5/pa5GDGtPd8ty3ti02IQgQ3uE9p6Tofj4uqMOT2JTF72MW3NJOXXlJBRGkIL23iCMq idnCEhmVNCvYaiJeOyXnvapupKzIX6Ho+q507jNiKDa+PsKegKbCFpQlp7Mn023g/DNpyO rarQhs9VxVpcyFqtXWH7jqNQNGz19IU= ARC-Authentication-Results: i=1; imf24.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=df9Qf+vb; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf24.hostedemail.com: domain of richard.weiyang@gmail.com designates 209.85.218.47 as permitted sender) smtp.mailfrom=richard.weiyang@gmail.com Received: by mail-ej1-f47.google.com with SMTP id a640c23a62f3a-ae708b0e83eso819647366b.2 for ; Wed, 16 Jul 2025 01:27:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1752654470; x=1753259270; darn=kvack.org; h=references:in-reply-to:message-id:date:subject:cc:to:from:from:to :cc:subject:date:message-id:reply-to; bh=bEfc0veNlXcEt85xeZi9Qnz+9539GlgJUQMopNQd468=; b=df9Qf+vbO5zv1UMxOViri1jP+HFnjm17gdfXm/AxR2tiQTZIAj+dLRYSMEPb2vITyN mKFK5OOd7FFC8hfxiHPSzq+9FiEf5a8McVTFct4xZAADWrCN5l4o6OLh6qer//o4m2ke Ld0iE+Fqurx4TBCn0JIXoAsQELj1Ghl3IOU8cTpQbR46odXag3mJnwizs2S7uN1JjyQ+ yTPzUhY4CfkA/ZjZC6Zi83FzwsiipfUDiEsXyijBuuDXYvzd5j3SnorzbooLWgyLO8Tg CIJLiKqJIFvA+fJQsccwvFtaTkJGtMAU+pXEII+eu5ORrPoVr5uukvISRxXP1mFK96/4 cVVQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1752654470; x=1753259270; h=references:in-reply-to:message-id:date:subject:cc:to:from :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=bEfc0veNlXcEt85xeZi9Qnz+9539GlgJUQMopNQd468=; b=ZgPMeFSoatnBnlkWmB0m7eNbMjL04yFATSWPcQjm09MBoWHfcQbmqqUPRpeVKiPXo1 QrBMKqeGtn5mq5Ag383iSBF+qyug/GQDmmkpbS4TY6vdY6HVgLm4enCUg7pFRu1YiCq7 pMc3Ecvxxjwy6mJtlvPZvGxno1PET4OiPh90HieMyIWkmsG9ifeaCae740pznKbne5IH mLxhr59EVz85DhLD/DalXW1DgJe8D0lj/jdsAUxfSeKh62QfxlTvrPGk/c2ztOQxTgmc as4TbrnH2zX8+gRmIZeiOMEab6QyIkZyemPE5Ubt10zG/bmWqQyzMgdLyR+u3sI0mxdI ENEA== X-Gm-Message-State: AOJu0YxtsBTP3Je59QcnGuaYxazI4PYXp1YAZ9pXA19/atZw0w7Z887Z Ij0PEIsOQU2UCtVMOtRJbIsOzsBzPf7CmhJ/Q2tVFGEqeDN/Th2eZJ9f X-Gm-Gg: ASbGncsSocmy4yjMYRgk3GGYIkbYGPe3oIhBxljcFUfQuiT2IvDN7BCcWskfpjof8ng pQx9pQ7cw52k/sayDOn2+Tzip2OUdzCY/7ZZPKZyxwxeb0QhjmaeVHtKCFyEyW+vFrGTKYGTbY2 ksa2nPZGAErrol2952aoDk4+GKCHIhhzHhqez4JwAp+JqqG/zmNFcuHqV/DobyaSmRhXASm3nvb CjHREoGrBTGrRYxE4GhT4fc9hICcKMS0Gt8yS+Am6+Im/97aNvRbfU6/x+7TcI06l4/fUmnWueo EeAfWWQukpjtFeN0BmZ7dyKeIbCiaYmgSiSlgmS7cbZtQ2SBi4Y7pqdiyHLl4Dq/bGK2WWONcqX GSP/LDWX7eaiC50GJQaUefQ== X-Google-Smtp-Source: AGHT+IHYcWp+EUJzbI1WaSeaHTeK5j0YCSXk+DlGnnFcs7rwLjtQMv9ArjiW6Z31qu+i1HFFPlwdsg== X-Received: by 2002:a17:907:96ac:b0:ae0:ce59:5952 with SMTP id a640c23a62f3a-ae9ce19f188mr143316766b.60.1752654470331; Wed, 16 Jul 2025 01:27:50 -0700 (PDT) Received: from localhost ([185.92.221.13]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-ae6e82df57asm1138686066b.161.2025.07.16.01.27.49 (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Wed, 16 Jul 2025 01:27:49 -0700 (PDT) From: Wei Yang To: akpm@linux-foundation.org Cc: linux-mm@kvack.org, Wei Yang , David Hildenbrand , Lorenzo Stoakes , Rik van Riel , "Liam R . Howlett" , Vlastimil Babka , Harry Yoo Subject: [PATCH 1/3] selftests/mm: check a valid fd with negative value Date: Wed, 16 Jul 2025 08:27:08 +0000 Message-Id: <20250716082710.2801-2-richard.weiyang@gmail.com> X-Mailer: git-send-email 2.11.0 In-Reply-To: <20250716082710.2801-1-richard.weiyang@gmail.com> References: <20250716082710.2801-1-richard.weiyang@gmail.com> X-Rspamd-Queue-Id: D553F180006 X-Stat-Signature: 5g9ppx5ueoow8yjjtndufibdtcmhw74a X-Rspam-User: X-Rspamd-Server: rspam11 X-HE-Tag: 1752654471-130704 X-HE-Meta: U2FsdGVkX1+spTagk/k0h7i9z+3EXkSKtVnbMOLQm+EI7i6ntB99FyJKW3z1uA6wkb5HiwZGhDv9r0WzhwBjOTNlmmmWso64XGxyzBI6p2yVAdF70Gh0sEU3Y/aH/VlRrws175kNeYYUTQgirJ6bARYk4b07aP99vx7vaSDOvWyhFm4Cw4nXBsUKuXXCToUadBwiH2U+PbEjhKHVHhsaS3Ke/GpYiQe1fw+2xhWasThiYEOojoSGWOqC5Aq0H8zHvVylRezHbDbtHVK54/EUl6AdVZ8sfI2AmMaPvXysUnAQpELu09aAzgE1zOHpdvS5sidkBUtTwrAKB6bp6nSOjN8q4um2WmN1kLiNJF/RkEz6zQ+7qbj6+64s4iQ+Q+AcikjUsne2VwOMSSje0F8yGX076Qm9pGBkOq1xBavsl1h5wkYBajfwERqyeUrS8J0B/6hD7D0xXLOXw8wWcc4+7FXeP+eh/RRgGHSnr6Ek32ptp6WRWk+RMKvxxHBzTyt7BMhqbO0WlXU5C9P3txrjzAr/Ag8e1GCuDTwaa3YHPCZ2SaHcmO96EuklkAtBsnYZKAmevbRsHvyHw1ZrkRW5YcMRvQn38pnMHWpkkcf1RGfXOXJTJOYjtvkSOvyS4yStnLeqAyXV22neMDeyYAdolJpX/fWlAc6bbTgMTHWVDvmQEoXCHWQhIO8uR2iT9ntw5e3Q3mgMW7sNLU9Wz91EyWhshO7HFOaFqH9tbxk860thyfqU2TZajhjxLL22KgApf1Rn0MvUyOl4ajBEMiCSSu0V7yW+6oLOrPbIp/fzhC+J+5iesQpLiHTXJE6K7hgOjQcf01yVXpL7pWV0dur/tpuUImN3ThQbYgkoEYaWqSO6VS2058y4z8v4sftGHdpmp7Y13oNvBwArNwnDZddeTGcKHgTZMkyVSsvtkos2zjhcIzsvJjR649IaEzsqeviyzrgRx0PXM63zzcBJ2X7 KD/INaFn 3Fq5ffN+3RACAvsXpE2nD/QbfoKTijFKYs7HpmmelMPGzhZJfAcSh0rkehQcTbDr1KNM4CouFnrYiFzheXwGlo0WLQZ1rUUfMps6KsPteGKMcTjjszU+Iqdl+fMNwXvTLUiwtDU/dyWRTa2Ryk6amqVU/1Pdi58BPOe4Q54w4CYV5R3LDTWkM/xrG3pp7EGNQC7aM0dSk9Vr4TsrA2XJz7QAm62ea9+viezbdSzn8Ncuo4IMt3OUKg7+p63wlz714EP2NItEhCXvciSYqx/vaujQsTbKsPgYS7iQUBg/DkAOt3fiJJdimN8yn/tU3AKjvDxAecfnIXCsxQTFkH9SYzHHwVD56w6fFRkV8osnuqtaj0PLC4HQpeO3PCxeiAMWmalKepfVQ1O6z0vFvMPU8PVAxF90NQ4h5ea1Pp7bsXeF60yQq1KFVd2ttgesZMXymTsVJh46XX0bxZ1amRbp5O+/ZssZc6pS/4xo2MAb+ZhXA7S5fkedKhuWd/IoEHxSiIdjiwF4wMM+7IiMeG+NM2+Kd5smkVkUa4d+zSbz0eg6DuIDd86dH8gsgwAAmLDFu/3djoQCkhXeovDXEc47/FwMd1td2vgRfAYH+HAwp1Ohi22aLCYMUyZ/JHGpr32kugyGI X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: fd 0 is usually occupied by stdin, which is not expected to be returned by open(). But 0 is still a valid fd. Check the valid fd with negative value like other places. Signed-off-by: Wei Yang Cc: David Hildenbrand Cc: Lorenzo Stoakes Cc: Rik van Riel Cc: Liam R. Howlett Cc: Vlastimil Babka Cc: Harry Yoo --- tools/testing/selftests/mm/ksm_functional_tests.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tools/testing/selftests/mm/ksm_functional_tests.c b/tools/testing/selftests/mm/ksm_functional_tests.c index d8bd1911dfc0..6da5c3340e10 100644 --- a/tools/testing/selftests/mm/ksm_functional_tests.c +++ b/tools/testing/selftests/mm/ksm_functional_tests.c @@ -81,7 +81,7 @@ static long get_my_ksm_zero_pages(void) ssize_t read_size; unsigned long my_ksm_zero_pages; - if (!proc_self_ksm_stat_fd) + if (proc_self_ksm_stat_fd < 0) return 0; read_size = pread(proc_self_ksm_stat_fd, buf, sizeof(buf) - 1, 0); -- 2.34.1