From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id DD33AC83F1B for ; Thu, 17 Jul 2025 01:18:34 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 6AFFB6B009E; Wed, 16 Jul 2025 21:18:34 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 6879D6B00A1; Wed, 16 Jul 2025 21:18:34 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 5C45C6B00A2; Wed, 16 Jul 2025 21:18:34 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 4F1FB6B009E for ; Wed, 16 Jul 2025 21:18:34 -0400 (EDT) Received: from smtpin17.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id CBA2E1602E4 for ; Thu, 17 Jul 2025 01:18:33 +0000 (UTC) X-FDA: 83671996506.17.31104F0 Received: from mail-ed1-f46.google.com (mail-ed1-f46.google.com [209.85.208.46]) by imf18.hostedemail.com (Postfix) with ESMTP id CC3941C000D for ; Thu, 17 Jul 2025 01:18:31 +0000 (UTC) Authentication-Results: imf18.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=Y1WF4jmx; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf18.hostedemail.com: domain of richard.weiyang@gmail.com designates 209.85.208.46 as permitted sender) smtp.mailfrom=richard.weiyang@gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1752715111; h=from:from:sender:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=r6AogFT751UzME1jSLh7PZ82SDNAxxvnS9xLESunb0s=; b=epf6V2sDwLK0l6bEUy/0NPXPuwzs9cvsIxjelxLwgO/pSIWW/0ATOaThTg5/EvkwqRMt8a J/0nwQ9z4GU4wFjt/7zvv6oTyTf4v/po4DY6fDrJdxnE9JJcVi0NnVbY+UU42aeYJap5cz XsvB7eXoudAU0nkT9OXE1bq+ZCjeRQY= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1752715111; a=rsa-sha256; cv=none; b=dfd1VZKji+f0sc/CBTk5Lv0dzpSjrPMWeDOx8A+hfpU/D/LUetUur8askhfTtlfKzUUuTM ZEJJGEfxaJ+Iy9OwUesufDadkboPK5hXLVSDxYrtMjfErwk1jv858AJRSeoXTAFqTPXUSq YWMkRBGvZs0XB2jcQkzhqbca/w/hBrk= ARC-Authentication-Results: i=1; imf18.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=Y1WF4jmx; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf18.hostedemail.com: domain of richard.weiyang@gmail.com designates 209.85.208.46 as permitted sender) smtp.mailfrom=richard.weiyang@gmail.com Received: by mail-ed1-f46.google.com with SMTP id 4fb4d7f45d1cf-608acb0a27fso617823a12.0 for ; Wed, 16 Jul 2025 18:18:31 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1752715110; x=1753319910; darn=kvack.org; h=user-agent:in-reply-to:content-disposition:mime-version:references :reply-to:message-id:subject:cc:to:from:date:from:to:cc:subject:date :message-id:reply-to; bh=r6AogFT751UzME1jSLh7PZ82SDNAxxvnS9xLESunb0s=; b=Y1WF4jmxjGClnajgWhp06uttspx21sYENr3HL2MJjlkpcUn8tN8j9vrflMip5yvbR+ VOboO2m/Hv2r5MJmFAFudIoLQFo5DePRu9wzv/3CzfNTdU5ACAw8UmSjYZzrbhLypkbr 6Hz62c9jYh9CZT0LovCV1eJniS4okc/PkQPGsXu0caTvOgWONxKyIcOZ8eOhgNFpnd7y 0OhK032TyByFco8sFYE0TphkJN8VqryjsoRlEvpaYwY3giFZxd5fzuizB9rir4Lb7WLB l0jDLTU5RpEiWDJ/6wuZn7rUYer/I+x9K1g+WNdJKcSu4vRyQHVcwC0UQl7WDGiFYgh2 HdLw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1752715110; x=1753319910; h=user-agent:in-reply-to:content-disposition:mime-version:references :reply-to:message-id:subject:cc:to:from:date:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=r6AogFT751UzME1jSLh7PZ82SDNAxxvnS9xLESunb0s=; b=C8I5dAn8i5PFNMWyiXDfYUCV7TB52bEJ12GuDQu1/10I/xwZoWiuHMCBZTwe0Zt43q yPkdbI0nsCFLlTuHnzUnyOqq3pnAUjx47naZAoQIcmAv/nc3LVd25MXz7OkNWG+rlGXi 5utQoGFh0qOwnHSnogYDH7o35dAjuKt50qA43cCcrvCDmhcIyMRfJKuGejSuji0AtViF Irc3q98gODFSAmakCPGKPCz1iqrJbIKUyH6STzxuvLPS9ZqmT0WwyM9HsTnTTadBvAzq S0KI8YkMlBwov2NKib8lmKdZHonluR1eRoVd6hnzBH4Vm9HlXagR2zxjHeb5Y+SYLsLU q0Vg== X-Forwarded-Encrypted: i=1; AJvYcCV9+7xMKeLyUovknyzw3hi+iX+scX3gRaew+IFC5N8B6LQDSW3Gc6Vy5qTJtOETHOuRxoZh57t5rg==@kvack.org X-Gm-Message-State: AOJu0YyhAZ3qDBi2o4NHjYqck51qZHoYnCwhASGkun8mpS/5EvIMmsk5 zmSn6e/92j4If+XK35744YTmkxqVlpDDbRKDOIdJHtnjnPLo8nM83TUr X-Gm-Gg: ASbGnctcxcFmvV2HHUj/0zTOgWbNmremdr3SQWG9crU/R7qqzpWKvoam45oM+4r0wbh JiAIE/J/gXkvFD7mduoVrRQq2hBNz8jB/d6gkc+BKBIQa00xWbpBedJCrPqkoN17UJ5709PMQRc 5Y5yryjKmzmaILRiciAsh2W3wfITw8+SQq+aKyfvWsLmpXdMKDM4o1zN03+GltGgVblcwKcoYXv VhdcmVf7nxvqHwJouW9uZrj3s73kmauKPDHNEaHA6vxxZGNma1Z1rpVkmWWjlQ5xR7HM9tVGbMw s+TD7mqAUjZ5cj/1ygl7svPhrJfWHFxDgS4cSaYh/XvEmpQo6BT+jAtR0BMxVuTz54svuDc0DCp Hy+phKQM2r4vwh3T115Jwbw== X-Google-Smtp-Source: AGHT+IHhp1Ryab/67Por6Wv3OasLlIwgDGJd7pB7Fg4dXujLO5fUzE7kDBVoSybWUuWdnlqM/Qx6VA== X-Received: by 2002:a17:907:3c82:b0:ade:2e4b:50d1 with SMTP id a640c23a62f3a-ae9ce0a5a13mr442786566b.29.1752715109922; Wed, 16 Jul 2025 18:18:29 -0700 (PDT) Received: from localhost ([185.92.221.13]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-ae6e7e90c70sm1298201366b.13.2025.07.16.18.18.29 (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Wed, 16 Jul 2025 18:18:29 -0700 (PDT) Date: Thu, 17 Jul 2025 01:18:29 +0000 From: Wei Yang To: David Hildenbrand Cc: Wei Yang , akpm@linux-foundation.org, linux-mm@kvack.org, Lorenzo Stoakes , Rik van Riel , "Liam R . Howlett" , Vlastimil Babka , Harry Yoo Subject: Re: [PATCH 1/3] selftests/mm: check a valid fd with negative value Message-ID: <20250717011829.yhzeq32f4pgzrfmj@master> Reply-To: Wei Yang References: <20250716082710.2801-1-richard.weiyang@gmail.com> <20250716082710.2801-2-richard.weiyang@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: NeoMutt/20170113 (1.7.2) X-Rspamd-Queue-Id: CC3941C000D X-Stat-Signature: 9abbjz1665gfb8m1kkqmh1644kcfibwm X-Rspam-User: X-Rspamd-Server: rspam11 X-HE-Tag: 1752715111-356014 X-HE-Meta: U2FsdGVkX1+2+1Ff5QSFrzNgyyfquzSN6MV5kSYnrW8hpKL4MiBNquVSaeGeDx9iQCrZbr3zVDfXDdkSLszYAfDifPpf5jd6/HBI5Qtzrd9d+iKR5fDZGLTCHGwTqh6fe+pcNAhYD7T2bcSxeSqJwkYtVDoBUHHh1SbuWX7quQn1z6gzrf6SL1ROmdZtSRDDLtt7uSpDoMefWHgW9/AqiAccJt9nCWCubp0fsWtuuVDzKRZ6Hanq135C0wOuhD3TMXMBf90sJPeOJvmhIzf+con8wrn3HG05AGIsyThjNpUoairxg/OZeHzk3jMvqUaVgI89JyrN/lTpQ1gXtNzZ1y/hSp35WWjr3tWtkoR5l4tOr1SFUMhUN6IYebvNPPjWGI8lHN8qIUcHk0Vo4MJcYK+G2Li2CZOtR1LXnY1oOFzd0yRkB09a6JcdFNoFvM5lFqe6sSSnrKZYyRH7XuenH0SsGvdwVsSVqoALT69psqvb0o8dz/g/axmdjCzoYnND0+m/ln9aVquTTiYs+A6G6RJIl3aYqWMcG/fHu6UJePOCqTk/zDvItXFjeocRMzqRzdrX5W6ZU7sry35Q2aI9E/tYI2OmlFOn32K/uoCI7hC1A4/2K1TKB0ZKLZMarTw8ye9GjkD4LxbUheJMDwOvfL/IY0TD/xjCOBgSMYb3ul/4fNRDfylD9NkZH2KPqhbpGHovHUzsXWkqkCxaBc17pYBS+hiRIHEAwC3cuUzgTiI5CErMf/cRN5/6hC6ARxWf36TrqXN/F+v6QUYbZ4JJGjsDRLBZpD0rdwMIAaD+D5iZgzBJEIAuhBSCp0Elbl45UlqEyv7NZiOZ56HhGZBN0F6IR7QMnxikuUi6RfIrajGxts/eBSRr9IjY6wXEnkv5VIUScKPnSmaExf5QR1Sx75wMyJntEuxLxg2QwXbBMlnJcUvXWb83YrHLyXHRawt8PqPn0tBlzPnd947fc+H NDmcC7wO gMHMZXxNSADAy/EnYD3ketmgxrQ3zxkUfEkt24cdus4jGY8aisWbOdA8DCH8PXQjS3vjfMBnQvFGmN57eOEa2xc4k9PFuU++ZrS+AVKyVV+K8w/j7AyrPWlVlRfo08YGD7l3YBmqvIn+GCo1wVTa3m3lI8kP39MojsgGl7V3teD4mh7D2gJRo55VbQXLaD2UNvTAPswyVNijNhQYhX0EK4NKi2JtmqhXE2Nduz5I38BajPApwjaarZiECuYBE7l9gDr3OfuhTdNxIrtMdKBxCQtdCFpAyZqfrfBFqCTVauBEb5OObHm9RgCtBF9ZfhJtBP1SeWMGmuL20m78fazvr/JAbR/R32ieVUZHapjzciTgFzA33FkMuR6FK26n2jblmbebEMysOThKcuogZH7Z0PoAGvuBwuBLl7Lkhj7kVYe+X/nQXi2nNRcBZtEzJUJw+AFkuFWYHR6vW5IM8udAs83ZE3qEITU4yPPO0DWv/h8TYIJh/DBEIvgsWn4TUNtqLw6cmRI1D/RwaEFZXF3EWvpwPdgIrQioQySjc6xXsLeNcKshj3bM/y7Rd5Uv9AJ6j63BAtNg/WH6iLSDPKmYswtmD6BrdRW0dxendEKAeSafcQsZ6AI8yWk63wRKvDLuIZTykv60kFIL+Oeq/K7PeB6x80j4NCdo/m9TXcAdPTpvJOYgMeDMlfxj2hUsQIvA8FPeaanIoMmw6IUudgnJgAC0vA1J8IRndfAqUitriPnnrdUm6mr28H+6SzhjqwPkVxnNsgyYqsP6yRvIHJRMMKrw5RACPX20H+fTUH806Qy5zBYeKWgUc669Rw3a7ymAfr4g33vnAVkPxteA= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Wed, Jul 16, 2025 at 10:52:21AM +0200, David Hildenbrand wrote: >On 16.07.25 10:27, Wei Yang wrote: >> fd 0 is usually occupied by stdin, which is not expected to be returned >> by open(). But 0 is still a valid fd. >> >> Check the valid fd with negative value like other places. >> >> Signed-off-by: Wei Yang >> Cc: David Hildenbrand >> Cc: Lorenzo Stoakes >> Cc: Rik van Riel >> Cc: Liam R. Howlett >> Cc: Vlastimil Babka >> Cc: Harry Yoo >> --- >> tools/testing/selftests/mm/ksm_functional_tests.c | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/tools/testing/selftests/mm/ksm_functional_tests.c b/tools/testing/selftests/mm/ksm_functional_tests.c >> index d8bd1911dfc0..6da5c3340e10 100644 >> --- a/tools/testing/selftests/mm/ksm_functional_tests.c >> +++ b/tools/testing/selftests/mm/ksm_functional_tests.c >> @@ -81,7 +81,7 @@ static long get_my_ksm_zero_pages(void) >> ssize_t read_size; >> unsigned long my_ksm_zero_pages; >> - if (!proc_self_ksm_stat_fd) >> + if (proc_self_ksm_stat_fd < 0) >> return 0; > >Only test_unmerge_zero_pages() calls get_my_ksm_zero_pages(). And there, we >have > >if (proc_self_ksm_stat_fd < 0) { > ksft_test_result_skip("open(\"/proc/self/ksm_stat\") failed\n"); > return; >} > >As the fd is opened after others, we should never get fd=0. > You are right. >So probably, this should just be handled as part of factoring it out, no need >for this change upfront AFAIKS. > My intention of this change is, we plan to move get_my_ksm_zero_pages() into a standalone helper and will open and check the fd there. To make following change consistent, I split it out. If you think it is not necessary, will drop this. >-- >Cheers, > >David / dhildenb -- Wei Yang Help you, Help me