From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 03E1CC83F1B for ; Thu, 17 Jul 2025 03:30:36 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 6215C8D0007; Wed, 16 Jul 2025 23:30:36 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 5D1CF8D0001; Wed, 16 Jul 2025 23:30:36 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 499CB8D0007; Wed, 16 Jul 2025 23:30:36 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 36A858D0001 for ; Wed, 16 Jul 2025 23:30:36 -0400 (EDT) Received: from smtpin20.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id B7F37110388 for ; Thu, 17 Jul 2025 03:30:35 +0000 (UTC) X-FDA: 83672329230.20.A6FE933 Received: from mail-ej1-f41.google.com (mail-ej1-f41.google.com [209.85.218.41]) by imf15.hostedemail.com (Postfix) with ESMTP id BA7C9A0003 for ; Thu, 17 Jul 2025 03:30:33 +0000 (UTC) Authentication-Results: imf15.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=RixYmgmZ; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf15.hostedemail.com: domain of richard.weiyang@gmail.com designates 209.85.218.41 as permitted sender) smtp.mailfrom=richard.weiyang@gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1752723033; a=rsa-sha256; cv=none; b=wFj4VfGsVYDF0EJ5dpzdwVHD3IUQopk3JiCqasKfVzLOkTAd01wJXIeWdSsOp2ZZ5MqVSP FTzL1tAl/Lb4068GwH5dWlqoMAnFozrKjxpDQjH2viVRmAGs/mbC6JEDeFy4HqqNhe6H7X k7/rTH6nIfl4G99q+diWHgu/y27EgWk= ARC-Authentication-Results: i=1; imf15.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=RixYmgmZ; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf15.hostedemail.com: domain of richard.weiyang@gmail.com designates 209.85.218.41 as permitted sender) smtp.mailfrom=richard.weiyang@gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1752723033; h=from:from:sender:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=WUDq5h/sm7HU9I31cfHuMHPLl5FfprkMyEeEEmBooNA=; b=AAD2cfPmv36C7OW3amFJHIFVVnJPMpXM+suRqfpCcpQH20RuLb01JdAK0AM2Ko82GnM/Jc Pn1heD+SbL1BAnlSYrnY5FQAVOOOMkfK/Asy+5d7q7NfpeSH7BAFSSV3l036Pw28urScsm oFo7h38HnycBbt4DJSYzDvxo3uy7seo= Received: by mail-ej1-f41.google.com with SMTP id a640c23a62f3a-ae0dad3a179so78942766b.1 for ; Wed, 16 Jul 2025 20:30:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1752723032; x=1753327832; darn=kvack.org; h=user-agent:in-reply-to:content-disposition:mime-version:references :reply-to:message-id:subject:cc:to:from:date:from:to:cc:subject:date :message-id:reply-to; bh=WUDq5h/sm7HU9I31cfHuMHPLl5FfprkMyEeEEmBooNA=; b=RixYmgmZ23XgaugWdNKh+P51LDmGDicb7BiM9O+DPe69oPXgVGH2i49NkxHo1e2yI+ UEayQcnyfy2Cawm+wscHELBqriQgIvFv/Y414/+gKkqNJvZrkOlkGEejE7gAo9rBKcuf SbPTRpqSWmP4QMl3/qFP6lwgFbNc8zHYpZbAk87wlbwUxrUZRDifJWGgm/0LJBoFsFE2 QUdt9iOYC5/Epj8LeGrUfb5jy1grbWl31ElG4Fx4qYn3T/9HC8VPhvx/ak0qvFl+A6mf wuJvS0ZpQq1OvYcapgxuXmVSmUqJK8+l1UceinwL5R2XgH0e9S258ajk68mQSsrW5DQt RQMw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1752723032; x=1753327832; h=user-agent:in-reply-to:content-disposition:mime-version:references :reply-to:message-id:subject:cc:to:from:date:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=WUDq5h/sm7HU9I31cfHuMHPLl5FfprkMyEeEEmBooNA=; b=jXnw8Gbwe4prc1bGyBY0xMgSCZHBgy5yp6HAmGxBPtb2q5nSJnPy4W/Ab9+fzA4zKX AO5ffRSyGo9703TbvftMN4HJNjkmjbJJyxvANYJIclOzdG6JzO78dUL/L+Vrug1f+maz 5KNWupaYwNIuSxTP3RezZMkjD1qX+1LJg/qXeXd04ibN1QA1kUEHp8Zm1MQaf36yxid4 NLoPS/WxRD5LvEpK6erTtwnrg1+pF/oSOKrWZbrN7id/0Y5BeuhVZ9t2n1vhGCxR2Fu/ 5dfdxlKuCJT9HBl0yxty26yxgbsY6oZVwp8ht/4+7nKbts26FDorHih8e8mXGeSvCvXr fQog== X-Forwarded-Encrypted: i=1; AJvYcCXyzEIU8rnCqqk8PCzq7lsrLBkyfDmzRGThIfUOkwmE+RcTduKbV5WbCAJ4NHuATs0yAdk73wxQnA==@kvack.org X-Gm-Message-State: AOJu0YzrMLvQ3/1TzJ2N42D7HPHh/ASqembA0nTIadJU/5g8v2p5Tned z2YlPdnA3//09dE1KFakUyvmZVWEtLgkLXsy7Rk6wDeVLdtCGWG8l8Pd X-Gm-Gg: ASbGncuvbllNE8oofYmDGva2YHug/St2Ip9K+QLlRhBhYQ3nF76fKnxNDYtZ8YNsQE3 qN9ZnGOwcbwvCqAY9rAnoT+jaTzU+JughVCHsuXBL3nJWZQgvgnjAgP6tDp8v4S4lvwcQi+iZ7D 96p0HTcEFgZ8nRGa01CVLbjzMtHBPUM+YnKkD+3kbWtNYv4SvFxqSvOjqvKtvxaWeuZkN27b95/ 5sipnlb4TyRtII9WYacyRuYHnzfgNUJT/ZRIprrVfijPQet9ZPgrKxPxRVE3rC1Q/bKM2rycZGm 5Ls0JfEA+nEY+bkag00Cu8eD91mBechoTX+H1DI1u+J/04aoVA/Smsb7BxJIRAm0IaY8CgLXONT TuR1spWtK8OhLwzkTgulklQ== X-Google-Smtp-Source: AGHT+IEKBjeHxDINZDu4SA0dxoVb/7fZiDWRq8MoGewBKpAdQIUkrMtBHLRnHYnkhJPKbQaT6aZt3Q== X-Received: by 2002:a17:906:7310:b0:ae0:a0b2:a45 with SMTP id a640c23a62f3a-aec4fa947e3mr132515166b.14.1752723031891; Wed, 16 Jul 2025 20:30:31 -0700 (PDT) Received: from localhost ([185.92.221.13]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-aec4f68d3acsm61994966b.109.2025.07.16.20.30.31 (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Wed, 16 Jul 2025 20:30:31 -0700 (PDT) Date: Thu, 17 Jul 2025 03:30:31 +0000 From: Wei Yang To: Wei Yang Cc: David Hildenbrand , akpm@linux-foundation.org, linux-mm@kvack.org, Lorenzo Stoakes , Rik van Riel , "Liam R . Howlett" , Vlastimil Babka , Harry Yoo Subject: Re: [PATCH 2/3] selftests/mm: put general ksm operation into vm_util Message-ID: <20250717033031.rts7keqjrt6jc77t@master> Reply-To: Wei Yang References: <20250716082710.2801-1-richard.weiyang@gmail.com> <20250716082710.2801-3-richard.weiyang@gmail.com> <5cadce02-cd80-4aa2-a078-6335beeb8a92@redhat.com> <20250717024504.3b4q3i6uuzd4nr2w@master> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20250717024504.3b4q3i6uuzd4nr2w@master> User-Agent: NeoMutt/20170113 (1.7.2) X-Rspamd-Queue-Id: BA7C9A0003 X-Stat-Signature: wctt9gukx6snke6ncudw4tozmyy141t3 X-Rspam-User: X-Rspamd-Server: rspam08 X-HE-Tag: 1752723033-684888 X-HE-Meta: U2FsdGVkX19kkmBcOwmAafoklTECAGni1ql3Om+A2wKdLIu9u2n63+JTxPd9hfFeA7jd7z0kUHAc+Sm5bSI5W4vsGUh3lpLEmSFugwwzMTc/7ScUz8Xrur9Pu2J+wlQs25LXtFCfZgcFXo2sACn8TEv8ZpGsESUMaCpubTop8jnoG2qndLCTUgDIWhMEavhNR8qX6RdPIAXkN3eCTLAjZa8YMRQc8iw7cmnRZV2priX4xE+PHyLYhAKor7lgENp/DSW9frAYNwYtQqmANwhn1qHO1yve31irr33Qu0dUgG6PbIXLopiwfsgLYCVGkMnAgMXDR67TGQAND0tPzjDAQ9cGCLZ/aHeY8d0biReIA+nT6G5bsTA/DCaHJe+009DlrISoPLAWwWZ9KEagW4EYM/ko7J/A83V7dUeLG2wt3etjBhJBgY/SUWCiNR6gQoL1Ae+BAYKt3jzT6jzE2COTaOxCxReUl9N57+yIe9MGMbf+fkE1G3prJEmmcXOmhbzivd3B6e+nJzzX9sLMNyMR3zHrwLM5sh5Rg98H3Ln+nQD1VrH/y/6XkOZc76DdpREtJcMCaLuVfvS7FiYBohK8LkbYPOKNvn16yz8k9v1b1hNfrp1wfr/mlGYAkQXiVljnWJx1wxlSBARaF5wUCXTJD3Cy11oHHLGxQ6jiljWOBwl+myO7qGafN2lVgOsvG+N4x9U/zt+/whBMMb6MX/jYfPwvYj38mVa9DxGggyePCzuobrXC1uPR1ayi8chgDaAobEqag3LsGRXPHkqo0SVIljXSa1HNGM65/P8FvItE2uuMl7YL4XW1lT6DpLO0rvGCBaABSrNUBjjd85Y27ydLLMDwtWq9RlcqG28cmnX98o23hi32cfH46rOVBYdwnjniliNj+59UkfcWx5OdoaCGodgVircy3Pe8NcqngUGiFVEezccJzCwrs0P9FMkUS1LvXLREKFFrQKTrRnAo9wF QN/m0zFm gVLecFrQXajX6Y+LjN/Uv83uqHEvq/XoBR/OSPB7UD2iBbLxXgcppXucSbkR7R/7vJaC6CWz1g2gaxRh3L39nm05HZMueeCu4bfRPZvZ+/KZ8riZmoAGMZtsulzVaVQhwY6Lrt1z1tHPViQT6bS4axmlygOOBLCixBeedaOzfMjbSABm/saYf1LonZyQO9TkCLZc0xWTsQKH4hjrkixxZwkael6rykH+abt2Ax5efknyV2REmi9ke4QuJwgpPkkMbC4ONxKp48fEFqLjA6MHPtelrOGONwRG60ciVHybhVV2uCYm11UD+AZn5I8P8hMF8ER8x2IfNxASTY26efnIg4fbU+FpMwZABLJn6iZy7SIaQWJqOecuOXE9oO0nDLhsvCY4jIA0bNwnSRdXmur1i5PlS21iGRhaODEA2weC7TlpEpZvKNq+zZY34CZA+/aYzZX8xenAU/veQ27yoc2kikNbu7SWBlVtY+naoqeQXI0A6OMNINnnXqsqdyQjZr4pHVVWc8L1gIw2Oacqbe36/MBFdUJSuUFgBjwsSsigFaJncLa+B3SrYkbAkLFrS9opbRda80izRwx1ajM6f8JWnpRF8zB5oZIrrqfCQBMhPLcFbrplohAuVDXs7x3Z5IvxA7bBcKuicwvgUuw2wGgDVRFkETGDmP/u9sGbuFd2aBOwm3OVrkp9abEXX6jc2fzuoFmGTA9S5f4RrCJ8JDGMsNAxf+O8+EPi9j0BG2hKy0o6Udq/lOPfchIyf1Q== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Thu, Jul 17, 2025 at 02:45:04AM +0000, Wei Yang wrote: [...] > >Looks reasonable, will remove it. > >So how about leave three helpers: > > ksm_merge() > ksm_start() > ksm_stop_and_unmerge() > >Would this be better? Or maybe we just export ksm_merge() and ksm_unmerge(). Leave ksm_start() as an internal function, since only ksm_merge() use it. -- Wei Yang Help you, Help me