From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 94F5CC83F22 for ; Sun, 20 Jul 2025 17:17:36 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id E63B26B00A3; Sun, 20 Jul 2025 13:17:13 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id DECC66B00A4; Sun, 20 Jul 2025 13:17:13 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id C686B6B00A5; Sun, 20 Jul 2025 13:17:13 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 8F35B6B00A4 for ; Sun, 20 Jul 2025 13:17:13 -0400 (EDT) Received: from smtpin12.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id 5A325140582 for ; Sun, 20 Jul 2025 17:17:13 +0000 (UTC) X-FDA: 83685298746.12.E882057 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf06.hostedemail.com (Postfix) with ESMTP id B3E0C180002 for ; Sun, 20 Jul 2025 17:17:11 +0000 (UTC) Authentication-Results: imf06.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=SIO8Tzv4; spf=pass (imf06.hostedemail.com: domain of sj@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=sj@kernel.org; dmarc=pass (policy=quarantine) header.from=kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1753031831; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=tyNSsMesygRJqKYsYvmodRQHfK9fY8UREkD0QkLTv0M=; b=IBijfd8dfZhzcebM+4dk/CPAlqFTteFmj2mgrJJpdR/cm3SATXScYgSI4S10JnVXY4bDvl YgCDk56hUtvi/Lu91k0ervd9UAnKnlb7TrA7n/iifh59FHu2fZPi4twPO3zGoG903Vh/so xD0rVgMaGgtRMZqhLBYVwZezjOgGCHs= ARC-Authentication-Results: i=1; imf06.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=SIO8Tzv4; spf=pass (imf06.hostedemail.com: domain of sj@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=sj@kernel.org; dmarc=pass (policy=quarantine) header.from=kernel.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1753031831; a=rsa-sha256; cv=none; b=lnLSC80LtDPaub8Wwl4fg33rJ3AEgoQRDkTVo7VTxeabkQquaF3JfcRjNFECWYl7FTM/U1 mB0cbFzfI5JRo/QjOPwJ2SI1qHBBkAob8bcKAQure0IkgW4r12EB3ad9p3xYAJDwavrZrQ ++ue5VBEEW/E7y1Hok9QLTMTV8/SgnM= Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id EC57A5C58EC; Sun, 20 Jul 2025 17:17:10 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 717DAC4CEE7; Sun, 20 Jul 2025 17:17:10 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1753031830; bh=lGHkMcba/CR1vJvOM12egev5VxmQknIZ9A3KZprvdZ8=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=SIO8Tzv4fUCNM0P6jf76Nt74AOJffaEqtg8Upt26Vzlh5BkNlrCX5knjfLpNglUbn gR3dYlWh2jXjQnsDHNS+S0uZgdkiq6khC+8v+s9glfteIdg0mmbviujpUYteT7zwH8 CqIc0+A0ibyrVgFIa+slw0ZuP7dq2+v5aUVTRyUhQhNg+iiTJPsL6UluBLg4/UiAgf cwHWmBSE8YePcPjui8LW+YkAhtr0juiM/FZ60golVCwTnaFh6Em+F2ZuBsOYSESfCO O262crcFEqyh7OQVEnzF9fg3zDwhTmV/7GLA+feFK985hYRimLAhJrNmCcb2TEVJPE 7Fvi2ppOiizqg== From: SeongJae Park To: Andrew Morton Cc: SeongJae Park , Shuah Khan , damon@lists.linux.dev, kernel-team@meta.com, linux-kernel@vger.kernel.org, linux-kselftest@vger.kernel.org, linux-mm@kvack.org Subject: [PATCH 13/22] selftests/damon/sysfs.py: generalize DamosQuota commit assertion Date: Sun, 20 Jul 2025 10:16:43 -0700 Message-Id: <20250720171652.92309-14-sj@kernel.org> X-Mailer: git-send-email 2.39.5 In-Reply-To: <20250720171652.92309-1-sj@kernel.org> References: <20250720171652.92309-1-sj@kernel.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Stat-Signature: azupewbsqz84qora9bzjs6hu8sdchqzt X-Rspamd-Server: rspam01 X-Rspamd-Queue-Id: B3E0C180002 X-Rspam-User: X-HE-Tag: 1753031831-574120 X-HE-Meta: U2FsdGVkX1+eJkUExDcG5SeqAQhUTfEa37Stm2ZcIWGQm1YFzNa0EuO+r94EQ32SH2zNfrkh8LePOiIdp3WWpPmv5ja4cy+UK9Wsb3m5Z5SDkVMx7Z2rRnXhMG8y61ZuV+WlgtIjaJmA3TmguEe3J3UuuDwgJXKUohx5PceH6SvnZrdTeGUn90QUkI7QcCz42eLLo73rt8IxCReZPzTpohBqQDkN+uXvX0dYpRvFPsgYZZWhNAoRaqKNFukXeqQho0+XiyIcI0azq4Fba07gsWL5mbHiSMIceuMBsivaPmLk9bO+44f4KfLPOFJuKFeVxg1adHRXOn3rtbGoHop3ZI+/6tbEQiddpRbcKqDwg+P2wP6c8N+A8FKbpRoXY9ccRGoUoYxSYvYViW8phQ1Z/ni3/8QTRBxnmI/XRHHjIIWjVgDsh3r3+Kb2DpZ+UvHf+I98nURWfU7mf3FRomn36kxvfEiCoGDvkdGYTq1Nyoyvx606y92E4T7e7F56mT3kIArDk/Fuf/zV8j0k8eWQ+uIUuqI9Q1je+9XgokQ/u+STr6tMpix1oilnItcpm1bjRQUIkuxT2LEOFcPHGsvR2YwZYOdGPHnm7EaaI/l9FHLBfqb6hE9YPzII1DaspsATQvvQsFBYHJnrkLIoIz1muAogu7G/SdXsMi+MqhzjxwojN3SkR9xxis0xMsvYpTqqGpUZBzBtzpl42mvcvFicnQFH26HwmDAEMKZIuDlDhtdFLzGkOM85QeYJdBOnNtGqwioW9pWnS7nnHKtDRmhls3CyoOLXKJW0IaErHIeStYRLSYh7RiSccPjftyJ7zzwjDGX1J4YFyGKc88pO0731hdC7EuVWsNQzYza96z/G8Cm12LgqwLGjuciHmSejfKqFQmb71bQoj8wVQBu83suFBKZYgJTtfVGVMFWup6LJF3d9hMcYVQJ/aezVmvdHdBTPknxbkJO4hdeDD2S0wdW 1rNJ0mhz HvDxKRFWK1kymoFj6DY3CaBthWCwlqz4wbw1HJJx1EB5aWPFu0IGWUYRN7+T5/4bqOaEYFY/I4Hl1CKcdXQi7Ri+r4a/tVrpaz56wuQzLeES9FPk4GKL/oolVC1rKLHxvt9dK+ira8tRzyktZlcSzzJHb4Jd0eoc3KHzXqNy+4wCV/xIDPNGPU1c4oQpc3PCJhYyRw+ms6kcSjmO2OyFhmfWS1h7WAcc+UAvLfTqtDX0dYkE= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: DamosQuota commitment assertion is hard-coded for a specific test case. Split it out into a general version that can be reused for different test cases. Signed-off-by: SeongJae Park --- tools/testing/selftests/damon/sysfs.py | 31 +++++++++++++++++--------- 1 file changed, 20 insertions(+), 11 deletions(-) diff --git a/tools/testing/selftests/damon/sysfs.py b/tools/testing/selftests/damon/sysfs.py index 91a28d97b015..dbe9f1a3b976 100755 --- a/tools/testing/selftests/damon/sysfs.py +++ b/tools/testing/selftests/damon/sysfs.py @@ -41,6 +41,18 @@ def assert_watermarks_committed(watermarks, dump): assert_true(dump['mid'] == watermarks.mid, 'mid', dump) assert_true(dump['low'] == watermarks.low, 'low', dump) +def assert_quota_committed(quota, dump): + assert_true(dump['reset_interval'] == quota.reset_interval_ms, + 'reset_interval', dump) + assert_true(dump['ms'] == quota.ms, 'ms', dump) + assert_true(dump['sz'] == quota.sz, 'sz', dump) + # TODO: assert goals are committed + assert_true(dump['weight_sz'] == quota.weight_sz_permil, 'weight_sz', dump) + assert_true(dump['weight_nr_accesses'] == quota.weight_nr_accesses_permil, + 'weight_nr_accesses', dump) + assert_true( + dump['weight_age'] == quota.weight_age_permil, 'weight_age', dump) + def main(): kdamonds = _damon_sysfs.Kdamonds( [_damon_sysfs.Kdamond( @@ -104,18 +116,15 @@ def main(): if scheme['target_nid'] != -1: fail('damos target nid', status) - if scheme['quota'] != { - 'reset_interval': 0, - 'ms': 0, - 'sz': 0, - 'goals': [], - 'esz': 0, - 'weight_sz': 0, - 'weight_nr_accesses': 0, - 'weight_age': 0, - }: - fail('damos quota', status) + migrate_dests = scheme['migrate_dests'] + if migrate_dests['nr_dests'] != 0: + fail('nr_dests', status) + if migrate_dests['node_id_arr'] != []: + fail('node_id_arr', status) + if migrate_dests['weight_arr'] != []: + fail('weight_arr', status) + assert_quota_committed(_damon_sysfs.DamosQuota(), scheme['quota']) assert_watermarks_committed(_damon_sysfs.DamosWatermarks(), scheme['wmarks']) -- 2.39.5