From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 70E5DC83F1A for ; Sun, 20 Jul 2025 17:17:44 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 31AB56B00A7; Sun, 20 Jul 2025 13:17:17 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 255036B00A8; Sun, 20 Jul 2025 13:17:17 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 0F5B06B00A9; Sun, 20 Jul 2025 13:17:17 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id EB5156B00A7 for ; Sun, 20 Jul 2025 13:17:16 -0400 (EDT) Received: from smtpin06.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id B32CC160568 for ; Sun, 20 Jul 2025 17:17:16 +0000 (UTC) X-FDA: 83685298872.06.036BBB4 Received: from sea.source.kernel.org (sea.source.kernel.org [172.234.252.31]) by imf10.hostedemail.com (Postfix) with ESMTP id EB9A5C000C for ; Sun, 20 Jul 2025 17:17:14 +0000 (UTC) Authentication-Results: imf10.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=sXB5Von2; spf=pass (imf10.hostedemail.com: domain of sj@kernel.org designates 172.234.252.31 as permitted sender) smtp.mailfrom=sj@kernel.org; dmarc=pass (policy=quarantine) header.from=kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1753031835; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=CD+wnEPJu5sNDN/ASnTtblCmVPsCJliGVOpmK7Pq1/I=; b=hMFIuneHd3LMOupfMxVtB7S+D9Xm7iZsC7fnJSTeQHFXcVCdxCTVhQxZFZFNpG+EypNYJA 3Kve7LWiLP1YrM8LAZFLFbzzJSSvk3zNGCGKvJHkfBCIP/HtH/mDYHU6INOLl9FvEb+emQ gKumeB3j6mu/gM118341cb6zkpC29fM= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1753031835; a=rsa-sha256; cv=none; b=lj3CRCQU5cPNAYaQ4fyt9/J8IGgfMiz2nhP8Zu7qG7UkWrjzonBQYe2r82FeC+gy4VNdQ9 bmHopZlF41AZo5j5p0BQCjfr14I7wI3ULBVpzC13ec/LOOwJrxC5+b9U3xv1n4H6WHV0FP ZjtaR/wP0CCBK0WWg/3QyTPBYRSVE64= ARC-Authentication-Results: i=1; imf10.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=sXB5Von2; spf=pass (imf10.hostedemail.com: domain of sj@kernel.org designates 172.234.252.31 as permitted sender) smtp.mailfrom=sj@kernel.org; dmarc=pass (policy=quarantine) header.from=kernel.org Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by sea.source.kernel.org (Postfix) with ESMTP id 0392D4517B; Sun, 20 Jul 2025 17:17:14 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id AECB5C4CEEB; Sun, 20 Jul 2025 17:17:13 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1753031833; bh=C+MxPYrYclaVcjxNdOPDcCVwFLKAkLjsoAGfPMtg1OA=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=sXB5Von2EQuwiNj2cE5N7Xo2r4+0Urh50yw+hf7Jyb8tgbWzn3FBGP+eZSDWpMOGA NmJ62BsRk8eMKEKWUIH8QVdT5XRxJ2UNgU9IJsU5F972j4Kd3fhrL1d9b2atb7xXCd yO6BobtBGJOBBcTj5NS0y2hpF6gRTBd6M9J9TAFkcU2WQzRttzz2coueEawxG419BA gUr6I2MvtB+d+KzTDaD37SnqNyo5HbNjxrO/Fo1xjofMziYvUNYJQ5DGbS1JeQHQSk 8v0MyiDOaakxx4+7ZyGpiiFJxwYg5Xh24bUa7R4StMH8bnr3R7nAt9d/A0iv93c1Oh dN7KxJ3gPTHdQ== From: SeongJae Park To: Andrew Morton Cc: SeongJae Park , Shuah Khan , damon@lists.linux.dev, kernel-team@meta.com, linux-kernel@vger.kernel.org, linux-kselftest@vger.kernel.org, linux-mm@kvack.org Subject: [PATCH 16/22] selftests/damon/sysfs.py: generalize DAMOS schemes commit assertion Date: Sun, 20 Jul 2025 10:16:46 -0700 Message-Id: <20250720171652.92309-17-sj@kernel.org> X-Mailer: git-send-email 2.39.5 In-Reply-To: <20250720171652.92309-1-sj@kernel.org> References: <20250720171652.92309-1-sj@kernel.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Rspamd-Server: rspam03 X-Rspamd-Queue-Id: EB9A5C000C X-Stat-Signature: feryq3u1nmxdm1hrz33c8w1nynxs58kt X-Rspam-User: X-HE-Tag: 1753031834-638294 X-HE-Meta: U2FsdGVkX1+ajehimTYrSsviEDpRq4avm/1FSOjPLFFYmYU03S5SIbovXlAC2Zam5Y39FcDVtEjn/xQT2Cod4nd5VwFfod0TIyCfZoX14+x+NvbwaF+mIFQ/1zSqSEpMhq1CCmzr9sW8v5DLBvrHnyaWz8zpCbs/hDHp0dC3IRhftcLp7KCp+j+v/I5KlRB2gxc+1oLHzynlgqd7T/LP2cekSbpzoNzRhaz7zFzLAnC7stP4wbYWjDCjLRudjoz2JxA2c6fxkxQRer9y/6dN5fVvn9sASXjHdqUmAErZedYw4iea2KnZ6o3CCsKHE5CyCDvJVIsgHBVg2D0NkGM0ZvSNDr6KhEwkSyEsN0kUV3Q2PpOFX0EpIG5XUfmSy/ainh1rXJHuK48nPdgQ1qiFWKne1oZx7xm3g++emZU57IVJKiUvlhjuK3eydXXX+4aaeqIo/1Kl7Bj/hV25R8QcGZKbQf4N7SWWWt5FZIWF4dV47G42Fnfj4ss9iWiGKKybAveTx/klxCuPVztCFYil3vawnkyqA8JRGXzJD1tUH5OxIPmZQKza8Cm26Ioze50ETTiqiZpomCmF9WGmWGSRFHGKpJd5l8Ji5i/pknItU/tQOWPAt7UTY24jpaMdM2NuH+lmOuqozeQb1PyL0jGPmy9hQbCvcgepb5qHvpRGdEhNzn+GBdFN5bLLLwIm5TUQ3QDel88xkTt7V6MjHTM13SLkGI9EnOGNTWQa7Fxr/R4zyj8KaeR3HIwibMQ2lDhLjHZK6tfVWjQmsYKcsl3hzEne2KIfIiA/pVmnTQCcxpV6YpTaWCqe3c3IEAC6jl42rTrvucwYVH0OaokYnqUGRn/ZwRKu314D4hYw9sZVV55Wrhd+O7FlP/pSWLfxnL+4s5WpPZMbS8+FYXPZuHKtg+nllzcoyGn6t+Mls+NPqIRDMmXBCMSTnuNGUU1KMxZUtgqQ8gyBu+eszrJkcNd J7PxYGAk DbeHtvVHlnA39VX3beqQWBKtx9GmPGcuz+ifFZdu8zAxqNQeHeHRBYgT0WEGlYa4+mF76feRD1v8Od8QXqz7CA29TxEFYUCA7bfwde3k+vHD55FyUMsX7CorTWxxsL7HTnr9RLcKMB6Z1ftztdPUjeew4OlrI/4eZpgkiM36XYynTdOjHd/CaBSdJyJF2sWo9pQJO3REgJgqIU2KRYuxFTlZ8Izc3FrmIjWftwrQXLhDC0S8= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: DAMOS scheme commitment assertion is hard-coded for a specific test case. Split it out into a general version that can be reused for different test cases. Signed-off-by: SeongJae Park --- tools/testing/selftests/damon/sysfs.py | 59 ++++++++++++++++---------- 1 file changed, 37 insertions(+), 22 deletions(-) diff --git a/tools/testing/selftests/damon/sysfs.py b/tools/testing/selftests/damon/sysfs.py index 803f38b61ab3..584a71cbb891 100755 --- a/tools/testing/selftests/damon/sysfs.py +++ b/tools/testing/selftests/damon/sysfs.py @@ -76,6 +76,42 @@ def assert_migrate_dests_committed(dests, dump): assert_true(dump['node_id_arr'][idx] == dest.id, 'node_id', dump) assert_true(dump['weight_arr'][idx] == dest.weight, 'weight', dump) +def assert_access_pattern_committed(pattern, dump): + assert_true(dump['min_sz_region'] == pattern.size[0], 'min_sz_region', + dump) + assert_true(dump['max_sz_region'] == pattern.size[1], 'max_sz_region', + dump) + assert_true(dump['min_nr_accesses'] == pattern.nr_accesses[0], + 'min_nr_accesses', dump) + assert_true(dump['max_nr_accesses'] == pattern.nr_accesses[1], + 'max_nr_accesses', dump) + assert_true(dump['min_age_region'] == pattern.age[0], 'min_age_region', + dump) + assert_true(dump['max_age_region'] == pattern.age[1], 'miaxage_region', + dump) + +def assert_scheme_committed(scheme, dump): + assert_access_pattern_committed(scheme.access_pattern, dump['pattern']) + action_val = { + 'willneed': 0, + 'cold': 1, + 'pageout': 2, + 'hugepage': 3, + 'nohugeapge': 4, + 'lru_prio': 5, + 'lru_deprio': 6, + 'migrate_hot': 7, + 'migrate_cold': 8, + 'stat': 9, + } + assert_true(dump['action'] == action_val[scheme.action], 'action', dump) + assert_true(dump['apply_interval_us'] == scheme. apply_interval_us, + 'apply_interval_us', dump) + assert_true(dump['target_nid'] == scheme.target_nid, 'target_nid', dump) + assert_migrate_dests_committed(scheme.dests, dump['migrate_dests']) + assert_quota_committed(scheme.quota, dump['quota']) + assert_watermarks_committed(scheme.watermarks, dump['wmarks']) + def main(): kdamonds = _damon_sysfs.Kdamonds( [_damon_sysfs.Kdamond( @@ -122,28 +158,7 @@ def main(): if len(ctx['schemes']) != 1: fail('number of schemes', status) - scheme = ctx['schemes'][0] - if scheme['pattern'] != { - 'min_sz_region': 0, - 'max_sz_region': 2**64 - 1, - 'min_nr_accesses': 0, - 'max_nr_accesses': 2**32 - 1, - 'min_age_region': 0, - 'max_age_region': 2**32 - 1, - }: - fail('damos pattern', status) - if scheme['action'] != 9: # stat - fail('damos action', status) - if scheme['apply_interval_us'] != 0: - fail('damos apply interval', status) - if scheme['target_nid'] != -1: - fail('damos target nid', status) - - assert_migrate_dests_committed(_damon_sysfs.DamosDests(), - scheme['migrate_dests']) - assert_quota_committed(_damon_sysfs.DamosQuota(), scheme['quota']) - assert_watermarks_committed(_damon_sysfs.DamosWatermarks(), - scheme['wmarks']) + assert_scheme_committed(_damon_sysfs.Damos(), ctx['schemes'][0]) kdamonds.stop() -- 2.39.5